167984 2017-02-08 05:42:40 -0800 [GTK] Fix translatable form validation messages 2017-02-08 08:22:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1274314 0 cgarcia 2017-02-08 05:42:40 -0800 Most of them are just wrong. We could simply use the same messages than mac which will also make some tests pass. 1274315 1 300892 cgarcia 2017-02-08 05:46:09 -0800 Created attachment 300892 Patch 1274340 2 cgarcia 2017-02-08 08:22:05 -0800 Committed r211871: <http://trac.webkit.org/changeset/211871> 300892 2017-02-08 05:46:09 -0800 2017-02-08 07:51:55 -0800 Patch wk-validation-messages.diff text/plain 6206 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3N2QwNjc3NjkxNy4uZDI1NWM3YThmNWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzNCBAQAorMjAxNy0wMi0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRml4IHRyYW5zbGF0YWJsZSBmb3JtIHZhbGlkYXRp b24gbWVzc2FnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2Nzk4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1vc3Qgb2YgdGhlbSBhcmUganVzdCB3cm9uZy4gVXNlIHRoZSBzYW1lIG1lc2FnZXMgdGhh biBtYWMsIHdoaWNoIGFsc28gbWFrZXMgc29tZSB0ZXN0cyBwYXNzLgorCisgICAgICAgIEZpeGVz OiBmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS1tYXhMZW5ndGguaHRtbAorICAgICAgICAg ICAgICAgZmFzdC9mb3Jtcy92YWxpZGF0aW9uTWVzc2FnZS5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2YWxp ZGF0aW9uTWVzc2FnZVZhbHVlTWlzc2luZ1RleHQpOgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRh dGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdGb3JDaGVja2JveFRleHQpOgorICAgICAgICAoV2ViQ29y ZTo6dmFsaWRhdGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdGb3JGaWxlVGV4dCk6CisgICAgICAgIChX ZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2FnZVZhbHVlTWlzc2luZ0Zvck11bHRpcGxlRmlsZVRleHQp OgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRhdGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdGb3JSYWRp b1RleHQpOgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRhdGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdG b3JTZWxlY3RUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnZhbGlkYXRpb25NZXNzYWdlVHlwZU1p c21hdGNoVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2FnZVR5cGVNaXNt YXRjaEZvckVtYWlsVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2FnZVR5 cGVNaXNtYXRjaEZvck11bHRpcGxlRW1haWxUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnZhbGlk YXRpb25NZXNzYWdlVHlwZU1pc21hdGNoRm9yVVJMVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2 YWxpZGF0aW9uTWVzc2FnZVBhdHRlcm5NaXNtYXRjaFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6 dmFsaWRhdGlvbk1lc3NhZ2VUb29TaG9ydFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6dmFsaWRh dGlvbk1lc3NhZ2VUb29Mb25nVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVz c2FnZVJhbmdlVW5kZXJmbG93VGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVz c2FnZVJhbmdlT3ZlcmZsb3dUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnZhbGlkYXRpb25NZXNz YWdlU3RlcE1pc21hdGNoVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp2YWxpZGF0aW9uTWVzc2Fn ZUJhZElucHV0Rm9yTnVtYmVyVGV4dCk6CisKIDIwMTctMDItMDggIE1pZ3VlbCBHb21leiAgPG1h Z29tZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZWR1Y2UgVGlsZWRCYWNraW5nU3Rv cmUgdGlsZSBjb3ZlcmFnZSB3aGVuIG9uIG1lbW9yeSBwcmVzc3VyZSBzdGF0ZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCmluZGV4 IDMwZmRlZTdiYjliLi5mMWMwODc5NGMwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcApAQCAtNzU2LDkxICs3NTYsOTEgQEAg U3RyaW5nIGxvY2FsaXplZE1lZGlhVGltZURlc2NyaXB0aW9uKGZsb2F0IHRpbWUpCiAKIFN0cmlu ZyB2YWxpZGF0aW9uTWVzc2FnZVZhbHVlTWlzc2luZ1RleHQoKQogewotICAgIHJldHVybiBTdHJp bmc6OmZyb21VVEY4KF8oInZhbHVlIG1pc3NpbmciKSk7CisgICAgcmV0dXJuIFN0cmluZzo6ZnJv bVVURjgoXygiRmlsbCBvdXQgdGhpcyBmaWVsZCIpKTsKIH0KIAogU3RyaW5nIHZhbGlkYXRpb25N ZXNzYWdlVmFsdWVNaXNzaW5nRm9yQ2hlY2tib3hUZXh0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRl ZCgpOwotICAgIHJldHVybiB2YWxpZGF0aW9uTWVzc2FnZVZhbHVlTWlzc2luZ1RleHQoKTsKKyAg ICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJTZWxlY3QgdGhpcyBjaGVja2JveCIpKTsKIH0K IAogU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlVmFsdWVNaXNzaW5nRm9yRmlsZVRleHQoKQogewot ICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIHZhbGlkYXRpb25NZXNzYWdlVmFsdWVN aXNzaW5nVGV4dCgpOworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oIlNlbGVjdCBhIGZp bGUiKSk7CiB9CiAKIFN0cmluZyB2YWxpZGF0aW9uTWVzc2FnZVZhbHVlTWlzc2luZ0Zvck11bHRp cGxlRmlsZVRleHQoKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIHZhbGlk YXRpb25NZXNzYWdlVmFsdWVNaXNzaW5nVGV4dCgpOworICAgIHJldHVybiB2YWxpZGF0aW9uTWVz c2FnZVZhbHVlTWlzc2luZ0ZvckZpbGVUZXh0KCk7CiB9CiAKIFN0cmluZyB2YWxpZGF0aW9uTWVz c2FnZVZhbHVlTWlzc2luZ0ZvclJhZGlvVGV4dCgpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsK LSAgICByZXR1cm4gdmFsaWRhdGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdUZXh0KCk7CisgICAgcmV0 dXJuIFN0cmluZzo6ZnJvbVVURjgoXygiU2VsZWN0IG9uZSBvZiB0aGVzZSBvcHRpb25zIikpOwog fQogCiBTdHJpbmcgdmFsaWRhdGlvbk1lc3NhZ2VWYWx1ZU1pc3NpbmdGb3JTZWxlY3RUZXh0KCkK IHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiB2YWxpZGF0aW9uTWVzc2FnZVZh bHVlTWlzc2luZ1RleHQoKTsKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJTZWxlY3Qg YW4gaXRlbSBpbiB0aGUgbGlzdCIpKTsKIH0KIAogU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlVHlw ZU1pc21hdGNoVGV4dCgpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gU3Ry aW5nOjpmcm9tVVRGOChfKCJ0eXBlIG1pc21hdGNoIikpOworICAgIHJldHVybiBTdHJpbmc6OmZy b21VVEY4KF8oIkludmFsaWQgdmFsdWUiKSk7CiB9CiAKIFN0cmluZyB2YWxpZGF0aW9uTWVzc2Fn ZVR5cGVNaXNtYXRjaEZvckVtYWlsVGV4dCgpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAg ICByZXR1cm4gdmFsaWRhdGlvbk1lc3NhZ2VUeXBlTWlzbWF0Y2hUZXh0KCk7CisgICAgcmV0dXJu IFN0cmluZzo6ZnJvbVVURjgoXygiRW50ZXIgYW4gZW1haWwgYWRkcmVzcyIpKTsKIH0KIAogU3Ry aW5nIHZhbGlkYXRpb25NZXNzYWdlVHlwZU1pc21hdGNoRm9yTXVsdGlwbGVFbWFpbFRleHQoKQog ewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIHZhbGlkYXRpb25NZXNzYWdlVHlw ZU1pc21hdGNoVGV4dCgpOworICAgIHJldHVybiB2YWxpZGF0aW9uTWVzc2FnZVR5cGVNaXNtYXRj aEZvckVtYWlsVGV4dCgpOwogfQogCiBTdHJpbmcgdmFsaWRhdGlvbk1lc3NhZ2VUeXBlTWlzbWF0 Y2hGb3JVUkxUZXh0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiB2YWxp ZGF0aW9uTWVzc2FnZVR5cGVNaXNtYXRjaFRleHQoKTsKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9t VVRGOChfKCJFbnRlciBhIFVSTCIpKTsKIH0KIAogU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlUGF0 dGVybk1pc21hdGNoVGV4dCgpCiB7Ci0gICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoXygicGF0 dGVybiBtaXNtYXRjaCIpKTsKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJNYXRjaCB0 aGUgcmVxdWVzdGVkIGZvcm1hdCIpKTsKIH0KIAotU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlVG9v U2hvcnRUZXh0KGludCwgaW50KQorU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlVG9vU2hvcnRUZXh0 KGludCwgaW50IG1pbkxlbmd0aCkKIHsKLSAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJ0 b28gc2hvcnQiKSk7CisgICAgR1VuaXF1ZVB0cjxjaGFyPiBzdHJpbmcoZ19zdHJkdXBfcHJpbnRm KG5nZXR0ZXh0KCJVc2UgYXQgbGVhc3Qgb25lIGNoYXJhY3RlciIsICJVc2UgYXQgbGVhc3QgJWQg Y2hhcmFjdGVycyIsIG1pbkxlbmd0aCksIG1pbkxlbmd0aCkpOworICAgIHJldHVybiBTdHJpbmc6 OmZyb21VVEY4KHN0cmluZy5nZXQoKSk7CiB9CiAKLVN0cmluZyB2YWxpZGF0aW9uTWVzc2FnZVRv b0xvbmdUZXh0KGludCwgaW50KQorU3RyaW5nIHZhbGlkYXRpb25NZXNzYWdlVG9vTG9uZ1RleHQo aW50LCBpbnQgbWF4TGVuZ3RoKQogewotICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oInRv byBsb25nIikpOworICAgIEdVbmlxdWVQdHI8Y2hhcj4gc3RyaW5nKGdfc3RyZHVwX3ByaW50Zihu Z2V0dGV4dCgiVXNlIG5vIG1vcmUgdGhhbiBvbmUgY2hhcmFjdGVyIiwgIlVzZSBubyBtb3JlIHRo YW4gJWQgY2hhcmFjdGVycyIsIG1heExlbmd0aCksIG1heExlbmd0aCkpOworICAgIHJldHVybiBT dHJpbmc6OmZyb21VVEY4KHN0cmluZy5nZXQoKSk7CiB9CiAKLVN0cmluZyB2YWxpZGF0aW9uTWVz c2FnZVJhbmdlVW5kZXJmbG93VGV4dChjb25zdCBTdHJpbmcmKQorU3RyaW5nIHZhbGlkYXRpb25N ZXNzYWdlUmFuZ2VVbmRlcmZsb3dUZXh0KGNvbnN0IFN0cmluZyYgbWluaW11bSkKIHsKLSAgICBy ZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJyYW5nZSB1bmRlcmZsb3ciKSk7CisgICAgR1VuaXF1 ZVB0cjxjaGFyPiBzdHJpbmcoZ19zdHJkdXBfcHJpbnRmKF8oIlZhbHVlIG11c3QgYmUgZ3JlYXRl ciB0aGFuIG9yIGVxdWFsIHRvICVzIiksIG1pbmltdW0udXRmOCgpLmRhdGEoKSkpOworICAgIHJl dHVybiBTdHJpbmc6OmZyb21VVEY4KHN0cmluZy5nZXQoKSk7CiB9CiAKLVN0cmluZyB2YWxpZGF0 aW9uTWVzc2FnZVJhbmdlT3ZlcmZsb3dUZXh0KGNvbnN0IFN0cmluZyYpCitTdHJpbmcgdmFsaWRh dGlvbk1lc3NhZ2VSYW5nZU92ZXJmbG93VGV4dChjb25zdCBTdHJpbmcmIG1heGltdW0pCiB7Ci0g ICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoXygicmFuZ2Ugb3ZlcmZsb3ciKSk7CisgICAgR1Vu aXF1ZVB0cjxjaGFyPiBzdHJpbmcoZ19zdHJkdXBfcHJpbnRmKF8oIlZhbHVlIG11c3QgYmUgbGVz cyB0aGFuIG9yIGVxdWFsIHRvICVzIiksIG1heGltdW0udXRmOCgpLmRhdGEoKSkpOworICAgIHJl dHVybiBTdHJpbmc6OmZyb21VVEY4KHN0cmluZy5nZXQoKSk7CiB9CiAKIFN0cmluZyB2YWxpZGF0 aW9uTWVzc2FnZVN0ZXBNaXNtYXRjaFRleHQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJikK IHsKLSAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChfKCJzdGVwIG1pc21hdGNoIikpOworICAg IHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oIkVudGVyIGEgdmFsaWQgdmFsdWUiKSk7Cit9CisK K1N0cmluZyB2YWxpZGF0aW9uTWVzc2FnZUJhZElucHV0Rm9yTnVtYmVyVGV4dCgpCit7CisgICAg cmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoXygiRW50ZXIgYSBudW1iZXIiKSk7CiB9CiAKIFN0cmlu ZyB1bmFjY2VwdGFibGVUTFNDZXJ0aWZpY2F0ZSgpCkBAIC04NTMsMTIgKzg1Myw2IEBAIFN0cmlu ZyBsb2NhbGl6ZWRTdHJpbmcoY29uc3QgY2hhcioga2V5KQogICAgIHJldHVybiBTdHJpbmc6OmZy b21VVEY4KGtleSwgc3RybGVuKGtleSkpOwogfQogCi1TdHJpbmcgdmFsaWRhdGlvbk1lc3NhZ2VC YWRJbnB1dEZvck51bWJlclRleHQoKQotewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0 dXJuIHZhbGlkYXRpb25NZXNzYWdlVHlwZU1pc21hdGNoVGV4dCgpOwotfQotCiAjaWYgRU5BQkxF KFZJREVPX1RSQUNLKQogU3RyaW5nIHRleHRUcmFja1N1YnRpdGxlc1RleHQoKQogewo=