167981 2017-02-08 03:40:36 -0800 [GStreamer] Critical warnings when media player is destroyed 2017-02-08 04:41:00 -0800 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris commit-queue eocanha oldest_to_newest 1274297 0 cgarcia 2017-02-08 03:40:36 -0800 (WebKitWebProcess:6556): GLib-GObject-WARNING **: invalid (NULL) pointer instance (WebKitWebProcess:6556): GLib-GObject-CRITICAL **: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed #0 _g_log_abort (breakpoint=breakpoint@entry=1) at gmessages.c:487 #1 0x00007f388fbf6e25 in g_logv (log_domain=0x7f388fef22e4 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=args@entry=0x7ffef14916c8) at gmessages.c:1296 #2 0x00007f388fbf6f72 in g_log (log_domain=log_domain@entry=0x7f388fef22e4 "GLib-GObject", log_level=log_level@entry=G_LOG_LEVEL_WARNING, format=<optimized out>) at gmessages.c:1337 #3 0x00007f388feeb8fa in g_type_check_instance (type_instance=type_instance@entry=0x0) at gtype.c:4142 #4 0x00007f388fee0184 in g_signal_handlers_disconnect_matched (instance=0x0, mask=(G_SIGNAL_MATCH_FUNC | G_SIGNAL_MATCH_DATA), signal_id=0, detail=0, closure=0x0, func=0x7f3898aef720 <WebCore::MediaPlayerPrivateGStreamer::uriDecodeBinElementAddedCallback(_GstBin*, _GstElement*, WebCore::MediaPlayerPrivateGStreamer*)>, data=0x7f3811a958c0) at gsignal.c:2931 #5 0x00007f3898af5ac0 in WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007f3898af5bf9 in WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007f38985fa8f5 in WebCore::MediaPlayer::~MediaPlayer() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007f38985fa989 in WebCore::MediaPlayer::~MediaPlayer() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007f389820b568 in WebCore::HTMLMediaElement::createMediaPlayer() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007f389820bced in WebCore::HTMLMediaElement::prepareForLoad() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007f389820f08c in WebCore::HTMLMediaElement::load() () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007f3898e42346 in WebCore::jsHTMLMediaElementPrototypeFunctionLoad(JSC::ExecState*) () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007f3833ffffc8 in ?? () #14 0x00007ffef14919b0 in ?? () #15 0x00007f389616a4df in llint_entry () from /home/cgarcia/src/git/gnome/WebKit-2.14/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 1274298 1 300888 cgarcia 2017-02-08 03:42:26 -0800 Created attachment 300888 Patch 1274299 2 eocanha 2017-02-08 03:45:00 -0800 This was caused by my patch on https://bugs.webkit.org/show_bug.cgi?id=119477 , sorry. 1274302 3 eocanha 2017-02-08 04:06:43 -0800 At first I feared that with the new condition (or even with the critical) the handler remained connected, but in the end it'll be automatically disconnected when the GstUriDecodeBin is destroyed: https://developer.gnome.org/gobject/stable/gobject-Signals.html states that "signal handlers are automatically disconnected when the object emitting the signal is finalised". Therefore, the patch looks good. 1274306 4 300888 commit-queue 2017-02-08 04:40:56 -0800 Comment on attachment 300888 Patch Clearing flags on attachment: 300888 Committed r211868: <http://trac.webkit.org/changeset/211868> 1274307 5 commit-queue 2017-02-08 04:41:00 -0800 All reviewed patches have been landed. Closing bug. 300888 2017-02-08 03:42:26 -0800 2017-02-08 04:40:56 -0800 Patch wk-gst-warnings.diff text/plain 2129 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZmQ5YTliYTc2NC4uMWNmZTU3ODJhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMi0wOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gQ3JpdGljYWwgd2FybmluZ3Mgd2hlbiBt ZWRpYSBwbGF5ZXIgaXMgZGVzdHJveWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjc5ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJdCBjYW4gaGFwcGVuIHRoYXQgdGhlIHNvdXJjZSBkb2Vzbid0IGhh dmUgYSBwYXJlbnQgd2hlbiB3ZSB0cnkgdG8gZGlzY29ubmVjdCB0aGUgZWxlbWVudC1hZGRlZCBz aWduYWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6fk1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcik6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OnNvdXJjZUNoYW5nZWQpOgorCiAy MDE3LTAyLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIyMTA3NDApOiBbR1RLXSAyLjE1IGJyb2tlIGVtYmVkZGVkIHZp ZGVvcyBpbiBHTk9NRSdzIHllbHAgYXBwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGRkNGJiZTU1YjY4Li4wYzkwZjdkZjZiMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTIwMCw3 ICsyMDAsNyBAQCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6On5NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXIoKQogICAgICAgICBtX21lZGlhTG9jYXRpb25zID0gMDsKICAgICB9CiAKLSAg ICBpZiAoV0VCS0lUX0lTX1dFQl9TUkMobV9zb3VyY2UuZ2V0KCkpKQorICAgIGlmIChXRUJLSVRf SVNfV0VCX1NSQyhtX3NvdXJjZS5nZXQoKSkgJiYgR1NUX09CSkVDVF9QQVJFTlQobV9zb3VyY2Uu Z2V0KCkpKQogICAgICAgICBnX3NpZ25hbF9oYW5kbGVyc19kaXNjb25uZWN0X2J5X2Z1bmMoR1NU X0VMRU1FTlRfUEFSRU5UKG1fc291cmNlLmdldCgpKSwgcmVpbnRlcnByZXRfY2FzdDxncG9pbnRl cj4odXJpRGVjb2RlQmluRWxlbWVudEFkZGVkQ2FsbGJhY2spLCB0aGlzKTsKIAogICAgIGlmICht X2F1dG9BdWRpb1NpbmspCkBAIC0xNDExLDcgKzE0MTEsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6cHVyZ2VPbGREb3dubG9hZEZpbGVzKGNvbnN0IGNoYXIqIGRvd25sb2Fk RmlsZQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6c291cmNlQ2hhbmdlZCgp CiB7Ci0gICAgaWYgKFdFQktJVF9JU19XRUJfU1JDKG1fc291cmNlLmdldCgpKSkKKyAgICBpZiAo V0VCS0lUX0lTX1dFQl9TUkMobV9zb3VyY2UuZ2V0KCkpICYmIEdTVF9PQkpFQ1RfUEFSRU5UKG1f c291cmNlLmdldCgpKSkKICAgICAgICAgZ19zaWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9m dW5jKEdTVF9FTEVNRU5UX1BBUkVOVChtX3NvdXJjZS5nZXQoKSksIHJlaW50ZXJwcmV0X2Nhc3Q8 Z3BvaW50ZXI+KHVyaURlY29kZUJpbkVsZW1lbnRBZGRlZENhbGxiYWNrKSwgdGhpcyk7CiAKICAg ICBtX3NvdXJjZS5jbGVhcigpOwo=