167972 2017-02-07 17:55:44 -0800 Add WebRTC as an off-by-default experimental feature menu item. 2017-02-16 09:07:39 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 168330 1 eric.carlson eric.carlson achristensen commit-queue jonlee webkit-bug-importer oldest_to_newest 1274230 0 eric.carlson 2017-02-07 17:55:44 -0800 Add WebRTC as an off-by-default experimental feature menu item. WebRTC requires Media Streams, so enable/disable both at the same time. 1274231 1 eric.carlson 2017-02-07 17:56:17 -0800 <rdar://problem/30293429> 1274243 2 300871 eric.carlson 2017-02-07 18:09:22 -0800 Created attachment 300871 Proposed patch. 1274280 3 300871 jonlee 2017-02-08 00:36:25 -0800 Comment on attachment 300871 Proposed patch. Can we file a follow up bug to turn it on, and relate it appropriately? 1274391 4 300871 commit-queue 2017-02-08 09:30:40 -0800 Comment on attachment 300871 Proposed patch. Clearing flags on attachment: 300871 Committed r211879: <http://trac.webkit.org/changeset/211879> 1274392 5 commit-queue 2017-02-08 09:30:44 -0800 All reviewed patches have been landed. Closing bug. 1276890 6 commit-queue 2017-02-14 13:14:08 -0800 Re-opened since this is blocked by bug 168330 1277565 7 jonlee 2017-02-16 00:37:31 -0800 Reland? 1277687 8 300871 commit-queue 2017-02-16 09:07:35 -0800 Comment on attachment 300871 Proposed patch. Clearing flags on attachment: 300871 Committed r212434: <http://trac.webkit.org/changeset/212434> 1277688 9 commit-queue 2017-02-16 09:07:39 -0800 All reviewed patches have been landed. Closing bug. 300871 2017-02-07 18:09:22 -0800 2017-02-16 09:07:35 -0800 Proposed patch. experimental_menu_patch_1.txt text/plain 4479 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTg1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAyLTA3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBXZWJSVEMgYXMg YW4gb2ZmLWJ5LWRlZmF1bHQgZXhwZXJpbWVudGFsIGZlYXR1cmUgbWVudSBpdGVtLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3OTcyCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zMDI5MzQyOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmg6 CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUHJlZmVyZW5jZXM6OnNldFBlZXJDb25uZWN0aW9uQW5kTWVkaWFTdHJlYW1FbmFibGVk KTogV2UgbmVlZCB0byBlbmFibGUvZGlzYWJsZQorICAgICAgICBwZWVyIGNvbm5lY3Rpb24gYW5k IG1lZGlhIHN0cmVhbSBwcmVmZXJlbmNlcyBhdCB0aGUgc2FtZSB0aW1lLCBzbyBzcGVjaWFsIGNh c2UgdGhlbS4KKyAgICAgICAgKFdlYktpdDo6V2ViUHJlZmVyZW5jZXM6OnNldEVuYWJsZWRGb3JG ZWF0dXJlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuaDoKKwogMjAxNy0w Mi0wNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBDb3Jy ZWN0IGluaXRpYWxpemF0aW9uIG9mIFJlc291cmNlIExvYWQgU3RhdGlzdGljcyBmb3IgdXNlIGlu IFdlYktpdFRlc3RSdW5uZXIKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJl bmNlc0RlZmluaXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL1dl YlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAkocmV2aXNpb24gMjExNzYxKQorKysgU291cmNlL1dl YktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaAkod29ya2luZyBjb3B5KQpA QCAtMjEzLDcgKzIxMyw2IEBACiAgICAgbWFjcm8oU3VicGl4ZWxDU1NPTUVsZW1lbnRNZXRyaWNz RW5hYmxlZCwgc3VicGl4ZWxDU1NPTUVsZW1lbnRNZXRyaWNzRW5hYmxlZCwgQm9vbCwgYm9vbCwg ZmFsc2UsICIiLCAiIikgXAogICAgIG1hY3JvKFVzZUdpYW50VGlsZXMsIHVzZUdpYW50VGlsZXMs IEJvb2wsIGJvb2wsIGZhbHNlLCAiIiwgIiIpIFwKICAgICBtYWNybyhNZWRpYVN0cmVhbUVuYWJs ZWQsIG1lZGlhU3RyZWFtRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAotICAg IG1hY3JvKFBlZXJDb25uZWN0aW9uRW5hYmxlZCwgcGVlckNvbm5lY3Rpb25FbmFibGVkLCBCb29s LCBib29sLCBmYWxzZSwgIiIsICIiKSBcCiAgICAgbWFjcm8oVXNlTGVnYWN5VGV4dEFsaWduUG9z aXRpb25lZEVsZW1lbnRCZWhhdmlvciwgdXNlTGVnYWN5VGV4dEFsaWduUG9zaXRpb25lZEVsZW1l bnRCZWhhdmlvciwgQm9vbCwgYm9vbCwgZmFsc2UsICIiLCAiIikgXAogICAgIG1hY3JvKFNwYXRp YWxOYXZpZ2F0aW9uRW5hYmxlZCwgc3BhdGlhbE5hdmlnYXRpb25FbmFibGVkLCBCb29sLCBib29s LCBmYWxzZSwgIiIsICIiKSBcCiAgICAgbWFjcm8oTWVkaWFTb3VyY2VFbmFibGVkLCBtZWRpYVNv dXJjZUVuYWJsZWQsIEJvb2wsIGJvb2wsIHRydWUsICIiLCAiIikgXApAQCAtMzE4LDYgKzMxNyw3 IEBACiAgICAgbWFjcm8oTGlua1ByZWxvYWRFbmFibGVkLCBsaW5rUHJlbG9hZEVuYWJsZWQsIEJv b2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQsICJMaW5rIFBy ZWxvYWQiLCAiTGluayBwcmVsb2FkIHN1cHBvcnQiKSBcCiAgICAgbWFjcm8oTW9kZXJuTWVkaWFD b250cm9sc0VuYWJsZWQsIG1vZGVybk1lZGlhQ29udHJvbHNFbmFibGVkLCBCb29sLCBib29sLCBE RUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVELCAiTW9kZXJuIE1lZGlhIENvbnRy b2xzIiwgIlVzZSBtb2Rlcm4gbWVkaWEgY29udHJvbHMgbG9vayIpIFwKICAgICBtYWNybyhJbnB1 dEV2ZW50c0VuYWJsZWQsIGlucHV0RXZlbnRzRW5hYmxlZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9F WFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCwgIklucHV0IEV2ZW50cyIsICJFbmFibGUgSW5w dXRFdmVudHMgc3VwcG9ydCIpIFwKKyAgICBtYWNybyhQZWVyQ29ubmVjdGlvbkVuYWJsZWQsIHBl ZXJDb25uZWN0aW9uRW5hYmxlZCwgQm9vbCwgYm9vbCwgZmFsc2UsICJXZWJSVEMiLCAiRW5hYmxl IFdlYlJUQyBBUEkiKSBcCiAgICAgbWFjcm8oU3VidGxlQ3J5cHRvRW5hYmxlZCwgc3VidGxlQ3J5 cHRvRW5hYmxlZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5B QkxFRCwgIlN1YnRsZUNyeXB0byIsICJFbmFibGUgU3VidGxlQ3J5cHRvIHN1cHBvcnQiKSBcCiAg ICAgbWFjcm8oVXNlclRpbWluZ0VuYWJsZWQsIHVzZXJUaW1pbmdFbmFibGVkLCBCb29sLCBib29s LCBmYWxzZSwgIlVzZXIgVGltaW5nIiwgIkVuYWJsZSBVc2VyVGltaW5nIEFQSSIpIFwKICAgICBt YWNybyhXZWJBbmltYXRpb25zRW5hYmxlZCwgd2ViQW5pbWF0aW9uc0VuYWJsZWQsIEJvb2wsIGJv b2wsIGZhbHNlLCAiV2ViIEFuaW1hdGlvbnMiLCAiV2ViIEFuaW1hdGlvbnMgcHJvdG90eXBlIikg XApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByZWZlcmVuY2VzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5jZXMuY3BwCShy ZXZpc2lvbiAyMTE3NjEpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJlZmVyZW5j ZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNTksNiArMjU5LDEyIEBAIGJvb2wgV2ViUHJlZmVy ZW5jZXM6OmlzRW5hYmxlZEZvckZlYXR1cmUKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKK3ZvaWQg V2ViUHJlZmVyZW5jZXM6OnNldFBlZXJDb25uZWN0aW9uQW5kTWVkaWFTdHJlYW1FbmFibGVkKGJv b2wgdmFsdWUpCit7CisgICAgc2V0UGVlckNvbm5lY3Rpb25FbmFibGVkKHZhbHVlKTsKKyAgICBz ZXRNZWRpYVN0cmVhbUVuYWJsZWQodmFsdWUpOworfQorCiB2b2lkIFdlYlByZWZlcmVuY2VzOjpz ZXRFbmFibGVkRm9yRmVhdHVyZShib29sIHZhbHVlLCBjb25zdCBBUEk6OkV4cGVyaW1lbnRhbEZl YXR1cmUmIGZlYXR1cmUpCiB7CiAgICAgc3RydWN0IEZlYXR1cmVTZXR0ZXJNYXBwaW5nIHsKQEAg LTI3OSw3ICsyODUsMTAgQEAgdm9pZCBXZWJQcmVmZXJlbmNlczo6c2V0RW5hYmxlZEZvckZlYXR1 cgogICAgIAogICAgIGZvciAoYXV0byYgc2V0dGVyIDogc2V0dGVycykgewogICAgICAgICBpZiAo a2V5ID09IHNldHRlci5uYW1lKSB7Ci0gICAgICAgICAgICAodGhpcy0+KnNldHRlci5mdW5jdGlv bikodmFsdWUpOworICAgICAgICAgICAgaWYgKGtleSA9PSBXZWJQcmVmZXJlbmNlc0tleTo6cGVl ckNvbm5lY3Rpb25FbmFibGVkS2V5KCkpCisgICAgICAgICAgICAgICAgc2V0UGVlckNvbm5lY3Rp b25BbmRNZWRpYVN0cmVhbUVuYWJsZWQodmFsdWUpOworICAgICAgICAgICAgZWxzZQorICAgICAg ICAgICAgICAgICh0aGlzLT4qc2V0dGVyLmZ1bmN0aW9uKSh2YWx1ZSk7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KICAgICB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUHJlZmVyZW5jZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUHJlZmVyZW5jZXMuaAkocmV2aXNpb24gMjExNzYxKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlByZWZlcmVuY2VzLmgJKHdvcmtpbmcgY29weSkKQEAgLTkzLDYgKzkzLDggQEAg cHJpdmF0ZToKIAogICAgIHZvaWQgdXBkYXRlUHJpdmF0ZUJyb3dzaW5nVmFsdWUoYm9vbCB2YWx1 ZSk7CiAKKyAgICB2b2lkIHNldFBlZXJDb25uZWN0aW9uQW5kTWVkaWFTdHJlYW1FbmFibGVkKGJv b2wgdmFsdWUpOworCiAgICAgdm9pZCByZWdpc3RlckRlZmF1bHRCb29sVmFsdWVGb3JLZXkoY29u c3QgU3RyaW5nJiwgYm9vbCk7CiAgICAgdm9pZCByZWdpc3RlckRlZmF1bHRVSW50MzJWYWx1ZUZv cktleShjb25zdCBTdHJpbmcmLCB1aW50MzJfdCk7CiAK