167931 2017-02-07 06:04:22 -0800 [GTK][Efl] Do not require LibXslt if XSLT is disabled 2017-02-07 09:22:33 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned annulen aperez bugs-noreply commit-queue gyuyoung.kim mcatanzaro zan oldest_to_newest 1273967 0 olivier.blin 2017-02-07 06:04:22 -0800 Build with --no-xslt fails when the libxslt dev files are not installed, while they are not needed. 1273975 1 300807 olivier.blin 2017-02-07 06:44:16 -0800 Created attachment 300807 Patch 1273976 2 olivier.blin 2017-02-07 06:45:40 -0800 As a side note, this has been noticed on WebKitForWayland first, it would be nice to factorize options that are common to non-Apple ports (GTK, Efl, WPE, Qt). 1274000 3 300807 mcatanzaro 2017-02-07 08:36:51 -0800 Comment on attachment 300807 Patch I don't think we should support building with ENABLE_XSLT=OFF. Why do you want to do this? 1274004 4 annulen 2017-02-07 08:42:38 -0800 FWIW, I do this to avoid extra dependency and reduce WebKit size a bit for embedded system, XSLT is not a very popular Web feature 1274005 5 olivier.blin 2017-02-07 08:45:06 -0800 Because I don't need libxslt and the XSL stylesheets feature in my embedded systems (set-top boxes). 1274010 6 300807 mcatanzaro 2017-02-07 08:56:22 -0800 Comment on attachment 300807 Patch *grumble not supported grumble* 1274014 7 aperez 2017-02-07 09:02:47 -0800 It makes sense to be able to disable seldom used features (like XSLT) at build time, when targeting embedded hardware with limited resources. This is something that it's interesting to support. XSLT should be enabled and built by default, though. As long as the proposed patch keeps XSLT enabled unless explicitly disabled, it looks good to me. 1274025 8 300807 commit-queue 2017-02-07 09:22:28 -0800 Comment on attachment 300807 Patch Clearing flags on attachment: 300807 Committed r211813: <http://trac.webkit.org/changeset/211813> 1274026 9 commit-queue 2017-02-07 09:22:33 -0800 All reviewed patches have been landed. Closing bug. 300807 2017-02-07 06:44:16 -0800 2017-02-07 09:22:28 -0800 Patch bug-167931-20170207154154.patch text/plain 2476 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGFjZWU1 NDA4YjYyMzFiYjA1OTQwZWQwNWFkNWM4YWE2MTI1YmRmMjMuLjljNjA0YTlhNmE2NjQ3NGNiZGVj ZGY4MTJhOTVmNTkyM2Q5ZTczNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0xNDAsNyArMTQw LDYgQEAgZmluZF9wYWNrYWdlKENhaXJvIDEuMTAuMiBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShG b250Y29uZmlnIDIuOC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKExpYkdjcnlwdCAxLjYuMCBS RVFVSVJFRCkKIGZpbmRfcGFja2FnZShMaWJYbWwyIDIuOC4wIFJFUVVJUkVEKQotZmluZF9wYWNr YWdlKExpYlhzbHQgMS4xLjcgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoSUNVIFJFUVVJUkVEKQog ZmluZF9wYWNrYWdlKEpQRUcgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUE5HIFJFUVVJUkVEKQpA QCAtMTQ5LDYgKzE0OCwxMCBAQCBmaW5kX3BhY2thZ2UoVGhyZWFkcyBSRVFVSVJFRCkKIGZpbmRf cGFja2FnZShXZWJQIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFpMSUIgUkVRVUlSRUQpCiAKK2lm IChFTkFCTEVfWFNMVCkKKyAgICBmaW5kX3BhY2thZ2UoTGliWHNsdCAxLjEuNyBSRVFVSVJFRCkK K2VuZGlmICgpCisKIG9wdGlvbihFTkFCTEVfRUNPUkVfWCAiRW5hYmxlIEVjb3JlX1ggc3BlY2lm aWMgdXNhZ2UgKGN1cnNvciwgYmVsbCkiIE9OKQogaWYgKEVOQUJMRV9FQ09SRV9YKQogICAgICMg V2UgbmVlZCBYZXh0LmggdG8gZGlzYWJsZSBYbGliIGVycm9yIG1lc3NhZ2VzICB3aGVuIHJ1bm5p bmcgV1RSIG9uIFh2ZmIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFr ZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDcxZTFjYjAwZmY3YTZjYzky NmEwYTM4YjY4NjVmNzA0NjZhNWYzMWQuLjI5ODc2NTQxOWNjZWVjMWE1ZTQ3MWJmNTZhMjBjYTRh OTAyOTMyMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC00MCw3ICs0MCw2IEBAIGZpbmRfcGFj a2FnZShJQ1UgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoSlBFRyBSRVFVSVJFRCkKIGZpbmRfcGFj a2FnZShMaWJTb3VwIDIuNDIuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShMaWJYbWwyIDIuOC4w IFJFUVVJUkVEKQotZmluZF9wYWNrYWdlKExpYlhzbHQgMS4xLjcgUkVRVUlSRUQpCiBmaW5kX3Bh Y2thZ2UoUE5HIFJFUVVJUkVEKQogZmluZF9wYWNrYWdlKFNxbGl0ZSBSRVFVSVJFRCkKIGZpbmRf cGFja2FnZShUaHJlYWRzIFJFUVVJUkVEKQpAQCAtMjIwLDYgKzIxOSwxMCBAQCBpZiAoRU5BQkxF X0dBTUVQQURfREVQUkVDQVRFRCBPUiBFTkFCTEVfR0VPTE9DQVRJT04pCiBlbmRpZiAoKQogZmlu ZF9wYWNrYWdlKEdMSUIgMi4zNiBSRVFVSVJFRCBDT01QT05FTlRTICR7Z2xpYl9jb21wb25lbnRz fSkKIAoraWYgKEVOQUJMRV9YU0xUKQorICAgIGZpbmRfcGFja2FnZShMaWJYc2x0IDEuMS43IFJF UVVJUkVEKQorZW5kaWYgKCkKKwogaWYgKEVOQUJMRV9BQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCiAg ICAgaWYgKEdMWF9GT1VORCkKICAgICAgICAgbGlzdChBUFBFTkQgQ0FJUk9HTF9DT01QT05FTlRT IGNhaXJvLWdseCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZGZk MzI0ZmQ3ZDkyZDE0MzdhOTg2NjBmMWZkN2ZiZWMzN2NjOWExLi40ZDhjZmFhOTY2MTFlNTk2Nzhk MTU4ZGNmYjlmZDkzMmExZjE4OThhIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDItMDcgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIu YmxpbkBzb2Z0YXRob21lLmNvbT4KKworICAgICAgICBbR1RLXVtFZmxdIERvIG5vdCByZXF1aXJl IExpYlhzbHQgaWYgWFNMVCBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3OTMxCisKKyAgICAgICAgVGhpcyBmaXhlcyBidWlsZCB3 aXRoIC0tbm8teHNsdCwgd2hlbiB0aGUgbGlieHNsdCBkZXYgZmlsZXMgYXJlIG5vdCBpbnN0YWxs ZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZToKKwogMjAxNy0wMi0wMyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxl bkB5YW5kZXgucnU+CiAKICAgICAgICAgW0NNYWtlXSBSZWxXaXRoRGViSW5mbyBidWlsZHMgYXJl IHN1cGVyIGJyb2tlbiBhdCBydW50aW1lCg==