167912 2017-02-06 16:38:51 -0800 ExtendedColor leaks seen on leaks bot 2017-02-06 18:41:35 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck ap commit-queue dino oldest_to_newest 1273768 0 joepeck 2017-02-06 16:38:51 -0800 ExtendedColor leaks seen on leaks bot Test: WebCore::Color c1(1.0, 0.5, 0.25, 1.0, WebCore::ColorSpaceDisplayP3); WebCore::Color c2(0.1, 0.5, 0.25, 1.0, WebCore::ColorSpaceDisplayP3); c1 = WTFMove(c2); Leak: Leak: 0x7fdda21060f0 size=32 zone: WebKit Using System Malloc_0x10f14c000 0x00000001 0x60000000 0x3f800000 0x3f000000 .......`...?...? 0x3e800000 0x3f800000 0x00000003 0x706d6f63 ...>...?....comp Call stack: [thread 0x7fffc18523c0]: | 0x1 | start ... | WebKit::testLeak() | WebCore::Color::Color(float, float, float, float, WebCore::ColorSpace) Color.cpp:308 | WebCore::Color::Color(float, float, float, float, WebCore::ColorSpace) Color.cpp:305 | WebCore::ExtendedColor::create(float, float, float, float, WebCore::ColorSpace) ExtendedColor.cpp:38 | WTF::RefCounted<WebCore::ExtendedColor>::operator new(unsigned long) RefCounted.h:140 | WTF::fastMalloc(unsigned long) FastMalloc.cpp:256 | bmalloc::api::malloc(unsigned long) bmalloc.h:43 | bmalloc::Cache::allocate(unsigned long) Cache.h:80 | bmalloc::Allocator::allocate(unsigned long) Allocator.h:89 | bmalloc::Allocator::allocateSlowCase(unsigned long) Allocator.cpp:187 | bmalloc::DebugHeap::malloc(unsigned long) DebugHeap.cpp:44 1273770 1 300767 joepeck 2017-02-06 16:43:31 -0800 Created attachment 300767 [PATCH] Proposed Fix 1273814 2 300767 commit-queue 2017-02-06 18:41:31 -0800 Comment on attachment 300767 [PATCH] Proposed Fix Clearing flags on attachment: 300767 Committed r211768: <http://trac.webkit.org/changeset/211768> 1273815 3 commit-queue 2017-02-06 18:41:35 -0800 All reviewed patches have been landed. Closing bug. 300767 2017-02-06 16:43:31 -0800 2017-02-06 18:41:31 -0800 [PATCH] Proposed Fix color-1.patch text/plain 1279 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjI3OWY4MzYxMi4uZDMyNTlhODhjN2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNiBAQAogMjAxNy0wMi0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIEV4dGVuZGVkQ29sb3IgbGVha3Mgc2VlbiBvbiBsZWFrcyBib3QKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzkxMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvQ29sb3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29sb3I6Om9wZXJhdG9yPSk6 CisgICAgICAgIEJlZm9yZSBvdmVyd3JpdGluZyBtX2NvbG9yRGF0YSwgd2UgbXVzdCBkZXJlZiB0 aGUgZXh0ZW5kZWQgY29sb3IgaW5zaWRlIGl0LgorCisyMDE3LTAyLTA2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IHVzZSBSdW5Mb29wIHdoZW4gZGlzcGF0Y2hpbmcgaW5zcGVjdG9yIEdDIGV2ZW50CiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc2ODMKICAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzMwMTY3NzkxPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvQ29sb3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvQ29sb3IuY3BwCmluZGV4IDU2MmZlNWVjZmQyLi5mYTU2N2NjNzU2YyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3IuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcApAQCAtMzMzLDYgKzMzMyw5IEBAIENv bG9yJiBDb2xvcjo6b3BlcmF0b3I9KENvbG9yJiYgb3RoZXIpCiAgICAgaWYgKCp0aGlzID09IG90 aGVyKQogICAgICAgICByZXR1cm4gKnRoaXM7CiAKKyAgICBpZiAoaXNFeHRlbmRlZCgpKQorICAg ICAgICBtX2NvbG9yRGF0YS5leHRlbmRlZENvbG9yLT5kZXJlZigpOworCiAgICAgbV9jb2xvckRh dGEgPSBvdGhlci5tX2NvbG9yRGF0YTsKICAgICBvdGhlci5tX2NvbG9yRGF0YS5yZ2JhQW5kRmxh Z3MgPSBpbnZhbGlkUkdCQUNvbG9yOwogCg==