167898 2017-02-06 12:05:55 -0800 [iOS] -[WKWebView becomeFirstResponder] and -[WKWebView resignFirstResponder] don’t get called when non-programmatic first responder changes happen 2017-02-06 20:25:38 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz thorton oldest_to_newest 1273674 0 mitz 2017-02-06 12:05:55 -0800 Because the child WKContentView can and does become first responder, WKWebView’s -becomeFirstResponder never gets called by UIKit. Similarly, because the WKWebView is never the first responder, its -resignFirstResponder is never called. This means that overrides of these methods in a WKWebView subclass normally don’t get called. 1273806 1 300776 mitz 2017-02-06 18:04:01 -0800 Created attachment 300776 Make WKContentView’s -becomeFirstResponder and -resignFirstResponder forward to the WKWebView 1273807 2 300776 thorton 2017-02-06 18:07:37 -0800 Comment on attachment 300776 Make WKContentView’s -becomeFirstResponder and -resignFirstResponder forward to the WKWebView View in context: https://bugs.webkit.org/attachment.cgi?id=300776&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1017 > + if (currentContentView == _contentView && [_contentView superview]) usesStandardContentView? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:854 > + _becomingFirstResponder = YES; ScopedChange? or whatever we called it? 1273838 3 mitz 2017-02-06 20:25:38 -0800 Fixed in <https://trac.webkit.org/r211770>. 300776 2017-02-06 18:04:01 -0800 2017-02-06 18:07:37 -0800 Make WKContentView’s -becomeFirstResponder and -resignFirstResponder forward to the WKWebView bug-167898-20170206180140.patch text/plain 7288 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTc2MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQxIEBACisyMDE3LTAyLTA2ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gLVtXS1dlYlZpZXcgYmVj b21lRmlyc3RSZXNwb25kZXJdIGFuZCAtW1dLV2ViVmlldyByZXNpZ25GaXJzdFJlc3BvbmRlcl0g ZG9u4oCZdCBnZXQgY2FsbGVkIHdoZW4gbm9uLXByb2dyYW1tYXRpYyBmaXJzdCByZXNwb25kZXIg Y2hhbmdlcyBoYXBwZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2Nzg5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE1hZGUgV0tDb250ZW50Vmlld+KAmXMgLWJlY29tZUZpcnN0UmVzcG9uZGVyIGFuZCAt cmVzaWduRmlyc3RSZXNwb25kZXIgZm9yd2FyZCB0byB0aGUKKyAgICAgICAgV0tXZWJWaWV3LCBn aXZpbmcgc3ViY2xhc3NlcyBhbiBvcHBvcnR1bml0eSB0byBvdmVycmlkZSB0aGVzZSBtZXRob2Rz LiBDaGFuZ2VkIHRoZSBXS1dlYlZpZXcKKyAgICAgICAgaW1wbGVtZW50YXRpb25zIHRvIGNhbGwg YmFjayBpbnRvIFdLQ29udGVudFZpZXcgbWV0aG9kcyB0aGF0IGFjdHVhbGx5IGRvIHRoZSB3b3Jr LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAg ICgtW1dLV2ViVmlldyBiZWNvbWVGaXJzdFJlc3BvbmRlcl0pOiBJZiB0aGUgY3VycmVudCBjb250 ZW50IHZpZXcgaXMgYSBXS0NvbnRlbnRWaWV3LCBjYWxsCisgICAgICAgICAgLWJlY29tZUZpcnN0 UmVzcG9uZGVyRm9yV2ViVmlldy4gQWRkZWQgYSBjaGVjayB0aGF0IHRoZSBjb250ZW50IHZpZXcg aGFzIGEgc3VwZXJ2aWV3IHRvCisgICAgICAgICAgZ2V0IHRoZSByaWdodCBiZWhhdmlvciB3aGVu IHRoaXMgaXMgY2FsbGVkIGR1cmluZyB0aGUgdHJhbnNpdGlvbiBmcm9tIG5vdCBoYXZpbmcgdG8g aGF2aW5nCisgICAgICAgICAgYSBjdXN0b20gY29udGVudCB2aWV3LgorICAgICAgICAoLVtXS1dl YlZpZXcgY2FuQmVjb21lRmlyc3RSZXNwb25kZXJdKTogSWYgdGhlIGN1cnJlbnQgY29udGVudCB2 aWV3IGlzIGEgV0tDb250ZW50VmlldywgY2FsbAorICAgICAgICAgIC1jYW5CZWNvbWVGaXJzdFJl c3BvbmRlckZvcldlYlZpZXcuCisgICAgICAgICgtW1dLV2ViVmlldyByZXNpZ25GaXJzdFJlc3Bv bmRlcl0pOiBJZiB0aGUgY3VycmVudCBjb250ZW50IHZpZXcgaXMgYSBXS0NvbnRlbnRWaWV3LCBj YWxsCisgICAgICAgICAgLXJlc2lnbkZpcnN0UmVzcG9uZGVyRm9yV2ViVmlldy4KKyAgICAgICAg KC1bV0tXZWJWaWV3IF9zZXRIYXNDdXN0b21Db250ZW50Vmlldzpsb2FkZWRNSU1FVHlwZTpdKTog SWYgdGhlIG5ldyBjb250ZW50IHZpZXcgaXMgYQorICAgICAgICAgIFdLQ29udGVudFZpZXcsIHVz ZSAtY2FuQmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3LgorCisgICAgICAgICogVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaDogQWRkZWQgX2JlY29taW5nRmlyc3RS ZXNwb25kZXIgaXZhci4KKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBjYW5CZWNvbWVGaXJzdFJlc3Bv bmRlcl0pOiBSZXR1cm4gX2JlY29taW5nRmlyc3RSZXNwb25kZXIuIE5vcm1hbGx5IHRoaXMgaXMK KyAgICAgICAgICBOTywgc28gY29kZSB0aGF0IGhpdC10ZXN0cyB0aGVuIHdhbGtzIHVwIHRoZSB2 aWV3IGhpZXJhcmNoeSB0byBzZWxlY3QgYSBmaXJzdCByZXNwb25kZXIKKyAgICAgICAgICB3aWxs IGNvbnRpbnVlIHRvIHRoZSBXS1dlYlZpZXcuIEJ1dCB3ZSBuZWVkIHRvIHJldHVybiBZRVMgYXJv dW5kIHRoZSBjYWxsIHRvIHN1cGVy4oCZcworICAgICAgICAgIC1iZWNvbWVGaXJzdFJlc3BvbmRl ciBpbiAtYmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3LgorICAgICAgICAoLVtXS0NvbnRl bnRWaWV3IGNhbkJlY29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld10pOiBNb3ZlZCB0aGUgb2xk CisgICAgICAgICAgLWJlY29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlldyBpbXBsZW1lbnRhdGlv biBoZXJlLgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyXSk6 IEZvcndhcmQgdG8gdGhlIFdLV2ViVmlldy4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBiZWNv bWVGaXJzdFJlc3BvbmRlckZvcldlYlZpZXddKTogTW92ZWQgdGhlIG9sZCAtYmVjb21lRmlyc3RS ZXNwb25kZXIKKyAgICAgICAgICBpbXBsZW1lbnRhdGlvbiBoZXJlLCBzZXR0aW5nIF9iZWNvbWlu Z0ZpcnN0UmVzcG9uZGVyIHRvIFlFUyBhcm91bmQgdGhlIGNhbGwgdG8gc3VwZXIuCisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgcmVzaWduRmlyc3RSZXNwb25kZXJdKTogRm9yd2FyZCB0byB0aGUg V0tXZWJWaWV3LgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHJlc2lnbkZpcnN0UmVzcG9uZGVy Rm9yV2ViVmlld10pOiBNb3ZlZCB0aGUgb2xkIC1yZXNpZ25GaXJzdFJlc3BvbmRlcgorICAgICAg ICAgIGltcGxlbWVudGF0aW9uIGhlcmUuCisKIDIwMTctMDItMDYgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgVGlsZWQgc2Nyb2xsaW5nIGluZGljYXRv ciBnZXRzIGRvdWJsZWQgdXAgb24gbmF2aWdhdGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlzaW9uIDIxMTY5NikKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xMDEzLDE2ICsxMDEzLDI5IEBAIC0gKFdLQnJvd3NpbmdDb250ZXh0Q29udHJv bGxlciAqKWJyb3dzaW4KIAogLSAoQk9PTCliZWNvbWVGaXJzdFJlc3BvbmRlcgogewotICAgIHJl dHVybiBbc2VsZi5fY3VycmVudENvbnRlbnRWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyXSB8fCBb c3VwZXIgYmVjb21lRmlyc3RSZXNwb25kZXJdOworICAgIFVJVmlldyAqY3VycmVudENvbnRlbnRW aWV3ID0gc2VsZi5fY3VycmVudENvbnRlbnRWaWV3OworICAgIGlmIChjdXJyZW50Q29udGVudFZp ZXcgPT0gX2NvbnRlbnRWaWV3ICYmIFtfY29udGVudFZpZXcgc3VwZXJ2aWV3XSkKKyAgICAgICAg cmV0dXJuIFtfY29udGVudFZpZXcgYmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XSB8fCBb c3VwZXIgYmVjb21lRmlyc3RSZXNwb25kZXJdOworCisgICAgcmV0dXJuIFtjdXJyZW50Q29udGVu dFZpZXcgYmVjb21lRmlyc3RSZXNwb25kZXJdIHx8IFtzdXBlciBiZWNvbWVGaXJzdFJlc3BvbmRl cl07CiB9CiAKIC0gKEJPT0wpY2FuQmVjb21lRmlyc3RSZXNwb25kZXIKIHsKLSAgICBpZiAoc2Vs Zi5fY3VycmVudENvbnRlbnRWaWV3ID09IF9jb250ZW50VmlldyAmJiBbX2NvbnRlbnRWaWV3IGlz UmVzaWduaW5nRmlyc3RSZXNwb25kZXJdKQotICAgICAgICByZXR1cm4gTk87CisgICAgaWYgKHNl bGYuX2N1cnJlbnRDb250ZW50VmlldyA9PSBfY29udGVudFZpZXcpCisgICAgICAgIHJldHVybiBb X2NvbnRlbnRWaWV3IGNhbkJlY29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld107CisKICAgICBy ZXR1cm4gWUVTOwogfQogCistIChCT09MKXJlc2lnbkZpcnN0UmVzcG9uZGVyCit7CisgICAgaWYg KFtfY29udGVudFZpZXcgaXNGaXJzdFJlc3BvbmRlcl0pCisgICAgICAgIHJldHVybiBbX2NvbnRl bnRWaWV3IHJlc2lnbkZpcnN0UmVzcG9uZGVyRm9yV2ViVmlld107CisKKyAgICByZXR1cm4gW3N1 cGVyIHJlc2lnbkZpcnN0UmVzcG9uZGVyXTsKK30KKwogc3RhdGljIGlubGluZSBDR0Zsb2F0IGZs b29yVG9EZXZpY2VQaXhlbChDR0Zsb2F0IGlucHV0LCBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvcikK IHsKICAgICByZXR1cm4gQ0dGbG9vcihpbnB1dCAqIGRldmljZVNjYWxlRmFjdG9yKSAvIGRldmlj ZVNjYWxlRmFjdG9yOwpAQCAtMTA4OSw4ICsxMTAyLDExIEBAIC0gKHZvaWQpX3NldEhhc0N1c3Rv bUNvbnRlbnRWaWV3OihCT09MKXAKICAgICAgICAgW3NlbGYgYWRkU3VidmlldzpfY3VzdG9tQ29u dGVudEZpeGVkT3ZlcmxheVZpZXcuZ2V0KCldOwogICAgIH0KIAotICAgIGlmIChzZWxmLmlzRmly c3RSZXNwb25kZXIgJiYgc2VsZi5fY3VycmVudENvbnRlbnRWaWV3LmNhbkJlY29tZUZpcnN0UmVz cG9uZGVyKQotICAgICAgICBbc2VsZi5fY3VycmVudENvbnRlbnRWaWV3IGJlY29tZUZpcnN0UmVz cG9uZGVyXTsKKyAgICBpZiAoc2VsZi5pc0ZpcnN0UmVzcG9uZGVyKSB7CisgICAgICAgIFVJVmll dyAqY3VycmVudENvbnRlbnRWaWV3ID0gc2VsZi5fY3VycmVudENvbnRlbnRWaWV3OworICAgICAg ICBpZiAoY3VycmVudENvbnRlbnRWaWV3ID09IF9jb250ZW50VmlldyA/IFtfY29udGVudFZpZXcg Y2FuQmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3XSA6IGN1cnJlbnRDb250ZW50Vmlldy5j YW5CZWNvbWVGaXJzdFJlc3BvbmRlcikKKyAgICAgICAgICAgIFtjdXJyZW50Q29udGVudFZpZXcg YmVjb21lRmlyc3RSZXNwb25kZXJdOworICAgIH0KIH0KIAogLSAodm9pZClfZGlkRmluaXNoTG9h ZGluZ0RhdGFGb3JDdXN0b21Db250ZW50UHJvdmlkZXJXaXRoU3VnZ2VzdGVkRmlsZW5hbWU6KGNv bnN0IFN0cmluZyYpc3VnZ2VzdGVkRmlsZW5hbWUgZGF0YTooTlNEYXRhICopZGF0YQpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24uaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5oCShyZXZpc2lvbiAyMTE2OTYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODQs NiArMTg0LDcgQEAgc3RydWN0IFdLQXV0b0NvcnJlY3Rpb25EYXRhIHsKICAgICBCT09MIF9pc0V4 cGVjdGluZ0Zhc3RTaW5nbGVUYXBDb21taXQ7CiAgICAgQk9PTCBfc2hvd0RlYnVnVGFwSGlnaGxp Z2h0c0ZvckZhc3RDbGlja2luZzsKIAorICAgIEJPT0wgX2JlY29taW5nRmlyc3RSZXNwb25kZXI7 CiAgICAgQk9PTCBfcmVzaWduaW5nRmlyc3RSZXNwb25kZXI7CiAgICAgQk9PTCBfbmVlZHNEZWZl cnJlZEVuZFNjcm9sbGluZ1NlbGVjdGlvblVwZGF0ZTsKIApAQCAtMjEzLDYgKzIxNCwxMCBAQCBz dHJ1Y3QgV0tBdXRvQ29ycmVjdGlvbkRhdGEgewogCiAtICh2b2lkKXNjcm9sbFZpZXdXaWxsU3Rh cnRQYW5PclBpbmNoR2VzdHVyZTsKIAorLSAoQk9PTCljYW5CZWNvbWVGaXJzdFJlc3BvbmRlckZv cldlYlZpZXc7CistIChCT09MKWJlY29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlldzsKKy0gKEJP T0wpcmVzaWduRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3OworCiAjaWYgRU5BQkxFKFRPVUNIX0VW RU5UUykKIC0gKHZvaWQpX3dlYlRvdWNoRXZlbnQ6KGNvbnN0IFdlYktpdDo6TmF0aXZlV2ViVG91 Y2hFdmVudCYpdG91Y2hFdmVudCBwcmV2ZW50c05hdGl2ZUdlc3R1cmVzOihCT09MKXByZXZlbnRz RGVmYXVsdDsKICNlbmRpZgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0JKHJldmlzaW9uIDIxMTY5NikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC04MzAsNiArODMwLDExIEBAIC0gKEJPT0wpc2V0SXNFZGl0 YWJsZTooQk9PTClpc0VkaXRhYmxlCiAKIC0gKEJPT0wpY2FuQmVjb21lRmlyc3RSZXNwb25kZXIK IHsKKyAgICByZXR1cm4gX2JlY29taW5nRmlyc3RSZXNwb25kZXI7Cit9CisKKy0gKEJPT0wpY2Fu QmVjb21lRmlyc3RSZXNwb25kZXJGb3JXZWJWaWV3Cit7CiAgICAgaWYgKF9yZXNpZ25pbmdGaXJz dFJlc3BvbmRlcikKICAgICAgICAgcmV0dXJuIE5POwogICAgIC8vIFdlIG1pZ2h0IHdhbnQgdG8g cmV0dXJuIHNvbWV0aGluZyBlbHNlCkBAIC04MzksOSArODQ0LDE2IEBAIC0gKEJPT0wpY2FuQmVj b21lRmlyc3RSZXNwb25kZXIKIAogLSAoQk9PTCliZWNvbWVGaXJzdFJlc3BvbmRlcgogeworICAg IHJldHVybiBbX3dlYlZpZXcgYmVjb21lRmlyc3RSZXNwb25kZXJdOworfQorCistIChCT09MKWJl Y29tZUZpcnN0UmVzcG9uZGVyRm9yV2ViVmlldworewogICAgIGlmIChfcmVzaWduaW5nRmlyc3RS ZXNwb25kZXIpCiAgICAgICAgIHJldHVybiBOTzsKKyAgICBfYmVjb21pbmdGaXJzdFJlc3BvbmRl ciA9IFlFUzsKICAgICBCT09MIGRpZEJlY29tZUZpcnN0UmVzcG9uZGVyID0gW3N1cGVyIGJlY29t ZUZpcnN0UmVzcG9uZGVyXTsKKyAgICBfYmVjb21pbmdGaXJzdFJlc3BvbmRlciA9IE5POwogICAg IGlmIChkaWRCZWNvbWVGaXJzdFJlc3BvbmRlcikKICAgICAgICAgW190ZXh0U2VsZWN0aW9uQXNz aXN0YW50IGFjdGl2YXRlU2VsZWN0aW9uXTsKIApAQCAtODUwLDYgKzg2MiwxMSBAQCAtIChCT09M KWJlY29tZUZpcnN0UmVzcG9uZGVyCiAKIC0gKEJPT0wpcmVzaWduRmlyc3RSZXNwb25kZXIKIHsK KyAgICByZXR1cm4gW193ZWJWaWV3IHJlc2lnbkZpcnN0UmVzcG9uZGVyXTsKK30KKworLSAoQk9P TClyZXNpZ25GaXJzdFJlc3BvbmRlckZvcldlYlZpZXcKK3sKICAgICAvLyBGSVhNRTogTWF5YmUg d2Ugc2hvdWxkIGNhbGwgcmVzaWduRmlyc3RSZXNwb25kZXIgb24gdGhlIHN1cGVyY2xhc3MKICAg ICAvLyBhbmQgZG8gbm90aGluZyBpZiB0aGUgcmV0dXJuIHZhbHVlIGlzIE5PLgogCg==