167890 2017-02-06 10:14:54 -0800 [Soup] Long resources loaded by custom protocols sometimes never finish loading 2017-02-06 22:14:35 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Soup P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro tpopela oldest_to_newest 1273615 0 cgarcia 2017-02-06 10:14:54 -0800 It's another bug that has appeared in WebKitSoupRequestInputStream after moving the custom protocols handling to the main thread. The problem is that webkitSoupRequestInputStreamPendingReadAsyncComplete invalidates pendingAsyncRead after calling webkitSoupRequestInputStreamReadAsyncResultComplete, but in some cases webkitSoupRequestInputStreamReadAsyncResultComplete completes the task in the same run loop iteration. In that case webkitSoupRequestInputStreamReadAsync is called again creating a new AsyncReadData that is destroyed right after webkitSoupRequestInputStreamReadAsyncResultComplete returns. 1273616 1 300731 cgarcia 2017-02-06 10:19:48 -0800 Created attachment 300731 Patch 1273625 2 mcatanzaro 2017-02-06 10:35:50 -0800 Could this be the cause of bug #167887? 1273863 3 cgarcia 2017-02-06 22:04:58 -0800 (In reply to comment #2) > Could this be the cause of bug #167887? I don't think so. I haven't looked at the yelp issue yet, but I would bet it's the same volume check. 1273865 4 cgarcia 2017-02-06 22:14:35 -0800 Committed r211773: <http://trac.webkit.org/changeset/211773> 300731 2017-02-06 10:19:48 -0800 2017-02-06 10:36:45 -0800 Patch wk2-custom-protocols-long.diff text/plain 4631 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlNDQ5MDYwNDlmMy4uYmQ2MTNkMzJkMjMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNyBAQAogMjAxNy0wMi0wNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW1NvdXBdIExvbmcgcmVzb3VyY2VzIGxvYWRlZCBieSBjdXN0 b20gcHJvdG9jb2xzIHNvbWV0aW1lcyBuZXZlciBmaW5pc2ggbG9hZGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODkwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQncyBhbm90aGVyIGJ1ZyB0aGF0 IGhhcyBhcHBlYXJlZCBpbiBXZWJLaXRTb3VwUmVxdWVzdElucHV0U3RyZWFtIGFmdGVyIG1vdmlu ZyB0aGUgY3VzdG9tIHByb3RvY29scyBoYW5kbGluZyB0bworICAgICAgICB0aGUgbWFpbiB0aHJl YWQuIFRoZSBwcm9ibGVtIGlzIHRoYXQgd2Via2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbVBlbmRp bmdSZWFkQXN5bmNDb21wbGV0ZSBpbnZhbGlkYXRlcworICAgICAgICBwZW5kaW5nQXN5bmNSZWFk IGFmdGVyIGNhbGxpbmcgd2Via2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbVJlYWRBc3luY1Jlc3Vs dENvbXBsZXRlLCBidXQgaW4gc29tZSBjYXNlcworICAgICAgICB3ZWJraXRTb3VwUmVxdWVzdElu cHV0U3RyZWFtUmVhZEFzeW5jUmVzdWx0Q29tcGxldGUgY29tcGxldGVzIHRoZSB0YXNrIGluIHRo ZSBzYW1lIHJ1biBsb29wIGl0ZXJhdGlvbi4gSW4gdGhhdAorICAgICAgICBjYXNlIHdlYmtpdFNv dXBSZXF1ZXN0SW5wdXRTdHJlYW1SZWFkQXN5bmMgaXMgY2FsbGVkIGFnYWluIGNyZWF0aW5nIGEg bmV3IEFzeW5jUmVhZERhdGEgdGhhdCBpcyBkZXN0cm95ZWQgcmlnaHQKKyAgICAgICAgYWZ0ZXIg d2Via2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbVJlYWRBc3luY1Jlc3VsdENvbXBsZXRlIHJldHVy bnMuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL3NvdXAvV2ViS2l0U291cFJlcXVlc3RJbnB1dFN0 cmVhbS5jcHA6CisgICAgICAgIChBc3luY1JlYWREYXRhOjpBc3luY1JlYWREYXRhKTogVXNlIGFu IHJ2YWx1ZSByZWZlcmVuY2UgZm9yIHRoZSB0YXNrLgorICAgICAgICAod2Via2l0U291cFJlcXVl c3RJbnB1dFN0cmVhbVBlbmRpbmdSZWFkQXN5bmNDb21wbGV0ZSk6IFVzZSBXVEZNb3ZlIHRvIGVu c3VyZSBwZW5kaW5nQXN5bmNSZWFkIGlzIGNsZWFyZWQgYmVmb3JlCisgICAgICAgIHdlYmtpdFNv dXBSZXF1ZXN0SW5wdXRTdHJlYW1SZWFkQXN5bmNSZXN1bHRDb21wbGV0ZSBpcyBjYWxsZWQsIGFu ZCBjb250aW51ZSBwcm9jZXNzaW5nIHBlbmRpbmcgcmVxdWVzdHMgaWYgdGhlcmUKKyAgICAgICAg YXJlIG5ldyBvbmVzIGFmdGVyIHdlYmtpdFNvdXBSZXF1ZXN0SW5wdXRTdHJlYW1SZWFkQXN5bmNS ZXN1bHRDb21wbGV0ZS4KKyAgICAgICAgKHdlYmtpdFNvdXBSZXF1ZXN0SW5wdXRTdHJlYW1SZWFk QXN5bmMpOiBVc2UgV1RGTW92ZSB0byB0cmFuc2ZlciB0aGUgdGFzayB0byBBc3luY1JlYWREYXRh LgorICAgICAgICAod2Via2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbURpZEZhaWxXaXRoRXJyb3Ip OiBVc2UgV1RGTW92ZSB0byBlbnN1cmUgcGVuZGluZ0FzeW5jUmVhZCBpcyBjbGVhcmVkLgorCisy MDE3LTAyLTA2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwog ICAgICAgICBbU291cF0gRGVhZGxvY2sgaW4gTmV0d29ya1Byb2Nlc3MKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Nzg3NgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViS2l0U291cFJlcXVlc3RJbnB1dFN0cmVh bS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViS2l0U291cFJlcXVlc3RJ bnB1dFN0cmVhbS5jcHAKaW5kZXggNzhkOTc2MWVkYTguLjI1YjZjMDc3ODU3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3NvdXAvV2ViS2l0U291cFJlcXVlc3RJbnB1dFN0 cmVhbS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9zb3VwL1dlYktpdFNvdXBS ZXF1ZXN0SW5wdXRTdHJlYW0uY3BwCkBAIC0yNSw4ICsyNSw4IEBACiAjaW5jbHVkZSA8d3RmL2ds aWIvR1VuaXF1ZVB0ci5oPgogCiBzdHJ1Y3QgQXN5bmNSZWFkRGF0YSB7Ci0gICAgQXN5bmNSZWFk RGF0YShHVGFzayogdGFzaywgdm9pZCogYnVmZmVyLCBnc2l6ZSBjb3VudCkKLSAgICAgICAgOiB0 YXNrKHRhc2spCisgICAgQXN5bmNSZWFkRGF0YShHUmVmUHRyPEdUYXNrPiYmIHRhc2ssIHZvaWQq IGJ1ZmZlciwgZ3NpemUgY291bnQpCisgICAgICAgIDogdGFzayhXVEZNb3ZlKHRhc2spKQogICAg ICAgICAsIGJ1ZmZlcihidWZmZXIpCiAgICAgICAgICwgY291bnQoY291bnQpCiAgICAgewpAQCAt NjMsMTIgKzYzLDEwIEBAIHN0YXRpYyB2b2lkIHdlYmtpdFNvdXBSZXF1ZXN0SW5wdXRTdHJlYW1S ZWFkQXN5bmNSZXN1bHRDb21wbGV0ZShHVGFzayogdGFzaywgdm9pCiAKIHN0YXRpYyB2b2lkIHdl YmtpdFNvdXBSZXF1ZXN0SW5wdXRTdHJlYW1QZW5kaW5nUmVhZEFzeW5jQ29tcGxldGUoV2ViS2l0 U291cFJlcXVlc3RJbnB1dFN0cmVhbSogc3RyZWFtKQogewotICAgIGlmICghc3RyZWFtLT5wcml2 LT5wZW5kaW5nQXN5bmNSZWFkKQotICAgICAgICByZXR1cm47Ci0KLSAgICBBc3luY1JlYWREYXRh KiBkYXRhID0gc3RyZWFtLT5wcml2LT5wZW5kaW5nQXN5bmNSZWFkLmdldCgpOwotICAgIHdlYmtp dFNvdXBSZXF1ZXN0SW5wdXRTdHJlYW1SZWFkQXN5bmNSZXN1bHRDb21wbGV0ZShkYXRhLT50YXNr LmdldCgpLCBkYXRhLT5idWZmZXIsIGRhdGEtPmNvdW50KTsKLSAgICBzdHJlYW0tPnByaXYtPnBl bmRpbmdBc3luY1JlYWQgPSBudWxscHRyOworICAgIHdoaWxlIChzdHJlYW0tPnByaXYtPnBlbmRp bmdBc3luY1JlYWQpIHsKKyAgICAgICAgYXV0byBkYXRhID0gV1RGTW92ZShzdHJlYW0tPnByaXYt PnBlbmRpbmdBc3luY1JlYWQpOworICAgICAgICB3ZWJraXRTb3VwUmVxdWVzdElucHV0U3RyZWFt UmVhZEFzeW5jUmVzdWx0Q29tcGxldGUoZGF0YS0+dGFzay5nZXQoKSwgZGF0YS0+YnVmZmVyLCBk YXRhLT5jb3VudCk7CisgICAgfQogfQogCiBzdGF0aWMgYm9vbCB3ZWJraXRTb3VwUmVxdWVzdElu cHV0U3RyZWFtSGFzRGF0YVRvUmVhZChXZWJLaXRTb3VwUmVxdWVzdElucHV0U3RyZWFtKiBzdHJl YW0pCkBAIC0xMDIsNyArMTAwLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0U291cFJlcXVlc3RJbnB1 dFN0cmVhbVJlYWRBc3luYyhHSW5wdXRTdHJlYW0qIGlucHV0U3RyZWFtLCB2b2kKICAgICAgICAg cmV0dXJuOwogICAgIH0KIAotICAgIHN0cmVhbS0+cHJpdi0+cGVuZGluZ0FzeW5jUmVhZCA9IHN0 ZDo6bWFrZV91bmlxdWU8QXN5bmNSZWFkRGF0YT4odGFzay5nZXQoKSwgYnVmZmVyLCBjb3VudCk7 CisgICAgc3RyZWFtLT5wcml2LT5wZW5kaW5nQXN5bmNSZWFkID0gc3RkOjptYWtlX3VuaXF1ZTxB c3luY1JlYWREYXRhPihXVEZNb3ZlKHRhc2spLCBidWZmZXIsIGNvdW50KTsKIH0KIAogc3RhdGlj IGdzc2l6ZSB3ZWJraXRTb3VwUmVxdWVzdElucHV0U3RyZWFtUmVhZEZpbmlzaChHSW5wdXRTdHJl YW0qIGlucHV0U3RyZWFtLCBHQXN5bmNSZXN1bHQqIHJlc3VsdCwgR0Vycm9yKiogZXJyb3IpCkBA IC0xNzEsMTAgKzE2OSw5IEBAIHZvaWQgd2Via2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbUFkZERh dGEoV2ViS2l0U291cFJlcXVlc3RJbnB1dFN0cmVhbSogc3RyZWFtLCBjCiB2b2lkIHdlYmtpdFNv dXBSZXF1ZXN0SW5wdXRTdHJlYW1EaWRGYWlsV2l0aEVycm9yKFdlYktpdFNvdXBSZXF1ZXN0SW5w dXRTdHJlYW0qIHN0cmVhbSwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYgcmVzb3VyY2VF cnJvcikKIHsKICAgICBHVW5pcXVlUHRyPEdFcnJvcj4gZXJyb3IoZ19lcnJvcl9uZXcoZ19xdWFy a19mcm9tX3N0cmluZyhyZXNvdXJjZUVycm9yLmRvbWFpbigpLnV0ZjgoKS5kYXRhKCkpLCByZXNv dXJjZUVycm9yLmVycm9yQ29kZSgpLCAiJXMiLCByZXNvdXJjZUVycm9yLmxvY2FsaXplZERlc2Ny aXB0aW9uKCkudXRmOCgpLmRhdGEoKSkpOwotICAgIGlmIChzdHJlYW0tPnByaXYtPnBlbmRpbmdB c3luY1JlYWQpIHsKLSAgICAgICAgQXN5bmNSZWFkRGF0YSogZGF0YSA9IHN0cmVhbS0+cHJpdi0+ cGVuZGluZ0FzeW5jUmVhZC5nZXQoKTsKKyAgICBpZiAoYXV0byBkYXRhID0gV1RGTW92ZShzdHJl YW0tPnByaXYtPnBlbmRpbmdBc3luY1JlYWQpKQogICAgICAgICBnX3Rhc2tfcmV0dXJuX2Vycm9y KGRhdGEtPnRhc2suZ2V0KCksIGVycm9yLnJlbGVhc2UoKSk7Ci0gICAgfSBlbHNlIHsKKyAgICBl bHNlIHsKICAgICAgICAgc3RyZWFtLT5wcml2LT5jb250ZW50TGVuZ3RoID0gc3RyZWFtLT5wcml2 LT5ieXRlc1JlY2VpdmVkOwogICAgICAgICBzdHJlYW0tPnByaXYtPmVycm9yID0gV1RGTW92ZShl cnJvcik7CiAgICAgfQo=