167887 2017-02-06 09:40:44 -0800 REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app 2017-02-08 05:09:52 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=778240 https://bugs.webkit.org/show_bug.cgi?id=167309 P3 Normal --- 1 jbicha webkit-unassigned bugs-noreply cgarcia magomez mcatanzaro zan oldest_to_newest 1273607 0 jbicha 2017-02-06 09:40:44 -0800 Originally reported at https://bugzilla.gnome.org/778240 but reporting here now since it may be an unintentional WebKit regression. Ubuntu GNOME 17.04 Alpha yelp 3.22.0-1ubuntu1 webkit2gtk 2.15.4-1ubuntu1 yelp is GNOME's help app for viewing user documention. The embedded videos provided by gnome-getting-started-docs don't work with webkit 2.15.4 More specifically, I see the subtitles and the play menubar with the slider and the timestamp/time remaining but the video content is solid black. And if I let the video play to the end, clicking the X or pressing the Esc key to close the video player does nothing. And sometimes, the video doesn't play at all (no slider, no subtitles). I tried rebuilding yelp against webkit 2.15 but that didn't make a difference. 1273921 1 cgarcia 2017-02-07 04:31:19 -0800 This was broken by r210740. When the video sink is created, the media player doesn't have a renderer yet, and accelerated compositing is not available in that moment. When the video starts playing we have Ac available but we cached the value, so we end up mixing the drawing models. 1273922 2 cgarcia 2017-02-07 04:34:15 -0800 Note also that the accelerated compositing setting can change too. 1273970 3 300806 cgarcia 2017-02-07 06:13:01 -0800 Created attachment 300806 Patch 1274007 4 300806 mcatanzaro 2017-02-07 08:46:04 -0800 Comment on attachment 300806 Patch Is it not possible to make a layout test for this? This is exactly the sort of regression I was worried could happen when we decided to backport on-demand accelerated compositing to 2.14. At least we caught it *barely* in time for 2.14.4, but it feels like luck that Jeremy decided to test 2.15.4 at just the right time. I know the status of accelerated compositing in 2.14 is a really exceptional situation and we probably ought to make the change in the stable branch anyway, but we need to avoid large stable branch changes like this in the future, especially so late in the cycle. 1274011 5 cgarcia 2017-02-07 09:00:40 -0800 This is not because of on-demand Ac mode. Even when Ac mode forced, when the media player doesn't have a renderer, the condition will not be tru, because mediaPlayerRenderingCanBeAccelerated will return false. 1274274 6 cgarcia 2017-02-07 22:55:47 -0800 Committed r211854: <http://trac.webkit.org/changeset/211854> 1274308 7 jbicha 2017-02-08 05:09:52 -0800 Thanks. I confirm the patch fixes my issue. 300806 2017-02-07 06:13:01 -0800 2017-02-07 08:46:04 -0800 Patch wk2-video-ac-off.diff text/plain 3273 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhOTNhZDhhNzk1Yy4uMDk4MGZiMTYwMWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNy0wMi0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMjEwNzQwKTogW0dUS10gMi4xNSBicm9r ZSBlbWJlZGRlZCB2aWRlb3MgaW4gR05PTUUncyB5ZWxwIGFwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIHRoZSBtX3JlbmRlcmluZ0NhbkJl QWNjZWxlcmF0ZWQgd2hlbiBhY2NlbGVyYXRlZCByZW5kZXJpbmcgc3RhdGUgY2hhbmdlcy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6OmFjY2VsZXJhdGVkUmVuZGVyaW5nU3RhdGVDaGFuZ2VkKToKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0ZVZpZGVvU2lu ayk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2UuaDoKKworMjAxNy0wMi0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dTdHJlYW1lcl0gRGVhZGxvY2sgd2hl biBtZWRpYSBwbGF5ZXIgaXMgZGVzdHJveWVkCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc4NjEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDNlMTM3MDQ2YmRlLi5hN2VkZjgz ZmE1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmNwcApAQCAtNjEzLDYgKzYxMywxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6Om11dGVDaGFuZ2VkQ2FsbGJhY2soTWVkaWFQbGF5ZXJQcml2YXRlR1N0cgog ICAgIHBsYXllci0+bV9ub3RpZmllci5ub3RpZnkoTWFpblRocmVhZE5vdGlmaWNhdGlvbjo6TXV0 ZUNoYW5nZWQsIFtwbGF5ZXJdIHsgcGxheWVyLT5ub3RpZnlQbGF5ZXJPZk11dGUoKTsgfSk7CiB9 CiAKK3ZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6YWNjZWxlcmF0ZWRSZW5k ZXJpbmdTdGF0ZUNoYW5nZWQoKQoreworICAgIG1fcmVuZGVyaW5nQ2FuQmVBY2NlbGVyYXRlZCA9 IG1fcGxheWVyICYmIG1fcGxheWVyLT5jbGllbnQoKS5tZWRpYVBsYXllckFjY2VsZXJhdGVkQ29t cG9zaXRpbmdFbmFibGVkKCkgJiYgbV9wbGF5ZXItPmNsaWVudCgpLm1lZGlhUGxheWVyUmVuZGVy aW5nQ2FuQmVBY2NlbGVyYXRlZChtX3BsYXllcik7Cit9CisKICNpZiBVU0UoVEVYVFVSRV9NQVBQ RVJfR0wpICYmICFVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfTVVMVElQUk9DRVNTKQogdm9pZCBN ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjp1cGRhdGVUZXh0dXJlKEJpdG1hcFRleHR1 cmVHTCYgdGV4dHVyZSwgR3N0VmlkZW9JbmZvJiB2aWRlb0luZm8pCiB7CkBAIC0xMTA1LDggKzEx MTAsNyBAQCBHc3RFbGVtZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVh dGVWaWRlb1NpbmtHTCgpCiAKIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6OmNyZWF0ZVZpZGVvU2luaygpCiB7Ci0gICAgbV9yZW5kZXJpbmdDYW5CZUFjY2VsZXJh dGVkID0gc3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZygpICYmIG1fcGxheWVyLT5jbGllbnQo KS5tZWRpYVBsYXllckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKCkKLSAgICAgICAgJiYg bV9wbGF5ZXItPmNsaWVudCgpLm1lZGlhUGxheWVyUmVuZGVyaW5nQ2FuQmVBY2NlbGVyYXRlZCht X3BsYXllcik7CisgICAgYWNjZWxlcmF0ZWRSZW5kZXJpbmdTdGF0ZUNoYW5nZWQoKTsKIAogI2lm IFVTRShHU1RSRUFNRVJfR0wpCiAgICAgaWYgKG1fcmVuZGVyaW5nQ2FuQmVBY2NlbGVyYXRlZCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCmlu ZGV4IGQ5ZjYzNWY4NTgyLi4zNjM0ODZkYjMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCkBAIC0xMDUsNiArMTA1LDggQEAgcHVibGlj OgogICAgIHVuc2lnbmVkIGF1ZGlvRGVjb2RlZEJ5dGVDb3VudCgpIGNvbnN0IG92ZXJyaWRlOwog ICAgIHVuc2lnbmVkIHZpZGVvRGVjb2RlZEJ5dGVDb3VudCgpIGNvbnN0IG92ZXJyaWRlOwogCisg ICAgdm9pZCBhY2NlbGVyYXRlZFJlbmRlcmluZ1N0YXRlQ2hhbmdlZCgpIG92ZXJyaWRlOworCiAj aWYgVVNFKFRFWFRVUkVfTUFQUEVSX0dMKSAmJiAhVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQog ICAgIFBsYXRmb3JtTGF5ZXIqIHBsYXRmb3JtTGF5ZXIoKSBjb25zdCBvdmVycmlkZSB7IHJldHVy biBjb25zdF9jYXN0PE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UqPih0aGlzKTsgfQog I2lmIFBMQVRGT1JNKFdJTl9DQUlSTykK