16787 2008-01-08 12:37:48 -0800 array.splice() with 1 argument not working 2008-01-14 01:14:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED HasReduction P2 Normal --- 1 jjj ap ap darin ddkilzer eric ggaren sam oldest_to_newest 66572 0 jjj 2008-01-08 12:37:48 -0800 splice() with 1 element is not working in Webkit. Compare behaviour with Firefox. array.splice(index) should remove all items starting from index. See attachment. 66573 1 18332 jjj 2008-01-08 12:40:30 -0800 Created attachment 18332 array.splice() with one element 66624 2 ddkilzer 2008-01-08 21:32:51 -0800 Same issue occurs with Safari 2.0.4 (419.3) and Safari 3.0.4 (523.12.2) with original WebKit(s) on Mac OS X 10.4.11 (8S165). 66657 3 ap 2008-01-09 05:10:29 -0800 According to <http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Reference:Objects:Array:splice>, this is a non-standard Mozilla extension (not to imply that we don't want to support it). 66658 4 ddkilzer 2008-01-09 05:50:46 -0800 Safari 3.0.4, MSIE 7 and Opera 9.24 follow the standard, and thus splice() with one argument does nothing in these browsers. 66659 5 18350 ap 2008-01-09 05:57:33 -0800 Created attachment 18350 proposed fix I have a fix anyway, a reviewer can decide whether we want this. 66660 6 18350 ddkilzer 2008-01-09 06:05:04 -0800 Comment on attachment 18350 proposed fix r=me Does this change impact SunSpider performance? The following two tests use splice: SunSpider/tests/date-format-tofte.js SunSpider/tests/string-unpack-code.js 67122 7 18350 darin 2008-01-13 11:17:02 -0800 Comment on attachment 18350 proposed fix + if (!args.size()) + if (args.size() > 1) Our usual design is to always consider undefined arguments rather than checking number of arguments. So rather than checking for lack of arguments, we detect the case where arguments are undefined, treating a smaller number of arguments identically to a call with explicit "undefined" for th extra arguments. I'd like to see test cases that pass undefined to make this clear one way or another. Normally I consider it forbidden to actually look at args.size(), but if we're trying to match the Mozilla behavior it's possible it's needed here. 67126 8 ap 2008-01-13 11:23:53 -0800 (In reply to comment #7) The included test checks for this, if I understood you correctly: +shouldBe("arr.splice()", "undefined") +shouldBe("arr", "['a','b','c','d']"); +shouldBe("arr.splice(undefined)", "['a','b','c','d']") +shouldBe("arr", "[]"); (similar for the second argument). Indeed, I was trying to match Mozilla behavior. If anyone wonders why I haven't landed this yet - it's because I didn't have the time to build release and test performance. 67150 9 jjj 2008-01-13 13:05:56 -0800 This may be off-topic, but Darin's comment reminded me that before I found this little omission, I wondered if this could be possible: array1 = ['a','b','c','d']; array2 = array1.splice(2,undefined,'e','f','g'); --> array1 = ['a','b','e','f','g']; --> array2 = ['c','d']; In other words, remove unknown amount of elements starting from position 2 like in splice(2), and add some elements. Ofcourse there are other ways... The actual result (in Webkit and Firefox) is: --> array1 = ['a','b','e','f','g','c','d']; 67196 10 ap 2008-01-14 01:14:40 -0800 Committed revision 29459. 18332 2008-01-08 12:40:30 -0800 2008-01-08 12:40:30 -0800 array.splice() with one element Naamloos.txt text/html 216 jjj PHNjcmlwdCBsYW5ndWFnZT1qYXZhc2NyaXB0PgoJdmFyIGFycmF5MSA9IFsnYScsJ2InLCdjJywn ZCddOwoJdmFyIGFycmF5MiA9IGFycmF5MS5zcGxpY2UoMik7Cglkb2N1bWVudC53cml0ZSgnYXJy YXkxOiAnICsgYXJyYXkxLmpvaW4oKSArICc8YnIgLz4nKTsKCWRvY3VtZW50LndyaXRlKCdhcnJh eTI6ICcgKyBhcnJheTIuam9pbigpICsgJzxiciAvPicpOwo8L3NjcmlwdD4K 18350 2008-01-09 05:57:33 -0800 2008-01-09 06:05:04 -0800 proposed fix 16787r1_patch.txt text/plain 5979 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MzM2KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDEtMDkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2Nzg3CisgICAgICAgIGFycmF5LnNwbGljZSgpIHdpdGggMSBlbGVtZW50IG5vdCB3b3Jr aW5nCisKKyAgICAgICAgKiBranMvYXJyYXlfb2JqZWN0LmNwcDoKKyAgICAgICAgKEtKUzo6QXJy YXlQcm90b0Z1bmNTcGxpY2U6OmNhbGxBc0Z1bmN0aW9uKTogSW1wbGVtZW50IHRoaXMgTW96aWxs YSBleHRlbnNpb24sIGFuZCBmaXgKKyAgICAgICAgc29tZSBvdGhlciBlZGdlIGNhc2VzLgorCiAy MDA4LTAxLTA3ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlf b2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0 LmNwcAkocmV2aXNpb24gMjkzMzYpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfb2JqZWN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMwLDEyICs0MzAsMTkgQEAgSlNWYWx1ZSogQXJyYXlQ cm90b0Z1bmNTcGxpY2U6OmNhbGxBc0Z1bgogICAgIEpTT2JqZWN0KiByZXNPYmogPSBzdGF0aWNf Y2FzdDxKU09iamVjdCogPihleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCktPmFycmF5Q29uc3Ry dWN0b3IoKS0+Y29uc3RydWN0KGV4ZWMsIGV4ZWMtPmVtcHR5TGlzdCgpKSk7CiAgICAgSlNWYWx1 ZSogcmVzdWx0ID0gcmVzT2JqOwogICAgIHVuc2lnbmVkIGxlbmd0aCA9IHRoaXNPYmotPmdldChl eGVjLCBleGVjLT5wcm9wZXJ0eU5hbWVzKCkubGVuZ3RoKS0+dG9VSW50MzIoZXhlYyk7CisgICAg aWYgKCFhcmdzLnNpemUoKSkKKyAgICAgICAgcmV0dXJuIGpzVW5kZWZpbmVkKCk7CiAgICAgaW50 IGJlZ2luID0gYXJnc1swXS0+dG9VSW50MzIoZXhlYyk7CiAgICAgaWYgKGJlZ2luIDwgMCkKICAg ICAgICAgYmVnaW4gPSBzdGQ6Om1heDxpbnQ+KGJlZ2luICsgbGVuZ3RoLCAwKTsKICAgICBlbHNl CiAgICAgICAgIGJlZ2luID0gc3RkOjptaW48aW50PihiZWdpbiwgbGVuZ3RoKTsKLSAgICB1bnNp Z25lZCBpbnQgZGVsZXRlQ291bnQgPSBzdGQ6Om1pbjxpbnQ+KHN0ZDo6bWF4PGludD4oYXJnc1sx XS0+dG9VSW50MzIoZXhlYyksIDApLCBsZW5ndGggLSBiZWdpbik7CisKKyAgICB1bnNpZ25lZCBp bnQgZGVsZXRlQ291bnQ7CisgICAgaWYgKGFyZ3Muc2l6ZSgpID4gMSkKKyAgICAgICAgZGVsZXRl Q291bnQgPSBzdGQ6Om1pbjxpbnQ+KHN0ZDo6bWF4PGludD4oYXJnc1sxXS0+dG9VSW50MzIoZXhl YyksIDApLCBsZW5ndGggLSBiZWdpbik7CisgICAgZWxzZQorICAgICAgICBkZWxldGVDb3VudCA9 IGxlbmd0aCAtIGJlZ2luOwogCiAgICAgZm9yICh1bnNpZ25lZCBpbnQgayA9IDA7IGsgPCBkZWxl dGVDb3VudDsgaysrKSB7CiAgICAgICAgIGlmIChKU1ZhbHVlKiB2ID0gZ2V0UHJvcGVydHkoZXhl YywgdGhpc09iaiwgayArIGJlZ2luKSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5MzM2KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgt MDEtMDkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2Nzg3CisgICAgICAgIGFycmF5LnNwbGljZSgpIHdpdGggMSBl bGVtZW50IG5vdCB3b3JraW5nCisKKyAgICAgICAgKiBmYXN0L2pzL2FycmF5LXNwbGljZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvanMvYXJyYXktc3BsaWNlLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL2FycmF5LXNwbGljZS5qczogQWRkZWQu CisKIDIwMDctMTAtMDEgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPHNhbmRmZWxkQGtkZS5vcmc+ CiAKICAgICAgICAgVXBkYXRlZCBieSBFcmljLCBSZXZpZXdlZCBieSBIeWF0dC4KSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvanMvYXJyYXktc3BsaWNlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2pzL2FycmF5LXNwbGljZS1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2FycmF5LXNwbGljZS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMzAgQEAKK1RoaXMgdGVzdHMgYXJyYXkuc3BsaWNlIGJlaGF2 aW9yLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3Nh Z2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBhcnIgaXMgWydhJywn YicsJ2MnLCdkJ10KK1BBU1MgYXJyLnNwbGljZSgyKSBpcyBbJ2MnLCdkJ10KK1BBU1MgYXJyIGlz IFsnYScsJ2InXQorUEFTUyBhcnIuc3BsaWNlKDApIGlzIFsnYScsJ2InXQorUEFTUyBhcnIgaXMg W10KK1BBU1MgYXJyLnNwbGljZSgpIGlzIHVuZGVmaW5lZAorUEFTUyBhcnIgaXMgWydhJywnYics J2MnLCdkJ10KK1BBU1MgYXJyLnNwbGljZSh1bmRlZmluZWQpIGlzIFsnYScsJ2InLCdjJywnZCdd CitQQVNTIGFyciBpcyBbXQorUEFTUyBhcnIuc3BsaWNlKG51bGwpIGlzIFsnYScsJ2InLCdjJywn ZCddCitQQVNTIGFyciBpcyBbXQorUEFTUyBhcnIuc3BsaWNlKDEwMCkgaXMgW10KK1BBU1MgYXJy IGlzIFsnYScsJ2InLCdjJywnZCddCitQQVNTIGFyci5zcGxpY2UoLTEpIGlzIFsnZCddCitQQVNT IGFyciBpcyBbJ2EnLCdiJywnYyddCitQQVNTIGFyci5zcGxpY2UoMiwgdW5kZWZpbmVkKSBpcyBb XQorUEFTUyBhcnIuc3BsaWNlKDIsIG51bGwpIGlzIFtdCitQQVNTIGFyci5zcGxpY2UoMiwgLTEp IGlzIFtdCitQQVNTIGFyciBpcyBbJ2EnLCdiJywnYyddCitQQVNTIGFyci5zcGxpY2UoMiwgMTAw KSBpcyBbJ2MnXQorUEFTUyBhcnIgaXMgWydhJywnYiddCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0 VGVzdHMvZmFzdC9qcy9hcnJheS1zcGxpY2UtZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTog c3ZuOm1pbWUtdHlwZQogICArIHRleHQvcGxhaW4KTmFtZTogc3ZuOmVvbC1zdHlsZQogICArIG5h dGl2ZQoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMvYXJyYXktc3BsaWNlLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9hcnJheS1zcGxpY2UuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvYXJyYXktc3BsaWNlLmh0bWwJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhU TUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9InJl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9u Ij48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMv YXJyYXktc3BsaWNlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMg b246IExheW91dFRlc3RzL2Zhc3QvanMvYXJyYXktc3BsaWNlLmh0bWwKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1l OiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9q cy9yZXNvdXJjZXMvYXJyYXktc3BsaWNlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvanMvcmVzb3VyY2VzL2FycmF5LXNwbGljZS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2Zhc3QvanMvcmVzb3VyY2VzL2FycmF5LXNwbGljZS5qcwkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwzNSBAQAorZGVzY3JpcHRpb24oCisiVGhpcyB0ZXN0cyBhcnJheS5zcGxpY2UgYmVoYXZp b3IuIgorKTsKKwordmFyIGFyciA9IFsnYScsJ2InLCdjJywnZCddOworc2hvdWxkQmUoImFyciIs ICJbJ2EnLCdiJywnYycsJ2QnXSIpOworc2hvdWxkQmUoImFyci5zcGxpY2UoMikiLCAiWydjJywn ZCddIik7CitzaG91bGRCZSgiYXJyIiwgIlsnYScsJ2InXSIpOworc2hvdWxkQmUoImFyci5zcGxp Y2UoMCkiLCAiWydhJywnYiddIik7CitzaG91bGRCZSgiYXJyIiwgIltdIikKKworYXJyID0gWydh JywnYicsJ2MnLCdkJ107CitzaG91bGRCZSgiYXJyLnNwbGljZSgpIiwgInVuZGVmaW5lZCIpCitz aG91bGRCZSgiYXJyIiwgIlsnYScsJ2InLCdjJywnZCddIik7CitzaG91bGRCZSgiYXJyLnNwbGlj ZSh1bmRlZmluZWQpIiwgIlsnYScsJ2InLCdjJywnZCddIikKK3Nob3VsZEJlKCJhcnIiLCAiW10i KTsKKworYXJyID0gWydhJywnYicsJ2MnLCdkJ107CitzaG91bGRCZSgiYXJyLnNwbGljZShudWxs KSIsICJbJ2EnLCdiJywnYycsJ2QnXSIpCitzaG91bGRCZSgiYXJyIiwgIltdIik7CisKK2FyciA9 IFsnYScsJ2InLCdjJywnZCddOworc2hvdWxkQmUoImFyci5zcGxpY2UoMTAwKSIsICJbXSIpCitz aG91bGRCZSgiYXJyIiwgIlsnYScsJ2InLCdjJywnZCddIik7CitzaG91bGRCZSgiYXJyLnNwbGlj ZSgtMSkiLCAiWydkJ10iKQorc2hvdWxkQmUoImFyciIsICJbJ2EnLCdiJywnYyddIik7CisKK3No b3VsZEJlKCJhcnIuc3BsaWNlKDIsIHVuZGVmaW5lZCkiLCAiW10iKQorc2hvdWxkQmUoImFyci5z cGxpY2UoMiwgbnVsbCkiLCAiW10iKQorc2hvdWxkQmUoImFyci5zcGxpY2UoMiwgLTEpIiwgIltd IikKK3Nob3VsZEJlKCJhcnIiLCAiWydhJywnYicsJ2MnXSIpOworc2hvdWxkQmUoImFyci5zcGxp Y2UoMiwgMTAwKSIsICJbJ2MnXSIpCitzaG91bGRCZSgiYXJyIiwgIlsnYScsJ2InXSIpOworCit2 YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91 dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2FycmF5LXNwbGljZS5qcwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6 IHRleHQvcGxhaW4KICAgKyAKTmFtZTogc3ZuOmVvbC1zdHlsZQogICArIG5hdGl2ZQoK