167854 2017-02-05 09:07:12 -0800 The VMInspector should use an RAII Locker. 2017-02-05 11:28:23 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1273382 0 mark.lam 2017-02-05 09:07:12 -0800 Patch coming. 1273383 1 300666 mark.lam 2017-02-05 09:14:19 -0800 Created attachment 300666 proposed patch. 1273396 2 300666 saam 2017-02-05 11:01:04 -0800 Comment on attachment 300666 proposed patch. r=me 1273397 3 300666 mark.lam 2017-02-05 11:02:03 -0800 Comment on attachment 300666 proposed patch. Thanks for the review. 1273405 4 300666 commit-queue 2017-02-05 11:28:19 -0800 Comment on attachment 300666 proposed patch. Clearing flags on attachment: 300666 Committed r211684: <http://trac.webkit.org/changeset/211684> 1273406 5 commit-queue 2017-02-05 11:28:23 -0800 All reviewed patches have been landed. Closing bug. 300666 2017-02-05 09:14:19 -0800 2017-02-05 11:28:19 -0800 proposed patch. bug-167854.patch text/plain 6519 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjExNjgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE3LTAyLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU aGUgVk1JbnNwZWN0b3Igc2hvdWxkIHVzZSBhbiBSQUlJIExvY2tlci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Nzg1NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZpb3VzbHksIFZNSW5zcGVjdG9y Ojpsb2NrKCkgd2FzIHJldHVybmluZyBhbiBleHBlY3RlZCBMb2NrVG9rZW4sIGFuZCB0aGVyZSdz CisgICAgICAgIG5vIHdheSB0byB1bmxvY2sgaXQgd2hlbiB3ZSdyZSBkb25lIHdpdGggaXQuICBU aGlzIHdhcyBub3QgYSBwcm9ibGVtIGJlZm9yZQorICAgICAgICBiZWNhdXNlIHRoZSBWTUluc3Bl Y3RvciBoYWQgb25seSBvbmUgY2xpZW50LCB0aGUgU2lnaWxsQ3Jhc2hBbmFseXplciwgdGhhdAor ICAgICAgICBleHBlY3RlZCB0aGUgcHJvY2VzcyB0byBjcmFzaCBkdWUgdG8gYSBTSUdJTEwgc2hv cnRseSB0aGVyZWFmdGVyLgorCisgICAgICAgIEhvd2V2ZXIsIHRoZSBWTUluc3BlY3RvciBpcyB1 c2VmdWwgYXMgYSBkZWJ1Z2dpbmcgdG9vbCB0aGF0IHdlIGNhbiBhcHBseSBpbiBvdGhlcgorICAg ICAgICBkZWJ1Z2dpbmcgdGFza3MuICBGaXhpbmcgVk1JbnNwZWN0b3I6OmxvY2soKSB0byByZXR1 cm4gYW4gUkFJSSBsb2NrZXIgd2lsbCBlbmFibGUKKyAgICAgICAgb3RoZXIgdXNlIGNhc2VzLiAg UGx1cyBpdCdzIGp1c3QgYmFkIGZvcm0gdG8gYmUgYWJsZSB0byBsb2NrIHNvbWV0aGluZyBhbmQg bmV2ZXIKKyAgICAgICAgYmUgYWJsZSB0byB1bmxvY2sgaXQuCisKKyAgICAgICAgKiB0b29scy9T aWdpbGxDcmFzaEFuYWx5emVyLmNwcDoKKyAgICAgICAgKEpTQzo6U2lnaWxsQ3Jhc2hBbmFseXpl cjo6YW5hbHl6ZSk6CisgICAgICAgICogdG9vbHMvVk1JbnNwZWN0b3IuY3BwOgorICAgICAgICAq IHRvb2xzL1ZNSW5zcGVjdG9yLmg6CisKIDIwMTctMDItMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBTdGF0aWMgQW5hbHl6ZXI6IFZhbHVlIHN0b3Jl ZCB0byAncmVjb3JkZWRNYWNoaW5lVGhyZWFkcycgZHVyaW5nIGl0cyBpbml0aWFsaXphdGlvbiBp cyBuZXZlciByZWFkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvU2lnaWxsQ3Jh c2hBbmFseXplci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xz L1NpZ2lsbENyYXNoQW5hbHl6ZXIuY3BwCShyZXZpc2lvbiAyMTE2ODApCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvdG9vbHMvU2lnaWxsQ3Jhc2hBbmFseXplci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI0MSwxNiArMjQxLDE2IEBAIHZvaWQgU2lnaWxsQ3Jhc2hBbmFseXplcjo6YW5hbHl6ZShT aWduYWwKIAogICAgICAgICAvLyBVc2UgYSB0aW1lb3V0IHBlcmlvZCBvZiAyIHNlY29uZHMuIFRo ZSBjbGllbnQgaXMgYWJvdXQgdG8gY3Jhc2gsIGFuZCB3ZSBkb24ndAogICAgICAgICAvLyB3YW50 IHRvIHR1cm4gdGhlIGNyYXNoIGludG8gYSBoYW5nIGJ5IHJlLXRyeWluZyB0aGUgbG9jayBmb3Ig dG9vIGxvbmcuCi0gICAgICAgIGF1dG8gZXhwZWN0ZWRMb2NrVG9rZW4gPSBpbnNwZWN0b3IubG9j ayhTZWNvbmRzKDIpKTsKLSAgICAgICAgaWYgKCFleHBlY3RlZExvY2tUb2tlbikgewotICAgICAg ICAgICAgQVNTRVJUKGV4cGVjdGVkTG9ja1Rva2VuLmVycm9yKCkgPT0gVk1JbnNwZWN0b3I6OkVy cm9yOjpUaW1lZE91dCk7CisgICAgICAgIGF1dG8gZXhwZWN0ZWRMb2NrZXIgPSBpbnNwZWN0b3Iu bG9jayhTZWNvbmRzKDIpKTsKKyAgICAgICAgaWYgKCFleHBlY3RlZExvY2tlcikgeworICAgICAg ICAgICAgQVNTRVJUKGV4cGVjdGVkTG9ja2VyLmVycm9yKCkgPT0gVk1JbnNwZWN0b3I6OkVycm9y OjpUaW1lZE91dCk7CiAgICAgICAgICAgICBsb2coIkVSUk9SOiBVbmFibGUgdG8gYW5hbHl6ZSBT SUdJTEwuIFRpbWVkIG91dCB3aGlsZSB3YWl0aW5nIHRvIGl0ZXJhdGUgVk1zLiIpOwogICAgICAg ICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAgICAgIGF1dG8gbG9ja1Rva2VuID0gZXhwZWN0 ZWRMb2NrVG9rZW4udmFsdWUoKTsKKyAgICAgICAgYXV0byYgbG9ja2VyID0gZXhwZWN0ZWRMb2Nr ZXIudmFsdWUoKTsKIAogICAgICAgICB2b2lkKiBwYyA9IGNvbnRleHQubWFjaGluZVBDOwotICAg ICAgICBhdXRvIGlzSW5KSVRNZW1vcnkgPSBpbnNwZWN0b3IuaXNWYWxpZEV4ZWN1dGFibGVNZW1v cnkobG9ja1Rva2VuLCBwYyk7CisgICAgICAgIGF1dG8gaXNJbkpJVE1lbW9yeSA9IGluc3BlY3Rv ci5pc1ZhbGlkRXhlY3V0YWJsZU1lbW9yeShsb2NrZXIsIHBjKTsKICAgICAgICAgaWYgKCFpc0lu SklUTWVtb3J5KSB7CiAgICAgICAgICAgICBsb2coIkVSUk9SOiBUaW1lZCBvdXQ6IG5vdCBhYmxl IHRvIGRldGVybWluZSBpZiBwYyAlcCBpcyBpbiB2YWxpZCBKSVQgZXhlY3V0YWJsZSBtZW1vcnki LCBwYyk7CiAgICAgICAgICAgICByZXR1cm47CkBAIC0yNzQsNyArMjc0LDcgQEAgdm9pZCBTaWdp bGxDcmFzaEFuYWx5emVyOjphbmFseXplKFNpZ25hbAogICAgICAgICBsb2coImluc3RydWN0aW9u IGJpdHMgYXQgcGMgJXAgaXM6IDB4JTA4eCIsIHBjLCB3b3JkQXRQQyk7CiAjZW5kaWYKIAotICAg ICAgICBhdXRvIGV4cGVjdGVkQ29kZUJsb2NrID0gaW5zcGVjdG9yLmNvZGVCbG9ja0Zvck1hY2hp bmVQQyhsb2NrVG9rZW4sIHBjKTsKKyAgICAgICAgYXV0byBleHBlY3RlZENvZGVCbG9jayA9IGlu c3BlY3Rvci5jb2RlQmxvY2tGb3JNYWNoaW5lUEMobG9ja2VyLCBwYyk7CiAgICAgICAgIGlmICgh ZXhwZWN0ZWRDb2RlQmxvY2spIHsKICAgICAgICAgICAgIGlmIChleHBlY3RlZENvZGVCbG9jay5l cnJvcigpID09IFZNSW5zcGVjdG9yOjpFcnJvcjo6VGltZWRPdXQpCiAgICAgICAgICAgICAgICAg bG9nKCJFUlJPUjogVGltZWQgb3V0OiBub3QgYWJsZSB0byBkZXRlcm1pbmUgaWYgcGMgJXAgaXMg aW4gYSB2YWxpZCBDb2RlQmxvY2siLCBwYyk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv dG9vbHMvVk1JbnNwZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS90b29scy9WTUluc3BlY3Rvci5jcHAJKHJldmlzaW9uIDIxMTY4MCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90b29scy9WTUluc3BlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcg KzYwLDcgQEAgdm9pZCBWTUluc3BlY3Rvcjo6cmVtb3ZlKFZNKiB2bSkKICAgICBtX2xpc3QucmVt b3ZlKHZtKTsKIH0KIAotYXV0byBWTUluc3BlY3Rvcjo6bG9jayhTZWNvbmRzIHRpbWVvdXQpIC0+ IEV4cGVjdGVkPExvY2tUb2tlbiwgRXJyb3I+CithdXRvIFZNSW5zcGVjdG9yOjpsb2NrKFNlY29u ZHMgdGltZW91dCkgLT4gRXhwZWN0ZWQ8TG9ja2VyLCBFcnJvcj4KIHsKICAgICAvLyBUaGlzIGZ1 bmN0aW9uIG1heSBiZSBjYWxsZWQgZnJvbSBhIHNpZ25hbCBoYW5kbGVyIChlLmcuIHZpYSB2aXNp dCgpKS4gSGVuY2UsCiAgICAgLy8gaXQgc2hvdWxkIG9ubHkgdXNlIEFQSXMgdGhhdCBhcmUgc2Fm ZSB0byBjYWxsIGZyb20gc2lnbmFsIGhhbmRsZXJzLiBUaGlzIGlzCkBAIC02OSwxOSArNjksMTkg QEAgYXV0byBWTUluc3BlY3Rvcjo6bG9jayhTZWNvbmRzIHRpbWVvdXQpIAogICAgIC8vIFdlJ2xs IGJlIGRvaW5nIHNsZWVwKDEpIGJldHdlZW4gdHJpZXMgYmVsb3cuIEhlbmNlLCBzbGVlcFBlclJl dHJ5IGlzIDEuCiAgICAgdW5zaWduZWQgbWF4UmV0cmllcyA9ICh0aW1lb3V0IDwgU2Vjb25kczo6 aW5maW5pdHkoKSkgPyB0aW1lb3V0LnZhbHVlKCkgOiBVSU5UX01BWDsKIAotICAgIGJvb2wgbG9j a2VkID0gbV9sb2NrLnRyeUxvY2soKTsKKyAgICBFeHBlY3RlZDxMb2NrZXIsIEVycm9yPiBsb2Nr ZXIgPSBMb2NrZXI6OnRyeUxvY2sobV9sb2NrKTsKICAgICB1bnNpZ25lZCB0cnlDb3VudCA9IDA7 Ci0gICAgd2hpbGUgKCFsb2NrZWQgJiYgdHJ5Q291bnQgPCBtYXhSZXRyaWVzKSB7CisgICAgd2hp bGUgKCFsb2NrZXIgJiYgdHJ5Q291bnQgPCBtYXhSZXRyaWVzKSB7CiAgICAgICAgIC8vIFdlIHdh bnQgdGhlIHZlcnNpb24gb2Ygc2xlZXAgZnJvbSB1bmlzdGQuaC4gQ2FzdCB0byBkaXNhbWJpZ3Vh dGUuCiAjaWYgIU9TKFdJTkRPV1MpCiAgICAgICAgIChzdGF0aWNfY2FzdDx1bnNpZ25lZCAoKiko dW5zaWduZWQpPihzbGVlcCkpKDEpOwogI2VuZGlmCi0gICAgICAgIGxvY2tlZCA9IG1fbG9jay50 cnlMb2NrKCk7CisgICAgICAgIGxvY2tlciA9IExvY2tlcjo6dHJ5TG9jayhtX2xvY2spOwogICAg IH0KIAotICAgIGlmICghbG9ja2VkKQorICAgIGlmICghbG9ja2VyKQogICAgICAgICByZXR1cm4g bWFrZVVuZXhwZWN0ZWQoRXJyb3I6OlRpbWVkT3V0KTsKLSAgICByZXR1cm4gTG9ja1Rva2VuOjpM b2NrZWRWYWx1ZTsKKyAgICByZXR1cm4gbG9ja2VyOwogfQogCiAjaWYgRU5BQkxFKEpJVCkKQEAg LTEwMSw3ICsxMDEsNyBAQCBzdGF0aWMgYm9vbCBlbnN1cmVJc1NhZmVUb0xvY2soTG9jayYgbG9j CiB9OwogI2VuZGlmIC8vIEVOQUJMRShKSVQpCiAKLWF1dG8gVk1JbnNwZWN0b3I6OmlzVmFsaWRF eGVjdXRhYmxlTWVtb3J5KFZNSW5zcGVjdG9yOjpMb2NrVG9rZW4sIHZvaWQqIG1hY2hpbmVQQykg LT4gRXhwZWN0ZWQ8Ym9vbCwgRXJyb3I+CithdXRvIFZNSW5zcGVjdG9yOjppc1ZhbGlkRXhlY3V0 YWJsZU1lbW9yeShjb25zdCBWTUluc3BlY3Rvcjo6TG9ja2VyJiwgdm9pZCogbWFjaGluZVBDKSAt PiBFeHBlY3RlZDxib29sLCBFcnJvcj4KIHsKICNpZiBFTkFCTEUoSklUKQogICAgIGJvb2wgZm91 bmQgPSBmYWxzZTsKQEAgLTEzMyw3ICsxMzMsNyBAQCBhdXRvIFZNSW5zcGVjdG9yOjppc1ZhbGlk RXhlY3V0YWJsZU1lbW9yCiAjZW5kaWYKIH0KIAotYXV0byBWTUluc3BlY3Rvcjo6Y29kZUJsb2Nr Rm9yTWFjaGluZVBDKFZNSW5zcGVjdG9yOjpMb2NrVG9rZW4sIHZvaWQqIG1hY2hpbmVQQykgLT4g RXhwZWN0ZWQ8Q29kZUJsb2NrKiwgRXJyb3I+CithdXRvIFZNSW5zcGVjdG9yOjpjb2RlQmxvY2tG b3JNYWNoaW5lUEMoY29uc3QgVk1JbnNwZWN0b3I6OkxvY2tlciYsIHZvaWQqIG1hY2hpbmVQQykg LT4gRXhwZWN0ZWQ8Q29kZUJsb2NrKiwgRXJyb3I+CiB7CiAjaWYgRU5BQkxFKEpJVCkKICAgICBD b2RlQmxvY2sqIGNvZGVCbG9jayA9IG51bGxwdHI7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvdG9vbHMvVk1JbnNwZWN0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvdG9vbHMvVk1JbnNwZWN0b3IuaAkocmV2aXNpb24gMjExNjgwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rvb2xzL1ZNSW5zcGVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDE3ICsz OSwxNyBAQCBwdWJsaWM6CiAgICAgICAgIFRpbWVkT3V0CiAgICAgfTsKIAotICAgIGVudW0gY2xh c3MgTG9ja1Rva2VuIHsgTG9ja2VkVmFsdWUgfTsKKyAgICB0eXBlZGVmIFdURjo6TG9ja2VyPExv Y2s+IExvY2tlcjsKIAogICAgIHN0YXRpYyBWTUluc3BlY3RvciYgaW5zdGFuY2UoKTsKIAogICAg IHZvaWQgYWRkKFZNKik7CiAgICAgdm9pZCByZW1vdmUoVk0qKTsKIAotICAgIEV4cGVjdGVkPExv Y2tUb2tlbiwgRXJyb3I+IGxvY2soU2Vjb25kcyB0aW1lb3V0ID0gU2Vjb25kczo6aW5maW5pdHko KSk7CisgICAgRXhwZWN0ZWQ8TG9ja2VyLCBFcnJvcj4gbG9jayhTZWNvbmRzIHRpbWVvdXQgPSBT ZWNvbmRzOjppbmZpbml0eSgpKTsKIAotICAgIEV4cGVjdGVkPGJvb2wsIEVycm9yPiBpc1ZhbGlk RXhlY3V0YWJsZU1lbW9yeShMb2NrVG9rZW4sIHZvaWQqKTsKLSAgICBFeHBlY3RlZDxDb2RlQmxv Y2sqLCBFcnJvcj4gY29kZUJsb2NrRm9yTWFjaGluZVBDKExvY2tUb2tlbiwgdm9pZCopOworICAg IEV4cGVjdGVkPGJvb2wsIEVycm9yPiBpc1ZhbGlkRXhlY3V0YWJsZU1lbW9yeShjb25zdCBMb2Nr ZXImLCB2b2lkKik7CisgICAgRXhwZWN0ZWQ8Q29kZUJsb2NrKiwgRXJyb3I+IGNvZGVCbG9ja0Zv ck1hY2hpbmVQQyhjb25zdCBMb2NrZXImLCB2b2lkKik7CiAKIHByaXZhdGU6CiAgICAgZW51bSBj bGFzcyBGdW5jdG9yU3RhdHVzIHsK