167849 2017-02-04 18:18:16 -0800 Static Analyzer: WebCoreNSURLExtras.mm: Potential leak of memory pointed to by 'allBytesBuffer' 2017-02-04 22:25:13 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue oldest_to_newest 1273334 0 joepeck 2017-02-04 18:18:16 -0800 Static Analyzer: WebCoreNSURLExtras.mm: Potential leak of memory pointed to by 'allBytesBuffer' Test: // $ xcrun clang -framework Foundation -framework WebKit leak-test.m // $ ./a.out // $ leaks `pgrep a.out` #import <Foundation/Foundation.h> #import <WebKit/WebKit.h> @interface NSURL (WebNSURLExtras) - (NSString *)_web_hostString; @end int main() { @autoreleasepool { // String greater than 2048 chracters. NSString *str = @"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa..."; NSLog(@">>> %@", [[NSURL URLWithString:str] _web_hostString]); } [[NSRunLoop mainRunLoop] run]; return 0; } 1273338 1 300654 joepeck 2017-02-04 18:21:41 -0800 Created attachment 300654 [PATCH] Proposed Fix 1273349 2 300654 commit-queue 2017-02-04 22:25:10 -0800 Comment on attachment 300654 [PATCH] Proposed Fix Clearing flags on attachment: 300654 Committed r211677: <http://trac.webkit.org/changeset/211677> 1273350 3 commit-queue 2017-02-04 22:25:13 -0800 All reviewed patches have been landed. Closing bug. 300654 2017-02-04 18:21:41 -0800 2017-02-04 22:25:10 -0800 [PATCH] Proposed Fix a-4.patch text/plain 1738 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZTIxMjQwMzQ5NS4uODljMzc4NTZjMjUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wMi0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFN0YXRpYyBBbmFseXplcjogV2ViQ29yZU5TVVJMRXh0cmFzLm1tOiBQ b3RlbnRpYWwgbGVhayBvZiBtZW1vcnkgcG9pbnRlZCB0byBieSAnYWxsQnl0ZXNCdWZmZXInCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc4NDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TVVJMRXh0cmFzLm1tOjg4MzoyMDogd2FybmluZzog UG90ZW50aWFsIGxlYWsgb2YgbWVtb3J5IHBvaW50ZWQgdG8gYnkgJ2FsbEJ5dGVzQnVmZmVyJwor ICAgICAgICAgICAgICAgICAgICByZXR1cm4gbmlsOworICAgICAgICAgICAgICAgICAgICAgICAg ICAgXn5+CisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29yZU5TVVJMRXh0cmFzLm1tOgor ICAgICAgICAoV2ViQ29yZTo6ZGF0YUZvclVSTENvbXBvbmVudFR5cGUpOgorICAgICAgICBGcmVl IHRoZSBwb3RlbnRpYWxseSBtYWxsb2MnZCBidWZmZXIgYmVmb3JlIHRoZSBlYXJseSByZXR1cm4u CisKIDIwMTctMDItMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBQZXJmb3JtYW5jZSBUaW1pbmc6IENvbnZlcnQgV1RGOjpNb25vdG9uaWNUaW1lIGFu ZCBXVEY6OlNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJDb3JlTlNVUkxFeHRyYXMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29y ZU5TVVJMRXh0cmFzLm1tCmluZGV4IDJiZGM2YmU0YWZiLi5iMmIzNTI1MWU4MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVOU1VSTEV4dHJhcy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZU5TVVJMRXh0cmFzLm1tCkBAIC04 NzksOCArODc5LDExIEBAIE5TRGF0YSAqZGF0YUZvclVSTENvbXBvbmVudFR5cGUoTlNVUkwgKlVS TCwgQ0ZVUkxDb21wb25lbnRUeXBlIGNvbXBvbmVudFR5cGUpCiAgICAgQ0ZSYW5nZSByYW5nZTsK ICAgICBpZiAoY29tcG9uZW50VHlwZSAhPSBjb21wbGV0ZVVSTCkgewogICAgICAgICByYW5nZSA9 IENGVVJMR2V0Qnl0ZVJhbmdlRm9yQ29tcG9uZW50KChDRlVSTFJlZilVUkwsIGNvbXBvbmVudFR5 cGUsIE5VTEwpOwotICAgICAgICBpZiAocmFuZ2UubG9jYXRpb24gPT0ga0NGTm90Rm91bmQpCisg ICAgICAgIGlmIChyYW5nZS5sb2NhdGlvbiA9PSBrQ0ZOb3RGb3VuZCkgeworICAgICAgICAgICAg aWYgKHN0YXRpY0FsbEJ5dGVzQnVmZmVyICE9IGFsbEJ5dGVzQnVmZmVyKQorICAgICAgICAgICAg ICAgIGZyZWUoYWxsQnl0ZXNCdWZmZXIpOwogICAgICAgICAgICAgcmV0dXJuIG5pbDsKKyAgICAg ICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIHJhbmdlLmxvY2F0aW9uID0gMDsKICAgICAgICAg cmFuZ2UubGVuZ3RoID0gYnl0ZXNGaWxsZWQ7Cg==