167848 2017-02-04 17:36:21 -0800 Static Analyzer: JSContext.mm: Incorrect decrement of the reference count of an object 2017-02-06 11:17:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1273331 0 joepeck 2017-02-04 17:36:21 -0800 Static Analyzer: JSContext.mm: Incorrect decrement of the reference count of an object > Source/JavaScriptCore/API/JSContext.mm:87:5: warning: Incorrect decrement of the reference count of an object that is not owned at this point by the caller > [self.exceptionHandler release]; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 warning generated. In practice this is normally harmless, but lets do the canonical thing here and just release the ivar instead of going through the getter. 1273332 1 300652 joepeck 2017-02-04 17:37:16 -0800 Created attachment 300652 [PATCH] Proposed Fix 1273417 2 300652 saam 2017-02-05 12:35:30 -0800 Comment on attachment 300652 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=300652&action=review > Source/JavaScriptCore/API/JSContext.mm:-50 > -@synthesize exceptionHandler; Is this auto generated? > Source/JavaScriptCore/API/JSContext.mm:85 > + [_exceptionHandler release]; Is this because the copy semantics of the getter? 1273633 3 300652 joepeck 2017-02-06 10:51:38 -0800 Comment on attachment 300652 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=300652&action=review >> Source/JavaScriptCore/API/JSContext.mm:-50 >> -@synthesize exceptionHandler; > > Is this auto generated? Yes, and the auto-generated version would be equivalent to: @synthesize exceptionHandler = _exceptionHandler; >> Source/JavaScriptCore/API/JSContext.mm:85 >> + [_exceptionHandler release]; > > Is this because the copy semantics of the getter? The idea here is that we just release our ivar directly instead of accessing it through the getter (which typically implies a memory neutral operation). The getter could even be overridden by a subclass that returns something else that isn't owned by this class, so invoking release would be incorrect. We don't own the value returned by the getter, but we own the ivar. 1273644 4 300652 commit-queue 2017-02-06 11:17:38 -0800 Comment on attachment 300652 [PATCH] Proposed Fix Clearing flags on attachment: 300652 Committed r211740: <http://trac.webkit.org/changeset/211740> 1273645 5 commit-queue 2017-02-06 11:17:41 -0800 All reviewed patches have been landed. Closing bug. 300652 2017-02-04 17:37:16 -0800 2017-02-06 11:17:38 -0800 [PATCH] Proposed Fix a-3.patch text/plain 1705 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0Lm1tIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW0KaW5kZXggMzI5MTYyMmQxYTEuLmZk OTMyZDQyNWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4 dC5tbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4dC5tbQpAQCAtNDcs OCArNDcsNiBAQAogICAgIEpTQzo6U3Ryb25nPEpTQzo6SlNPYmplY3Q+IG1fZXhjZXB0aW9uOwog fQogCi1Ac3ludGhlc2l6ZSBleGNlcHRpb25IYW5kbGVyOwotCiAtIChKU0dsb2JhbENvbnRleHRS ZWYpSlNHbG9iYWxDb250ZXh0UmVmCiB7CiAgICAgcmV0dXJuIG1fY29udGV4dDsKQEAgLTg0LDcg KzgyLDcgQEAKICAgICBbbV93cmFwcGVyTWFwIHJlbGVhc2VdOwogICAgIEpTR2xvYmFsQ29udGV4 dFJlbGVhc2UobV9jb250ZXh0KTsKICAgICBbbV92aXJ0dWFsTWFjaGluZSByZWxlYXNlXTsKLSAg ICBbc2VsZi5leGNlcHRpb25IYW5kbGVyIHJlbGVhc2VdOworICAgIFtfZXhjZXB0aW9uSGFuZGxl ciByZWxlYXNlXTsKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCmluZGV4IGU0YzdhNDFmYmIzLi4xZTk5ZmQ4MjllNyAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTctMDItMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBTdGF0aWMgQW5hbHl6ZXI6IEpTQ29udGV4dC5tbTog SW5jb3JyZWN0IGRlY3JlbWVudCBvZiB0aGUgcmVmZXJlbmNlIGNvdW50IG9mIGFuIG9iamVjdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU291cmNlL0ph dmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHQubW06ODc6NTogd2FybmluZzogSW5jb3JyZWN0IGRl Y3JlbWVudCBvZiB0aGUgcmVmZXJlbmNlIGNvdW50IG9mIGFuIG9iamVjdCB0aGF0IGlzIG5vdCBv d25lZCBhdCB0aGlzIHBvaW50IGJ5IHRoZSBjYWxsZXIKKyAgICAgICAgICAgIFtzZWxmLmV4Y2Vw dGlvbkhhbmRsZXIgcmVsZWFzZV07CisgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+CisgICAgICAgIDEgd2FybmluZyBnZW5lcmF0ZWQuCisKKyAgICAgICAgKiBBUEkv SlNDb250ZXh0Lm1tOgorICAgICAgICAoLVtKU0NvbnRleHQgZGVhbGxvY10pOgorICAgICAgICBV c2UgdGhlIGl2YXIgaW4gZGVhbGxvYyBpbnN0ZWFkIG9mIGdvaW5nIHRocm91Z2ggdGhlIGdldHRl ci4KKworMjAxNy0wMi0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFN0YXRpYyBBbmFseXplcjogVmFsdWUgc3RvcmVkIHRvICdyZWNvcmRlZE1hY2hp bmVUaHJlYWRzJyBkdXJpbmcgaXRzIGluaXRpYWxpemF0aW9uIGlzIG5ldmVyIHJlYWQKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Nzg0NQogCg==