167845 2017-02-04 16:41:39 -0800 Static Analyzer: Value stored to 'recordedMachineThreads' during its initialization is never read 2017-03-10 11:26:02 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 104114 1 joepeck joepeck commit-queue joepeck keith_miller mark.lam mcatanzaro msaboff saam webkit-bug-importer oldest_to_newest 1273308 0 joepeck 2017-02-04 16:41:39 -0800 Seeing the following Static Analyzer Warnings: > AnalyzeShallow heap/MachineStackMarker.cpp > Source/JavaScriptCore/heap/MachineStackMarker.cpp:151:14: warning: Value stored to 'recordedMachineThreads' during its initialization is never read > auto recordedMachineThreads = m_set.take(machineThreads); > ^~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~ > Source/JavaScriptCore/heap/MachineStackMarker.cpp:179:5: warning: Returning null reference > return *manager; > ^~~~~~~~~~~~~~~ > 2 warnings generated. The first seems valid given some context: auto recordedMachineThreads = m_set.take(machineThreads); RELEASE_ASSERT(recordedMachineThreads = machineThreads); Seems the assert should be an `==` instead of an `=`. 1273309 1 300647 joepeck 2017-02-04 16:43:43 -0800 Created attachment 300647 [PATCH] Proposed Fix 1273344 2 300647 saam 2017-02-04 21:02:23 -0800 Comment on attachment 300647 [PATCH] Proposed Fix r=me 1273355 3 300647 commit-queue 2017-02-04 23:03:59 -0800 Comment on attachment 300647 [PATCH] Proposed Fix Clearing flags on attachment: 300647 Committed r211678: <http://trac.webkit.org/changeset/211678> 1273356 4 commit-queue 2017-02-04 23:04:03 -0800 All reviewed patches have been landed. Closing bug. 1285863 5 webkit-bug-importer 2017-03-10 11:26:02 -0800 <rdar://problem/30977452> 300647 2017-02-04 16:43:43 -0800 2017-02-04 23:03:59 -0800 [PATCH] Proposed Fix a-2.patch text/plain 1645 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDc5N2FkNzRmYTUxLi5lNGM3YTQxZmJiMyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTctMDItMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBTdGF0aWMgQW5hbHl6 ZXI6IFZhbHVlIHN0b3JlZCB0byAncmVjb3JkZWRNYWNoaW5lVGhyZWFkcycgZHVyaW5nIGl0cyBp bml0aWFsaXphdGlvbiBpcyBuZXZlciByZWFkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc4NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3Rh Y2tNYXJrZXIuY3BwOjE1MToxNDogd2FybmluZzogVmFsdWUgc3RvcmVkIHRvICdyZWNvcmRlZE1h Y2hpbmVUaHJlYWRzJyBkdXJpbmcgaXRzIGluaXRpYWxpemF0aW9uIGlzIG5ldmVyIHJlYWQKKyAg ICAgICAgICAgICAgICBhdXRvIHJlY29yZGVkTWFjaGluZVRocmVhZHMgPSBtX3NldC50YWtlKG1h Y2hpbmVUaHJlYWRzKTsKKyAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+ fn4gICB+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fgorCisgICAgICAgICogaGVhcC9NYWNoaW5l U3RhY2tNYXJrZXIuY3BwOgorICAgICAgICAoSlNDOjpBY3RpdmVNYWNoaW5lVGhyZWFkc01hbmFn ZXI6OnJlbW92ZSk6CisKKzIwMTctMDItMDQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKwogICAgICAgICBTdGF0aWMgQW5hbHl6ZXI6IFZhbHVlIHN0b3JlZCB0byAncHJl dicgaXMgbmV2ZXIgcmVhZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY3ODQ0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hY2hpbmVTdGFja01hcmtlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNo aW5lU3RhY2tNYXJrZXIuY3BwCmluZGV4IGRmNzc5MzllNTViLi5lMzNmM2IyMjcwMCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFjaGluZVN0YWNrTWFya2VyLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYWNoaW5lU3RhY2tNYXJrZXIuY3BwCkBA IC0xNDksNyArMTQ5LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgTG9ja0hvbGRlciBtYW5h Z2VyTG9jayhtX2xvY2spOwogICAgICAgICBhdXRvIHJlY29yZGVkTWFjaGluZVRocmVhZHMgPSBt X3NldC50YWtlKG1hY2hpbmVUaHJlYWRzKTsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlQocmVjb3Jk ZWRNYWNoaW5lVGhyZWFkcyA9IG1hY2hpbmVUaHJlYWRzKTsKKyAgICAgICAgUkVMRUFTRV9BU1NF UlQocmVjb3JkZWRNYWNoaW5lVGhyZWFkcyA9PSBtYWNoaW5lVGhyZWFkcyk7CiAgICAgfQogCiAg ICAgYm9vbCBjb250YWlucyhNYWNoaW5lVGhyZWFkcyogbWFjaGluZVRocmVhZHMpCg==