167844 2017-02-04 16:38:30 -0800 Static Analyzer: Value stored to 'prev' is never read 2017-02-04 17:27:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1273306 0 joepeck 2017-02-04 16:38:30 -0800 Seeing this static analyzer warning all over JavaScriptCore: Source/JavaScriptCore/runtime/JSMapIterator.h:60:13: warning: Value stored to 'prev' is never read prev = bucket; ^ ~~~~~~ Source/JavaScriptCore/runtime/JSSetIterator.h:60:13: warning: Value stored to 'prev' is never read prev = bucket; ^ ~~~~~~ 2 warnings generated. 1273307 1 300646 joepeck 2017-02-04 16:39:17 -0800 Created attachment 300646 [PATCH] Proposed Fix 1273311 2 300646 saam 2017-02-04 16:47:39 -0800 Comment on attachment 300646 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=300646&action=review r=me > Source/JavaScriptCore/runtime/JSMapIterator.h:59 > + while (bucket && bucket->deleted()) Oh wow. Can you add a test that would cause this to infinite loop? I don't think it'd be hard. Perhaps something like this: - add three entries to a map - get an iterator to give result of the first entry - delete all entries - call next 1273315 3 webkit-bug-importer 2017-02-04 16:48:21 -0800 <rdar://problem/30364994> 1273322 4 300646 saam 2017-02-04 17:02:46 -0800 Comment on attachment 300646 [PATCH] Proposed Fix Ignore my previous comment, I misread the diff, thinking that bucket = bucket->next() was only just now added. 1273329 5 300646 commit-queue 2017-02-04 17:27:54 -0800 Comment on attachment 300646 [PATCH] Proposed Fix Clearing flags on attachment: 300646 Committed r211675: <http://trac.webkit.org/changeset/211675> 1273330 6 commit-queue 2017-02-04 17:27:58 -0800 All reviewed patches have been landed. Closing bug. 300646 2017-02-04 16:39:17 -0800 2017-02-04 17:27:54 -0800 [PATCH] Proposed Fix a-1.patch text/plain 2462 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDI1ODU5MGQxNjA4Li43OTdhZDc0ZmE1MSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTctMDItMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBTdGF0aWMgQW5hbHl6 ZXI6IFZhbHVlIHN0b3JlZCB0byAncHJldicgaXMgbmV2ZXIgcmVhZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODQ0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNNYXBJdGVyYXRvci5oOjYwOjEzOiB3YXJuaW5nOiBWYWx1ZSBzdG9yZWQgdG8gJ3By ZXYnIGlzIG5ldmVyIHJlYWQKKyAgICAgICAgICAgICAgICAgICAgcHJldiA9IGJ1Y2tldDsKKyAg ICAgICAgICAgICAgICAgICAgXiAgICAgIH5+fn5+fgorICAgICAgICBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU1NldEl0ZXJhdG9yLmg6NjA6MTM6IHdhcm5pbmc6IFZhbHVlIHN0b3Jl ZCB0byAncHJldicgaXMgbmV2ZXIgcmVhZAorICAgICAgICAgICAgICAgICAgICBwcmV2ID0gYnVj a2V0OworICAgICAgICAgICAgICAgICAgICBeICAgICAgfn5+fn5+CisKKyAgICAgICAgKiBydW50 aW1lL0pTTWFwSXRlcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6SlNNYXBJdGVyYXRvcjo6YWR2YW5j ZUl0ZXIpOgorICAgICAgICAqIHJ1bnRpbWUvSlNTZXRJdGVyYXRvci5oOgorICAgICAgICAoSlND OjpKU1NldEl0ZXJhdG9yOjphZHZhbmNlSXRlcik6CisKKzIwMTctMDItMDQgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEbyBu b3QgdXNlIFJ1bkxvb3Agd2hlbiBkaXNwYXRjaGluZyBpbnNwZWN0b3IgR0MgZXZlbnQKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzY4MwogICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzAxNjc3OTE+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU01hcEl0ZXJhdG9yLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU01hcEl0ZXJhdG9yLmgKaW5kZXggMzY2NTMzZTBlNjMuLjZlOTc3YzIyYmIxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU01hcEl0ZXJhdG9yLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNNYXBJdGVyYXRvci5oCkBAIC01Niwx MCArNTYsOCBAQCBwdWJsaWM6CiAgICAgICAgIGlmICghcHJldikKICAgICAgICAgICAgIHJldHVy biBudWxscHRyOwogICAgICAgICBIYXNoTWFwQnVja2V0VHlwZSogYnVja2V0ID0gbV9pdGVyLT5u ZXh0KCk7Ci0gICAgICAgIHdoaWxlIChidWNrZXQgJiYgYnVja2V0LT5kZWxldGVkKCkpIHsKLSAg ICAgICAgICAgIHByZXYgPSBidWNrZXQ7CisgICAgICAgIHdoaWxlIChidWNrZXQgJiYgYnVja2V0 LT5kZWxldGVkKCkpCiAgICAgICAgICAgICBidWNrZXQgPSBidWNrZXQtPm5leHQoKTsKLSAgICAg ICAgfQogICAgICAgICBpZiAoIWJ1Y2tldCkgewogICAgICAgICAgICAgc2V0SXRlcmF0b3IoZXhl Yy0+dm0oKSwgbnVsbHB0cik7CiAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU2V0SXRlcmF0b3IuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTU2V0SXRlcmF0b3IuaAppbmRleCA0MWZjNTdmMjc1 Yi4uYTZmYjFiNjJiZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTU2V0SXRlcmF0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Nl dEl0ZXJhdG9yLmgKQEAgLTU2LDEwICs1Niw4IEBAIHB1YmxpYzoKICAgICAgICAgaWYgKCFwcmV2 KQogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAgIEhhc2hNYXBCdWNrZXRUeXBl KiBidWNrZXQgPSBtX2l0ZXItPm5leHQoKTsKLSAgICAgICAgd2hpbGUgKGJ1Y2tldCAmJiBidWNr ZXQtPmRlbGV0ZWQoKSkgewotICAgICAgICAgICAgcHJldiA9IGJ1Y2tldDsKKyAgICAgICAgd2hp bGUgKGJ1Y2tldCAmJiBidWNrZXQtPmRlbGV0ZWQoKSkKICAgICAgICAgICAgIGJ1Y2tldCA9IGJ1 Y2tldC0+bmV4dCgpOwotICAgICAgICB9CiAgICAgICAgIGlmICghYnVja2V0KSB7CiAgICAgICAg ICAgICBzZXRJdGVyYXRvcihleGVjLT52bSgpLCBudWxscHRyKTsKICAgICAgICAgICAgIHJldHVy biBudWxscHRyOwo=