167841 2017-02-04 15:35:51 -0800 Web Inspector: changing dock side from windowed to bottom should cause split console to collapse on Timeline and Network tabs 2017-02-09 12:13:52 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg hi commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1273293 0 bburg 2017-02-04 15:35:51 -0800 Per https://bugs.webkit.org/show_bug.cgi?id=167075, we don't support split console when docked. But if we are showing split console then become docked, the split console is still showing and makes the Timeline tab impossible to read. We should listen for dock side changes and collapse the split console if it isn't supported for the new tab+dock side combination. 1273294 1 webkit-bug-importer 2017-02-04 15:36:06 -0800 <rdar://problem/30364851> 1274899 2 301052 hi 2017-02-09 09:51:18 -0800 Created attachment 301052 Patch 1274964 3 301052 commit-queue 2017-02-09 12:13:48 -0800 Comment on attachment 301052 Patch Clearing flags on attachment: 301052 Committed r211976: <http://trac.webkit.org/changeset/211976> 1274965 4 commit-queue 2017-02-09 12:13:52 -0800 All reviewed patches have been landed. Closing bug. 301052 2017-02-09 09:51:18 -0800 2017-02-09 12:13:48 -0800 Patch bug-167841-20170209094852.patch text/plain 1438 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjYzAxOTIyOGRjZmY3NzY2YTRmZGRjMmQxZjFl ODg3YWMwODVhZWEuLjE3YTg3ZDYzZjc1YTgxMzI0NmYwN2U1YWZkYzZiYzgwMTY0Zjg1YTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTA5ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGNoYW5naW5nIGRvY2sgc2lkZSBmcm9tIHdpbmRvd2VkIHRvIGJvdHRvbSBzaG91bGQg Y2F1c2Ugc3BsaXQgY29uc29sZSB0byBjb2xsYXBzZSBvbiBUaW1lbGluZSBhbmQgTmV0d29yayB0 YWJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc4 NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLnVwZGF0ZURv Y2tlZFN0YXRlKToKKwogMjAxNy0wMi0wOSAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFw cGxlLmNvbT4KIAogICAgICAgICBbTWVkaWFTdHJlYW1dIFJlbW92ZSBsZWdhY3kgTmF2aWdhdG9y LndlYmtpdEdldFVzZXJNZWRpYQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDgzZWFkM2U2NWIyODg3NjcwYTg0ZTQzZmRiNmFjYzll MjQxNDU3NDguLjE0NmY2MmJjNDAwODI1MWU0ZDVmMWNiNzZmOTQ0ZGEwYWE0MDBjZGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAg LTc2NSw2ICs3NjUsOSBAQCBXZWJJbnNwZWN0b3IudXBkYXRlRG9ja2VkU3RhdGUgPSBmdW5jdGlv bihzaWRlKQogICAgIHRoaXMuX2lnbm9yZVRvb2xiYXJNb2RlRGlkQ2hhbmdlRXZlbnRzID0gZmFs c2U7CiAKICAgICB0aGlzLl91cGRhdGVEb2NrTmF2aWdhdGlvbkl0ZW1zKCk7CisKKyAgICBpZiAo IXRoaXMuZG9ja2VkQ29uZmlndXJhdGlvblN1cHBvcnRzU3BsaXRDb250ZW50QnJvd3NlcigpICYm IHRoaXMuaXNTaG93aW5nU3BsaXRDb25zb2xlKCkpCisgICAgICAgIHRoaXMuaGlkZVNwbGl0Q29u c29sZSgpOwogfTsKIAogV2ViSW5zcGVjdG9yLnVwZGF0ZVZpc2liaWxpdHlTdGF0ZSA9IGZ1bmN0 aW9uKHZpc2libGUpCg==