167832 2017-02-03 21:36:25 -0800 Fix misleading comment in RunLoop.h 2019-05-02 16:22:02 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 168152 1 joepeck joepeck andersca ap benjamin cdumez cmarcelo commit-queue dbates ddkilzer joepeck linnalandau sam oldest_to_newest 1273188 0 joepeck 2017-02-03 21:36:25 -0800 Fix misleading comment in RunLoop.h. Mac initialization used to force using CFRunLoopGetMain(). Now however it just uses RunLoop::current which uses CFRunLoopGetCurrent(). So this comment that it can be done on any thread is misleading and can lead to incorrect behavior if it is actually done on a non-main thread on Mac. 1273190 1 300604 joepeck 2017-02-03 21:37:33 -0800 Created attachment 300604 [PATCH] Proposed Fix 1273202 2 300604 ap 2017-02-04 00:07:57 -0800 Comment on attachment 300604 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=300604&action=review > Source/WTF/wtf/RunLoop.h:53 > + // Must be called from the main thread. On the Mac, this can be checked with an assertion (using pthread_main_np). 1273298 3 300643 joepeck 2017-02-04 15:55:50 -0800 Created attachment 300643 [PATCH] Proposed Fix 1273323 4 300643 joepeck 2017-02-04 17:04:49 -0800 Comment on attachment 300643 [PATCH] Proposed Fix Oh, that makes sense. WebKit1 will need some kind of "wait a beat". 1273324 5 300643 joepeck 2017-02-04 17:05:38 -0800 Comment on attachment 300643 [PATCH] Proposed Fix That comment was meant for another bug. 1275514 6 300643 commit-queue 2017-02-10 13:10:06 -0800 Comment on attachment 300643 [PATCH] Proposed Fix Clearing flags on attachment: 300643 Committed r212139: <http://trac.webkit.org/changeset/212139> 1275515 7 commit-queue 2017-02-10 13:10:12 -0800 All reviewed patches have been landed. Closing bug. 1275621 8 commit-queue 2017-02-10 16:17:10 -0800 Re-opened since this is blocked by bug 168152 1275627 9 joepeck 2017-02-10 16:23:02 -0800 This revealed a few issues where non-main thread code triggers WebKit2Initialize and so could potentially be initializing the main run loop on a non-main thread (because WebKit2Initialize is not dispatch_once and always calls down into RunLoop::initializeMainThread). For example, this case in DumpRenderTree: (Bug 168149) https://bugs.webkit.org/show_bug.cgi?id=168149 300604 2017-02-03 21:37:33 -0800 2017-02-04 15:55:50 -0800 [PATCH] Proposed Fix comment-1.patch text/plain 1466 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTE1MmExMDNjMjguLmQ1NWQwMjk2MmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3 LTAyLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAg Rml4IG1pc2xlYWRpbmcgY29tbWVudCBpbiBSdW5Mb29wLmgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzgzMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1J1bkxvb3AuaDoKKyAgICAgICAgTWFj IGluaXRpYWxpemF0aW9uIHVzZWQgdG8gZm9yY2UgdXNpbmcgQ0ZSdW5Mb29wR2V0TWFpbigpLiBO b3cgaG93ZXZlciBpdCBqdXN0CisgICAgICAgIHVzZXMgUnVuTG9vcDo6Y3VycmVudCB3aGljaCB1 c2VzIENGUnVuTG9vcEdldEN1cnJlbnQoKS4gU28gdGhpcyBjb21tZW50IHRoYXQKKyAgICAgICAg aXQgY2FuIGJlIGRvbmUgb24gYW55IHRocmVhZCBpcyBtaXNsZWFkaW5nIGFuZCBjYW4gbGVhZCB0 byBpbmNvcnJlY3QgYmVoYXZpb3IKKyAgICAgICAgaWYgaXQgaXMgYWN0dWFsbHkgZG9uZSBvbiBh IG5vbi1tYWluIHRocmVhZCBvbiBNYWMuCisKKzIwMTctMDItMDMgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBQZXJmb3JtYW5jZSBUaW1pbmc6IENvbnZl cnQgV1RGOjpNb25vdG9uaWNUaW1lIGFuZCBXVEY6OlNlY29uZHMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Nzc2OAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9SdW5Mb29wLmggYi9Tb3VyY2UvV1RGL3d0Zi9SdW5Mb29wLmgKaW5kZXggYWE1 MDNmNDZjZWYuLjE5ZTQ3MTEyMDYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9SdW5Mb29w LmgKKysrIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5oCkBAIC01MCw4ICs1MCw3IEBAIG5hbWVz cGFjZSBXVEYgewogY2xhc3MgUnVuTG9vcCA6IHB1YmxpYyBGdW5jdGlvbkRpc3BhdGNoZXIgewog ICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFJ1bkxvb3ApOwogcHVibGljOgotICAgIC8vIE11c3Qg YmUgY2FsbGVkIGZyb20gdGhlIG1haW4gdGhyZWFkIChleGNlcHQgZm9yIHRoZSBNYWMgcGxhdGZv cm0sIHdoZXJlIGl0Ci0gICAgLy8gY2FuIGJlIGNhbGxlZCBmcm9tIGFueSB0aHJlYWQpLgorICAg IC8vIE11c3QgYmUgY2FsbGVkIGZyb20gdGhlIG1haW4gdGhyZWFkLgogICAgIFdURl9FWFBPUlRf UFJJVkFURSBzdGF0aWMgdm9pZCBpbml0aWFsaXplTWFpblJ1bkxvb3AoKTsKIAogICAgIFdURl9F WFBPUlRfUFJJVkFURSBzdGF0aWMgUnVuTG9vcCYgY3VycmVudCgpOwo= 300643 2017-02-04 15:55:50 -0800 2017-02-10 13:10:06 -0800 [PATCH] Proposed Fix assert-1.patch text/plain 1849 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYTE1MmExMDNjMjguLmQ1NWQwMjk2MmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3 LTAyLTAzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAg Rml4IG1pc2xlYWRpbmcgY29tbWVudCBpbiBSdW5Mb29wLmgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzgzMgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1J1bkxvb3AuaDoKKyAgICAgICAgTWFj IGluaXRpYWxpemF0aW9uIHVzZWQgdG8gZm9yY2UgdXNpbmcgQ0ZSdW5Mb29wR2V0TWFpbigpLiBO b3cgaG93ZXZlciBpdCBqdXN0CisgICAgICAgIHVzZXMgUnVuTG9vcDo6Y3VycmVudCB3aGljaCB1 c2VzIENGUnVuTG9vcEdldEN1cnJlbnQoKS4gU28gdGhpcyBjb21tZW50IHRoYXQKKyAgICAgICAg aXQgY2FuIGJlIGRvbmUgb24gYW55IHRocmVhZCBpcyBtaXNsZWFkaW5nIGFuZCBjYW4gbGVhZCB0 byBpbmNvcnJlY3QgYmVoYXZpb3IKKyAgICAgICAgaWYgaXQgaXMgYWN0dWFsbHkgZG9uZSBvbiBh IG5vbi1tYWluIHRocmVhZCBvbiBNYWMuCisKKzIwMTctMDItMDMgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBQZXJmb3JtYW5jZSBUaW1pbmc6IENvbnZl cnQgV1RGOjpNb25vdG9uaWNUaW1lIGFuZCBXVEY6OlNlY29uZHMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Nzc2OAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9SdW5Mb29wLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuY3BwCmluZGV4 IDNiMDI2N2U5NzFiLi45ODIyYWU0NDQyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUnVu TG9vcC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvUnVuTG9vcC5jcHAKQEAgLTUwLDYgKzUwLDkg QEAgcHJpdmF0ZToKIAogdm9pZCBSdW5Mb29wOjppbml0aWFsaXplTWFpblJ1bkxvb3AoKQogewor I2lmIE9TKERBUldJTikKKyAgICBBU1NFUlQocHRocmVhZF9tYWluX25wKCkpOworI2VuZGlmCiAg ICAgaWYgKHNfbWFpblJ1bkxvb3ApCiAgICAgICAgIHJldHVybjsKICAgICBzX21haW5SdW5Mb29w ID0gJlJ1bkxvb3A6OmN1cnJlbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1J1bkxv b3AuaCBiL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuaAppbmRleCBhYTUwM2Y0NmNlZi4uMTllNDcx MTIwNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1J1bkxvb3AuaAorKysgYi9Tb3VyY2Uv V1RGL3d0Zi9SdW5Mb29wLmgKQEAgLTUwLDggKzUwLDcgQEAgbmFtZXNwYWNlIFdURiB7CiBjbGFz cyBSdW5Mb29wIDogcHVibGljIEZ1bmN0aW9uRGlzcGF0Y2hlciB7CiAgICAgV1RGX01BS0VfTk9O Q09QWUFCTEUoUnVuTG9vcCk7CiBwdWJsaWM6Ci0gICAgLy8gTXVzdCBiZSBjYWxsZWQgZnJvbSB0 aGUgbWFpbiB0aHJlYWQgKGV4Y2VwdCBmb3IgdGhlIE1hYyBwbGF0Zm9ybSwgd2hlcmUgaXQKLSAg ICAvLyBjYW4gYmUgY2FsbGVkIGZyb20gYW55IHRocmVhZCkuCisgICAgLy8gTXVzdCBiZSBjYWxs ZWQgZnJvbSB0aGUgbWFpbiB0aHJlYWQuCiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHN0YXRpYyB2 b2lkIGluaXRpYWxpemVNYWluUnVuTG9vcCgpOwogCiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHN0 YXRpYyBSdW5Mb29wJiBjdXJyZW50KCk7Cg==