167827 2017-02-03 20:42:10 -0800 Simple line layout: Remove redundant codepath check. 2017-02-05 09:43:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 167855 1 zalan zalan bfulgham commit-queue esprehn+autocc glenn koivisto kondapallykalyan mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 1273161 0 zalan 2017-02-03 20:42:10 -0800 RenderText already has this information. 1273162 1 webkit-bug-importer 2017-02-03 20:42:33 -0800 <rdar://problem/30361850> 1273163 2 300597 zalan 2017-02-03 20:49:44 -0800 Created attachment 300597 Patch 1273186 3 300597 mmaxfield 2017-02-03 21:27:22 -0800 Comment on attachment 300597 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300597&action=review > Source/WebCore/rendering/SimpleLineLayout.cpp:-109 > - FlowFontIsNotSimple = 1LLU << 43, Wait, what about all the uses of this symbol? Don't they have to be updated? 1273194 4 300597 commit-queue 2017-02-03 22:04:57 -0800 Comment on attachment 300597 Patch Clearing flags on attachment: 300597 Committed r211668: <http://trac.webkit.org/changeset/211668> 1273195 5 commit-queue 2017-02-03 22:05:02 -0800 All reviewed patches have been landed. Closing bug. 1273388 6 commit-queue 2017-02-05 09:34:30 -0800 Re-opened since this is blocked by bug 167855 300597 2017-02-03 20:49:44 -0800 2017-02-03 22:04:57 -0800 Patch bug-167827-20170203204728.patch text/plain 3030 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmUyMTI0MDM0OTU4MzVl MzdjNjRmMzA5ZmRjZmU2MzJhMWNlNmUwZC4uZTA5NzU0ZWI5MjNiYzlmMzQyMGYwMTA5MzhjMTdl NmY1YTRhYTIzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0 OiBSZW1vdmUgcmVkdW5kYW50IGNvZGVwYXRoIGNoZWNrLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zMDM2MTg1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGb250Q2FzY2FkZTo6Y29kZVBhdGgoKSBpdGVyYXRlcyB0aHJvdWdoIHRoZSBlbnRpcmUg dGV4dC4gSXQncyByYXRoZXIgd2FzdGVmdWwgdG8gZG8gdHdpY2UuCisKKyAgICAgICAgTm8gY2hh bmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvU2ltcGxlTGluZUxh eW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3JG b250QW5kVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVMaW5lTGF5b3V0OjpwcmludFJl YXNvbik6CisKIDIwMTctMDItMDMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBQZXJmb3JtYW5jZSBUaW1pbmc6IENvbnZlcnQgV1RGOjpNb25vdG9uaWNU aW1lIGFuZCBXVEY6OlNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9TaW1wbGVMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVM aW5lTGF5b3V0LmNwcAppbmRleCAwNzM2YWViMDliMjE5ZWQ0NjAxODAwZDA1YjJkYTc4ZDQyNTM3 ODFlLi4zNTIwYWE5ZDFmY2ViYzdmMDhkYjE5YjRmMWMxMDk2MjhlYTRiZDExIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCkBAIC0xMDYsNyArMTA2 LDcgQEAgZW51bSBBdm9pZGFuY2VSZWFzb25fIDogdWludDY0X3QgewogICAgIEZsb3dUZXh0SXNS ZW5kZXJRdW90ZSAgICAgICAgICAgICAgICAgPSAxTExVICA8PCA0MCwKICAgICBGbG93VGV4dElz VGV4dEZyYWdtZW50ICAgICAgICAgICAgICAgID0gMUxMVSAgPDwgNDEsCiAgICAgRmxvd1RleHRJ c1NWR0lubGluZVRleHQgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDQyLAotICAgIEZsb3dGb250 SXNOb3RTaW1wbGUgICAgICAgICAgICAgICAgICAgPSAxTExVICA8PCA0MywKKyAgICBGbG93SGFz Q29tcGxleEZvbnRDb2RlUGF0aCAgICAgICAgICAgID0gMUxMVSAgPDwgNDMsCiAgICAgRmVhdHVy ZUlzRGlzYWJsZWQgICAgICAgICAgICAgICAgICAgICA9IDFMTFUgIDw8IDQ0LAogICAgIEZsb3dI YXNOb1BhcmVudCAgICAgICAgICAgICAgICAgICAgICAgPSAxTExVICA8PCA0NSwKICAgICBGbG93 SGFzTm9DaGlsZCAgICAgICAgICAgICAgICAgICAgICAgID0gMUxMVSAgPDwgNDYsCkBAIC0yMDks OCArMjA5LDggQEAgc3RhdGljIEF2b2lkYW5jZVJlYXNvbkZsYWdzIGNhblVzZUZvckZvbnRBbmRU ZXh0KGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgZmxvdywgSW4KICAgICAgICAgICAgIFNFVF9SRUFT T05fQU5EX1JFVFVSTl9JRl9ORUVERUQoRmxvd1RleHRJc1RleHRGcmFnbWVudCwgcmVhc29ucywg aW5jbHVkZVJlYXNvbnMpOwogICAgICAgICBpZiAodGV4dFJlbmRlcmVyLmlzU1ZHSW5saW5lVGV4 dCgpKQogICAgICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93VGV4 dElzU1ZHSW5saW5lVGV4dCwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwotICAgICAgICBpZiAo c3R5bGUuZm9udENhc2NhZGUoKS5jb2RlUGF0aChUZXh0UnVuKHRleHRSZW5kZXJlci50ZXh0KCkp KSAhPSBGb250Q2FzY2FkZTo6U2ltcGxlKQotICAgICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVU VVJOX0lGX05FRURFRChGbG93Rm9udElzTm90U2ltcGxlLCByZWFzb25zLCBpbmNsdWRlUmVhc29u cyk7CisgICAgICAgIGlmICghdGV4dFJlbmRlcmVyLmNhblVzZVNpbXBsZUZvbnRDb2RlUGF0aCgp KQorICAgICAgICAgICAgU0VUX1JFQVNPTl9BTkRfUkVUVVJOX0lGX05FRURFRChGbG93SGFzQ29t cGxleEZvbnRDb2RlUGF0aCwgcmVhc29ucywgaW5jbHVkZVJlYXNvbnMpOwogCiAgICAgICAgIGF1 dG8gdGV4dFJlYXNvbnMgPSBjYW5Vc2VGb3JUZXh0KHRleHRSZW5kZXJlciwgZm9udENhc2NhZGUs IGxpbmVIZWlnaHRDb25zdHJhaW50LCBmbG93SXNKdXN0aWZpZWQsIGluY2x1ZGVSZWFzb25zKTsK ICAgICAgICAgaWYgKHRleHRSZWFzb25zICE9IE5vUmVhc29uKQpAQCAtMTA1MSw4ICsxMDUxLDgg QEAgc3RhdGljIHZvaWQgcHJpbnRSZWFzb24oQXZvaWRhbmNlUmVhc29uIHJlYXNvbiwgVGV4dFN0 cmVhbSYgc3RyZWFtKQogICAgIGNhc2UgRmxvd1RleHRJc1NWR0lubGluZVRleHQ6CiAgICAgICAg IHN0cmVhbSA8PCAidW5zdXBwb3J0ZWQgU1ZHSW5saW5lVGV4dCI7CiAgICAgICAgIGJyZWFrOwot ICAgIGNhc2UgRmxvd0ZvbnRJc05vdFNpbXBsZToKLSAgICAgICAgc3RyZWFtIDw8ICJjb21wbGV4 dCBmb250IjsKKyAgICBjYXNlIEZsb3dIYXNDb21wbGV4Rm9udENvZGVQYXRoOgorICAgICAgICBz dHJlYW0gPDwgInRleHQgd2l0aCBjb21wbGV4IGZvbnQgY29kZXBhdGgiOwogICAgICAgICBicmVh azsKICAgICBjYXNlIEZsb3dIYXNUZXh0U2hhZG93OgogICAgICAgICBzdHJlYW0gPDwgInRleHQt c2hhZG93IjsK