167804 2017-02-03 11:18:57 -0800 WKActionSheet should dismiss with animation when done with the sheet 2017-02-03 12:09:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue enrica thorton webkit-bug-importer oldest_to_newest 1272990 0 wenson_hsieh 2017-02-03 11:18:57 -0800 <rdar://problem/30334861> 1272991 1 300552 wenson_hsieh 2017-02-03 11:24:31 -0800 Created attachment 300552 Patch 1272992 2 300552 thorton 2017-02-03 11:28:23 -0800 Comment on attachment 300552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300552&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585 > - [_dataInteractionGestureRecognizer setDelay:0.25]; > + [_dataInteractionGestureRecognizer setDelay:0.5]; ? 1272994 3 wenson_hsieh 2017-02-03 11:42:55 -0800 (In reply to comment #2) Thanks! > Comment on attachment 300552 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300552&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585 > > - [_dataInteractionGestureRecognizer setDelay:0.25]; > > + [_dataInteractionGestureRecognizer setDelay:0.5]; > > ? This is still arbitrary, and will be changed to a final value in the near future! Without this, long press to bring up the action sheet seemed unnaturally fast. 1273006 4 300552 commit-queue 2017-02-03 12:09:17 -0800 Comment on attachment 300552 Patch Clearing flags on attachment: 300552 Committed r211643: <http://trac.webkit.org/changeset/211643> 1273007 5 commit-queue 2017-02-03 12:09:20 -0800 All reviewed patches have been landed. Closing bug. 300552 2017-02-03 11:24:31 -0800 2017-02-03 12:09:17 -0800 Patch bug-167804-20170203112215.patch text/plain 4242 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDA4ZGIxMGNiNjY4NDhk ZDgzMzk5YmJmOGM2YmEyYThjODE5MGFkOS4uZDJkZWMzZGNhNDZlNmU5YWI3NzM3ODFkN2Q5YWJj Y2M0ZDUwMzIwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAyLTAzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFdLQWN0aW9uU2hl ZXQgc2hvdWxkIGRpc21pc3Mgd2l0aCBhbmltYXRpb24gd2hlbiBkb25lIHdpdGggdGhlIHNoZWV0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc4MDQK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwMzM0ODYxPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgd2UgZG8gbm90IGRpc21pc3Mg dGhlIGFjdGlvbiBtZW51IHdoZW4gLWRvbmVXaXRoU2hlZXQgaXMgaW52b2tlZC4gV2hpbGUgdGhp cyBpcyBva2F5IHdoZW4gdGhlIG1lbnUgaXMKKyAgICAgICAgZGlzbWlzc2VkIHZpYSB0YXAgKHNp bmNlIGl0IHdpbGwgYmUgZGlzbWlzc2VkIGFzIGRlZmF1bHQgYmVoYXZpb3IgYnkgdGhlIHBvcG92 ZXIgY29udHJvbGxlcikgd2UgbmVlZCB0byBtYW51YWxseQorICAgICAgICBkaXNtaXNzIGl0IGlm IHdlIGFyZSB0cnlpbmcgdG8gcHJvZ3JhbW1hdGljYWxseSBkaXNtaXNzIHRoZSBhY3Rpb24gc2hl ZXQvbWVudS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldC5tbToKKyAg ICAgICAgKC1bV0tBY3Rpb25TaGVldCBwcmVzZW50U2hlZXRGcm9tUmVjdDpdKToKKyAgICAgICAg KC1bV0tBY3Rpb25TaGVldCBkb25lV2l0aFNoZWV0XSk6CisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg c2V0dXBJbnRlcmFjdGlvbl0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHJlc2lnbkZpcnN0 UmVzcG9uZGVyXSk6CisKIDIwMTctMDItMDIgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMTE1MzUsIHIy MTE1NjYsIGFuZCByMjExNTY4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0FjdGlvblNoZWV0Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Fj dGlvblNoZWV0Lm1tCmluZGV4IDRmYzhjNGYxNjMxNjViMWM3NDEwMjkyZmUzZDJjNDZmNTlmM2Yz NTYuLjNjODI1MmQyYmE3NWIyYWViNWEwZjBhNzJiYmZiOTQ3YzdlYmU0MjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldC5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXQubW0KQEAgLTM3LDYgKzM3LDcg QEAKICAgICBCT09MIF9pc1JvdGF0aW5nOwogICAgIEJPT0wgX3JlYWR5VG9QcmVzZW50QWZ0ZXJS b3RhdGlvbjsKIAorICAgIFJldGFpblB0cjxVSVZpZXdDb250cm9sbGVyPiBfY3VycmVudFByZXNl bnRpbmdWaWV3Q29udHJvbGxlcjsKICAgICBSZXRhaW5QdHI8VUlWaWV3Q29udHJvbGxlcj4gX3By ZXNlbnRlZFZpZXdDb250cm9sbGVyV2hpbGVSb3RhdGluZzsKICAgICBSZXRhaW5QdHI8aWQgPFVJ UG9wb3ZlclByZXNlbnRhdGlvbkNvbnRyb2xsZXJEZWxlZ2F0ZT4+IF9wb3BvdmVyUHJlc2VudGF0 aW9uQ29udHJvbGxlckRlbGVnYXRlV2hpbGVSb3RhdGluZzsKIH0KQEAgLTk5LDE0ICsxMDAsMTgg QEAKICAgICBpZiAoX3BvcG92ZXJQcmVzZW50YXRpb25Db250cm9sbGVyRGVsZWdhdGVXaGlsZVJv dGF0aW5nKQogICAgICAgICBwcmVzZW50YXRpb25Db250cm9sbGVyLmRlbGVnYXRlID0gX3BvcG92 ZXJQcmVzZW50YXRpb25Db250cm9sbGVyRGVsZWdhdGVXaGlsZVJvdGF0aW5nLmdldCgpOwogCi0g ICAgVUlWaWV3Q29udHJvbGxlciAqcHJlc2VudGluZ1ZpZXdDb250cm9sbGVyID0gW1VJVmlld0Nv bnRyb2xsZXIgX3ZpZXdDb250cm9sbGVyRm9yRnVsbFNjcmVlblByZXNlbnRhdGlvbkZyb21WaWV3 OnZpZXddOwotICAgIFtwcmVzZW50aW5nVmlld0NvbnRyb2xsZXIgcHJlc2VudFZpZXdDb250cm9s bGVyOnByZXNlbnRlZFZpZXdDb250cm9sbGVyIGFuaW1hdGVkOllFUyBjb21wbGV0aW9uOk5VTExd OworICAgIF9jdXJyZW50UHJlc2VudGluZ1ZpZXdDb250cm9sbGVyID0gW1VJVmlld0NvbnRyb2xs ZXIgX3ZpZXdDb250cm9sbGVyRm9yRnVsbFNjcmVlblByZXNlbnRhdGlvbkZyb21WaWV3OnZpZXdd OworICAgIFtfY3VycmVudFByZXNlbnRpbmdWaWV3Q29udHJvbGxlciBwcmVzZW50Vmlld0NvbnRy b2xsZXI6cHJlc2VudGVkVmlld0NvbnRyb2xsZXIgYW5pbWF0ZWQ6WUVTIGNvbXBsZXRpb246bmls XTsKIAogICAgIHJldHVybiBZRVM7CiB9CiAKIC0gKHZvaWQpZG9uZVdpdGhTaGVldAogeworICAg IGlmIChfY3VycmVudFByZXNlbnRpbmdWaWV3Q29udHJvbGxlcikKKyAgICAgICAgW19jdXJyZW50 UHJlc2VudGluZ1ZpZXdDb250cm9sbGVyIGRpc21pc3NWaWV3Q29udHJvbGxlckFuaW1hdGVkOllF UyBjb21wbGV0aW9uOm5pbF07CisKKyAgICBfY3VycmVudFByZXNlbnRpbmdWaWV3Q29udHJvbGxl ciA9IG5pbDsKICAgICBfcHJlc2VudGVkVmlld0NvbnRyb2xsZXJXaGlsZVJvdGF0aW5nID0gbmls OwogICAgIF9wb3BvdmVyUHJlc2VudGF0aW9uQ29udHJvbGxlckRlbGVnYXRlV2hpbGVSb3RhdGlu ZyA9IG5pbDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Nv bnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dL Q29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCA4MWFkYTJlYzg3YjczNWQxY2JkYjRjMGUy MmFiY2U0YjZkZTIwZTc2Li40MDYwZTk2NmVhZGMxOTY1MjA1NDIxZTc0YWU4NTdkYWY2ODE5ZTcy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJ bnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNTgyLDcgKzU4Miw3IEBAIHN0YXRpYyBVSVdlYlNlbGVj dGlvbk1vZGUgdG9VSVdlYlNlbGVjdGlvbk1vZGUoV0tTZWxlY3Rpb25HcmFudWxhcml0eSBncmFu dWxhcml0CiAKICNpZiBFTkFCTEUoREFUQV9JTlRFUkFDVElPTikKICAgICBfZGF0YUludGVyYWN0 aW9uR2VzdHVyZVJlY29nbml6ZXIgPSBhZG9wdE5TKFtbVUlMb25nUHJlc3NHZXN0dXJlUmVjb2du aXplciBhbGxvY10gaW5pdFdpdGhUYXJnZXQ6c2VsZiBhY3Rpb246QHNlbGVjdG9yKF9kYXRhSW50 ZXJhY3Rpb25HZXN0dXJlUmVjb2duaXplcjopXSk7Ci0gICAgW19kYXRhSW50ZXJhY3Rpb25HZXN0 dXJlUmVjb2duaXplciBzZXREZWxheTowLjI1XTsKKyAgICBbX2RhdGFJbnRlcmFjdGlvbkdlc3R1 cmVSZWNvZ25pemVyIHNldERlbGF5OjAuNV07CiAgICAgW19kYXRhSW50ZXJhY3Rpb25HZXN0dXJl UmVjb2duaXplciBzZXREZWxlZ2F0ZTpzZWxmXTsKICAgICBbX2RhdGFJbnRlcmFjdGlvbkdlc3R1 cmVSZWNvZ25pemVyIF9zZXRSZXF1aXJlc1F1aWV0SW1wdWxzZTpZRVNdOwogICAgIFtzZWxmIGFk ZEdlc3R1cmVSZWNvZ25pemVyOl9kYXRhSW50ZXJhY3Rpb25HZXN0dXJlUmVjb2duaXplci5nZXQo KV07CkBAIC04NTAsOSArODUwLDYgQEAgc3RhdGljIFVJV2ViU2VsZWN0aW9uTW9kZSB0b1VJV2Vi U2VsZWN0aW9uTW9kZShXS1NlbGVjdGlvbkdyYW51bGFyaXR5IGdyYW51bGFyaXQKIAogLSAoQk9P TClyZXNpZ25GaXJzdFJlc3BvbmRlcgogewotI2lmIEVOQUJMRShEQVRBX0lOVEVSQUNUSU9OKQot ICAgIF9kYXRhSW50ZXJhY3Rpb25TdGF0ZS5zaG91bGRIYW5kbGVMb25nUHJlc3NBY3Rpb24gPSBO TzsKLSNlbmRpZgogICAgIC8vIEZJWE1FOiBNYXliZSB3ZSBzaG91bGQgY2FsbCByZXNpZ25GaXJz dFJlc3BvbmRlciBvbiB0aGUgc3VwZXJjbGFzcwogICAgIC8vIGFuZCBkbyBub3RoaW5nIGlmIHRo ZSByZXR1cm4gdmFsdWUgaXMgTk8uCiAK