167800 2017-02-03 10:15:59 -0800 malloc and posix_memalign used without including cstdlib 2017-02-03 14:00:39 -0800 1 1 1 Unclassified WebKit bmalloc WebKit Local Build Unspecified Other RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned commit-queue ggaren oldest_to_newest 1272967 0 lantw44 2017-02-03 10:15:59 -0800 This causes compilation error on FreeBSD: /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:78:20: error: no member named 'malloc' in the global namespace; did you mean simply 'malloc'? void* result = ::malloc(size); ^~~~~~~~ malloc /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:76:18: note: 'malloc' declared here void* DebugHeap::malloc(size_t size) ^ /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:87:9: error: use of undeclared identifier 'posix_memalign' if (posix_memalign(&result, alignment, size)) { ^ /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:97:20: error: no member named 'realloc' in the global namespace; did you mean simply 'realloc'? void* result = ::realloc(object, size); ^~~~~~~~~ realloc /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:95:18: note: 'realloc' declared here void* DebugHeap::realloc(void* object, size_t size) ^ /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:105:7: error: no type named 'free' in the global namespace ::free(object); ~~^ /path/to/WebKit/Source/bmalloc/bmalloc/DebugHeap.cpp:103:28: warning: unused parameter 'object' [-Wunused-parameter] void DebugHeap::free(void* object) ^ 1 warning and 4 errors generated. 1272968 1 300543 lantw44 2017-02-03 10:18:34 -0800 Created attachment 300543 mmm 1272969 2 300544 lantw44 2017-02-03 10:19:25 -0800 Created attachment 300544 Patch 1273040 3 300544 ggaren 2017-02-03 13:48:39 -0800 Comment on attachment 300544 Patch r=me 1273049 4 300544 commit-queue 2017-02-03 14:00:35 -0800 Comment on attachment 300544 Patch Clearing flags on attachment: 300544 Committed r211651: <http://trac.webkit.org/changeset/211651> 1273050 5 commit-queue 2017-02-03 14:00:39 -0800 All reviewed patches have been landed. Closing bug. 300543 2017-02-03 10:18:34 -0800 2017-02-03 10:19:20 -0800 mmm bug-167800-20170203181617.patch text/plain 1070 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNTQ4ZjdkOGNjMmE4NTBi OGQ0MzBmNTYwNjY1MzQ1NDVkZjMwMDdmOC4uZGMyZTQzZTJlNTJmNDVhNmI3ZTg2NjU3YmMzYWQ0 MTBlMWZkYjhjMyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTAxICBUaW5n LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBJbmNsdWRlIGNzdGRsaWIg YmVmb3JlIHVzaW5nIDo6bWFsbG9jIGFuZCBwb3NpeF9tZW1hbGlnbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0RlYnVnSGVhcC5jcHA6 CisKIDIwMTctMDItMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAg ICAgIEltcGxlbWVudCB0aGUgYWx3YXlzUnVuc0F0QmFja2dyb3VuZFByaW9yaXR5IFdLMiBzZXR0 aW5nIHVzaW5nIHRocmVhZCBRb1MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0RlYnVnSGVhcC5jcHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0RlYnVnSGVhcC5jcHAKaW5k ZXggMzIwZDgxNGQ3MmUxZGZkMDkwMzFkNzBhMmQ1YjE2Y2I2NmJmN2E0NS4uNmEwZjA3Y2YxNWIz NDYzZGFjYWVhMDE5ZDk2YjA5YWI2MmIxYjllNSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9EZWJ1Z0hlYXAuY3BwCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRGVidWdI ZWFwLmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkRlYnVnSGVhcC5oIgogI2luY2x1 ZGUgIkJBc3NlcnQuaCIKICNpbmNsdWRlICJCUGxhdGZvcm0uaCIKKyNpbmNsdWRlIDxjc3RkbGli PgogI2luY2x1ZGUgPHRocmVhZD4KIAogbmFtZXNwYWNlIGJtYWxsb2Mgewo= 300544 2017-02-03 10:19:25 -0800 2017-02-03 14:00:35 -0800 Patch bug-167800-20170203181707.patch text/plain 1070 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNTQ4ZjdkOGNjMmE4NTBi OGQ0MzBmNTYwNjY1MzQ1NDVkZjMwMDdmOC4uZGMyZTQzZTJlNTJmNDVhNmI3ZTg2NjU3YmMzYWQ0 MTBlMWZkYjhjMyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTAyLTAxICBUaW5n LVdlaSBMYW4gIDxsYW50dzQ0QGdtYWlsLmNvbT4KKworICAgICAgICBJbmNsdWRlIGNzdGRsaWIg YmVmb3JlIHVzaW5nIDo6bWFsbG9jIGFuZCBwb3NpeF9tZW1hbGlnbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3ODAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBibWFsbG9jL0RlYnVnSGVhcC5jcHA6 CisKIDIwMTctMDItMDEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAg ICAgIEltcGxlbWVudCB0aGUgYWx3YXlzUnVuc0F0QmFja2dyb3VuZFByaW9yaXR5IFdLMiBzZXR0 aW5nIHVzaW5nIHRocmVhZCBRb1MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0RlYnVnSGVhcC5jcHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0RlYnVnSGVhcC5jcHAKaW5k ZXggMzIwZDgxNGQ3MmUxZGZkMDkwMzFkNzBhMmQ1YjE2Y2I2NmJmN2E0NS4uNmEwZjA3Y2YxNWIz NDYzZGFjYWVhMDE5ZDk2YjA5YWI2MmIxYjllNSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9EZWJ1Z0hlYXAuY3BwCisrKyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRGVidWdI ZWFwLmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkRlYnVnSGVhcC5oIgogI2luY2x1 ZGUgIkJBc3NlcnQuaCIKICNpbmNsdWRlICJCUGxhdGZvcm0uaCIKKyNpbmNsdWRlIDxjc3RkbGli PgogI2luY2x1ZGUgPHRocmVhZD4KIAogbmFtZXNwYWNlIGJtYWxsb2Mgewo=