167796 2017-02-03 09:18:49 -0800 Doc generation failure in WebKitSecurityOrigin 2017-02-03 10:46:59 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1272938 0 olivier.blin 2017-02-03 09:18:49 -0800 The doc generation fails in Source/WebKit2/UIProcess/API/gtk/WebKitSecurityOrigin.cpp:167: warning: Free-form return value description in webkit_security_origin_get_protocol. Use `Returns:' to avoid ambiguities. 1272944 1 300537 olivier.blin 2017-02-03 09:24:19 -0800 Created attachment 300537 Patch 1272946 2 commit-queue 2017-02-03 09:27:17 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1272982 3 300537 commit-queue 2017-02-03 10:46:54 -0800 Comment on attachment 300537 Patch Clearing flags on attachment: 300537 Committed r211639: <http://trac.webkit.org/changeset/211639> 1272983 4 commit-queue 2017-02-03 10:46:59 -0800 All reviewed patches have been landed. Closing bug. 300537 2017-02-03 09:24:19 -0800 2017-02-03 10:46:54 -0800 Patch bug-167796-20170203182202.patch text/plain 1467 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmY2NzhiM2UwOGU4YjQ2 NzI3MzY0ZTAwMmRhZmJlOGExOWM3NDJiNi4uMTEyMjM2ODBjNTg3Mjc1OTAyNTFiMjAzZDg4MTI2 OTJhNGMxODZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTAzICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgRG9jIGdl bmVyYXRpb24gZmFpbHVyZSBpbiBXZWJLaXRTZWN1cml0eU9yaWdpbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3Nzk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRTZWN1cml0eU9yaWdpbi5jcHA6CisgICAgICAgIHdhcm5pbmc6IEZyZWUtZm9ybSByZXR1cm4g dmFsdWUgZGVzY3JpcHRpb24gaW4gd2Via2l0X3NlY3VyaXR5X29yaWdpbl9nZXRfcHJvdG9jb2wu IFVzZSBgUmV0dXJuczonIHRvIGF2b2lkIGFtYmlndWl0aWVzLgorCiAyMDE3LTAyLTAzICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBB ZGQgaW5pdGlhbCBpbXBsZW1lbnRhdGlvbiBvZiByZXNvdXJjZSB1c2FnZSBvdmVybGF5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZWN1cml0eU9y aWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZWN1cml0 eU9yaWdpbi5jcHAKaW5kZXggZWNjYzgyZDU3MDk0YjIxZTQ4OGY4NDY2ZGMxYjZmMGI3MTIzMzlk NS4uMGE1YmE2M2U3YmFkMmMwY2I0ZWM0YzExZmUzZmVhZmYxYzY5MmFhYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0U2VjdXJpdHlPcmlnaW4uY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFNlY3VyaXR5T3Jp Z2luLmNwcApAQCAtMTYxLDcgKzE2MSw3IEBAIHZvaWQgd2Via2l0X3NlY3VyaXR5X29yaWdpbl91 bnJlZihXZWJLaXRTZWN1cml0eU9yaWdpbiogb3JpZ2luKQogICoKICAqIEdldHMgdGhlIHByb3Rv Y29sIG9mIEBvcmlnaW4sIG9yICVOVUxMIGlmIEBvcmlnaW4gaXMgb3BhcXVlLgogICoKLSAqIFJl dHVybnMgKGFsbG93LW5vbmUpOiBUaGUgcHJvdG9jb2wgb2YgdGhlICNXZWJLaXRTZWN1cml0eU9y aWdpbgorICogUmV0dXJuczogKGFsbG93LW5vbmUpOiBUaGUgcHJvdG9jb2wgb2YgdGhlICNXZWJL aXRTZWN1cml0eU9yaWdpbgogICoKICAqIFNpbmNlOiAyLjE2CiAgKi8K