167793 2017-02-03 08:27:50 -0800 [Modern Media Controls] Skip back button is visible with a live broadcast video 2017-02-03 11:55:07 -0800 1 1 1 Unclassified WebKit Media Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue webkit-bug-importer oldest_to_newest 1272915 0 300533 graouts 2017-02-03 08:27:50 -0800 Created attachment 300533 Testcase We shouldn't be showing the skip back button for a live broadcast video. 1272916 1 webkit-bug-importer 2017-02-03 08:28:12 -0800 <rdar://problem/30348780> 1272932 2 graouts 2017-02-03 09:06:18 -0800 We simply need to teach SkipBackSupport about the "durationchange" event and check when we have an infinity duration video (ie. live broadcast) to toggle the control's enabled state. 1272945 3 300538 graouts 2017-02-03 09:26:48 -0800 Created attachment 300538 Patch 1272996 4 300538 commit-queue 2017-02-03 11:55:04 -0800 Comment on attachment 300538 Patch Clearing flags on attachment: 300538 Committed r211641: <http://trac.webkit.org/changeset/211641> 1272997 5 commit-queue 2017-02-03 11:55:07 -0800 All reviewed patches have been landed. Closing bug. 300533 2017-02-03 08:27:50 -0800 2017-02-03 08:27:50 -0800 Testcase video-broadcast.html text/html 257 graouts PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDx0aXRsZT5WaWRlbzwvdGl0bGU+CiAg ICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoIj4KPC9o ZWFkPgo8Ym9keT4KICAgIDx2aWRlbyBzcmM9Imh0dHA6Ly9saXZlLnNjaG91Lm1lL2Zpc2gubTN1 OCIgc3R5bGU9IndpZHRoOiA4NDhweCIgd2Via2l0LXBsYXlzaW5saW5lIGF1dG9wbGF5IGNvbnRy b2xzPjwvdmlkZW8+CjwvYm9keT4KPC9odG1sPgo= 300538 2017-02-03 09:26:48 -0800 2017-02-03 11:55:04 -0800 Patch bug-167793-20170203182431.patch text/plain 5425 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU1YTgyMjE0MjI2ZjYw MTNlNWIyZDUxY2UwOTdlODJmZTFhYjg3Mi4uZTUwODg3NmQ3NDFiY2QzNTQyZjE4MDY3M2E2YTJj ZWNlNzkzODk5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAyLTAzICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gU2tpcCBiYWNrIGJ1dHRvbiBpcyB2aXNpYmxlIHdpdGggYSBsaXZlIGJyb2FkY2Fz dCB2aWRlbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY3NzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2Ugc2hvdWxkbid0IGJlIHNob3dpbmcgdGhlIHNraXAgYmFjayBidXR0b24gd2hlbiBhIGxpdmUg YnJvYWRjYXN0IHZpZGVvIGlzIHBsYXlpbmcuCisgICAgICAgIFdlIG5vdyBsaXN0ZW4gdG8gdGhl ICJkdXJhdGlvbmNoYW5nZSIgZXZlbnQgdG8gZGV0ZXJtaW5lIHdoZW4gd2UgaGF2ZSBhbiBpbmlm aW5pdGUtZHVyYXRpb24KKyAgICAgICAgdmlkZW8gYW5kIGRpc2FibGUgdGhlIHNraXAgYnV0dG9u IGluIHRoYXQgY2FzZS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL21lZGlhL21vZGVybi1t ZWRpYS1jb250cm9scy9za2lwLWJhY2stc3VwcG9ydC9za2lwLWJhY2stc3VwcG9ydC1saXZlLWJy b2FkY2FzdC5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9t ZWRpYS9za2lwLWJhY2stc3VwcG9ydC5qczoKKyAgICAgICAgKFNraXBCYWNrU3VwcG9ydC5wcm90 b3R5cGUuZ2V0IG1lZGlhRXZlbnRzKToKKyAgICAgICAgKFNraXBCYWNrU3VwcG9ydC5wcm90b3R5 cGUuc3luY0NvbnRyb2wpOgorICAgICAgICAoU2tpcEJhY2tTdXBwb3J0KToKKwogMjAxNy0wMi0w MiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFz aFRyYWNlcjogW1VTRVJdIGNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCBhdCBjb20uYXBwbGUu V2ViQ29yZTogV2ViQ29yZTo6VVJMOjpob3N0IGNvbnN0ICsgOQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEvc2tpcC1iYWNrLXN1 cHBvcnQuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9t ZWRpYS9za2lwLWJhY2stc3VwcG9ydC5qcwppbmRleCA2YWUwYmJhMjBkMWZmM2MxMWM4MGQ1Yjcz ZTI2OTc1YWVkY2YwY2FjLi5lYTA3YzcwM2FjNGNmYmU1ODBjMDI0YjRhZTg4NWRhZmRlOWFiNmYx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9s cy9tZWRpYS9za2lwLWJhY2stc3VwcG9ydC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS9za2lwLWJhY2stc3VwcG9ydC5qcwpAQCAtMzUs MTAgKzM1LDIwIEBAIGNsYXNzIFNraXBCYWNrU3VwcG9ydCBleHRlbmRzIE1lZGlhQ29udHJvbGxl clN1cHBvcnQKICAgICAgICAgcmV0dXJuIHRoaXMubWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnNr aXBCYWNrQnV0dG9uOwogICAgIH0KIAorICAgIGdldCBtZWRpYUV2ZW50cygpCisgICAgeworICAg ICAgICByZXR1cm4gWyJkdXJhdGlvbmNoYW5nZSJdOworICAgIH0KKwogICAgIGJ1dHRvbldhc1By ZXNzZWQoY29udHJvbCkKICAgICB7CiAgICAgICAgIGNvbnN0IG1lZGlhID0gdGhpcy5tZWRpYUNv bnRyb2xsZXIubWVkaWE7CiAgICAgICAgIG1lZGlhLmN1cnJlbnRUaW1lID0gTWF0aC5tYXgobWVk aWEuY3VycmVudFRpbWUgLSBTa2lwQmFja1NlY29uZHMsIG1lZGlhLnNlZWthYmxlLnN0YXJ0KDAp KTsKICAgICB9CiAKKyAgICBzeW5jQ29udHJvbCgpCisgICAgeworICAgICAgICB0aGlzLmNvbnRy b2wuZW5hYmxlZCA9IHRoaXMubWVkaWFDb250cm9sbGVyLm1lZGlhLmR1cmF0aW9uICE9PSBOdW1i ZXIuUE9TSVRJVkVfSU5GSU5JVFk7CisgICAgfQorCiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTRiMDU1ODYyMGNiMjg2 NWVjODQxZjEyMjhhNjY2ZDAwNDc1MGE3MC4uYzI0MWRkYzM2NDlkOTY3ODg3MTMyODllZGYxZmE3 YjY3MGYyODFiZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTAzICBBbnRvaW5lIFF1 aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBDb250cm9s c10gU2tpcCBiYWNrIGJ1dHRvbiBpcyB2aXNpYmxlIHdpdGggYSBsaXZlIGJyb2FkY2FzdCB2aWRl bworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3Nzkz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEg bmV3IHRlc3QgdG8gY2hlY2sgdGhhdCBhIGxpdmUgYnJvYWRjYXN0IHZpZGVvIGRvZXNuJ3Qgc2hv dyB0aGUgc2tpcCBiYWNrIGJ1dHRvbi4KKworICAgICAgICAqIGh0dHAvdGVzdHMvbWVkaWEvbW9k ZXJuLW1lZGlhLWNvbnRyb2xzL3NraXAtYmFjay1zdXBwb3J0L3NraXAtYmFjay1zdXBwb3J0LWxp dmUtYnJvYWRjYXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9t ZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvc2tpcC1iYWNrLXN1cHBvcnQvc2tpcC1iYWNrLXN1 cHBvcnQtbGl2ZS1icm9hZGNhc3QuaHRtbDogQWRkZWQuCisKIDIwMTctMDItMDIgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgTXVsdGlwbGUgSFRUUCB0ZXN0 cyBmYWlsIHdpdGggQXBhY2hlIDIuNC4yNQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvc2tpcC1iYWNrLXN1cHBvcnQvc2tpcC1i YWNrLXN1cHBvcnQtbGl2ZS1icm9hZGNhc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvc2tpcC1iYWNrLXN1cHBvcnQvc2tp cC1iYWNrLXN1cHBvcnQtbGl2ZS1icm9hZGNhc3QtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY0 ZjA0YWJjMDcyODk5NTMyNWYzODdmZTNkMDRhN2FhMzg4ZWJiMWYKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9za2lw LWJhY2stc3VwcG9ydC9za2lwLWJhY2stc3VwcG9ydC1saXZlLWJyb2FkY2FzdC1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSwxMiBAQAorVGVzdGluZyB0aGUgU2tpcEJhY2tTdXBwb3J0IGJlaGF2aW9y IHdpdGggbGl2ZSBicm9hZGNhc3QuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIG1lZGlhLmR1cmF0aW9uIGlzIE51bWJlci5QT1NJVElWRV9JTkZJTklUWQorUEFTUyBtZWRp YUNvbnRyb2xsZXIuY29udHJvbHMuc2tpcEJhY2tCdXR0b24uZW5hYmxlZCBpcyBmYWxzZQorCitQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMv c2tpcC1iYWNrLXN1cHBvcnQvc2tpcC1iYWNrLXN1cHBvcnQtbGl2ZS1icm9hZGNhc3QuaHRtbCBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3NraXAt YmFjay1zdXBwb3J0L3NraXAtYmFjay1zdXBwb3J0LWxpdmUtYnJvYWRjYXN0Lmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZjZkODlkMjIzOGMwN2U5NmM4NTkxZGRlNWY4NDI2NDY3OTZlODMxNQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRy b2xzL3NraXAtYmFjay1zdXBwb3J0L3NraXAtYmFjay1zdXBwb3J0LWxpdmUtYnJvYWRjYXN0Lmh0 bWwKQEAgLTAsMCArMSwyOCBAQAorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uLy4uLy4uL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iL21lZGlhLXJlc291cmNl cy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvcmVzb3VyY2VzL21lZGlhLWNvbnRyb2xzLWxvYWRlci5q cyI+PC9zY3JpcHQ+Cis8Ym9keT4KKzx2aWRlbyBzcmM9Ii4uLy4uL3Jlc291cmNlcy9obHMvdGVz dC1saXZlLnBocCIgc3R5bGU9IndpZHRoOiA4MDBweDsiIGF1dG9wbGF5PjwvdmlkZW8+Cis8ZGl2 IGlkPSJzaGFkb3ciPjwvZGl2PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCit3 aW5kb3cuanNUZXN0SXNBc3luYyA9IHRydWU7CisKK2Rlc2NyaXB0aW9uKCJUZXN0aW5nIHRoZSA8 Y29kZT5Ta2lwQmFja1N1cHBvcnQ8L2NvZGU+IGJlaGF2aW9yIHdpdGggbGl2ZSBicm9hZGNhc3Qu Iik7CisKK2NvbnN0IHNoYWRvd1Jvb3QgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJkaXYjc2hh ZG93IikuYXR0YWNoU2hhZG93KHsgbW9kZTogIm9wZW4iIH0pOworY29uc3QgbWVkaWEgPSBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCJ2aWRlbyIpOworY29uc3QgbWVkaWFDb250cm9sbGVyID0gY3Jl YXRlQ29udHJvbHMoc2hhZG93Um9vdCwgbWVkaWEsIG51bGwpOworCittZWRpYS5hZGRFdmVudExp c3RlbmVyKCJkdXJhdGlvbmNoYW5nZSIsIGV2ZW50ID0+IHsKKyAgICBzaG91bGRCZSgibWVkaWEu ZHVyYXRpb24iLCAiTnVtYmVyLlBPU0lUSVZFX0lORklOSVRZIik7CisgICAgc2hvdWxkQmVGYWxz ZSgibWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnNraXBCYWNrQnV0dG9uLmVuYWJsZWQiKTsKKwor ICAgIGRlYnVnKCIiKTsKKyAgICBzaGFkb3dSb290Lmhvc3QucmVtb3ZlKCk7CisgICAgbWVkaWEu cmVtb3ZlKCk7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9KTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cis8L2JvZHk+Cg==