167785 2017-02-03 01:47:06 -0800 JSDOMWindowBase.cpp doesn't build if the JIT is disabled 2017-02-06 05:04:17 -0800 1 1 1 Unclassified WebKit WebCore JavaScript Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned calvaris cgarcia jbicha oldest_to_newest 1272842 0 berto 2017-02-03 01:47:06 -0800 r211403 moved GetCallerGlobalObjectFunctor from JSDOMBinding.cpp to JSDOMWindowBase.cpp, but forgot to include bytecode/CodeBlock.h in the latter file. This breaks the build if the JIT is disabled because the headers that would include ClodeBlock.h indirectly are guarded by ENABLE(JIT). Reproduced with WebKitGTK+ 2.15.4: Source/WebCore/bindings/js/JSDOMWindowBase.cpp: In member function 'JSC::StackVisitor::Status WebCore::callerDOMWindow(JSC::ExecState*)::GetCallerGlobalObjectFunctor::operator()(JSC::StackVisitor&) const': Source/WebCore/bindings/js/JSDOMWindowBase.cpp:304:43: error: invalid use of incomplete type 'class JSC::CodeBlock' m_globalObject = codeBlock->globalObject(); 1272843 1 300513 berto 2017-02-03 01:48:34 -0800 Created attachment 300513 Patch 1272848 2 berto 2017-02-03 02:25:33 -0800 Committed r211624: <http://trac.webkit.org/changeset/211624> 1273530 3 cgarcia 2017-02-06 05:04:17 -0800 *** Bug 167873 has been marked as a duplicate of this bug. *** 300513 2017-02-03 01:48:34 -0800 2017-02-03 04:11:50 -0800 Patch 167785.diff text/plain 1425 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NDg1NTQ5OWE4ZC4uNTEzZjQ5YmYzZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wMi0wMyAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29t PgorCisgICAgICAgIEpTRE9NV2luZG93QmFzZS5jcHAgZG9lc24ndCBidWlsZCBpZiB0aGUgSklU IGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjc3ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICByMjExNDAzIG1vdmVkIEdldENhbGxlckdsb2JhbE9iamVjdEZ1bmN0b3IgZnJvbSBKU0RP TUJpbmRpbmcuY3BwCisgICAgICAgIHRvIEpTRE9NV2luZG93QmFzZS5jcHAsIGJ1dCBmb3Jnb3Qg dG8gaW5jbHVkZSBieXRlY29kZS9Db2RlQmxvY2suaAorICAgICAgICBpbiB0aGUgbGF0dGVyIGZp bGUuCisKKyAgICAgICAgVGhpcyBicmVha3MgdGhlIGJ1aWxkIGlmIHRoZSBKSVQgaXMgZGlzYWJs ZWQgYmVjYXVzZSB0aGUgaGVhZGVycworICAgICAgICB0aGF0IHdvdWxkIGluY2x1ZGUgQ2xvZGVC bG9jay5oIGluZGlyZWN0bHkgYXJlIGd1YXJkZWQgYnkKKyAgICAgICAgRU5BQkxFKEpJVCkuCisK KyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3BwOgorCiAyMDE3LTAyLTAy ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBJbi1w cm9jZXNzIG1lbW9yeSBwcmVzc3VyZSBtb25pdG9yIGZvciBXZWJDb250ZW50IHByb2Nlc3NlcyBB S0Egd2Vic2FtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdp bmRvd0Jhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNl LmNwcAppbmRleCAyMDIyOGI5YmZjMi4uNDVkZjVhOGUwMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNlLmNwcApAQCAtNDQsNiArNDQsNyBAQAogI2lu Y2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRl ICJXZWJDb3JlSlNDbGllbnREYXRhLmgiCisjaW5jbHVkZSA8Ynl0ZWNvZGUvQ29kZUJsb2NrLmg+ CiAjaW5jbHVkZSA8aGVhcC9TdHJvbmdJbmxpbmVzLmg+CiAjaW5jbHVkZSA8cnVudGltZS9KU0lu dGVybmFsUHJvbWlzZURlZmVycmVkLmg+CiAjaW5jbHVkZSA8cnVudGltZS9NaWNyb3Rhc2suaD4K