<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>167756</bug_id>
          
          <creation_ts>2017-02-02 14:23:36 -0800</creation_ts>
          <short_desc>Nullptr crash under styleForFirstLetter</short_desc>
          <delta_ts>2017-02-09 08:33:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antti Koivisto">koivisto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1272639</commentid>
    <comment_count>0</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2017-02-02 14:23:36 -0800</bug_when>
    <thetext>Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed ↩:
0   WebCore                       	0x1fb5bd26 WebCore::RenderStyle::clone(WebCore::RenderStyle const&amp;) + 0 (Ref.h:142)
1   WebCore                       	0x1fabdcda WebCore::styleForFirstLetter(WebCore::RenderElement const&amp;, WebCore::RenderObject const&amp;) + 86 (RenderBlock.cpp:3020)
2   WebCore                       	0x1fabe1ac WebCore::RenderBlock::createFirstLetterRenderer(WebCore::RenderElement*, WebCore::RenderText*) + 24 (RenderBlock.cpp:3144)
3   WebCore                       	0x1fabe678 WebCore::RenderBlock::updateFirstLetter(WebCore::RenderBlock::RenderTreeMutationIsAllowed) + 96 (RenderBlock.cpp:3296)
4   WebCore                       	0x1f173ef8 WebCore::RenderBlock::layout() + 30 (RenderBlock.cpp:1056)
5   WebCore                       	0x1fac6fde WebCore::RenderBlockFlow::insertFloatingObject(WebCore::RenderBox&amp;) + 356 (RenderElement.h:129)
6   WebCore                       	0x1f9d97f6 WebCore::LineBreaker::skipLeadingWhitespace(WebCore::BidiResolverWithIsolate&lt;WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun&gt;&amp;, WebCore::LineInfo&amp;, WebCore::FloatingObject*, WebCore::LineWidth&amp;) + 326 (LineBreaker.cpp:69)
7   WebCore                       	0x1f9d9974 WebCore::LineBreaker::nextLineBreak(WebCore::BidiResolverWithIsolate&lt;WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun&gt;&amp;, WebCore::LineInfo&amp;, WebCore::LineLayoutState&amp;, WebCore::RenderTextInfo&amp;, WebCore::FloatingObject*, unsigned int, WTF::Vector&lt;WebCore::WordMeasurement, 64ul, WTF::CrashOnOverflow, 16ul&gt;&amp;) + 174 (LineBreaker.cpp:90)
8   WebCore                       	0x1fad1fda WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&amp;, WebCore::BidiResolverWithIsolate&lt;WebCore::InlineIterator, WebCore::BidiRun, WebCore::BidiIsolatedRun&gt;&amp;, WebCore::InlineIterator const&amp;, WebCore::BidiStatus const&amp;, unsigned int) + 634 (RenderBlockLineLayout.cpp:1371)
9   WebCore                       	0x1fad1092 WebCore::RenderBlockFlow::layoutRunsAndFloats(WebCore::LineLayoutState&amp;, bool) + 680 (RenderBlockLineLayout.cpp:1324)
10  WebCore                       	0x1fad3fd6 WebCore::RenderBlockFlow::layoutLineBoxes(bool, WebCore::LayoutUnit&amp;, WebCore::LayoutUnit&amp;) + 1298 (RenderBlockLineLayout.cpp:1750)
11  WebCore                       	0x1fac5e34 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) + 880 (RenderBlockFlow.cpp:686)
12  WebCore                       	0x1f173f06 WebCore::RenderBlock::layout() + 44 (RenderBlock.cpp:1060)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1272645</commentid>
    <comment_count>1</comment_count>
      <attachid>300450</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2017-02-02 14:38:20 -0800</bug_when>
    <thetext>Created attachment 300450
possible patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1272646</commentid>
    <comment_count>2</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2017-02-02 14:38:46 -0800</bug_when>
    <thetext>rdar://problem/30029354</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1272647</commentid>
    <comment_count>3</comment_count>
      <attachid>300451</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2017-02-02 14:39:44 -0800</bug_when>
    <thetext>Created attachment 300451
possible patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1274864</commentid>
    <comment_count>4</comment_count>
      <attachid>300451</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-09 08:33:46 -0800</bug_when>
    <thetext>Comment on attachment 300451
possible patch

Clearing flags on attachment: 300451

Committed r211957: &lt;http://trac.webkit.org/changeset/211957&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1274865</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-02-09 08:33:51 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>300450</attachid>
            <date>2017-02-02 14:38:20 -0800</date>
            <delta_ts>2017-02-02 14:39:44 -0800</delta_ts>
            <desc>possible patch</desc>
            <filename>first-letter-nullptr.patch</filename>
            <type>application/octet-stream</type>
            <size>1958</size>
            <attacher name="Antti Koivisto">koivisto</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTU5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTAyICBBbnR0aSBL
b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNyYXNoIHVuZGVy
IHN0eWxlRm9yRmlyc3RMZXR0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2Nzc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIERvbid0IGtub3cgaG93IHdlIGdldCBoZXJlLiBQYXBlciBvdmVyIHRoZSBj
cmFzaC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChX
ZWJDb3JlOjpzdHlsZUZvckZpcnN0TGV0dGVyKToKKworICAgICAgICAgICAgVXNlIHBhcmVudCBm
aXJzdCBsaW5lIHN0eWxlIGlmIHdlIGNvbXB1dGUgbnVsbCBzdHlsZSBmb3IgdGhlIGZpcnN0IGxl
dHRlciByZW5kZXJlci4KKwogMjAxNy0wMi0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A
YXBwbGUuY29tPgogCiAgICAgICAgIFN1cHBvcnQgUGVyZm9ybWFuY2UgQVBJIChwZXJmb3JtYW5j
ZS5ub3coKSwgVXNlclRpbWluZykgaW4gV29ya2VycwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVu
ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k
ZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAyMTE1NjMpCisrKyBTb3VyY2UvV2ViQ29y
ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDE2LDcgKzMw
MTYsMTAgQEAgUmVuZGVyQmxvY2sqIFJlbmRlckJsb2NrOjpmaXJzdExpbmVCbG9jawogCiBzdGF0
aWMgUmVuZGVyU3R5bGUgc3R5bGVGb3JGaXJzdExldHRlcihjb25zdCBSZW5kZXJFbGVtZW50JiBm
aXJzdExldHRlckJsb2NrLCBjb25zdCBSZW5kZXJPYmplY3QmIGZpcnN0TGV0dGVyQ29udGFpbmVy
KQogewotICAgIGF1dG8gZmlyc3RMZXR0ZXJTdHlsZSA9IFJlbmRlclN0eWxlOjpjbG9uZSgqZmly
c3RMZXR0ZXJCbG9jay5nZXRDYWNoZWRQc2V1ZG9TdHlsZShGSVJTVF9MRVRURVIsICZmaXJzdExl
dHRlckNvbnRhaW5lci5maXJzdExpbmVTdHlsZSgpKSk7CisgICAgYXV0byogY29udGFpbmVyRmly
c3RMZXR0ZXJTdHlsZSA9IGZpcnN0TGV0dGVyQmxvY2suZ2V0Q2FjaGVkUHNldWRvU3R5bGUoRklS
U1RfTEVUVEVSLCAmZmlyc3RMZXR0ZXJDb250YWluZXIuZmlyc3RMaW5lU3R5bGUoKSk7CisgICAg
Ly8gRklYTUU6IFRoZXJlIGFwcGVhcnMgdG8gYmUgc29tZSBwYXRoIHdoZXJlIHdlIGhhdmUgYSBm
aXJzdCBsZXR0ZXIgcmVuZGVyZXIgd2l0aG91dCBmaXJzdCBsZXR0ZXIgc3R5bGUuCisgICAgQVNT
RVJUKGNvbnRhaW5lckZpcnN0TGV0dGVyU3R5bGUpOworICAgIGF1dG8gZmlyc3RMZXR0ZXJTdHls
ZSA9IFJlbmRlclN0eWxlOjpjbG9uZShjb250YWluZXJGaXJzdExldHRlclN0eWxlID8gKmNvbnRh
aW5lckZpcnN0TGV0dGVyU3R5bGUgOiBmaXJzdExldHRlckNvbnRhaW5lci5maXJzdExpbmVTdHls
ZSgpKTsKIAogICAgIC8vIElmIHdlIGhhdmUgYW4gaW5pdGlhbCBsZXR0ZXIgZHJvcCB0aGF0IGlz
ID49IDEsIHRoZW4gd2UgbmVlZCB0byBmb3JjZSBmbG9hdGluZyB0byBiZSBvbi4KICAgICBpZiAo
Zmlyc3RMZXR0ZXJTdHlsZS5pbml0aWFsTGV0dGVyRHJvcCgpID49IDEgJiYgIWZpcnN0TGV0dGVy
U3R5bGUuaXNGbG9hdGluZygpKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300451</attachid>
            <date>2017-02-02 14:39:44 -0800</date>
            <delta_ts>2017-02-09 08:33:46 -0800</delta_ts>
            <desc>possible patch</desc>
            <filename>first-letter-nullptr-2.patch</filename>
            <type>text/plain</type>
            <size>1991</size>
            <attacher name="Antti Koivisto">koivisto</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTU5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAyLTAyICBBbnR0aSBL
b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNyYXNoIHVuZGVy
IHN0eWxlRm9yRmlyc3RMZXR0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2Nzc1NgorICAgICAgICByZGFyOi8vcHJvYmxlbS8zMDAyOTM1NAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGtub3cg
aG93IHdlIGdldCBoZXJlLiBQYXBlciBvdmVyIHRoZSBjcmFzaC4KKworICAgICAgICAqIHJlbmRl
cmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzdHlsZUZvckZpcnN0TGV0
dGVyKToKKworICAgICAgICAgICAgVXNlIHBhcmVudCBmaXJzdCBsaW5lIHN0eWxlIGlmIHdlIGNv
bXB1dGUgbnVsbCBzdHlsZSBmb3IgdGhlIGZpcnN0IGxldHRlciByZW5kZXJlci4KKwogMjAxNy0w
Mi0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFN1
cHBvcnQgUGVyZm9ybWFuY2UgQVBJIChwZXJmb3JtYW5jZS5ub3coKSwgVXNlclRpbWluZykgaW4g
V29ya2VycwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShy
ZXZpc2lvbiAyMTE1NjMpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDE2LDcgKzMwMTYsMTAgQEAgUmVuZGVyQmxvY2sqIFJl
bmRlckJsb2NrOjpmaXJzdExpbmVCbG9jawogCiBzdGF0aWMgUmVuZGVyU3R5bGUgc3R5bGVGb3JG
aXJzdExldHRlcihjb25zdCBSZW5kZXJFbGVtZW50JiBmaXJzdExldHRlckJsb2NrLCBjb25zdCBS
ZW5kZXJPYmplY3QmIGZpcnN0TGV0dGVyQ29udGFpbmVyKQogewotICAgIGF1dG8gZmlyc3RMZXR0
ZXJTdHlsZSA9IFJlbmRlclN0eWxlOjpjbG9uZSgqZmlyc3RMZXR0ZXJCbG9jay5nZXRDYWNoZWRQ
c2V1ZG9TdHlsZShGSVJTVF9MRVRURVIsICZmaXJzdExldHRlckNvbnRhaW5lci5maXJzdExpbmVT
dHlsZSgpKSk7CisgICAgYXV0byogY29udGFpbmVyRmlyc3RMZXR0ZXJTdHlsZSA9IGZpcnN0TGV0
dGVyQmxvY2suZ2V0Q2FjaGVkUHNldWRvU3R5bGUoRklSU1RfTEVUVEVSLCAmZmlyc3RMZXR0ZXJD
b250YWluZXIuZmlyc3RMaW5lU3R5bGUoKSk7CisgICAgLy8gRklYTUU6IFRoZXJlIGFwcGVhcnMg
dG8gYmUgc29tZSBwYXRoIHdoZXJlIHdlIGhhdmUgYSBmaXJzdCBsZXR0ZXIgcmVuZGVyZXIgd2l0
aG91dCBmaXJzdCBsZXR0ZXIgc3R5bGUuCisgICAgQVNTRVJUKGNvbnRhaW5lckZpcnN0TGV0dGVy
U3R5bGUpOworICAgIGF1dG8gZmlyc3RMZXR0ZXJTdHlsZSA9IFJlbmRlclN0eWxlOjpjbG9uZShj
b250YWluZXJGaXJzdExldHRlclN0eWxlID8gKmNvbnRhaW5lckZpcnN0TGV0dGVyU3R5bGUgOiBm
aXJzdExldHRlckNvbnRhaW5lci5maXJzdExpbmVTdHlsZSgpKTsKIAogICAgIC8vIElmIHdlIGhh
dmUgYW4gaW5pdGlhbCBsZXR0ZXIgZHJvcCB0aGF0IGlzID49IDEsIHRoZW4gd2UgbmVlZCB0byBm
b3JjZSBmbG9hdGluZyB0byBiZSBvbi4KICAgICBpZiAoZmlyc3RMZXR0ZXJTdHlsZS5pbml0aWFs
TGV0dGVyRHJvcCgpID49IDEgJiYgIWZpcnN0TGV0dGVyU3R5bGUuaXNGbG9hdGluZygpKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>