167754 2017-02-02 13:53:36 -0800 Don't attempt wide gamut on older OSes 2017-02-02 15:26:52 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner megan_gardner bdakin dino megan_gardner simon.fraser thorton oldest_to_newest 1272626 0 megan_gardner 2017-02-02 13:53:36 -0800 Don't attempt wide gammut on older OSes 1272636 1 300446 megan_gardner 2017-02-02 14:16:21 -0800 Created attachment 300446 Patch 1272637 2 megan_gardner 2017-02-02 14:18:13 -0800 Not sure if we needed the iOS check, but thought I should be more not less thorough. 1272655 3 300446 thorton 2017-02-02 14:44:52 -0800 Comment on attachment 300446 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300446&action=review > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:65 > +#if (__MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) No need for the parens. > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2500 > +#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 100000) This matches the extendedSRGBColorSpaceRef() thing, right? Also, no parens. 1272673 4 megan_gardner 2017-02-02 15:13:44 -0800 Yep, matches. I'll take out parens and commit. 1272680 5 megan_gardner 2017-02-02 15:26:52 -0800 https://trac.webkit.org/changeset/211601 300446 2017-02-02 14:16:21 -0800 2017-02-02 14:44:52 -0800 Patch bug-167754-20170202141407.patch text/plain 3023 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTU5MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTAyICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3QgYXR0ZW1w dCB3aWRlIGdhbW11dCBvbiBvbGRlciBPU2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc3NTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5OTMx NTg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl IG5lZWQgdG8gZ3VhcmQgb3VyIGV4dGVuZGVkIGNvbG9yIGNoZWNrcyB0aGUgc2FtZSB3YXkgdGhy b3VnaG91dCB0aGUgY29kZSwgb3Igd2Ugd2lsbCBhdHRlbXB0IHRvIHNldCB1cAorICAgICAgICBz dXBwb3J0IGZvciB3aWRlIGdhbXV0IHBhcnRpYWxseSwgd2hpY2ggY2F1c2VzIGNyYXNoZXMgd2hl biB1c2luZyBzaGFyYWJsZSBiaXRtYXAuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVT dXBwb3J0L21hYy9XZWJEcmFnQ2xpZW50TWFjLm1tOgorICAgICAgICAoV2ViS2l0Ojpjb252ZXJ0 SW1hZ2VUb0JpdG1hcCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9ybWF0aW9u KToKKwogMjAxNy0wMi0wMiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxMTU3MSBhbmQgcjIxMTU4Mi4K SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkRy YWdDbGllbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0NsaWVudE1hYy5tbQkocmV2aXNpb24gMjExNDU5KQor KysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRHJhZ0Ns aWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNjIsOCArNjIsMTAgQEAgbmFtZXNwYWNlIFdl YktpdCB7CiBzdGF0aWMgUGFzc1JlZlB0cjxTaGFyZWFibGVCaXRtYXA+IGNvbnZlcnRJbWFnZVRv Qml0bWFwKE5TSW1hZ2UgKmltYWdlLCBjb25zdCBJbnRTaXplJiBzaXplLCBGcmFtZSYgZnJhbWUp CiB7CiAgICAgU2hhcmVhYmxlQml0bWFwOjpGbGFncyBmbGFncyA9IFNoYXJlYWJsZUJpdG1hcDo6 U3VwcG9ydHNBbHBoYTsKKyNpZiAoX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDEyMDApCiAgICAgaWYgKHNjcmVlblN1cHBvcnRzRXh0ZW5kZWRDb2xvcihmcmFtZS5tYWluRnJh bWUoKS52aWV3KCkpKQogICAgICAgICBmbGFncyB8PSBTaGFyZWFibGVCaXRtYXA6OlN1cHBvcnRz RXh0ZW5kZWRDb2xvcjsKKyNlbmRpZgogICAgIGF1dG8gYml0bWFwID0gU2hhcmVhYmxlQml0bWFw OjpjcmVhdGVTaGFyZWFibGUoc2l6ZSwgZmxhZ3MpOwogICAgIGlmICghYml0bWFwKQogICAgICAg ICByZXR1cm4gbnVsbHB0cjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0JKHJldmlzaW9uIDIxMTQ1OSkKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkod29ya2luZyBj b3B5KQpAQCAtMjQ5Nyw3ICsyNDk3LDkgQEAgdm9pZCBXZWJQYWdlOjpnZXRQb3NpdGlvbkluZm9y bWF0aW9uKGNvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRmxvYXRTaXpl IGJpdG1hcFNpemUgPSBzY2FsZWRTaXplLndpZHRoKCkgPCBpbWFnZS0+c2l6ZSgpLndpZHRoKCkg PyBzY2FsZWRTaXplIDogaW1hZ2UtPnNpemUoKTsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIC8vIEZJWE1FOiBPbmx5IHNlbGVjdCBFeHRlbmRlZENvbG9yIG9uIGltYWdlcyBr bm93biB0byBuZWVkIHdpZGUgZ2FtdXQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFNoYXJlYWJsZUJpdG1hcDo6RmxhZ3MgZmxhZ3MgPSBTaGFyZWFibGVCaXRtYXA6OlN1cHBv cnRzQWxwaGE7CisjaWYgKF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMDAw MCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsYWdzIHw9IHNjcmVlblN1 cHBvcnRzRXh0ZW5kZWRDb2xvcigpID8gU2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0V4dGVuZGVk Q29sb3IgOiAwOworI2VuZGlmCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp ZiAoUmVmUHRyPFNoYXJlYWJsZUJpdG1hcD4gc2hhcmVkQml0bWFwID0gU2hhcmVhYmxlQml0bWFw OjpjcmVhdGVTaGFyZWFibGUoSW50U2l6ZShiaXRtYXBTaXplKSwgZmxhZ3MpKSB7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYXV0byBncmFwaGljc0NvbnRleHQgPSBz aGFyZWRCaXRtYXAtPmNyZWF0ZUdyYXBoaWNzQ29udGV4dCgpOwogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC0+ZHJhd0ltYWdlKCppbWFnZSwg RmxvYXRSZWN0KDAsIDAsIGJpdG1hcFNpemUud2lkdGgoKSwgYml0bWFwU2l6ZS5oZWlnaHQoKSkp Owo=