167733 2017-02-02 08:42:12 -0800 Column progression wrong after enabling pagination on RTL document 2017-02-02 09:07:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield simon.fraser zalan oldest_to_newest 1272471 0 koivisto 2017-02-02 08:42:12 -0800 Column progression depends on document direction but is not updated when direction changes. 1272473 1 300413 koivisto 2017-02-02 08:46:50 -0800 Created attachment 300413 patch 1272474 2 koivisto 2017-02-02 08:47:34 -0800 <rdar://problem/29012252> 1272479 3 koivisto 2017-02-02 09:07:53 -0800 Committed r211564: <http://trac.webkit.org/changeset/211564> 300413 2017-02-02 08:46:50 -0800 2017-02-02 09:02:10 -0800 patch rtl-pagination-direction.patch text/plain 5781 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTU2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAyLTAyICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBDb2x1bW4gcHJvZ3Jlc3Npb24g d3JvbmcgYWZ0ZXIgZW5hYmxpbmcgcGFnaW5hdGlvbiBvbiBSVEwgZG9jdW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzczMworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbHVtbiBwcm9ncmVzc2lv biBkZXBlbmRzIG9uIGRvY3VtZW50IGRpcmVjdGlvbiBidXQgd2FzIG5vdCB1cGRhdGVkIHdoZW4g ZGlyZWN0aW9uIGNoYW5nZWQuCisKKyAgICAgICAgVGVzdDogZmFzdC9tdWx0aWNvbC9wYWdpbmF0 aW9uL3BhZ2luYXRpb24tZHluYW1pYy1ydGwuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnN0eWxlRGlkQ2hhbmdl KToKKworICAgICAgICAgICAgVXBkYXRlIGNvbHVtbiBzdHlsZXMgaWYgZG9jdW1lbnQgZGlyZWN0 aW9uIGNoYW5nZXMuCisKIDIwMTctMDItMDIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIHVudXNlZCBFdmVudEhhbmRsZXIgbWVtYmVycwpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAJKHJldmlzaW9uIDIxMTM2 MSkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zOTIsMTMgKzM5MiwxMiBAQCB2b2lkIFJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2Uo U3R5bGVEaWZmCiAgICAgICAgIC8vIFByb3BhZ2F0ZSB0aGUgbmV3IHdyaXRpbmcgbW9kZSBhbmQg ZGlyZWN0aW9uIHVwIHRvIHRoZSBSZW5kZXJWaWV3LgogICAgICAgICBhdXRvKiBkb2N1bWVudEVs ZW1lbnRSZW5kZXJlciA9IGRvY3VtZW50KCkuZG9jdW1lbnRFbGVtZW50KCktPnJlbmRlcmVyKCk7 CiAgICAgICAgIGF1dG8mIHZpZXdTdHlsZSA9IHZpZXcoKS5tdXRhYmxlU3R5bGUoKTsKLSAgICAg ICAgYm9vbCB2aWV3Q2hhbmdlZFdyaXRpbmdNb2RlID0gZmFsc2U7CiAgICAgICAgIGJvb2wgcm9v dFN0eWxlQ2hhbmdlZCA9IGZhbHNlOwotICAgICAgICBib29sIHZpZXdTdHlsZUNoYW5nZWQgPSBm YWxzZTsKKyAgICAgICAgYm9vbCB2aWV3RGlyZWN0aW9uT3JXcml0aW5nTW9kZUNoYW5nZWQgPSBm YWxzZTsKICAgICAgICAgYXV0byogcm9vdFJlbmRlcmVyID0gaXNCb2R5UmVuZGVyZXIgPyBkb2N1 bWVudEVsZW1lbnRSZW5kZXJlciA6IG51bGxwdHI7CiAgICAgICAgIGlmICh2aWV3U3R5bGUuZGly ZWN0aW9uKCkgIT0gbmV3U3R5bGUuZGlyZWN0aW9uKCkgJiYgKGlzRG9jRWxlbWVudFJlbmRlcmVy IHx8ICFkb2N1bWVudEVsZW1lbnRSZW5kZXJlci0+c3R5bGUoKS5oYXNFeHBsaWNpdGx5U2V0RGly ZWN0aW9uKCkpKSB7CiAgICAgICAgICAgICB2aWV3U3R5bGUuc2V0RGlyZWN0aW9uKG5ld1N0eWxl LmRpcmVjdGlvbigpKTsKLSAgICAgICAgICAgIHZpZXdTdHlsZUNoYW5nZWQgPSB0cnVlOworICAg ICAgICAgICAgdmlld0RpcmVjdGlvbk9yV3JpdGluZ01vZGVDaGFuZ2VkID0gdHJ1ZTsKICAgICAg ICAgICAgIGlmIChpc0JvZHlSZW5kZXJlcikgewogICAgICAgICAgICAgICAgIHJvb3RSZW5kZXJl ci0+bXV0YWJsZVN0eWxlKCkuc2V0RGlyZWN0aW9uKG5ld1N0eWxlLmRpcmVjdGlvbigpKTsKICAg ICAgICAgICAgICAgICByb290U3R5bGVDaGFuZ2VkID0gdHJ1ZTsKQEAgLTQxMCw4ICs0MDksNyBA QCB2b2lkIFJlbmRlckJveDo6c3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmCiAKICAgICAgICAgaWYg KHZpZXdTdHlsZS53cml0aW5nTW9kZSgpICE9IG5ld1N0eWxlLndyaXRpbmdNb2RlKCkgJiYgKGlz RG9jRWxlbWVudFJlbmRlcmVyIHx8ICFkb2N1bWVudEVsZW1lbnRSZW5kZXJlci0+c3R5bGUoKS5o YXNFeHBsaWNpdGx5U2V0V3JpdGluZ01vZGUoKSkpIHsKICAgICAgICAgICAgIHZpZXdTdHlsZS5z ZXRXcml0aW5nTW9kZShuZXdTdHlsZS53cml0aW5nTW9kZSgpKTsKLSAgICAgICAgICAgIHZpZXdD aGFuZ2VkV3JpdGluZ01vZGUgPSB0cnVlOwotICAgICAgICAgICAgdmlld1N0eWxlQ2hhbmdlZCA9 IHRydWU7CisgICAgICAgICAgICB2aWV3RGlyZWN0aW9uT3JXcml0aW5nTW9kZUNoYW5nZWQgPSB0 cnVlOwogICAgICAgICAgICAgdmlldygpLnNldEhvcml6b250YWxXcml0aW5nTW9kZShuZXdTdHls ZS5pc0hvcml6b250YWxXcml0aW5nTW9kZSgpKTsKICAgICAgICAgICAgIHZpZXcoKS5tYXJrQWxs RGVzY2VuZGFudHNXaXRoRmxvYXRzRm9yTGF5b3V0KCk7CiAgICAgICAgICAgICBpZiAoaXNCb2R5 UmVuZGVyZXIpIHsKQEAgLTQyNSwxMyArNDIzLDEzIEBAIHZvaWQgUmVuZGVyQm94OjpzdHlsZURp ZENoYW5nZShTdHlsZURpZmYKICAgICAgICAgdmlldygpLmZyYW1lVmlldygpLnJlY2FsY3VsYXRl U2Nyb2xsYmFyT3ZlcmxheVN0eWxlKCk7CiAgICAgICAgIAogICAgICAgICBjb25zdCBQYWdpbmF0 aW9uJiBwYWdpbmF0aW9uID0gdmlldygpLmZyYW1lVmlldygpLnBhZ2luYXRpb24oKTsKLSAgICAg ICAgaWYgKHZpZXdDaGFuZ2VkV3JpdGluZ01vZGUgJiYgcGFnaW5hdGlvbi5tb2RlICE9IFBhZ2lu YXRpb246OlVucGFnaW5hdGVkKSB7CisgICAgICAgIGlmICh2aWV3RGlyZWN0aW9uT3JXcml0aW5n TW9kZUNoYW5nZWQgJiYgcGFnaW5hdGlvbi5tb2RlICE9IFBhZ2luYXRpb246OlVucGFnaW5hdGVk KSB7CiAgICAgICAgICAgICB2aWV3U3R5bGUuc2V0Q29sdW1uU3R5bGVzRnJvbVBhZ2luYXRpb25N b2RlKHBhZ2luYXRpb24ubW9kZSk7CiAgICAgICAgICAgICBpZiAodmlldygpLm11bHRpQ29sdW1u Rmxvd1RocmVhZCgpKQogICAgICAgICAgICAgICAgIHZpZXcoKS51cGRhdGVDb2x1bW5Qcm9ncmVz c2lvbkZyb21TdHlsZSh2aWV3U3R5bGUpOwogICAgICAgICB9CiAgICAgICAgIAotICAgICAgICBp ZiAodmlld1N0eWxlQ2hhbmdlZCAmJiB2aWV3KCkubXVsdGlDb2x1bW5GbG93VGhyZWFkKCkpCisg ICAgICAgIGlmICh2aWV3RGlyZWN0aW9uT3JXcml0aW5nTW9kZUNoYW5nZWQgJiYgdmlldygpLm11 bHRpQ29sdW1uRmxvd1RocmVhZCgpKQogICAgICAgICAgICAgdmlldygpLnVwZGF0ZVN0eWxlc0Zv ckNvbHVtbkNoaWxkcmVuKCk7CiAgICAgICAgIAogICAgICAgICBpZiAocm9vdFN0eWxlQ2hhbmdl ZCAmJiBpczxSZW5kZXJCbG9ja0Zsb3c+KHJvb3RSZW5kZXJlcikgJiYgZG93bmNhc3Q8UmVuZGVy QmxvY2tGbG93Pigqcm9vdFJlbmRlcmVyKS5tdWx0aUNvbHVtbkZsb3dUaHJlYWQoKSkKSW5kZXg6 IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHJldmlzaW9uIDIxMTM2MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTAyLTAyICBBbnR0aSBLb2l2aXN0byAgPGFudHRp QGFwcGxlLmNvbT4KKworICAgICAgICBDb2x1bW4gcHJvZ3Jlc3Npb24gd3JvbmcgYWZ0ZXIgZW5h YmxpbmcgcGFnaW5hdGlvbiBvbiBSVEwgZG9jdW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzczMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9tdWx0aWNvbC9wYWdpbmF0aW9uL3BhZ2lu YXRpb24tZHluYW1pYy1ydGwtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9t dWx0aWNvbC9wYWdpbmF0aW9uL3BhZ2luYXRpb24tZHluYW1pYy1ydGwuaHRtbDogQWRkZWQuCisK IDIwMTctMDEtMzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQuIFNraXAgbW9yZSB0ZXN0cyB0aW1pbmcgb3V0IGluIEdUSysg Ym90cy4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvcGFnaW5hdGlvbi9wYWdpbmF0 aW9uLWR5bmFtaWMtcnRsLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9tdWx0aWNvbC9wYWdpbmF0aW9uL3BhZ2luYXRpb24tZHluYW1pYy1ydGwtZXhwZWN0ZWQu aHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL3BhZ2luYXRp b24vcGFnaW5hdGlvbi1keW5hbWljLXJ0bC1leHBlY3RlZC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsMTUgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5pbnRl cm5hbHMpCisgICAgaW50ZXJuYWxzLnNldFBhZ2luYXRpb24oIlJpZ2h0VG9MZWZ0UGFnaW5hdGVk IiwgMCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IHN0eWxlPSJkaXJlY3Rpb246cnRsIj4K KzxkaXYgc3R5bGU9ImJvcmRlcjogc29saWQ7IGhlaWdodDogOTAwcHg7IGZvbnQ6IDUwcHggYWhl bTsgLXdlYmtpdC1mb250LXNtb290aGluZzogbm9uZTsiPgorPGJyPjxicj48YnI+PGJyPjxicj48 YnI+PGJyPjxicj48YnI+PGJyPgorTG9yZW08YnI+Cis8c3BhbiBzdHlsZT0iY29sb3I6IHJlZDsi Pmlwc3VtPC9icj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9tdWx0aWNvbC9wYWdpbmF0aW9uL3BhZ2luYXRpb24tZHluYW1pYy1ydGwuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL3BhZ2luYXRpb24vcGFnaW5hdGlv bi1keW5hbWljLXJ0bC5odG1sCShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2Zhc3QvbXVs dGljb2wvcGFnaW5hdGlvbi9wYWdpbmF0aW9uLWR5bmFtaWMtcnRsLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSwxNyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiB0 ZXN0KCkgeworaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgaW50ZXJuYWxzLnNldFBhZ2luYXRp b24oIlJpZ2h0VG9MZWZ0UGFnaW5hdGVkIiwgMCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5IHN0eWxlPSJkaXJlY3Rpb246cnRsIiBvbmxvYWQ9InRlc3QoKSI+Cis8ZGl2IHN0eWxlPSJi b3JkZXI6IHNvbGlkOyBoZWlnaHQ6IDkwMHB4OyBmb250OiA1MHB4IGFoZW07IC13ZWJraXQtZm9u dC1zbW9vdGhpbmc6IG5vbmU7Ij4KKzxicj48YnI+PGJyPjxicj48YnI+PGJyPjxicj48YnI+PGJy Pjxicj4KK0xvcmVtPGJyPgorPHNwYW4gc3R5bGU9ImNvbG9yOiByZWQ7Ij5pcHN1bTwvYnI+Cis8 L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K