167704 2017-02-01 13:09:20 -0800 IPC::Connection receive ports should be guarded 2017-02-03 09:50:07 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED P2 Normal --- 167765 1 andersca andersca commit-queue oldest_to_newest 1272242 0 andersca 2017-02-01 13:09:20 -0800 IPC::Connection receive ports should be guarded 1272245 1 300346 andersca 2017-02-01 13:13:51 -0800 Created attachment 300346 Patch 1272295 2 andersca 2017-02-01 14:53:28 -0800 Committed r211535: <http://trac.webkit.org/changeset/211535> 1272689 3 commit-queue 2017-02-02 15:38:42 -0800 Re-opened since this is blocked by bug 167765 1272957 4 ap 2017-02-03 09:50:07 -0800 The rollout out change was the cause of bug 167740. 300346 2017-02-01 13:13:51 -0800 2017-02-01 13:16:47 -0800 Patch bug-167704-20170201131139.patch text/plain 6281 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWNhNWZhMWVkYjZkMTZi MGMwNThiY2NjYjFlYTcwY2Y3MThkODNmNC4uM2NlMTYxMmEzOWMyM2EyYWYwNzdhMGRiMDU5NzJi NWVmYjM5MWIwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTAyLTAxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgSVBDOjpDb25uZWN0 aW9uIHJlY2VpdmUgcG9ydHMgc2hvdWxkIGJlIGd1YXJkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzcwNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEd1YXJkaW5nIHJlY2VpdmUgcmlnaHRzIHdpbGwg bWFrZSBzdXJlIHRoYXQgdGhleSB3b24ndCBiZSBjbG9zZWQgYWNjaWRlbnRhbGx5LiBUaGV5IGFy ZSBjcmVhdGVkCisgICAgICAgIHdpdGggYSBjb250ZXh0IHBvaW50ZXIgYW5kIGNhbiBvbmx5IGJl IHVuZ3VhcmRlZCBvciBkZXN0cnVjdGVkIHdpdGggdGhlIHNhbWUgY29udGV4dCBwb2ludGVyLgor CisgICAgICAgICogUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tOgorICAgICAgICAo SVBDOjpDb25uZWN0aW9uOjpwbGF0Zm9ybUludmFsaWRhdGUpOgorICAgICAgICBVc2UgbWFjaF9w b3J0X2Rlc3RydWN0IGFuZCBwYXNzIHRoZSBjb25uZWN0aW9uIHBvaW50ZXIgYXMgdGhlIGNvbnRl eHQuCisKKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6cGxhdGZvcm1Jbml0aWFsaXplKToKKyAg ICAgICAgR3VhcmQgdGhlIHNlcnZlciBwb3J0IHdpdGggdGhlIGNvbm5lY3Rpb24gcG9pbnRlciBh cyB0aGUgY29udGV4dC4KKworICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpvcGVuKToKKyAgICAg ICAgVXNlIG1hY2hfcG9ydF9jb25zdHJ1Y3QgdG8gY3JlYXRlIHRoZSBwb3J0IHdoaWNoIGxldHMg dXMgYXZvaWQgYSBjYWxsIHRvIG1hY2hfcG9ydF9zZXRfYXR0cmlidXRlcyBhbmQgc2V0TWFjaFBv cnRRdWV1ZUxlbmd0aC4KKyAgICAgICAgTWFrZSB0aGUgcG9ydCBndWFyZGVkIGFuZCB1c2UgdGhl IGNvbm5lY3Rpb24gcG9pbnRlciBhcyB0aGUgY29udGV4dC4KKyAgICAgICAgCisgICAgICAgIChJ UEM6OmNyZWF0ZVJlY2VpdmVTb3VyY2UpOgorICAgICAgICBHZXQgcmlkIG9mIHRoaXMgYW5kIGp1 c3QgZHVwbGljYXRlIHRoZSBmaXZlIGxpbmVzIG9mIGNvZGUgaW4gdHdvIHBsYWNlcy4gRm9yIHRo ZSByZWNlaXZlIHBvcnQgd2Ugd2FudCB0byB1c2UgbWFjaF9wb3J0X2Rlc3RydWN0CisgICAgICAg IGluIG91ciBjYW5jZWwgaGFuZGxlci4KKwogMjAxNy0wMS0zMSAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtb3JlIENSQVNIIGNhbGxzIHRvIHRy eSB0byBmaWd1cmUgb3V0IHdoeSB3ZSdyZSBmYWlsaW5nIHRvIHNlbmQgbWFjaCBwb3J0cyBvdmVy IHRoZSB3aXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nv bm5lY3Rpb25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rp b25NYWMubW0KaW5kZXggNzJiM2FhODNhMGUwZTQzZTlkOWFjMDA5MjMyODA5MzZmNGMyMjlmYi4u OWUxNDM1NWM3MTEzZWQ0NGE1MTM1ZDIxY2ZhZGUyNWM1NTg2ZmJiOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0aW9uTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlvbk1hYy5tbQpAQCAtMTIwLDcgKzEy MCw3IEBAIHZvaWQgQ29ubmVjdGlvbjo6cGxhdGZvcm1JbnZhbGlkYXRlKCkKICAgICAgICAgfQog CiAgICAgICAgIGlmIChtX3JlY2VpdmVQb3J0KSB7Ci0gICAgICAgICAgICBtYWNoX3BvcnRfbW9k X3JlZnMobWFjaF90YXNrX3NlbGYoKSwgbV9yZWNlaXZlUG9ydCwgTUFDSF9QT1JUX1JJR0hUX1JF Q0VJVkUsIC0xKTsKKyAgICAgICAgICAgIG1hY2hfcG9ydF9kZXN0cnVjdChtYWNoX3Rhc2tfc2Vs ZigpLCBtX3JlY2VpdmVQb3J0LCAwLCByZWludGVycHJldF9jYXN0PG1hY2hfcG9ydF9jb250ZXh0 X3Q+KHRoaXMpKTsKICAgICAgICAgICAgIG1fcmVjZWl2ZVBvcnQgPSBNQUNIX1BPUlRfTlVMTDsK ICAgICAgICAgfQogCkBAIC0xNzAsNiArMTcwLDggQEAgdm9pZCBDb25uZWN0aW9uOjpwbGF0Zm9y bUluaXRpYWxpemUoSWRlbnRpZmllciBpZGVudGlmaWVyKQogICAgIGlmIChtX2lzU2VydmVyKSB7 CiAgICAgICAgIG1fcmVjZWl2ZVBvcnQgPSBpZGVudGlmaWVyLnBvcnQ7CiAgICAgICAgIG1fc2Vu ZFBvcnQgPSBNQUNIX1BPUlRfTlVMTDsKKworICAgICAgICBtYWNoX3BvcnRfZ3VhcmQobWFjaF90 YXNrX3NlbGYoKSwgbV9yZWNlaXZlUG9ydCwgcmVpbnRlcnByZXRfY2FzdDxtYWNoX3BvcnRfY29u dGV4dF90Pih0aGlzKSwgdHJ1ZSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgbV9yZWNlaXZlUG9y dCA9IE1BQ0hfUE9SVF9OVUxMOwogICAgICAgICBtX3NlbmRQb3J0ID0gaWRlbnRpZmllci5wb3J0 OwpAQCAtMTgxLDE5ICsxODMsNiBAQCB2b2lkIENvbm5lY3Rpb246OnBsYXRmb3JtSW5pdGlhbGl6 ZShJZGVudGlmaWVyIGlkZW50aWZpZXIpCiAgICAgbV94cGNDb25uZWN0aW9uID0gaWRlbnRpZmll ci54cGNDb25uZWN0aW9uOwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdGlvbj4KLXN0YXRp YyBkaXNwYXRjaF9zb3VyY2VfdCBjcmVhdGVSZWNlaXZlU291cmNlKG1hY2hfcG9ydF90IHJlY2Vp dmVQb3J0LCBXb3JrUXVldWUmIHdvcmtRdWV1ZSwgRnVuY3Rpb24mJiBmdW5jdGlvbikKLXsKLSAg ICBkaXNwYXRjaF9zb3VyY2VfdCBzb3VyY2UgPSBkaXNwYXRjaF9zb3VyY2VfY3JlYXRlKERJU1BB VENIX1NPVVJDRV9UWVBFX01BQ0hfUkVDViwgcmVjZWl2ZVBvcnQsIDAsIHdvcmtRdWV1ZS5kaXNw YXRjaFF1ZXVlKCkpOwotICAgIGRpc3BhdGNoX3NvdXJjZV9zZXRfZXZlbnRfaGFuZGxlcihzb3Vy Y2UsIGZ1bmN0aW9uKTsKLQotICAgIGRpc3BhdGNoX3NvdXJjZV9zZXRfY2FuY2VsX2hhbmRsZXIo c291cmNlLCBeewotICAgICAgICBtYWNoX3BvcnRfbW9kX3JlZnMobWFjaF90YXNrX3NlbGYoKSwg cmVjZWl2ZVBvcnQsIE1BQ0hfUE9SVF9SSUdIVF9SRUNFSVZFLCAtMSk7Ci0gICAgfSk7Ci0KLSAg ICByZXR1cm4gc291cmNlOwotfQotCiBib29sIENvbm5lY3Rpb246Om9wZW4oKQogewogICAgIGlm IChtX2lzU2VydmVyKSB7CkBAIC0yMDUsMzcgKzE5NCw0NSBAQCBib29sIENvbm5lY3Rpb246Om9w ZW4oKQogICAgICAgICBBU1NFUlQobV9zZW5kUG9ydCk7CiAKICAgICAgICAgLy8gQ3JlYXRlIHRo ZSByZWNlaXZlIHBvcnQuCi0gICAgICAgIG1hY2hfcG9ydF9hbGxvY2F0ZShtYWNoX3Rhc2tfc2Vs ZigpLCBNQUNIX1BPUlRfUklHSFRfUkVDRUlWRSwgJm1fcmVjZWl2ZVBvcnQpOworICAgICAgICB1 aW50MzJfdCBmbGFncyA9IE1QT19DT05URVhUX0FTX0dVQVJEIHwgTVBPX1FMSU1JVCB8ICBNUE9f U1RSSUNUIHwgTVBPX0lOU0VSVF9TRU5EX1JJR0hUOwogCiAjaWYgUExBVEZPUk0oTUFDKQotICAg ICAgICBtYWNoX3BvcnRfc2V0X2F0dHJpYnV0ZXMobWFjaF90YXNrX3NlbGYoKSwgbV9yZWNlaXZl UG9ydCwgTUFDSF9QT1JUX0RFTkFQX1JFQ0VJVkVSLCAobWFjaF9wb3J0X2luZm9fdCkwLCAwKTsK KyAgICAgICAgZmxhZ3MgfD0gTVBPX0RFTkFQX1JFQ0VJVkVSOwogI2VuZGlmCiAKKyAgICAgICAg bWFjaF9wb3J0X29wdGlvbnNfdCBwb3J0T3B0aW9uczsKKyAgICAgICAgcG9ydE9wdGlvbnMuZmxh Z3MgPSBmbGFnczsKKyAgICAgICAgcG9ydE9wdGlvbnMubXBsLm1wbF9xbGltaXQgPSBNQUNIX1BP UlRfUUxJTUlUX0xBUkdFOworICAgICAgICBtYWNoX3BvcnRfY29uc3RydWN0KG1hY2hfdGFza19z ZWxmKCksICZwb3J0T3B0aW9ucywgcmVpbnRlcnByZXRfY2FzdDxtYWNoX3BvcnRfY29udGV4dF90 Pih0aGlzKSwgJm1fcmVjZWl2ZVBvcnQpOworCiAgICAgICAgIG1faXNDb25uZWN0ZWQgPSB0cnVl OwogICAgICAgICAKLSAgICAgICAgLy8gU2VuZCB0aGUgaW5pdGlhbGl6ZSBtZXNzYWdlLCB3aGlj aCBjb250YWlucyBhIHNlbmQgcmlnaHQgZm9yIHRoZSBzZXJ2ZXIgdG8gdXNlLgogICAgICAgICBh dXRvIGVuY29kZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPEVuY29kZXI+KCJJUEMiLCAiSW5pdGlhbGl6 ZUNvbm5lY3Rpb24iLCAwKTsKLSAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKE1hY2hQb3J0KG1fcmVj ZWl2ZVBvcnQsIE1BQ0hfTVNHX1RZUEVfTUFLRV9TRU5EKSk7CisgICAgICAgIGVuY29kZXItPmVu Y29kZShNYWNoUG9ydChtX3JlY2VpdmVQb3J0LCBNQUNIX01TR19UWVBFX01PVkVfU0VORCkpOwog CiAgICAgICAgIGluaXRpYWxpemVTZW5kU291cmNlKCk7CiAKICAgICAgICAgc2VuZE1lc3NhZ2Uo V1RGTW92ZShlbmNvZGVyKSwgeyB9KTsKICAgICB9CiAKLSAgICAvLyBDaGFuZ2UgdGhlIG1lc3Nh Z2UgcXVldWUgbGVuZ3RoIGZvciB0aGUgcmVjZWl2ZSBwb3J0LgotICAgIHNldE1hY2hQb3J0UXVl dWVMZW5ndGgobV9yZWNlaXZlUG9ydCwgTUFDSF9QT1JUX1FMSU1JVF9MQVJHRSk7Ci0KLSAgICAv LyBSZWdpc3RlciB0aGUgZGF0YSBhdmFpbGFibGUgaGFuZGxlci4KICAgICBSZWZQdHI8Q29ubmVj dGlvbj4gY29ubmVjdGlvbih0aGlzKTsKLSAgICBtX3JlY2VpdmVTb3VyY2UgPSBjcmVhdGVSZWNl aXZlU291cmNlKG1fcmVjZWl2ZVBvcnQsIG1fY29ubmVjdGlvblF1ZXVlLCBbY29ubmVjdGlvbl0g eworICAgIG1fcmVjZWl2ZVNvdXJjZSA9IGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElTUEFUQ0hf U09VUkNFX1RZUEVfTUFDSF9SRUNWLCBtX3JlY2VpdmVQb3J0LCAwLCBtX2Nvbm5lY3Rpb25RdWV1 ZS0+ZGlzcGF0Y2hRdWV1ZSgpKTsKKyAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRs ZXIobV9yZWNlaXZlU291cmNlLCBbY29ubmVjdGlvbl0gewogICAgICAgICBjb25uZWN0aW9uLT5y ZWNlaXZlU291cmNlRXZlbnRIYW5kbGVyKCk7CiAgICAgfSk7CisgICAgZGlzcGF0Y2hfc291cmNl X3NldF9jYW5jZWxfaGFuZGxlcihtX3JlY2VpdmVTb3VyY2UsIFtjb25uZWN0aW9uLCByZWNlaXZl UG9ydCA9IG1fcmVjZWl2ZVBvcnRdIHsKKyAgICAgICAgbWFjaF9wb3J0X2Rlc3RydWN0KG1hY2hf dGFza19zZWxmKCksIHJlY2VpdmVQb3J0LCAwLCByZWludGVycHJldF9jYXN0PG1hY2hfcG9ydF9j b250ZXh0X3Q+KGNvbm5lY3Rpb24uZ2V0KCkpKTsKKyAgICB9KTsKIAogI2lmIFBMQVRGT1JNKE1B QykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8PSAxMDEwMDAKICAgICBpZiAo bV9leGNlcHRpb25Qb3J0KSB7Ci0gICAgICAgIG1fZXhjZXB0aW9uUG9ydERhdGFBdmFpbGFibGVT b3VyY2UgPSBjcmVhdGVSZWNlaXZlU291cmNlKG1fZXhjZXB0aW9uUG9ydCwgbV9jb25uZWN0aW9u UXVldWUsIFtjb25uZWN0aW9uXSB7CisgICAgICAgIG1fZXhjZXB0aW9uUG9ydERhdGFBdmFpbGFi bGVTb3VyY2UgPSBkaXNwYXRjaF9zb3VyY2VfY3JlYXRlKERJU1BBVENIX1NPVVJDRV9UWVBFX01B Q0hfUkVDViwgbV9leGNlcHRpb25Qb3J0LCAwLCBtX2Nvbm5lY3Rpb25RdWV1ZS5kaXNwYXRjaFF1 ZXVlKCkpOworICAgICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRsZXIoc291cmNl LCBbY29ubmVjdGlvbl0gewogICAgICAgICAgICAgY29ubmVjdGlvbi0+ZXhjZXB0aW9uU291cmNl RXZlbnRIYW5kbGVyKCk7CiAgICAgICAgIH0pOworICAgICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0 X2NhbmNlbF9oYW5kbGVyKHNvdXJjZSwgW2Nvbm5lY3Rpb24sIGV4Y2VwdGlvblBvcnQgPSBjb25u ZWN0aW9uLT5tX2V4Y2VwdGlvblBvcnRdIHsKKyAgICAgICAgICAgIG1hY2hfcG9ydF9tb2RfcmVm cyhtYWNoX3Rhc2tfc2VsZigpLCBleGNlcHRpb25Qb3J0LCBNQUNIX1BPUlRfUklHSFRfUkVDRUlW RSwgLTEpOworICAgICAgICB9KTsKIAogICAgICAgICBhdXRvIGVuY29kZXIgPSBzdGQ6Om1ha2Vf dW5pcXVlPEVuY29kZXI+KCJJUEMiLCAiU2V0RXhjZXB0aW9uUG9ydCIsIDApOwogICAgICAgICBl bmNvZGVyLT5lbmNvZGUoTWFjaFBvcnQobV9leGNlcHRpb25Qb3J0LCBNQUNIX01TR19UWVBFX01B S0VfU0VORCkpOwo=