167699 2017-02-01 11:00:37 -0800 Serialization of custom props in longhand should be "" not value of shorthand 2017-03-24 16:18:26 -0700 1 1 1 Unclassified WebKit CSS Safari 10 Unspecified All RESOLVED FIXED https://jsfiddle.net/ok8uwunf/ FromImplementor, InRadar P2 Normal --- 1 gwhit dino dino gwhit simon.fraser webkit-bug-importer oldest_to_newest 1272201 0 gwhit 2017-02-01 11:00:37 -0800 Example URL: https://jsfiddle.net/ok8uwunf/ Steps to reproduce the problem: 1. Open https://jsfiddle.net/ok8uwunf/ 2. Look at value displayed in target element What is the expected behavior? ================================ The value should be "" since the variable substitution hasn't occurred What went wrong? ================================ It seems that Blink doesn't follow this line of the spec: "Pending-substitution values must be serialized as the empty string, if an API allows them to be observed." Since we are looking at specified style, this needs to be an empty string. Firefox: no repro Edge: no repro Blink: Repro 1272397 1 webkit-bug-importer 2017-02-02 00:13:58 -0800 <rdar://problem/30324200> 1291028 2 305329 dino 2017-03-24 16:00:38 -0700 Created attachment 305329 Patch 1291033 3 305329 sam 2017-03-24 16:04:10 -0700 Comment on attachment 305329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305329&action=review > LayoutTests/fast/css/variables/rule-property-get.html:9 > +/* https://www.w3.org/TR/css-variables/#variables-in-shorthands > + "Pending-substitution values must be serialized as the empty string, if an API allows them to be observed." */ I think this comment could use some context, explaining what the test is testing. 1291042 4 dino 2017-03-24 16:18:26 -0700 Committed r214383: <http://trac.webkit.org/changeset/214383> 305329 2017-03-24 16:00:38 -0700 2017-03-24 16:04:10 -0700 Patch bug-167699-20170325100034.patch text/plain 3937 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmVmMjBmZmEzNTgyZGZl Zjk2NGEwNTViMDRiNTUzNjE4MGFjY2NjNy4uMjVjNDZkNDc1YTdlZWQxZDE2Y2FjNGEyYTRiM2Ji Y2Q2YTllNDFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAzLTI0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTZXJpYWxpemF0aW9uIG9mIGN1 c3RvbSBwcm9wcyBpbiBsb25naGFuZCBzaG91bGQgYmUgIiIgbm90IHZhbHVlIG9mIHNob3J0aGFu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3Njk5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDMyNDIwMD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL3d3dy53My5vcmcvVFIvY3NzLXZh cmlhYmxlcy8jdmFyaWFibGVzLWluLXNob3J0aGFuZHMgc2F5cworICAgICAgICAiUGVuZGluZy1z dWJzdGl0dXRpb24gdmFsdWVzIG11c3QgYmUgc2VyaWFsaXplZCBhcyB0aGUgZW1wdHkgc3RyaW5n LCBpZgorICAgICAgICBhbiBBUEkgYWxsb3dzIHRoZW0gdG8gYmUgb2JzZXJ2ZWQuIgorCisgICAg ICAgIFdlIHdlcmUgcmV0dXJuaW5nIHRoZSBjc3NUZXh0IGluc3RlYWQuCisKKyAgICAgICAgVGVz dDogZmFzdC9jc3MvdmFyaWFibGVzL3J1bGUtcHJvcGVydHktZ2V0Lmh0bWwgaGFzIGJlZW4gdXBk YXRlZC4KKworICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnRpZXMuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6U3R5bGVQcm9wZXJ0aWVzOjpnZXRQcm9wZXJ0eVZhbHVlKTogUmV0dXJuIHRoZSBlbXB0 eSBzdHJpbmcKKyAgICAgICAgaWYgd2UncmUgYSBwZW5kaW5nIHN1YnN0aXR1dGlvbiB2YWx1ZS4K KwogMjAxNy0wMy0yMiAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAg TmV2ZXJEZXN0cm95ZWQ8TWVkaWFRdWVyeUV2YWx1YXRvcj4gbXVzdCBleHBsaWNpdGx5IGNvbnN0 cnVjdCB3aXRoIGEgU3RyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQ cm9wZXJ0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwCmlu ZGV4IDc4ZWEzZWQ3ZjhmY2Y5MjEyMGJmMTFkN2ZhNzYzNWYyOTIwZWExYzkuLjM0MGM3ODA4MTRi NjIxYzIxZTQzMmM2MWNmZWI3NmM0Yzg5M2U1MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVByb3BlcnRpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVBy b3BlcnRpZXMuY3BwCkBAIC0xMzEsMTAgKzEzMSw4IEBAIFN0cmluZyBTdHlsZVByb3BlcnRpZXM6 OmdldFByb3BlcnR5VmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlEKSBjb25zdAogICAgIGNv bnN0IFN0eWxlUHJvcGVydHlTaG9ydGhhbmQmIHNob3J0aGFuZCA9IHNob3J0aGFuZEZvclByb3Bl cnR5KHByb3BlcnR5SUQpOwogICAgIGlmIChzaG9ydGhhbmQubGVuZ3RoKCkpIHsKICAgICAgICAg UmVmUHRyPENTU1ZhbHVlPiB2YWx1ZSA9IGdldFByb3BlcnR5Q1NTVmFsdWVJbnRlcm5hbChzaG9y dGhhbmQucHJvcGVydGllcygpWzBdKTsKLSAgICAgICAgaWYgKCF2YWx1ZSkKKyAgICAgICAgaWYg KCF2YWx1ZSB8fCB2YWx1ZS0+aXNQZW5kaW5nU3Vic3RpdHV0aW9uVmFsdWUoKSkKICAgICAgICAg ICAgIHJldHVybiBTdHJpbmcoKTsKLSAgICAgICAgaWYgKHZhbHVlLT5pc1BlbmRpbmdTdWJzdGl0 dXRpb25WYWx1ZSgpKQotICAgICAgICAgICAgcmV0dXJuIGRvd25jYXN0PENTU1BlbmRpbmdTdWJz dGl0dXRpb25WYWx1ZT4oKnZhbHVlKS5zaG9ydGhhbmRWYWx1ZSgpLT5jc3NUZXh0KCk7CiAgICAg fQogCiAgICAgLy8gU2hvcnRoYW5kIGFuZCA0LXZhbHVlcyBwcm9wZXJ0aWVzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTkw Y2IwZmRlNzNkNDhiMDExYjlkZDY2ZGZiNDQ3YTBkZmM5MTQwZC4uZTNjYjc1YmM1ZWEwZWQ4NzBl MmFiZWRhODA0ZjE0YzQ5M2U3ZjQ4MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTI0 ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTZXJpYWxpemF0aW9u IG9mIGN1c3RvbSBwcm9wcyBpbiBsb25naGFuZCBzaG91bGQgYmUgIiIgbm90IHZhbHVlIG9mIHNo b3J0aGFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY3Njk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDMyNDIwMD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL3ZhcmlhYmxlcy9y dWxlLXByb3BlcnR5LWdldC1leHBlY3RlZC5odG1sOgorICAgICAgICAqIGZhc3QvY3NzL3Zhcmlh Ymxlcy9ydWxlLXByb3BlcnR5LWdldC5odG1sOgorCiAyMDE3LTAzLTIyICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEeW5hbWljYWxseSBhcHBsaWVkIDplbXB0 eSBwc2V1ZG8gY2xhc3Mgd2l0aCBkaXNwbGF5Om5vbmUgZG9lcyBub3QgZ2V0IHVuYXBwbGllZApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL3J1bGUtcHJvcGVydHkt Z2V0LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvcnVsZS1w cm9wZXJ0eS1nZXQtZXhwZWN0ZWQuaHRtbAppbmRleCAyMzJkYmRiM2Q5MzVlNjNhNGU1NmZkYjFm ZjRiMjQ2ZTI0MDYzNTk2Li5jYmEyZTJlYmFiNjMwYmQyNDY5MjdhOGEyZTUwM2YxOTcxYzEyNzRi IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMvcnVsZS1wcm9wZXJ0 eS1nZXQtZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy92YXJpYWJsZXMv cnVsZS1wcm9wZXJ0eS1nZXQtZXhwZWN0ZWQuaHRtbApAQCAtMSw1ICsxLDQgQEAKIDxodG1sPgog PGJvZHkgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6Z3JlZW4iPgotdmFyKC0tYmdjb2xvcikKIDwv Ym9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL3ZhcmlhYmxl cy9ydWxlLXByb3BlcnR5LWdldC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVz L3J1bGUtcHJvcGVydHktZ2V0Lmh0bWwKaW5kZXggMzE0MGUwODQ0ZjRkMzQ5MWMxM2U2Yjc5YzBi ZGU3NTg1YmVhNDNmYy4uNmNmMWZjYTAxZjEyNDc1NzI1MmI1YTE1NDM1MGI0NTUyM2U5NTc3NiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL3J1bGUtcHJvcGVydHkt Z2V0Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdmFyaWFibGVzL3J1bGUtcHJvcGVy dHktZ2V0Lmh0bWwKQEAgLTUsNiArNSw4IEBACiA8L3N0eWxlPgogPGJvZHk+CiA8c2NyaXB0Pgor LyogaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy12YXJpYWJsZXMvI3ZhcmlhYmxlcy1pbi1zaG9y dGhhbmRzCisgICAiUGVuZGluZy1zdWJzdGl0dXRpb24gdmFsdWVzIG11c3QgYmUgc2VyaWFsaXpl ZCBhcyB0aGUgZW1wdHkgc3RyaW5nLCBpZiBhbiBBUEkgYWxsb3dzIHRoZW0gdG8gYmUgb2JzZXJ2 ZWQuIiAqLwogZG9jdW1lbnQud3JpdGUoZG9jdW1lbnQuc3R5bGVTaGVldHNbMF0uY3NzUnVsZXNb MF0uc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgiYmFja2dyb3VuZCIpKQogPC9zY3JpcHQ+CiA8L2Jv ZHk+Cg==