167687 2017-02-01 04:26:55 -0800 The CSS property -webkit-text-stroke is not applied on captions. 2017-02-03 09:41:05 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue eric.carlson jonlee koivisto oldest_to_newest 1272109 0 pvollan 2017-02-01 04:26:55 -0800 Styling captions with text stroke has no effect on text rendering. 1272110 1 300319 pvollan 2017-02-01 04:33:45 -0800 Created attachment 300319 Patch 1272112 2 pvollan 2017-02-01 04:35:06 -0800 <rdar://problem/30305523> 1272152 3 300319 bfulgham 2017-02-01 09:17:16 -0800 Comment on attachment 300319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300319&action=review This change looks good, but please create a test case. > Source/WebCore/ChangeLog:8 > + Add style to list of valid properties for cue. This is a simple change, but it seems like a test case would help us avoid this breaking in the future. Could you please create a LayoutTest for this? 1272885 4 300521 pvollan 2017-02-03 05:29:36 -0800 Created attachment 300521 Patch 1272910 5 pvollan 2017-02-03 07:11:33 -0800 (In reply to comment #3) > Comment on attachment 300319 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300319&action=review > > This change looks good, but please create a test case. > > > Source/WebCore/ChangeLog:8 > > + Add style to list of valid properties for cue. > > This is a simple change, but it seems like a test case would help us avoid > this breaking in the future. > > Could you please create a LayoutTest for this? Thanks for reviewing :) Updated patch. 1272927 6 300521 bfulgham 2017-02-03 08:43:25 -0800 Comment on attachment 300521 Patch Thank you for adding the test! r=me 1272936 7 bfulgham 2017-02-03 09:14:09 -0800 <rdar://problem/17940996> 1272948 8 300521 commit-queue 2017-02-03 09:41:01 -0800 Comment on attachment 300521 Patch Clearing flags on attachment: 300521 Committed r211637: <http://trac.webkit.org/changeset/211637> 1272949 9 commit-queue 2017-02-03 09:41:05 -0800 All reviewed patches have been landed. Closing bug. 300319 2017-02-01 04:33:45 -0800 2017-02-03 05:29:29 -0800 Patch bug-167687-20170201133131.patch text/plain 1279 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTQ3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAyLTAxICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgQ1NTIHByb3BlcnR5 IC13ZWJraXQtdGV4dC1zdHJva2UgaXMgbm90IGFwcGxpZWQgb24gY2FwdGlvbnMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc2ODcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3R5bGUgdG8gbGlz dCBvZiB2YWxpZCBwcm9wZXJ0aWVzIGZvciBjdWUuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNv bHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjppc1ZhbGlkQ3VlU3R5 bGVQcm9wZXJ0eSk6CisKIDIwMTctMDItMDEgIEVucmlxdWUgT2Nhw7FhIEdvbnrDoWxleiAgPGVv Y2FuaGFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtNU0VdIHF0ZGVtdXg6IFVw ZGF0ZSB0aGUgdGZkdCBwYXRjaCB0byB0aGUgdmVyc2lvbiBmaW5hbGx5IGFjY2VwdGVkIHVwc3Ry ZWFtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCShyZXZpc2lvbiAyMTE0 NzgpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE1MDMsNiArMTUwMyw4IEBAIGlubGluZSBib29sIFN0eWxlUmVzb2x2ZXI6OmlzVmFs aWRDdWVTdHkKICAgICBjYXNlIENTU1Byb3BlcnR5VGV4dERlY29yYXRpb246CiAgICAgY2FzZSBD U1NQcm9wZXJ0eVRleHRTaGFkb3c6CiAgICAgY2FzZSBDU1NQcm9wZXJ0eUJvcmRlclN0eWxlOgor ICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0U3Ryb2tlQ29sb3I6CisgICAgY2FzZSBDU1NQ cm9wZXJ0eVdlYmtpdFRleHRTdHJva2VXaWR0aDoKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg ZGVmYXVsdDoKICAgICAgICAgYnJlYWs7Cg== 300521 2017-02-03 05:29:36 -0800 2017-02-03 09:41:01 -0800 Patch bug-167687-20170203142720.patch text/plain 4204 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTYyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAyLTAxICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBUaGUgQ1NTIHByb3BlcnR5 IC13ZWJraXQtdGV4dC1zdHJva2UgaXMgbm90IGFwcGxpZWQgb24gY2FwdGlvbnMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc2ODcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgc3R5bGUgdG8gbGlz dCBvZiB2YWxpZCBwcm9wZXJ0aWVzIGZvciBjdWUuCisKKyAgICAgICAgVGVzdDogbWVkaWEvdHJh Y2svdHJhY2stY3NzLXN0cm9rZS1jdWVzLmh0bWwKKworICAgICAgICAqIGNzcy9TdHlsZVJlc29s dmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OmlzVmFsaWRDdWVTdHls ZVByb3BlcnR5KToKKwogMjAxNy0wMi0wMiAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CiAKICAgICAgICAgW01hY10gSW4tcHJvY2VzcyBtZW1vcnkgcHJlc3N1cmUgbW9uaXRvciBm b3IgV2ViQ29udGVudCBwcm9jZXNzZXMgQUtBIHdlYnNhbQpJbmRleDogU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlUmVzb2x2ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9T dHlsZVJlc29sdmVyLmNwcAkocmV2aXNpb24gMjExNjIyKQorKysgU291cmNlL1dlYkNvcmUvY3Nz L1N0eWxlUmVzb2x2ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAzLDYgKzE1MDMsOCBAQCBp bmxpbmUgYm9vbCBTdHlsZVJlc29sdmVyOjppc1ZhbGlkQ3VlU3R5CiAgICAgY2FzZSBDU1NQcm9w ZXJ0eVRleHREZWNvcmF0aW9uOgogICAgIGNhc2UgQ1NTUHJvcGVydHlUZXh0U2hhZG93OgogICAg IGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJTdHlsZToKKyAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0 VGV4dFN0cm9rZUNvbG9yOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUZXh0U3Ryb2tlV2lk dGg6CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGJyZWFrOwpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMjExNjMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDItMDMgIFBlciBBcm5lIFZvbGxhbiAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFRoZSBDU1MgcHJvcGVydHkgLXdlYmtpdC10 ZXh0LXN0cm9rZSBpcyBub3QgYXBwbGllZCBvbiBjYXB0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzY4NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbWVkaWEvdHJhY2svdHJhY2stY3NzLXN0 cm9rZS1jdWVzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogbWVkaWEvdHJhY2svdHJh Y2stY3NzLXN0cm9rZS1jdWVzLmh0bWw6IEFkZGVkLgorCiAyMDE3LTAyLTAzICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgaW5p dGlhbCBpbXBsZW1lbnRhdGlvbiBvZiByZXNvdXJjZSB1c2FnZSBvdmVybGF5CkluZGV4OiBMYXlv dXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1ZXMtZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWNzcy1zdHJva2UtY3Vl cy1leHBlY3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv dHJhY2stY3NzLXN0cm9rZS1jdWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCww ICsxLDggQEAKKworVGVzdCB0aGF0IHN0eWxlIHRvIGFsbCBjdWVzIGlzIGFwcGxpZWQgY29ycmVj dGx5LgorRVZFTlQoY2FucGxheXRocm91Z2gpCitFVkVOVChzZWVrZWQpCitFWFBFQ1RFRCAoZ2V0 Q29tcHV0ZWRTdHlsZSh0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbywgJ2N1ZScpKS53ZWJr aXRUZXh0U3Ryb2tlV2lkdGggPT0gJzRweCcpIE9LCitFWFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHls ZSh0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbywgJ2N1ZScpKS53ZWJraXRUZXh0U3Ryb2tl Q29sb3IgPT0gJ3JnYigwLCAwLCAwKScpIE9LCitFTkQgT0YgVEVTVAorCkluZGV4OiBMYXlvdXRU ZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1ZXMuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1ZXMuaHRtbAkobm9u ZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1 ZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDQyIEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5 cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD11dGYtOCIgLz4KKworICAgICAgICA8c2Ny aXB0IHNyYz0uLi9tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz0u Li92aWRlby10ZXN0LmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz0uLi9tZWRpYS1j b250cm9scy5qcz48L3NjcmlwdD4KKworICAgICAgICA8c3R5bGU+CisKKyAgICAgICAgdmlkZW86 OmN1ZSB7IC13ZWJraXQtdGV4dC1zdHJva2U6IDRweCBibGFjazsgfQorCisgICAgICAgIDwvc3R5 bGU+CisKKyAgICAgICAgPHNjcmlwdD4KKworICAgICAgICBmdW5jdGlvbiBzZWVrZWQoKQorICAg ICAgICB7CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImdldENvbXB1dGVkU3R5bGUodGV4dFRy YWNrRGlzcGxheUVsZW1lbnQodmlkZW8sICdjdWUnKSkud2Via2l0VGV4dFN0cm9rZVdpZHRoIiwg IjRweCIpOworICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJnZXRDb21wdXRlZFN0eWxlKHRleHRU cmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnY3VlJykpLndlYmtpdFRleHRTdHJva2VDb2xvciIs ICJyZ2IoMCwgMCwgMCkiKTsKKyAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgfQorCisg ICAgICAgIGZ1bmN0aW9uIGxvYWRlZCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIGNvbnNvbGVX cml0ZSgiVGVzdCB0aGF0IHN0eWxlIHRvIGFsbCBjdWVzIGlzIGFwcGxpZWQgY29ycmVjdGx5LiIp OworICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICAgICAgdmlkZW8uc3Jj ID0gZmluZE1lZGlhRmlsZSgndmlkZW8nLCAnLi4vY29udGVudC90ZXN0Jyk7CisgICAgICAgICAg ICB3YWl0Rm9yRXZlbnQoJ3NlZWtlZCcsIHNlZWtlZCk7CisgICAgICAgICAgICB3YWl0Rm9yRXZl bnQoJ2NhbnBsYXl0aHJvdWdoJywgZnVuY3Rpb24oKSB7IHZpZGVvLmN1cnJlbnRUaW1lID0gLjU7 IH0pOworICAgICAgICB9CisKKyAgICAgICAgc2V0Q2FwdGlvbkRpc3BsYXlNb2RlKCdBdXRvbWF0 aWMnKTsKKyAgICAgICAgPC9zY3JpcHQ+CisgICAgPC9oZWFkPgorICAgIDxib2R5IG9ubG9hZD0i bG9hZGVkKCkiPgorICAgICAgICA8dmlkZW8gY29udHJvbHMgPgorICAgICAgICAgICAgPHRyYWNr IHNyYz0iY2FwdGlvbnMtd2VidnR0L3N0eWxpbmcudnR0IiBraW5kPSJjYXB0aW9ucyIgZGVmYXVs dD4KKyAgICAgICAgPC92aWRlbz4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==