167684 2017-01-31 21:12:08 -0800 ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category 2017-01-31 21:36:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck ddkilzer joepeck mitz oldest_to_newest 1272040 0 joepeck 2017-01-31 21:12:08 -0800 When building for iOS I see a linker warning: ld: warning: instance method '_setAutofilled:' in category from /Build/WebKit.build/Release-iphoneos/WebKitLegacy.build/Objects-normal/arm64/DOMHTML.o conflicts with same method from another category It looks like the same DOMHTMLInputElement extension appears in two places. Lets unify. 1272042 1 300298 joepeck 2017-01-31 21:20:16 -0800 Created attachment 300298 [PATCH] Proposed Fix 1272044 2 300298 mitz 2017-01-31 21:26:13 -0800 Comment on attachment 300298 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=300298&action=review > Source/WebKit/mac/DOM/DOMPrivate.h:103 > - (BOOL)_isTextField; You should update the comment above, because this isn’t used by Safari anymore. 1272045 3 joepeck 2017-01-31 21:36:27 -0800 <https://trac.webkit.org/changeset/211468> 300298 2017-01-31 21:20:16 -0800 2017-01-31 21:26:13 -0800 [PATCH] Proposed Fix linker-1.patch text/plain 3570 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBiN2MzNTY5ZjUwNi4uZjlkMjAwMjlkZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxNy0wMS0zMSAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIGxkOiB3YXJuaW5nOiBpbnN0YW5jZSBtZXRob2Qg J19zZXRBdXRvZmlsbGVkOicgaW4gY2F0ZWdvcnkgY29uZmxpY3RzIHdpdGggc2FtZSBtZXRob2Qg ZnJvbSBhbm90aGVyIGNhdGVnb3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjc2ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIERPTS9ET01IVE1MLm1tOgorICAgICAgICAoLVtET01IVE1MSW5wdXRF bGVtZW50IF9pc0F1dG9maWxsZWRdKTogRGVsZXRlZC4KKyAgICAgICAgKC1bRE9NSFRNTElucHV0 RWxlbWVudCBfc2V0QXV0b2ZpbGxlZDpdKTogRGVsZXRlZC4KKyAgICAgICAgQ29uc29saWRhdGUg aW4gdGhlIFdlYkRPTU9wZXJhdGlvbnNQcml2YXRlIGNhdGVnb3J5LgorCisgICAgICAgICogRE9N L0RPTVByaXZhdGUuaDoKKyAgICAgICAgSW5jbHVkZSBXZWJET01PcGVyYXRpb25zUHJpdmF0ZSBo ZWFkZXIgdG8gZ2V0IG90aGVyIERPTSBQcml2YXRlIGNhdGVnb3JpZXMuCisKKyAgICAgICAgKiBE T00vV2ViRE9NT3BlcmF0aW9ucy5tbToKKyAgICAgICAgKC1bRE9NSFRNTElucHV0RWxlbWVudCBf aXNBdXRvZmlsbGVkXSk6CisgICAgICAgICogRE9NL1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmg6 CisgICAgICAgIEluY2x1ZGUgZ2V0dGVyIGFsb25nc2lkZSB0aGUgc2V0dGVyLgorCiAyMDE3LTAx LTMwICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBbUXVpY2tMb29r XSBGcmFtZUxvYWRlckNsaWVudCBzaG91bGQgcmV0dXJuIHRoZSBuZXcgUXVpY2tMb29rSGFuZGxl Q2xpZW50IGl0IGNyZWF0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0RPTS9ET01I VE1MLm1tIGIvU291cmNlL1dlYktpdC9tYWMvRE9NL0RPTUhUTUwubW0KaW5kZXggYjE3MjcyNTZj NWIuLjcyZDY4Yjg4MWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9ET00vRE9NSFRN TC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9ET00vRE9NSFRNTC5tbQpAQCAtMTgyLDIyICsx ODIsNiBAQCB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKICAgICByZXR1cm4gY29yZShzZWxmKS0+ aXNUZXh0RmllbGQoKTsKIH0KIAotI2lmIFBMQVRGT1JNKElPUykKLQotLSAoQk9PTClfaXNBdXRv ZmlsbGVkCi17Ci0gICAgcmV0dXJuIGNvcmUoc2VsZiktPmlzQXV0b0ZpbGxlZCgpOwotfQotCi0t ICh2b2lkKV9zZXRBdXRvZmlsbGVkOihCT09MKWZpbGxlZAotewotICAgIC8vIFRoaXMgbm90aWZp ZXMgdGhlIGlucHV0IGVsZW1lbnQgdGhhdCB0aGUgY29udGVudCBoYXMgYmVlbiBhdXRvZmlsbGVk Ci0gICAgLy8gVGhpcyBhbGxvd3MgV2ViS2l0IHRvIG9iZXkgdGhlIC13ZWJraXQtYXV0b2ZpbGwg cHNldWRvIHN0eWxlLCB3aGljaAotICAgIC8vIGNoYW5nZXMgdGhlIGJhY2tncm91bmQgY29sb3Iu Ci0gICAgY29yZShzZWxmKS0+c2V0QXV0b0ZpbGxlZChmaWxsZWQpOwotfQotI2VuZGlmIC8vIFBM QVRGT1JNKElPUykKLQogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gRE9NSFRNTFNlbGVjdEVsZW1l bnQgKEZvcm1BdXRvRmlsbFRyYW5zaXRpb24pCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9ET00vRE9NUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9tYWMvRE9NL0RPTVByaXZhdGUuaApp bmRleCBmODlhYjc0M2FkMC4uZTY3MzAwMmEzOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv bWFjL0RPTS9ET01Qcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9tYWMvRE9NL0RPTVByaXZh dGUuaApAQCAtMjYsNiArMjYsNyBAQAogCiAjaW1wb3J0IDxXZWJLaXRMZWdhY3kvRE9NLmg+CiAj aW1wb3J0IDxXZWJLaXRMZWdhY3kvV2ViQXV0b2NhcGl0YWxpemVUeXBlcy5oPgorI2ltcG9ydCA8 V2ViS2l0TGVnYWN5L1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmg+CiAKICNpZiBUQVJHRVRfT1Nf SVBIT05FCiAjaW1wb3J0IDxDb3JlVGV4dC9Db3JlVGV4dC5oPgpAQCAtMTAwLDEwICsxMDEsNiBA QAogLy8gdXNpbmcgdGhhdCBwdWJsaWMgQVBJLCBhbmQgdGhlc2Ugd2lsbCBiZSBkZWxldGVkLgog QGludGVyZmFjZSBET01IVE1MSW5wdXRFbGVtZW50IChGb3JtQXV0b0ZpbGxUcmFuc2l0aW9uKQog LSAoQk9PTClfaXNUZXh0RmllbGQ7Ci0jaWYgVEFSR0VUX09TX0lQSE9ORQotLSAoQk9PTClfaXNB dXRvZmlsbGVkOwotLSAodm9pZClfc2V0QXV0b2ZpbGxlZDooQk9PTClmaWxsZWQ7Ci0jZW5kaWYK IEBlbmQKIAogI2lmIFRBUkdFVF9PU19JUEhPTkUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv bWFjL0RPTS9XZWJET01PcGVyYXRpb25zLm1tIGIvU291cmNlL1dlYktpdC9tYWMvRE9NL1dlYkRP TU9wZXJhdGlvbnMubW0KaW5kZXggMTlhNjk1MDAyZTYuLjQ0MmRjNDIzZDFlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L21hYy9ET00vV2ViRE9NT3BlcmF0aW9ucy5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0L21hYy9ET00vV2ViRE9NT3BlcmF0aW9ucy5tbQpAQCAtMjEyLDYgKzIxMiwxMSBAQCB1 c2luZyBuYW1lc3BhY2UgSlNDOwogCiBAaW1wbGVtZW50YXRpb24gRE9NSFRNTElucHV0RWxlbWVu dCAoV2ViRE9NSFRNTElucHV0RWxlbWVudE9wZXJhdGlvbnNQcml2YXRlKQogCistIChCT09MKV9p c0F1dG9maWxsZWQKK3sKKyAgICByZXR1cm4gZG93bmNhc3Q8SFRNTElucHV0RWxlbWVudD4oY29y ZSgoRE9NRWxlbWVudCAqKXNlbGYpKS0+aXNBdXRvRmlsbGVkKCk7Cit9CisKIC0gKHZvaWQpX3Nl dEF1dG9maWxsZWQ6KEJPT0wpYXV0b2ZpbGxlZAogewogICAgIGRvd25jYXN0PEhUTUxJbnB1dEVs ZW1lbnQ+KGNvcmUoKERPTUVsZW1lbnQgKilzZWxmKSktPnNldEF1dG9GaWxsZWQoYXV0b2ZpbGxl ZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9ET00vV2ViRE9NT3BlcmF0aW9uc1By aXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvbWFjL0RPTS9XZWJET01PcGVyYXRpb25zUHJpdmF0ZS5o CmluZGV4IGFlYmY5ZDE1M2RlLi43NjljZmY4MTEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9tYWMvRE9NL1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmgKKysrIGIvU291cmNlL1dlYktpdC9t YWMvRE9NL1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmgKQEAgLTQxLDYgKzQxLDcgQEAKIEBlbmQK IAogQGludGVyZmFjZSBET01IVE1MSW5wdXRFbGVtZW50IChXZWJET01IVE1MSW5wdXRFbGVtZW50 T3BlcmF0aW9uc1ByaXZhdGUpCistIChCT09MKV9pc0F1dG9maWxsZWQ7CiAtICh2b2lkKV9zZXRB dXRvZmlsbGVkOihCT09MKWF1dG9maWxsZWQ7CiBAZW5kCiAK