167667 2017-01-31 14:32:45 -0800 Make DumpRenderTree not crash 2017-01-31 20:30:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner megan_gardner bdakin simon.fraser thorton oldest_to_newest 1271899 0 megan_gardner 2017-01-31 14:32:45 -0800 Make Dump Render Tree not crash 1271902 1 300262 megan_gardner 2017-01-31 14:35:15 -0800 Created attachment 300262 Patch 1271903 2 megan_gardner 2017-01-31 14:35:49 -0800 <rdar://problem/29929387> 1271910 3 300262 simon.fraser 2017-01-31 14:45:15 -0800 Comment on attachment 300262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/ChangeLog:7 > + DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. > + So we're making sure it can do that without crashing. The tests won't work, but we won't crash. It would be nice if you explained the crash. Something like "We were using RunLoop::main().dispatch(), but this crashed because initBlah was never called so the global foo pointer was null. 1271915 4 300262 thorton 2017-01-31 14:52:09 -0800 Comment on attachment 300262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:47 > +#if PLATFORM(IOS) This should be in its own block at the bottom of the includes, not here. 1271989 5 megan_gardner 2017-01-31 17:06:06 -0800 Fixed the windows error. 1271990 6 megan_gardner 2017-01-31 17:07:46 -0800 https://trac.webkit.org/changeset/211460 1272032 7 300262 ap 2017-01-31 20:30:08 -0800 Comment on attachment 300262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:2414 > +#if !PLATFORM(IOS) We normally prefer to have iOS codego first. 300262 2017-01-31 14:35:15 -0800 2017-01-31 14:45:15 -0800 Patch bug-167667-20170131143304.patch text/plain 2492 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxMTQ0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTAxLTMxICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgTWFrZSBEdW1wIFJlbmRlciBUcmVlIG5vdCBjcmFzaAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NjY3CisKKyAgICAg ICAgRHVtcFJlbmRlclRyZWUgaXMgY3Jhc2hpbmcgd2hlbiBydW5uaW5nIFdLMiB0ZXN0cyB0aGF0 IGl0J3Mgbm90IHN1cHBvc2VkIHRvIGJlIHJ1bm5pbmcuIAorICAgICAgICBTbyB3ZSdyZSBtYWtp bmcgc3VyZSBpdCBjYW4gZG8gdGhhdCB3aXRob3V0IGNyYXNoaW5nLiBUaGUgdGVzdHMgd29uJ3Qg d29yaywgYnV0IHdlIHdvbid0IGNyYXNoLgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0UnVubmVyLmNw cDoKKyAgICAgICAgKFRlc3RSdW5uZXI6OmNhbGxVSVNjcmlwdENhbGxiYWNrKToKKwogMjAxNy0w MS0zMSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCB3ZWJraXRweSBmaXggYWZ0ZXIgcjIxMTQwNS4KSW5kZXg6IFRvb2xzL0R1bXBSZW5k ZXJUcmVlL1Rlc3RSdW5uZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVl L1Rlc3RSdW5uZXIuY3BwCShyZXZpc2lvbiAyMTE0MzgpCisrKyBUb29scy9EdW1wUmVuZGVyVHJl ZS9UZXN0UnVubmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDQsMTAgKzQ0LDE0IEBACiAjaW5j bHVkZSA8SmF2YVNjcmlwdENvcmUvVHlwZWRBcnJheUlubGluZXMuaD4KICNpbmNsdWRlIDxKYXZh U2NyaXB0Q29yZS9WTUlubGluZXMuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0xvZ0luaXRpYWxpemF0 aW9uLmg+CisjaWYgUExBVEZPUk0oSU9TKQorI2luY2x1ZGUgPFdlYkNvcmUvV2ViQ29yZVRocmVh ZFJ1bi5oPgorI2VuZGlmCiAjaW5jbHVkZSA8Y3N0cmluZz4KICNpbmNsdWRlIDxsb2NhbGUuaD4K ICNpbmNsdWRlIDxzdGRpby5oPgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW5jbHVk ZSA8d3RmL0Jsb2NrUHRyLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW5jbHVk ZSA8d3RmL0xvZ2dpbmdBY2N1bXVsYXRvci5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+ CkBAIC0yNDA3LDEyICsyNDExLDIxIEBAIHZvaWQgVGVzdFJ1bm5lcjo6cnVuVUlTY3JpcHQoSlND b250ZXh0UmUKIHZvaWQgVGVzdFJ1bm5lcjo6Y2FsbFVJU2NyaXB0Q2FsbGJhY2sodW5zaWduZWQg Y2FsbGJhY2tJRCwgSlNTdHJpbmdSZWYgcmVzdWx0KQogewogICAgIEpTUmV0YWluUHRyPEpTU3Ry aW5nUmVmPiBwcm90ZWN0ZWRSZXN1bHQocmVzdWx0KTsKLSAgICAKKyNpZiAhUExBVEZPUk0oSU9T KQogICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChbcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYo KnRoaXMpLCBjYWxsYmFja0lELCBwcm90ZWN0ZWRSZXN1bHRdKCkgbXV0YWJsZSB7CiAgICAgICAg IEpTQ29udGV4dFJlZiBjb250ZXh0ID0gcHJvdGVjdGVkVGhpcy0+bWFpbkZyYW1lSlNDb250ZXh0 KCk7CiAgICAgICAgIEpTVmFsdWVSZWYgcmVzdWx0VmFsdWUgPSBKU1ZhbHVlTWFrZVN0cmluZyhj b250ZXh0LCBwcm90ZWN0ZWRSZXN1bHQuZ2V0KCkpOwogICAgICAgICBwcm90ZWN0ZWRUaGlzLT5j YWxsVGVzdFJ1bm5lckNhbGxiYWNrKGNhbGxiYWNrSUQsIDEsICZyZXN1bHRWYWx1ZSk7CiAgICAg fSk7CisjZWxzZQorICAgIFdlYlRocmVhZFJ1bigKKyAgICAgICAgQmxvY2tQdHI8dm9pZCgpPjo6 ZnJvbUNhbGxhYmxlKFtwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGNhbGxiYWNrSUQs IHByb3RlY3RlZFJlc3VsdF0geworICAgICAgICAgICAgSlNDb250ZXh0UmVmIGNvbnRleHQgPSBw cm90ZWN0ZWRUaGlzLT5tYWluRnJhbWVKU0NvbnRleHQoKTsKKyAgICAgICAgICAgIEpTVmFsdWVS ZWYgcmVzdWx0VmFsdWUgPSBKU1ZhbHVlTWFrZVN0cmluZyhjb250ZXh0LCBwcm90ZWN0ZWRSZXN1 bHQuZ2V0KCkpOworICAgICAgICAgICAgcHJvdGVjdGVkVGhpcy0+Y2FsbFRlc3RSdW5uZXJDYWxs YmFjayhjYWxsYmFja0lELCAxLCAmcmVzdWx0VmFsdWUpOworICAgICAgICB9KS5nZXQoKQorICAg ICk7CisjZW5kaWYKIH0KIAogdm9pZCBUZXN0UnVubmVyOjp1aVNjcmlwdERpZENvbXBsZXRlKGNv bnN0IFN0cmluZyYgcmVzdWx0LCB1bnNpZ25lZCBjYWxsYmFja0lEKQo=