<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>167654</bug_id>
          
          <creation_ts>2017-01-31 11:24:29 -0800</creation_ts>
          <short_desc>Workaround for simctl install failing to report install failure</short_desc>
          <delta_ts>2017-01-31 16:17:13 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>iPhone / iPad</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>ryanhaddad</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1271801</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:24:29 -0800</bug_when>
    <thetext>simctl launch has a known issue where it will sometimes report a successful install even though the install failed.  We need to workaround this issue until it is fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271806</commentid>
    <comment_count>1</comment_count>
      <attachid>300241</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:30:04 -0800</bug_when>
    <thetext>Created attachment 300241
Complete workaround</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271807</commentid>
    <comment_count>2</comment_count>
      <attachid>300241</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:32:27 -0800</bug_when>
    <thetext>Comment on attachment 300241
Complete workaround

This workaround will recover from any recoverable bug in simctl install, but will take much longer to install an app in the event that any simctl install bug is encountered.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271808</commentid>
    <comment_count>3</comment_count>
      <attachid>300242</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:38:43 -0800</bug_when>
    <thetext>Created attachment 300242
Partial workaround</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271811</commentid>
    <comment_count>4</comment_count>
      <attachid>300242</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:40:41 -0800</bug_when>
    <thetext>Comment on attachment 300242
Partial workaround

This workaround will work if simctl launch never places the app in the target simulator&apos;s directory when it fails without warning.  We have no evidence that this is how simctl launch fails.  This patch, however, will take less time in the event that simctl launch does fail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271812</commentid>
    <comment_count>5</comment_count>
      <attachid>300241</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 11:41:35 -0800</bug_when>
    <thetext>Comment on attachment 300241
Complete workaround

View in context: https://bugs.webkit.org/attachment.cgi?id=300241&amp;action=review

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:266
&gt;      def install_app(self, app_path):

A comment pointing to the appropriate bug needs to be added</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271871</commentid>
    <comment_count>6</comment_count>
      <attachid>300242</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 13:53:12 -0800</bug_when>
    <thetext>Comment on attachment 300242
Partial workaround

Bugs related to the issue we are working around indicate that an app may exist on simulator but still not entirely be installed.  This workaround will still be susceptible to a failure of simctl install</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271895</commentid>
    <comment_count>7</comment_count>
      <attachid>300261</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 14:30:26 -0800</bug_when>
    <thetext>Created attachment 300261
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271914</commentid>
    <comment_count>8</comment_count>
      <attachid>300261</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2017-01-31 14:51:46 -0800</bug_when>
    <thetext>Comment on attachment 300261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300261&amp;action=review

I am not happy that we have to use launching of a simulator app as a way to validate whether the install was successful. I wish there was a more direct way to test that installation succeeded. Even better, I wish that &quot;simctl install&quot; only returned a zero status (for success) after successful installing the app.

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:267
&gt; +        # FIXME: This is a workaround for &lt;rdar://problem/30273973&gt;, Racey failure of simctl launch.

The bug title for &lt;rdar://problem/30273973&gt; mentions &quot;simctl launch&quot;. Is this the correct bug for this install_app workaround?

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:270
&gt; +                break

I would just return from here instead of breaking out of the loop.

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:277
&gt; +                bundle_id = self._host.executive.run_command([
&gt; +                    &apos;/usr/libexec/PlistBuddy&apos;,
&gt; +                    &apos;-c&apos;,
&gt; +                    &apos;Print CFBundleIdentifier&apos;,
&gt; +                    self._host.filesystem.join(app_path, &apos;Info.plist&apos;),
&gt; +                ]).rstrip()

This duplicates the logic of the function you added in the patch for bug #165927 (https://trac.webkit.org/changeset/211370),  DarwinPort.app_identifier_from_bundle().

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:278
&gt; +                pid = self.launch_app(bundle_id, [], attempts=1)

I take it you find it variable name pid to be helpful in documenting that launch_app returns a process identifier? I would have inlined the right-hand side of this expression into the line below and avoid the need for the local variable pid.

&gt; Tools/Scripts/webkitpy/xcode/simulator.py:294
&gt; +        # FIXME: This is a workaround for &lt;rdar://problem/30172453&gt;

Very Minor: Missing a period at the end of this sentence.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271918</commentid>
    <comment_count>9</comment_count>
      <attachid>300261</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 14:58:20 -0800</bug_when>
    <thetext>Comment on attachment 300261
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300261&amp;action=review

&gt;&gt; Tools/Scripts/webkitpy/xcode/simulator.py:267
&gt;&gt; +        # FIXME: This is a workaround for &lt;rdar://problem/30273973&gt;, Racey failure of simctl launch.
&gt; 
&gt; The bug title for &lt;rdar://problem/30273973&gt; mentions &quot;simctl launch&quot;. Is this the correct bug for this install_app workaround?

Right radar, wrong title.  Fixed.

&gt;&gt; Tools/Scripts/webkitpy/xcode/simulator.py:277
&gt;&gt; +                ]).rstrip()
&gt; 
&gt; This duplicates the logic of the function you added in the patch for bug #165927 (https://trac.webkit.org/changeset/211370),  DarwinPort.app_identifier_from_bundle().

Yes, it does.

I thought this was the best solution, rather than refactoring the entire device class just to pass in a port rather than an executive.  Hopefully, this fix is relatively short-lived.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271919</commentid>
    <comment_count>10</comment_count>
      <attachid>300266</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 15:00:19 -0800</bug_when>
    <thetext>Created attachment 300266
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271937</commentid>
    <comment_count>11</comment_count>
      <attachid>300266</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-31 15:30:18 -0800</bug_when>
    <thetext>Comment on attachment 300266
Patch

Rejecting attachment 300266 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.webkit.org&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 300266, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Dan Bates found in /Volumes/Data/EWS/WebKit/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Tools/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://webkit-queues.webkit.org/results/2981688</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271944</commentid>
    <comment_count>12</comment_count>
      <attachid>300274</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2017-01-31 15:38:31 -0800</bug_when>
    <thetext>Created attachment 300274
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271972</commentid>
    <comment_count>13</comment_count>
      <attachid>300274</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-31 16:17:09 -0800</bug_when>
    <thetext>Comment on attachment 300274
Patch for landing

Clearing flags on attachment: 300274

Committed r211457: &lt;http://trac.webkit.org/changeset/211457&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271973</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-01-31 16:17:13 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300241</attachid>
            <date>2017-01-31 11:30:04 -0800</date>
            <delta_ts>2017-01-31 14:30:24 -0800</delta_ts>
            <desc>Complete workaround</desc>
            <filename>bug-167654-20170131112752.patch</filename>
            <type>text/plain</type>
            <size>2217</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMTQ0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE3IEBACisyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBXb3JrYXJvdW5kIGZvciBzaW1jdGwgaW5zdGFsbCBmYWlsaW5nIHRvIHJl
cG9ydCBpbnN0YWxsIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2NzY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIHNpbWN0bCBpbnN0YWxsIHdpbGwgc29tZXRpbWVzIHJlcG9ydCBzdWNjZXNz
IGV2ZW4gdGhvdWdoIGluc3RhbGwgaGFzIGZhaWxlZC4KKyAgICAgICAgVG8gd29ya2Fyb3VuZCB0
aGlzIGJ1Zywgd2UgYXR0ZW1wdCBhbiBhcHAgbGF1bmNoIGFmdGVyIGluc3RhbGwgdG8gZW5zdXJl
CisgICAgICAgIGluc3RhbGwgaGFzIHN1Y2NlZWRlZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi
a2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5OgorICAgICAgICAoRGV2aWNlLmluc3RhbGxfYXBwKTog
QXR0ZW1wdCBhcHAgbGF1bmNoIGFmdGVyIGluc3RhbGwsIHJldHJ5IGluc3RhbGwgaWYgbGF1bmNo
IGZhaWxzLgorCiAyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KIAogICAgICAgICBVbnJldmlld2VkIHdlYmtpdHB5IGZpeCBhZnRlciByMjExNDA1LgpJbmRl
eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9uIDIx
MTQzMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3b3Jr
aW5nIGNvcHkpCkBAIC0yNjQsNyArMjY0LDIyIEBAIGNsYXNzIERldmljZShvYmplY3QpOgogICAg
ICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCcieGNydW4gc2ltY3RsIGVyYXNlIiBmYWlsZWQ6
IGRldmljZSBzdGF0ZSBpcyB7fScuZm9ybWF0KFNpbXVsYXRvci5kZXZpY2Vfc3RhdGUodWRpZCkp
KQogCiAgICAgZGVmIGluc3RhbGxfYXBwKHNlbGYsIGFwcF9wYXRoKToKLSAgICAgICAgcmV0dXJu
IG5vdCBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ3NpbWN0bCcs
ICdpbnN0YWxsJywgc2VsZi51ZGlkLCBhcHBfcGF0aF0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkK
KyAgICAgICAgZm9yIHggaW4geHJhbmdlKDMpOgorICAgICAgICAgICAgaWYgc2VsZi5faG9zdC5l
eGVjdXRpdmUucnVuX2NvbW1hbmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnaW5zdGFsbCcsIHNlbGYu
dWRpZCwgYXBwX3BhdGhdLCByZXR1cm5fZXhpdF9jb2RlPVRydWUpOgorICAgICAgICAgICAgICAg
IGJyZWFrCisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgYnVuZGxlX2lkID0gc2Vs
Zi5faG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWworICAgICAgICAgICAgICAgICAgICAnL3Vz
ci9saWJleGVjL1BsaXN0QnVkZHknLAorICAgICAgICAgICAgICAgICAgICAnLWMnLAorICAgICAg
ICAgICAgICAgICAgICAnUHJpbnQgQ0ZCdW5kbGVJZGVudGlmaWVyJywKKyAgICAgICAgICAgICAg
ICAgICAgc2VsZi5faG9zdC5maWxlc3lzdGVtLmpvaW4oYXBwX3BhdGgsICdJbmZvLnBsaXN0Jyks
CisgICAgICAgICAgICAgICAgXSkucnN0cmlwKCkKKyAgICAgICAgICAgICAgICBwaWQgPSBzZWxm
LmxhdW5jaF9hcHAoYnVuZGxlX2lkLCBbXSkKKyAgICAgICAgICAgICAgICBzZWxmLl9ob3N0LmV4
ZWN1dGl2ZS5raWxsX3Byb2Nlc3MocGlkKQorICAgICAgICAgICAgICAgIHJldHVybiBUcnVlCisg
ICAgICAgICAgICBleGNlcHQgUnVudGltZUVycm9yOgorICAgICAgICAgICAgICAgIHBhc3MKKyAg
ICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICBkZWYgbGF1bmNoX2FwcChzZWxmLCBidW5kbGVfaWQs
IGFyZ3MsIGVudj1Ob25lKToKICAgICAgICAgZW52aXJvbm1lbnRfdG9fdXNlID0ge30K
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300242</attachid>
            <date>2017-01-31 11:38:43 -0800</date>
            <delta_ts>2017-01-31 13:53:12 -0800</delta_ts>
            <desc>Partial workaround</desc>
            <filename>bug-167654-20170131113632.patch</filename>
            <type>text/plain</type>
            <size>2849</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMTQ0MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBXb3JrYXJvdW5kIGZvciBzaW1jdGwgaW5zdGFsbCBmYWlsaW5nIHRvIHJl
cG9ydCBpbnN0YWxsIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2NzY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIHNpbWN0bCBpbnN0YWxsIHdpbGwgc29tZXRpbWVzIHJlcG9ydCBzdWNjZXNz
IGV2ZW4gdGhvdWdoIGluc3RhbGwgaGFzIGZhaWxlZC4KKyAgICAgICAgVG8gd29ya2Fyb3VuZCB0
aGlzIGJ1Zywgd2UgY2hlY2sgaWYgYW4gYXBwIGV4aXN0cyBpbiB0aGUgdGFyZ2V0IHNpbXVsYXRv
cgorICAgICAgICB0byBlbnN1cmUgaW5zdGFsbCBoYXMgc3VjY2VlZGVkLgorCisgICAgICAgICog
U2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHk6CisgICAgICAgIChEZXZpY2UuaW5z
dGFsbF9hcHApOiBDaGVjayBmb3IgYXBwIGluIHNpbXVsYXRvciwgcmV0cnkgaW5zdGFsbCBpZiB0
aGUgYXBwIGlzIG5vdCBmb3VuZC4KKyAgICAgICAgKERldmljZS5sYXVuY2hfYXBwKTogQ29ycmVj
dCBjb21tZW50LgorCiAyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxl
LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHdlYmtpdHB5IGZpeCBhZnRlciByMjExNDA1LgpJ
bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9u
IDIxMTQzMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3
b3JraW5nIGNvcHkpCkBAIC0yNjQsNyArMjY0LDI2IEBAIGNsYXNzIERldmljZShvYmplY3QpOgog
ICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCcieGNydW4gc2ltY3RsIGVyYXNlIiBmYWls
ZWQ6IGRldmljZSBzdGF0ZSBpcyB7fScuZm9ybWF0KFNpbXVsYXRvci5kZXZpY2Vfc3RhdGUodWRp
ZCkpKQogCiAgICAgZGVmIGluc3RhbGxfYXBwKHNlbGYsIGFwcF9wYXRoKToKLSAgICAgICAgcmV0
dXJuIG5vdCBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ3NpbWN0
bCcsICdpbnN0YWxsJywgc2VsZi51ZGlkLCBhcHBfcGF0aF0sIHJldHVybl9leGl0X2NvZGU9VHJ1
ZSkKKyAgICAgICAgIyBGSVhNRTogVGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJv
YmxlbS8zMDI3Mzk3Mz4sIFJhY2V5IGZhaWx1cmUgb2Ygc2ltY3RsIGxhdW5jaC4KKyAgICAgICAg
aW5zdGFsbF9wYXRoID0gc2VsZi5faG9zdC5maWxlc3lzdGVtLmpvaW4oCisgICAgICAgICAgICBz
ZWxmLl9ob3N0LmZpbGVzeXN0ZW0uZXhwYW5kdXNlcignficpLAorICAgICAgICAgICAgJ0xpYnJh
cnknLAorICAgICAgICAgICAgJ0RldmVsb3BlcicsCisgICAgICAgICAgICAnQ29yZVNpbXVsYXRv
cicsCisgICAgICAgICAgICAnRGV2aWNlcycsCisgICAgICAgICAgICBzZWxmLnVkaWQsCisgICAg
ICAgICAgICAnZGF0YScsCisgICAgICAgICAgICAnQ29udGFpbmVycycsCisgICAgICAgICAgICAn
QnVuZGxlJywKKyAgICAgICAgICAgICdBcHBsaWNhdGlvbicsCisgICAgICAgICkKKyAgICAgICAg
Zm9yIHggaW4geHJhbmdlKDMpOgorICAgICAgICAgICAgaWYgc2VsZi5faG9zdC5leGVjdXRpdmUu
cnVuX2NvbW1hbmQoWyd4Y3J1bicsICdzaW1jdGwnLCAnaW5zdGFsbCcsIHNlbGYudWRpZCwgYXBw
X3BhdGhdLCByZXR1cm5fZXhpdF9jb2RlPVRydWUpOgorICAgICAgICAgICAgICAgIHJldHVybiBG
YWxzZQorICAgICAgICAgICAgZm9yIGRpciBpbiBzZWxmLl9ob3N0LmZpbGVzeXN0ZW0ubGlzdGRp
cihpbnN0YWxsX3BhdGgpOgorICAgICAgICAgICAgICAgIGlmIHNlbGYuX2hvc3QuZmlsZXN5c3Rl
bS5leGlzdHMoc2VsZi5faG9zdC5maWxlc3lzdGVtLmpvaW4oaW5zdGFsbF9wYXRoLCBkaXIsIHNl
bGYuX2hvc3QuZmlsZXN5c3RlbS5iYXNlbmFtZShhcHBfcGF0aCkpKToKKyAgICAgICAgICAgICAg
ICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICBkZWYgbGF1bmNo
X2FwcChzZWxmLCBidW5kbGVfaWQsIGFyZ3MsIGVudj1Ob25lKToKICAgICAgICAgZW52aXJvbm1l
bnRfdG9fdXNlID0ge30KQEAgLTI3NSw3ICsyOTQsNyBAQCBjbGFzcyBEZXZpY2Uob2JqZWN0KToK
ICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgZW52aXJvbm1lbnRfdG9fdXNlW3Zh
bHVlXSA9IGVudlt2YWx1ZV0KIAotICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3Vu
ZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzMwMjczOTczPiwgUmFjZXkgZmFpbHVyZSBvZiBzaW1jdGwg
bGF1bmNoLgorICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6
Ly9wcm9ibGVtLzMwMTcyNDUzPgogICAgICAgICBkZWYgX2xvZ19kZWJ1Z19lcnJvcihlcnJvcik6
CiAgICAgICAgICAgICBfbG9nLmRlYnVnKGVycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKSkKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300261</attachid>
            <date>2017-01-31 14:30:26 -0800</date>
            <delta_ts>2017-01-31 15:00:16 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-167654-20170131142815.patch</filename>
            <type>text/plain</type>
            <size>3171</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMTQ0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBXb3JrYXJvdW5kIGZvciBzaW1jdGwgaW5zdGFsbCBmYWlsaW5nIHRvIHJl
cG9ydCBpbnN0YWxsIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2NzY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIHNpbWN0bCBpbnN0YWxsIHdpbGwgc29tZXRpbWVzIHJlcG9ydCBzdWNjZXNz
IGV2ZW4gdGhvdWdoIGluc3RhbGwgaGFzIGZhaWxlZC4KKyAgICAgICAgVG8gd29ya2Fyb3VuZCB0
aGlzIGJ1Zywgd2UgYXR0ZW1wdCBhbiBhcHAgbGF1bmNoIGFmdGVyIGluc3RhbGwgdG8gZW5zdXJl
CisgICAgICAgIGluc3RhbGwgaGFzIHN1Y2NlZWRlZC4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi
a2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5OgorICAgICAgICAoRGV2aWNlLmluc3RhbGxfYXBwKTog
QXR0ZW1wdCBhcHAgbGF1bmNoIGFmdGVyIGluc3RhbGwsIHJldHJ5IGluc3RhbGwgaWYgbGF1bmNo
IGZhaWxzLgorICAgICAgICAoRGV2aWNlLmxhdW5jaF9hcHApOiBDb3JyZWN0IGNvbW1lbnQuCisK
IDIwMTctMDEtMzEgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAg
ICAgIFVucmV2aWV3ZWQgd2Via2l0cHkgZml4IGFmdGVyIHIyMTE0MDUuCkluZGV4OiBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T
Y3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkocmV2aXNpb24gMjExNDQ1KQorKysg
VG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHdvcmtpbmcgY29weSkK
QEAgLTI2NCw5ICsyNjQsMjUgQEAgY2xhc3MgRGV2aWNlKG9iamVjdCk6CiAgICAgICAgICAgICBy
YWlzZSBSdW50aW1lRXJyb3IoJyJ4Y3J1biBzaW1jdGwgZXJhc2UiIGZhaWxlZDogZGV2aWNlIHN0
YXRlIGlzIHt9Jy5mb3JtYXQoU2ltdWxhdG9yLmRldmljZV9zdGF0ZSh1ZGlkKSkpCiAKICAgICBk
ZWYgaW5zdGFsbF9hcHAoc2VsZiwgYXBwX3BhdGgpOgotICAgICAgICByZXR1cm4gbm90IHNlbGYu
X2hvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsneGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwn
LCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQorICAgICAgICAj
IEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzMwMjczOTcz
PiwgUmFjZXkgZmFpbHVyZSBvZiBzaW1jdGwgbGF1bmNoLgorICAgICAgICBmb3IgeCBpbiB4cmFu
Z2UoMyk6CisgICAgICAgICAgICBpZiBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChb
J3hjcnVuJywgJ3NpbWN0bCcsICdpbnN0YWxsJywgc2VsZi51ZGlkLCBhcHBfcGF0aF0sIHJldHVy
bl9leGl0X2NvZGU9VHJ1ZSk6CisgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgICAgIHRy
eToKKyAgICAgICAgICAgICAgICBidW5kbGVfaWQgPSBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5ydW5f
Y29tbWFuZChbCisgICAgICAgICAgICAgICAgICAgICcvdXNyL2xpYmV4ZWMvUGxpc3RCdWRkeScs
CisgICAgICAgICAgICAgICAgICAgICctYycsCisgICAgICAgICAgICAgICAgICAgICdQcmludCBD
RkJ1bmRsZUlkZW50aWZpZXInLAorICAgICAgICAgICAgICAgICAgICBzZWxmLl9ob3N0LmZpbGVz
eXN0ZW0uam9pbihhcHBfcGF0aCwgJ0luZm8ucGxpc3QnKSwKKyAgICAgICAgICAgICAgICBdKS5y
c3RyaXAoKQorICAgICAgICAgICAgICAgIHBpZCA9IHNlbGYubGF1bmNoX2FwcChidW5kbGVfaWQs
IFtdLCBhdHRlbXB0cz0xKQorICAgICAgICAgICAgICAgIHNlbGYuX2hvc3QuZXhlY3V0aXZlLmtp
bGxfcHJvY2VzcyhwaWQpCisgICAgICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgICAg
IGV4Y2VwdCBSdW50aW1lRXJyb3I6CisgICAgICAgICAgICAgICAgcGFzcworICAgICAgICByZXR1
cm4gRmFsc2UKIAotICAgIGRlZiBsYXVuY2hfYXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52
PU5vbmUpOgorICAgIGRlZiBsYXVuY2hfYXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52PU5v
bmUsIGF0dGVtcHRzPTMpOgogICAgICAgICBlbnZpcm9ubWVudF90b191c2UgPSB7fQogICAgICAg
ICBTSU1DVExfRU5WX1BSRUZJWCA9ICdTSU1DVExfQ0hJTERfJwogICAgICAgICBmb3IgdmFsdWUg
aW4gKGVudiBvciB7fSk6CkBAIC0yNzUsMTIgKzI5MSwxMiBAQCBjbGFzcyBEZXZpY2Uob2JqZWN0
KToKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgZW52aXJvbm1lbnRfdG9fdXNl
W3ZhbHVlXSA9IGVudlt2YWx1ZV0KIAotICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fy
b3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzMwMjczOTczPiwgUmFjZXkgZmFpbHVyZSBvZiBzaW1j
dGwgbGF1bmNoLgorICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJk
YXI6Ly9wcm9ibGVtLzMwMTcyNDUzPgogICAgICAgICBkZWYgX2xvZ19kZWJ1Z19lcnJvcihlcnJv
cik6CiAgICAgICAgICAgICBfbG9nLmRlYnVnKGVycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKSkK
IAogICAgICAgICBvdXRwdXQgPSBOb25lCi0gICAgICAgIGZvciB4IGluIHhyYW5nZSgzKToKKyAg
ICAgICAgZm9yIHggaW4geHJhbmdlKGF0dGVtcHRzKToKICAgICAgICAgICAgIG91dHB1dCA9IHNl
bGYuX2hvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKAogICAgICAgICAgICAgICAgIFsneGNydW4n
LCAnc2ltY3RsJywgJ2xhdW5jaCcsIHNlbGYudWRpZCwgYnVuZGxlX2lkXSArIGFyZ3MsCiAgICAg
ICAgICAgICAgICAgZW52PWVudmlyb25tZW50X3RvX3VzZSwK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300266</attachid>
            <date>2017-01-31 15:00:19 -0800</date>
            <delta_ts>2017-01-31 15:38:28 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-167654-20170131145808.patch</filename>
            <type>text/plain</type>
            <size>3148</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMTQ0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBXb3JrYXJvdW5kIGZvciBzaW1jdGwgaW5zdGFsbCBmYWlsaW5nIHRvIHJl
cG9ydCBpbnN0YWxsIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2NzY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhbiBCYXRlcy4KKwor
ICAgICAgICBzaW1jdGwgaW5zdGFsbCB3aWxsIHNvbWV0aW1lcyByZXBvcnQgc3VjY2VzcyBldmVu
IHRob3VnaCBpbnN0YWxsIGhhcyBmYWlsZWQuCisgICAgICAgIFRvIHdvcmthcm91bmQgdGhpcyBi
dWcsIHdlIGF0dGVtcHQgYW4gYXBwIGxhdW5jaCBhZnRlciBpbnN0YWxsIHRvIGVuc3VyZQorICAg
ICAgICBpbnN0YWxsIGhhcyBzdWNjZWVkZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5
L3hjb2RlL3NpbXVsYXRvci5weToKKyAgICAgICAgKERldmljZS5pbnN0YWxsX2FwcCk6IEF0dGVt
cHQgYXBwIGxhdW5jaCBhZnRlciBpbnN0YWxsLCByZXRyeSBpbnN0YWxsIGlmIGxhdW5jaCBmYWls
cy4KKyAgICAgICAgKERldmljZS5sYXVuY2hfYXBwKTogQ29ycmVjdCBjb21tZW50LgorCiAyMDE3
LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBV
bnJldmlld2VkIHdlYmtpdHB5IGZpeCBhZnRlciByMjExNDA1LgpJbmRleDogVG9vbHMvU2NyaXB0
cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0
cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9uIDIxMTQ0NSkKKysrIFRvb2xz
L1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0y
NjQsOSArMjY0LDI0IEBAIGNsYXNzIERldmljZShvYmplY3QpOgogICAgICAgICAgICAgcmFpc2Ug
UnVudGltZUVycm9yKCcieGNydW4gc2ltY3RsIGVyYXNlIiBmYWlsZWQ6IGRldmljZSBzdGF0ZSBp
cyB7fScuZm9ybWF0KFNpbXVsYXRvci5kZXZpY2Vfc3RhdGUodWRpZCkpKQogCiAgICAgZGVmIGlu
c3RhbGxfYXBwKHNlbGYsIGFwcF9wYXRoKToKLSAgICAgICAgcmV0dXJuIG5vdCBzZWxmLl9ob3N0
LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ3NpbWN0bCcsICdpbnN0YWxsJywgc2Vs
Zi51ZGlkLCBhcHBfcGF0aF0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkKKyAgICAgICAgIyBGSVhN
RTogVGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8zMDI3Mzk3Mz4sIFJh
Y2V5IGZhaWx1cmUgb2Ygc2ltY3RsIGluc3RhbGwuCisgICAgICAgIGZvciB4IGluIHhyYW5nZSgz
KToKKyAgICAgICAgICAgIGlmIHNlbGYuX2hvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsneGNy
dW4nLCAnc2ltY3RsJywgJ2luc3RhbGwnLCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJuX2V4
aXRfY29kZT1UcnVlKToKKyAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAgICAg
IHRyeToKKyAgICAgICAgICAgICAgICBidW5kbGVfaWQgPSBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5y
dW5fY29tbWFuZChbCisgICAgICAgICAgICAgICAgICAgICcvdXNyL2xpYmV4ZWMvUGxpc3RCdWRk
eScsCisgICAgICAgICAgICAgICAgICAgICctYycsCisgICAgICAgICAgICAgICAgICAgICdQcmlu
dCBDRkJ1bmRsZUlkZW50aWZpZXInLAorICAgICAgICAgICAgICAgICAgICBzZWxmLl9ob3N0LmZp
bGVzeXN0ZW0uam9pbihhcHBfcGF0aCwgJ0luZm8ucGxpc3QnKSwKKyAgICAgICAgICAgICAgICBd
KS5yc3RyaXAoKQorICAgICAgICAgICAgICAgIHNlbGYuX2hvc3QuZXhlY3V0aXZlLmtpbGxfcHJv
Y2VzcyhzZWxmLmxhdW5jaF9hcHAoYnVuZGxlX2lkLCBbXSwgYXR0ZW1wdHM9MSkpCisgICAgICAg
ICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgICAgIGV4Y2VwdCBSdW50aW1lRXJyb3I6Cisg
ICAgICAgICAgICAgICAgcGFzcworICAgICAgICByZXR1cm4gRmFsc2UKIAotICAgIGRlZiBsYXVu
Y2hfYXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52PU5vbmUpOgorICAgIGRlZiBsYXVuY2hf
YXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52PU5vbmUsIGF0dGVtcHRzPTMpOgogICAgICAg
ICBlbnZpcm9ubWVudF90b191c2UgPSB7fQogICAgICAgICBTSU1DVExfRU5WX1BSRUZJWCA9ICdT
SU1DVExfQ0hJTERfJwogICAgICAgICBmb3IgdmFsdWUgaW4gKGVudiBvciB7fSk6CkBAIC0yNzUs
MTIgKzI5MCwxMiBAQCBjbGFzcyBEZXZpY2Uob2JqZWN0KToKICAgICAgICAgICAgIGVsc2U6CiAg
ICAgICAgICAgICAgICAgZW52aXJvbm1lbnRfdG9fdXNlW3ZhbHVlXSA9IGVudlt2YWx1ZV0KIAot
ICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVt
LzMwMjczOTczPiwgUmFjZXkgZmFpbHVyZSBvZiBzaW1jdGwgbGF1bmNoLgorICAgICAgICAjIEZJ
WE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzMwMTcyNDUzPi4K
ICAgICAgICAgZGVmIF9sb2dfZGVidWdfZXJyb3IoZXJyb3IpOgogICAgICAgICAgICAgX2xvZy5k
ZWJ1ZyhlcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCiAKICAgICAgICAgb3V0cHV0ID0gTm9u
ZQotICAgICAgICBmb3IgeCBpbiB4cmFuZ2UoMyk6CisgICAgICAgIGZvciB4IGluIHhyYW5nZShh
dHRlbXB0cyk6CiAgICAgICAgICAgICBvdXRwdXQgPSBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5ydW5f
Y29tbWFuZCgKICAgICAgICAgICAgICAgICBbJ3hjcnVuJywgJ3NpbWN0bCcsICdsYXVuY2gnLCBz
ZWxmLnVkaWQsIGJ1bmRsZV9pZF0gKyBhcmdzLAogICAgICAgICAgICAgICAgIGVudj1lbnZpcm9u
bWVudF90b191c2UsCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>300274</attachid>
            <date>2017-01-31 15:38:31 -0800</date>
            <delta_ts>2017-01-31 16:17:09 -0800</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-167654-20170131153620.patch</filename>
            <type>text/plain</type>
            <size>3151</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIxMTQ0NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE4IEBACisyMDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBXb3JrYXJvdW5kIGZvciBzaW1jdGwgaW5zdGFsbCBmYWlsaW5nIHRvIHJl
cG9ydCBpbnN0YWxsIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2NzY1NAorCisgICAgICAgIFJldmlld2VkIGJ5IERhbmllbCBCYXRlcy4K
KworICAgICAgICBzaW1jdGwgaW5zdGFsbCB3aWxsIHNvbWV0aW1lcyByZXBvcnQgc3VjY2VzcyBl
dmVuIHRob3VnaCBpbnN0YWxsIGhhcyBmYWlsZWQuCisgICAgICAgIFRvIHdvcmthcm91bmQgdGhp
cyBidWcsIHdlIGF0dGVtcHQgYW4gYXBwIGxhdW5jaCBhZnRlciBpbnN0YWxsIHRvIGVuc3VyZQor
ICAgICAgICBpbnN0YWxsIGhhcyBzdWNjZWVkZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp
dHB5L3hjb2RlL3NpbXVsYXRvci5weToKKyAgICAgICAgKERldmljZS5pbnN0YWxsX2FwcCk6IEF0
dGVtcHQgYXBwIGxhdW5jaCBhZnRlciBpbnN0YWxsLCByZXRyeSBpbnN0YWxsIGlmIGxhdW5jaCBm
YWlscy4KKyAgICAgICAgKERldmljZS5sYXVuY2hfYXBwKTogQ29ycmVjdCBjb21tZW50LgorCiAy
MDE3LTAxLTMxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg
ICBVbnJldmlld2VkIHdlYmtpdHB5IGZpeCBhZnRlciByMjExNDA1LgpJbmRleDogVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny
aXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3IucHkJKHJldmlzaW9uIDIxMTQ0NSkKKysrIFRv
b2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CSh3b3JraW5nIGNvcHkpCkBA
IC0yNjQsOSArMjY0LDI0IEBAIGNsYXNzIERldmljZShvYmplY3QpOgogICAgICAgICAgICAgcmFp
c2UgUnVudGltZUVycm9yKCcieGNydW4gc2ltY3RsIGVyYXNlIiBmYWlsZWQ6IGRldmljZSBzdGF0
ZSBpcyB7fScuZm9ybWF0KFNpbXVsYXRvci5kZXZpY2Vfc3RhdGUodWRpZCkpKQogCiAgICAgZGVm
IGluc3RhbGxfYXBwKHNlbGYsIGFwcF9wYXRoKToKLSAgICAgICAgcmV0dXJuIG5vdCBzZWxmLl9o
b3N0LmV4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3hjcnVuJywgJ3NpbWN0bCcsICdpbnN0YWxsJywg
c2VsZi51ZGlkLCBhcHBfcGF0aF0sIHJldHVybl9leGl0X2NvZGU9VHJ1ZSkKKyAgICAgICAgIyBG
SVhNRTogVGhpcyBpcyBhIHdvcmthcm91bmQgZm9yIDxyZGFyOi8vcHJvYmxlbS8zMDI3Mzk3Mz4s
IFJhY2V5IGZhaWx1cmUgb2Ygc2ltY3RsIGluc3RhbGwuCisgICAgICAgIGZvciB4IGluIHhyYW5n
ZSgzKToKKyAgICAgICAgICAgIGlmIHNlbGYuX2hvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsn
eGNydW4nLCAnc2ltY3RsJywgJ2luc3RhbGwnLCBzZWxmLnVkaWQsIGFwcF9wYXRoXSwgcmV0dXJu
X2V4aXRfY29kZT1UcnVlKToKKyAgICAgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAg
ICAgIHRyeToKKyAgICAgICAgICAgICAgICBidW5kbGVfaWQgPSBzZWxmLl9ob3N0LmV4ZWN1dGl2
ZS5ydW5fY29tbWFuZChbCisgICAgICAgICAgICAgICAgICAgICcvdXNyL2xpYmV4ZWMvUGxpc3RC
dWRkeScsCisgICAgICAgICAgICAgICAgICAgICctYycsCisgICAgICAgICAgICAgICAgICAgICdQ
cmludCBDRkJ1bmRsZUlkZW50aWZpZXInLAorICAgICAgICAgICAgICAgICAgICBzZWxmLl9ob3N0
LmZpbGVzeXN0ZW0uam9pbihhcHBfcGF0aCwgJ0luZm8ucGxpc3QnKSwKKyAgICAgICAgICAgICAg
ICBdKS5yc3RyaXAoKQorICAgICAgICAgICAgICAgIHNlbGYuX2hvc3QuZXhlY3V0aXZlLmtpbGxf
cHJvY2VzcyhzZWxmLmxhdW5jaF9hcHAoYnVuZGxlX2lkLCBbXSwgYXR0ZW1wdHM9MSkpCisgICAg
ICAgICAgICAgICAgcmV0dXJuIFRydWUKKyAgICAgICAgICAgIGV4Y2VwdCBSdW50aW1lRXJyb3I6
CisgICAgICAgICAgICAgICAgcGFzcworICAgICAgICByZXR1cm4gRmFsc2UKIAotICAgIGRlZiBs
YXVuY2hfYXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52PU5vbmUpOgorICAgIGRlZiBsYXVu
Y2hfYXBwKHNlbGYsIGJ1bmRsZV9pZCwgYXJncywgZW52PU5vbmUsIGF0dGVtcHRzPTMpOgogICAg
ICAgICBlbnZpcm9ubWVudF90b191c2UgPSB7fQogICAgICAgICBTSU1DVExfRU5WX1BSRUZJWCA9
ICdTSU1DVExfQ0hJTERfJwogICAgICAgICBmb3IgdmFsdWUgaW4gKGVudiBvciB7fSk6CkBAIC0y
NzUsMTIgKzI5MCwxMiBAQCBjbGFzcyBEZXZpY2Uob2JqZWN0KToKICAgICAgICAgICAgIGVsc2U6
CiAgICAgICAgICAgICAgICAgZW52aXJvbm1lbnRfdG9fdXNlW3ZhbHVlXSA9IGVudlt2YWx1ZV0K
IAotICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9i
bGVtLzMwMjczOTczPiwgUmFjZXkgZmFpbHVyZSBvZiBzaW1jdGwgbGF1bmNoLgorICAgICAgICAj
IEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgPHJkYXI6Ly9wcm9ibGVtLzMwMTcyNDUz
Pi4KICAgICAgICAgZGVmIF9sb2dfZGVidWdfZXJyb3IoZXJyb3IpOgogICAgICAgICAgICAgX2xv
Zy5kZWJ1ZyhlcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCiAKICAgICAgICAgb3V0cHV0ID0g
Tm9uZQotICAgICAgICBmb3IgeCBpbiB4cmFuZ2UoMyk6CisgICAgICAgIGZvciB4IGluIHhyYW5n
ZShhdHRlbXB0cyk6CiAgICAgICAgICAgICBvdXRwdXQgPSBzZWxmLl9ob3N0LmV4ZWN1dGl2ZS5y
dW5fY29tbWFuZCgKICAgICAgICAgICAgICAgICBbJ3hjcnVuJywgJ3NpbWN0bCcsICdsYXVuY2gn
LCBzZWxmLnVkaWQsIGJ1bmRsZV9pZF0gKyBhcmdzLAogICAgICAgICAgICAgICAgIGVudj1lbnZp
cm9ubWVudF90b191c2UsCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>