167642 2017-01-31 07:18:45 -0800 Compilation error in JSArrayBufferView.h 2017-01-31 08:53:38 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela commit-queue fpizlo keith_miller mark.lam mcatanzaro msaboff saam oldest_to_newest 1271702 0 tpopela 2017-01-31 07:18:45 -0800 In file included from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayViewInlines.h:33:0, from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/API/JSTypedArray.cpp:37: /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h: In member function 'const typename Adaptor::Type* JSC::JSGenericTypedArrayView<Adaptor>::typedVector() const': /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:119:67: error: no matching function for call to 'JSC::JSGenericTypedArrayView<Adaptor>::vector() const' return bitwise_cast<const typename Adaptor::Type*>(vector()); ^ In file included from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferViewInlines.h:29:0, from /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/API/JSTypedArray.cpp:34: /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferView.h:170:11: note: candidate: void* JSC::JSArrayBufferView::vector() <nearmatch> void* vector() { return m_vector.get(); } ^~~~~~ /builddir/build/BUILD/webkitgtk-2.15.4/Source/JavaScriptCore/runtime/JSArrayBufferView.h:170:11: note: passing 'const JSC::JSGenericTypedArrayView<Adaptor>*' as 'this' argument discards qualifiers 1271703 1 300218 tpopela 2017-01-31 07:20:30 -0800 Created attachment 300218 Patch 1271717 2 mcatanzaro 2017-01-31 07:53:06 -0800 No clue whether this is a WebKit bug or a GCC 7 bug. 1271731 3 300218 achristensen 2017-01-31 08:51:15 -0800 Comment on attachment 300218 Patch const should definitely be there 1271732 4 300218 tpopela 2017-01-31 08:53:29 -0800 Comment on attachment 300218 Patch Clearing flags on attachment: 300218 Committed r211434: <http://trac.webkit.org/changeset/211434> 1271733 5 tpopela 2017-01-31 08:53:38 -0800 All reviewed patches have been landed. Closing bug. 300218 2017-01-31 07:20:30 -0800 2017-01-31 08:53:29 -0800 Patch bug-167642-20170131161819.patch text/plain 1324 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjExNDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj YmQwMDA3N2I0ZjBiY2UzNDVkYWE3OWQ1MGZhMDgwNmQ4Y2Q3NmY3Li41MGVkNmZkZTZmNTc4NDgz ZTkzOTQ0YmZiOTA5NGIwNTg4MzU3YjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNy0wMS0zMSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgorCisgICAgICAgIENvbXBpbGF0aW9uIGVycm9yIGluIEpTQXJyYXlCdWZmZXJWaWV3LmgKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzY0MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9K U0FycmF5QnVmZmVyVmlldy5oOgorICAgICAgICAoSlNDOjpKU0FycmF5QnVmZmVyVmlldzo6dmVj dG9yKToKKwogMjAxNy0wMS0zMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNv bT4KIAogICAgICAgICBbSlNDXSBEbyBub3QgcmVqZWN0IFdlYkFzc2VtYmx5LmNvbXBpbGUoKSB3 aXRoIEV4Y2VwdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNBcnJheUJ1ZmZlclZpZXcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJy YXlCdWZmZXJWaWV3LmgKaW5kZXggOGU4OTMzOTU4Y2JkYTBkYWRiYWVjY2IxYmE1MWJjMDcxNzI2 M2MyZS4uN2U1MWQ1MWRiZWIxZjExNGQ3MjcyODRhODBiOGJiNTEyNWQwYWU4YyAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheUJ1ZmZlclZpZXcuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5QnVmZmVyVmlldy5oCkBAIC0x NjcsNyArMTY3LDcgQEAgcHVibGljOgogICAgIGJvb2wgaXNOZXV0ZXJlZCgpIHsgcmV0dXJuIGhh c0FycmF5QnVmZmVyKCkgJiYgIXZlY3RvcigpOyB9CiAgICAgdm9pZCBuZXV0ZXIoKTsKICAgICAK LSAgICB2b2lkKiB2ZWN0b3IoKSB7IHJldHVybiBtX3ZlY3Rvci5nZXQoKTsgfQorICAgIHZvaWQq IHZlY3RvcigpIGNvbnN0IHsgcmV0dXJuIG1fdmVjdG9yLmdldCgpOyB9CiAgICAgCiAgICAgdW5z aWduZWQgYnl0ZU9mZnNldCgpOwogICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJu IG1fbGVuZ3RoOyB9Cg==