167594 2017-01-30 09:55:29 -0800 [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out 2017-04-21 15:56:17 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=170496 InRadar P2 Normal --- 161967 1 ryanhaddad aestes aestes ap mitz webkit-bug-importer oldest_to_newest 1271290 0 ryanhaddad 2017-01-30 09:55:29 -0800 [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20%28Tests%29/builds/3262 1271293 1 ryanhaddad 2017-01-30 10:02:16 -0800 Test was added with https://trac.webkit.org/changeset/211354 1271299 2 mitz 2017-01-30 10:09:18 -0800 The test passes for me in the iOS Simulator. Not sure what’s going on. 1271363 3 ryanhaddad 2017-01-30 12:15:12 -0800 (In reply to comment #2) > The test passes for me in the iOS Simulator. Not sure what’s going on. This is making the bots red, so I'd like to roll out if necessary. 1271372 4 mitz 2017-01-30 12:27:15 -0800 If possible, I’d just disable the test. 1271374 5 mitz 2017-01-30 12:27:43 -0800 Ryan, are you able to reproduce this locally? 1271438 6 webkit-bug-importer 2017-01-30 15:25:24 -0800 <rdar://problem/30274363> 1272026 7 ryanhaddad 2017-01-31 19:57:57 -0800 Disabled test in http://trac.webkit.org/projects/webkit/changeset/211467. 1272031 8 mitz 2017-01-31 20:28:47 -0800 On a computer that’s reproducing this failure, I see that the Web Content process is crashing with this backtrace: * frame #0: 0x000000010d113569 CoreFoundation`CFStringGetLength + 9 frame #1: 0x0000000123a611bd DataDetectorsCore`_typesAreEqual + 43 frame #2: 0x0000000123a613e4 DataDetectorsCore`_DDResultTypeIsAnyPhoneKind + 22 frame #3: 0x0000000123a61341 DataDetectorsCore`_DDGetRelevantResultsForUrlificationRange + 28 frame #4: 0x0000000123a61432 DataDetectorsCore`DDResultGetQueryRangeForURLification + 25 frame #5: 0x000000011538ac23 WebCore`WebCore::softLink_DataDetectorsCore_DDResultGetQueryRangeForURLification(result=0x00007fb1ab10acc0) + 35 at DataDetectorsCoreSoftLink.h:49 frame #6: 0x0000000115388411 WebCore`WebCore::DataDetection::detectContentInRange(contextRange=0x00007fff56249be8, types=DataDetectorTypeAll, context=0x00007fb1ab0009c0) + 5569 at DataDetection.mm:536 1272033 9 mitz 2017-01-31 20:49:09 -0800 The crash seems to happen because we somehow mangle the value passed to DDResultGetQueryRangeForURLification. It is not the value of result seen in frame #5 above. Perhaps something about the “soft linking” code or the forward declarations used when not using the Apple Internal SDK is causing it. 1294404 10 mitz 2017-04-04 23:24:45 -0700 Looks like Andy found the cause in bug 170496. 1294412 11 aestes 2017-04-04 23:41:45 -0700 *** Bug 170496 has been marked as a duplicate of this bug. *** 1294415 12 306265 aestes 2017-04-04 23:49:08 -0700 Created attachment 306265 Patch 1294418 13 306265 aestes 2017-04-05 00:08:17 -0700 Comment on attachment 306265 Patch Nevermind, this is just gardening. No need for a review. 1294423 14 aestes 2017-04-05 00:40:45 -0700 Committed r214933: <https://trac.webkit.org/r214933> 1295395 15 ryanhaddad 2017-04-07 11:11:21 -0700 This test is still timing out on the bots: https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/501 1295466 16 ryanhaddad 2017-04-07 13:13:03 -0700 I disabled test again in https://trac.webkit.org/changeset/215112/webkit 1297486 17 aestes 2017-04-14 13:35:14 -0700 Committed r215372: <https://trac.webkit.org/changeset/215372> 1297742 18 ap 2017-04-16 00:19:09 -0700 What was the new fix after 2017-04-07? 1297967 19 aestes 2017-04-17 12:07:38 -0700 (In reply to Alexey Proskuryakov from comment #18) > What was the new fix after 2017-04-07? See bug #161967 1299955 20 ryanhaddad 2017-04-21 15:48:23 -0700 This API test is still a flaky timeout. 1299960 21 ryanhaddad 2017-04-21 15:56:17 -0700 Disabled test in http://trac.webkit.org/projects/webkit/changeset/215651 306265 2017-04-04 23:49:08 -0700 2017-04-05 00:40:12 -0700 Patch bug-167594-20170404234908.patch text/plain 1603 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODM5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDU2ZTc0ZDI1OGZlZjIxZWVmZTk1ODA2MmZhODk2ZTEz M2NhMzU0Ni4uOTM4NjlmN2E3ZWVlMzU1Y2FhNzBjYTEyZjFhOTA1ZTYzNzA1YmYzNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA0LTA0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAg ICBbaW9zLXNpbXVsYXRvcl0gQVBJIHRlc3QgV2ViS2l0Mi5XS1dlYlByb2Nlc3NQbHVnSW5SYW5n ZUhhbmRsZSB0aW1pbmcgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjc1OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZS1lbmFibGVkIHRoaXMgQVBJIHRlc3Qgbm93IHRoYXQgd2Via2l0Lm9yZy9i LzE2MTk2NyBpcyBmaXhlZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 MkNvY29hL0J1bmRsZVJhbmdlSGFuZGxlLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMTctMDQt MDMgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgcnVuLXNhZmFyaSBz aG91bGQgc3VwcG9ydCBsYXVuY2hpbmcgd2l0aCBjdXN0b20gbGFuZ3VhZ2UgYW5kIGxvY2FsZQpk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvQnVuZGxl UmFuZ2VIYW5kbGUubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9C dW5kbGVSYW5nZUhhbmRsZS5tbQppbmRleCAwZDQ1ZDZmZjNlMDUxMDhlMzNiMTA2NjAwYjY2MGNk NjU5M2IxOWEzLi42MDk5OGY5MzIyY2FhY2ZlYzZjZjM4MjU2MzdiNjhkMTA2ODUzMmJmIDEwMDY0 NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9CdW5kbGVSYW5n ZUhhbmRsZS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9C dW5kbGVSYW5nZUhhbmRsZS5tbQpAQCAtNjEsNyArNjEsNyBAQCAtICh2b2lkKWJvZHlJbm5lckhU TUxBZnRlckRldGVjdGluZ0RhdGE6KE5TU3RyaW5nICopdGV4dAogCiBAZW5kCiAKLVRFU1QoV2Vi S2l0MiwgRElTQUJMRURfV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5kbGUpCitURVNUKFdlYktp dDIsIFdLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxlKQogewogICAgIFJldGFpblB0cjxXS1dl YlZpZXdDb25maWd1cmF0aW9uPiBjb25maWd1cmF0aW9uID0gcmV0YWluUHRyKFtXS1dlYlZpZXdD b25maWd1cmF0aW9uIHRlc3R3ZWJraXRhcGlfY29uZmlndXJhdGlvbldpdGhUZXN0UGx1Z0luQ2xh c3NOYW1lOkAiQnVuZGxlUmFuZ2VIYW5kbGVQbHVnSW4iXSk7CiAgICAgUmV0YWluUHRyPFdLV2Vi Vmlldz4gd2ViVmlldyA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6 TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdl dCgpXSk7Cg==