167584 2017-01-30 05:27:40 -0800 Allow to use stored credentials also for downloads started by DownloadManager::startDownload 2017-02-14 05:10:17 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167583 Gtk P2 Normal --- 1 cgarcia webkit-unassigned achristensen bugs-noreply calvaris mcatanzaro oldest_to_newest 1271228 0 cgarcia 2017-01-30 05:27:40 -0800 I don't know why this is the default in other ports, but I don't think it's what we want in GTK+. 1271229 1 300100 cgarcia 2017-01-30 05:39:24 -0800 Created attachment 300100 Patch 1271234 2 300100 mcatanzaro 2017-01-30 06:24:30 -0800 Comment on attachment 300100 Patch r=me but please ask Alex Christensen before landing if you can do this cross-platform. Either this must be broken on Mac too, or he might have a different suggestion. 1271577 3 cgarcia 2017-01-30 22:04:42 -0800 (In reply to comment #2) > Comment on attachment 300100 [details] > Patch > > r=me but please ask Alex Christensen before landing if you can do this > cross-platform. Either this must be broken on Mac too, or he might have a > different suggestion. Alex? :-) 1272237 4 300100 achristensen 2017-02-01 12:49:43 -0800 Comment on attachment 300100 Patch This should definitely have a test. If we allow stored credentials in an ephemeral session, won't it just use the credentials in the CredentialStorage for that session? 1272386 5 cgarcia 2017-02-01 22:24:44 -0800 (In reply to comment #4) > Comment on attachment 300100 [details] > Patch > > This should definitely have a test. If we allow stored credentials in an > ephemeral session, won't it just use the credentials in the > CredentialStorage for that session? But we don't allow it. The patch allows stored credentials only for the default session, the problem is that PendingDownload is created with the default parameter for allow stored credentials unconditionally, which is to no allow them. 1273992 6 mcatanzaro 2017-02-07 08:01:12 -0800 So this is good then...? 1276625 7 300100 achristensen 2017-02-13 23:55:29 -0800 Comment on attachment 300100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300100&action=review > Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp:64 > +#if PLATFORM(GTK) > + // The GTK+ port wants to allow using stored credentials also for pending downloads. > + parameters.allowStoredCredentials = sessionID.isEphemeral() ? DoNotAllowStoredCredentials : AllowStoredCredentials; > +#endif Let's make this the case on all ports. 1276688 8 cgarcia 2017-02-14 05:10:17 -0800 Committed r212291: <http://trac.webkit.org/changeset/212291> 300100 2017-01-30 05:39:24 -0800 2017-01-30 06:24:30 -0800 Patch wk2-download-auth.diff text/plain 2179 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYmM3MmI0MzU4Mi4uZTJiODFmMTg2YjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNy0wMS0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gQWxsb3cgdG8gdXNlIHN0b3JlZCBjcmVkZW50aWFs cyBhbHNvIGZvciBkb3dubG9hZHMgc3RhcnRlZCBieSBEb3dubG9hZE1hbmFnZXI6OnN0YXJ0RG93 bmxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NzU4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENs aWtpbmcgb24gYSBsaW5rIHRoYXQgdHJpZ2dlcnMgYSBkb3dubG9hZCB3b3JrcyBvbiBhbiBhbHJl YWR5IEhUVFAgYXV0aGVudGljYXRlZCBzaXRlIHdvcmtzLCBidXQgcmlnaHQgY2xpY2tpbmcKKyAg ICAgICAgYW5kIGRvd25sb2FkaW5nIGZyb20gdGhlIGNvbnRleHQgbWVudSBzaG93cyB0aGUgSFRU UCBhdXRoIGRpYWxvZyBhZ2Fpbi4gVGhpcyBpcyBiZWNhdXNlIFBlbmRpbmdEb3dubG9hZCB1c2Vz CisgICAgICAgIERvTm90QWxsb3dTdG9yZWRDcmVkZW50aWFscyB1bmNvbmRpdGlvbmFsbHkuIFdF IHdhbnQgdG8gYWxsb3cgdXNpbmcgY2FjaGVkIGNyZWRlbnRpYWxzIGF0IGxlYXN0IGZvcgorICAg ICAgICBub24tZXBoZW1lcmFsIHNlc3Npb25zLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv RG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2Fk TWFuYWdlcjo6c3RhcnREb3dubG9hZCk6CisKKzIwMTctMDEtMzAgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEhUVFAgYXV0aGVudGlj YXRpb24gaXMgbm90IGltcGxlbWVudGVkIGZvciBkb3dubG9hZHMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzU4MwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRNYW5hZ2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZE1hbmFnZXIu Y3BwCmluZGV4IDEyZmMxYmQ5MjcwLi44N2MwMzU4ZDA4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkTWFuYWdlci5j cHAKQEAgLTU4LDYgKzU4LDEwIEBAIHZvaWQgRG93bmxvYWRNYW5hZ2VyOjpzdGFydERvd25sb2Fk KE5ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzKiBjb25uZWN0aW9uLCBTCiAgICAgcGFyYW1l dGVycy5jbGllbnRDcmVkZW50aWFsUG9saWN5ID0gQ2xpZW50Q3JlZGVudGlhbFBvbGljeTo6TWF5 QXNrQ2xpZW50Rm9yQ3JlZGVudGlhbHM7CiAgICAgaWYgKHJlcXVlc3QudXJsKCkucHJvdG9jb2xJ c0Jsb2IoKSAmJiBjb25uZWN0aW9uKQogICAgICAgICBwYXJhbWV0ZXJzLmJsb2JGaWxlUmVmZXJl bmNlcyA9IE5ldHdvcmtCbG9iUmVnaXN0cnk6OnNpbmdsZXRvbigpLmZpbGVzSW5CbG9iKCpjb25u ZWN0aW9uLCByZXF1ZXN0LnVybCgpKTsKKyNpZiBQTEFURk9STShHVEspCisgICAgLy8gVGhlIEdU SysgcG9ydCB3YW50cyB0byBhbGxvdyB1c2luZyBzdG9yZWQgY3JlZGVudGlhbHMgYWxzbyBmb3Ig cGVuZGluZyBkb3dubG9hZHMuCisgICAgcGFyYW1ldGVycy5hbGxvd1N0b3JlZENyZWRlbnRpYWxz ID0gc2Vzc2lvbklELmlzRXBoZW1lcmFsKCkgPyBEb05vdEFsbG93U3RvcmVkQ3JlZGVudGlhbHMg OiBBbGxvd1N0b3JlZENyZWRlbnRpYWxzOworI2VuZGlmCiAKICAgICBtX3BlbmRpbmdEb3dubG9h ZHMuYWRkKGRvd25sb2FkSUQsIHN0ZDo6bWFrZV91bmlxdWU8UGVuZGluZ0Rvd25sb2FkPihXVEZN b3ZlKHBhcmFtZXRlcnMpLCBkb3dubG9hZElELCAqbmV0d29ya1Nlc3Npb24sIHN1Z2dlc3RlZE5h bWUpKTsKICNlbHNlCg==