167583 2017-01-30 05:20:49 -0800 [GTK] HTTP authentication is not implemented for downloads 2017-02-03 00:07:19 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167584 https://bugzilla.gnome.org/show_bug.cgi?id=778061 Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply calvaris commit-queue danw gustavo mcatanzaro mrobinson oldest_to_newest 1271224 0 cgarcia 2017-01-30 05:20:49 -0800 When a normal load is converted to a download, the HTTP authentication happens before the load is converted, and the download startes already authenticated. However, downloads started by DownloadManager::startDownload use the DownloadClient API to do the authentication. We don't implement didReceiveAuthenticationChallenge() in our download client, what makes the load to be cancelled and then fail silently. We should probably add API to handle downloads authentication, but we can also forward the authentication to the web view for downloads havign a web view associated. That would cover most of the cases, like downloading from the context menu. 1271225 1 300099 cgarcia 2017-01-30 05:23:01 -0800 Created attachment 300099 Patch 1271226 2 commit-queue 2017-01-30 05:24:11 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1271227 3 cgarcia 2017-01-30 05:25:59 -0800 Note that this patch doesn't work because of a bug in libsoup, see https://bugzilla.gnome.org/show_bug.cgi?id=777936. Downloads do not allow using stored credentials by default. This matches safari behavior, but I don't think it's desired, it's quite weird that credentials are asked again when downloading something from the context menu, and even more that the HTTP auth dialog is not filled with the stored credentials. 1271235 4 300099 mcatanzaro 2017-01-30 06:27:43 -0800 Comment on attachment 300099 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300099&action=review > Source/WebKit2/ChangeLog:9 > + the download startes already authenticated. However, downloads started by DownloadManager::startDownload use the startes -> starts > Source/WebKit2/ChangeLog:12 > + handle downloads authentication, but we can also forward the authentication to the web view for downloads havign havign -> having 1271582 5 cgarcia 2017-01-30 22:29:11 -0800 Committed r211407: <http://trac.webkit.org/changeset/211407> 300099 2017-01-30 05:23:01 -0800 2017-01-30 06:27:43 -0800 Patch wk2-auth-downloads.diff text/plain 2851 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMDgzYzM3ODJkNC4uYmJjNzJiNDM1ODIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wMS0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gSFRUUCBhdXRoZW50aWNhdGlvbiBpcyBub3QgaW1w bGVtZW50ZWQgZm9yIGRvd25sb2FkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY3NTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiBhIG5vcm1hbCBsb2FkIGlzIGNvbnZlcnRlZCB0byBhIGRvd25s b2FkLCB0aGUgSFRUUCBhdXRoZW50aWNhdGlvbiBoYXBwZW5zIGJlZm9yZSB0aGUgbG9hZCBpcyBj b252ZXJ0ZWQsIGFuZAorICAgICAgICB0aGUgZG93bmxvYWQgc3RhcnRlcyBhbHJlYWR5IGF1dGhl bnRpY2F0ZWQuIEhvd2V2ZXIsIGRvd25sb2FkcyBzdGFydGVkIGJ5IERvd25sb2FkTWFuYWdlcjo6 c3RhcnREb3dubG9hZCB1c2UgdGhlCisgICAgICAgIERvd25sb2FkQ2xpZW50IEFQSSB0byBkbyB0 aGUgYXV0aGVudGljYXRpb24uIFdlIGRvbid0IGltcGxlbWVudCBkaWRSZWNlaXZlQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UoKSBpbiBvdXIKKyAgICAgICAgZG93bmxvYWQgY2xpZW50LCB3aGF0IG1h a2VzIHRoZSBsb2FkIHRvIGJlIGNhbmNlbGxlZCBhbmQgdGhlbiBmYWlsIHNpbGVudGx5LiBXZSBz aG91bGQgcHJvYmFibHkgYWRkIEFQSSB0bworICAgICAgICBoYW5kbGUgZG93bmxvYWRzIGF1dGhl bnRpY2F0aW9uLCBidXQgd2UgY2FuIGFsc28gZm9yd2FyZCB0aGUgYXV0aGVudGljYXRpb24gdG8g dGhlIHdlYiB2aWV3IGZvciBkb3dubG9hZHMgaGF2aWduCisgICAgICAgIGEgd2ViIHZpZXcgYXNz b2NpYXRlZC4gVGhhdCB3b3VsZCBjb3ZlciBtb3N0IG9mIHRoZSBjYXNlcywgbGlrZSBkb3dubG9h ZGluZyBmcm9tIHRoZSBjb250ZXh0IG1lbnUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXREb3dubG9hZENsaWVudC5jcHA6IEFkZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25D aGFsbGVuZ2UgaW1wbGVtZW50YXRpb24uCisKIDIwMTctMDEtMjkgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtUaHJlYWRlZCBDb21wb3NpdG9y XSBDcmFzaCBvbiBXZWJDb3JlOjpHTENvbnRleHQ6OnZlcnNpb24oKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWRDbGllbnQuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWRDbGllbnQuY3Bw CmluZGV4IDZmMGE2MzA1NTUwLi5lODMzOGJjOTdlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWRDbGllbnQuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkQ2xpZW50LmNwcApAQCAt MjQsNiArMjQsNyBAQAogI2luY2x1ZGUgIldlYktpdERvd25sb2FkUHJpdmF0ZS5oIgogI2luY2x1 ZGUgIldlYktpdFVSSVJlc3BvbnNlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdFdlYkNvbnRl eHRQcml2YXRlLmgiCisjaW5jbHVkZSAiV2ViS2l0V2ViVmlld1ByaXZhdGUuaCIKICNpbmNsdWRl ICJXZWJQcm9jZXNzUG9vbC5oIgogI2luY2x1ZGUgPFdlYktpdC9XS1N0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KQEAgLTQ2LDYgKzQ3LDE3IEBAIHByaXZhdGU6CiAgICAg ICAgIHdlYmtpdFdlYkNvbnRleHREb3dubG9hZFN0YXJ0ZWQobV93ZWJDb250ZXh0LCBkb3dubG9h ZC5nZXQoKSk7CiAgICAgfQogCisgICAgdm9pZCBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFs bGVuZ2UoV2ViUHJvY2Vzc1Bvb2wqLCBEb3dubG9hZFByb3h5KiBkb3dubG9hZFByb3h5LCBBdXRo ZW50aWNhdGlvbkNoYWxsZW5nZVByb3h5KiBhdXRoZW50aWNhdGlvbkNoYWxsZW5nZSkgb3ZlcnJp ZGUKKyAgICB7CisgICAgICAgIEdSZWZQdHI8V2ViS2l0RG93bmxvYWQ+IGRvd25sb2FkID0gd2Vi a2l0V2ViQ29udGV4dEdldE9yQ3JlYXRlRG93bmxvYWQoZG93bmxvYWRQcm94eSk7CisgICAgICAg IGlmICh3ZWJraXREb3dubG9hZElzQ2FuY2VsbGVkKGRvd25sb2FkLmdldCgpKSkKKyAgICAgICAg ICAgIHJldHVybjsKKworICAgICAgICAvLyBGSVhNRTogQWRkIEFQSSB0byBoYW5kbGUgYXV0aGVu dGljYXRpb24gb2YgZG93bmxvYWRzIHdpdGhvdXQgYSB3ZWIgdmlldyBhc3NvY2l0ZWQuCisgICAg ICAgIGlmIChhdXRvKiB3ZWJWaWV3ID0gd2Via2l0X2Rvd25sb2FkX2dldF93ZWJfdmlldyhkb3du bG9hZC5nZXQoKSkpCisgICAgICAgICAgICB3ZWJraXRXZWJWaWV3SGFuZGxlQXV0aGVudGljYXRp b25DaGFsbGVuZ2Uod2ViVmlldywgYXV0aGVudGljYXRpb25DaGFsbGVuZ2UpOworICAgIH0KKwog ICAgIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlKFdlYlByb2Nlc3NQb29sKiwgRG93bmxvYWRQcm94 eSogZG93bmxvYWRQcm94eSwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzb3VyY2VSZXNwb25z ZSkgb3ZlcnJpZGUKICAgICB7CiAgICAgICAgIEdSZWZQdHI8V2ViS2l0RG93bmxvYWQ+IGRvd25s b2FkID0gd2Via2l0V2ViQ29udGV4dEdldE9yQ3JlYXRlRG93bmxvYWQoZG93bmxvYWRQcm94eSk7 Cg==