167578 2017-01-30 02:06:37 -0800 [css-grid] Enable CSS Grid Layout by default 2017-01-31 01:25:20 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego cgarcia commit-queue darin jfernandez mcatanzaro svillar oldest_to_newest 1271207 0 rego 2017-01-30 02:06:37 -0800 Now that Safari 10.1 is shipping CSS Grid Layout it seems safe to enable the feature by default: https://developer.apple.com/library/prerelease/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html 1271209 1 300092 rego 2017-01-30 02:07:48 -0800 Created attachment 300092 Patch 1271236 2 300092 mcatanzaro 2017-01-30 06:33:52 -0800 Comment on attachment 300092 Patch \o/ But you forgot a part: Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.[h,cpp]. You have to remove CSS grid layout from the settings array as well, since it's no longer experimental. But then we would have no more experimental features covered by this file, so it makes sense to remove the entire file. You could do this in a separate patch, but we should land them at the same time. I wanted to remove it anyway because it needs to be rewritten to use the enumerable experimental features API, so it covers all experimental features instead of just being one more place they have to be hardcoded, and I don't think it makes sense to keep it around in the meantime. 1271250 3 rego 2017-01-30 07:33:14 -0800 (In reply to comment #2) > But you forgot a part: > Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.[h,cpp]. You have to > remove CSS grid layout from the settings array as well, since it's no longer > experimental. But then we would have no more experimental features covered > by this file, so it makes sense to remove the entire file. You could do this > in a separate patch, but we should land them at the same time. I wanted to > remove it anyway because it needs to be rewritten to use the enumerable > experimental features API, so it covers all experimental features instead of > just being one more place they have to be hardcoded, and I don't think it > makes sense to keep it around in the meantime. True, let's do it in a different patch: bug #167586 1271369 4 rego 2017-01-30 12:24:24 -0800 Thanks for the review. I'll give some time to other people to comment on this. Otherwise I'll land it tomorrow. 1271629 5 300092 commit-queue 2017-01-31 01:25:17 -0800 Comment on attachment 300092 Patch Clearing flags on attachment: 300092 Committed r211415: <http://trac.webkit.org/changeset/211415> 1271630 6 commit-queue 2017-01-31 01:25:20 -0800 All reviewed patches have been landed. Closing bug. 300092 2017-01-30 02:07:48 -0800 2017-01-31 01:25:17 -0800 Patch bug-167578-20170130110539.patch text/plain 2743 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzA4M2MzNzgyZDRmNzA5 YzdkMzdjMjAxNGZjNDc1YjAzZjEwNTMxNC4uNzFkZWU1OTIxZGNmODExOWU0MzE1YTcxOGViZTY3 Njg1Y2MyMWJkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAxLTMwICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gRW5hYmxlIENTUyBHcmlkIExheW91dCBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc1NzgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCBTYWZhcmkgMTAuMSBpcyBzaGlw cGluZyBDU1MgR3JpZCBMYXlvdXQgaXQgc2VlbXMgc2FmZSB0byBlbmFibGUgdGhlIGZlYXR1cmUg YnkgZGVmYXVsdDoKKyAgICAgICAgaHR0cHM6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL2xpYnJhcnkv cHJlcmVsZWFzZS9jb250ZW50L3JlbGVhc2Vub3Rlcy9HZW5lcmFsL1doYXRzTmV3SW5TYWZhcmkv QXJ0aWNsZXMvU2FmYXJpXzEwXzEuaHRtbAorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVu Y2VzRGVmaW5pdGlvbnMuaDogUmVtb3ZlIEdyaWQgTGF5b3V0IGZyb20gdGhlIGxpc3Qgb2YgZXhw ZXJpbWVudGFsIGZsYWdzIGFuZCBlbmFibGUgaXQgYnkgZGVmYXVsdC4KKwogMjAxNy0wMS0yOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1Ro cmVhZGVkIENvbXBvc2l0b3JdIENyYXNoIG9uIFdlYkNvcmU6OkdMQ29udGV4dDo6dmVyc2lvbigp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0 aW9ucy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMu aAppbmRleCA1ODA3NzFkYzBlOWYzYWMzYTlmMzRmZDcyOWNlMGY0ODVkNzYxMGM5Li42MDE3ZTEw MGE0MzhlODg1MTYzOTU5ZDM1NDJlZjE5NjUwNzA0ZmJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTI0Nyw2ICsyNDcsNyBA QAogICAgIG1hY3JvKEludGVyc2VjdGlvbk9ic2VydmVyRW5hYmxlZCwgaW50ZXJzZWN0aW9uT2Jz ZXJ2ZXJFbmFibGVkLCBCb29sLCBib29sLCBmYWxzZSwgIkludGVyc2VjdGlvbiBPYnNlcnZlciIs ICJFbmFibGUgSW50ZXJzZWN0aW9uIE9ic2VydmVyIHN1cHBvcnQiKSBcCiAgICAgbWFjcm8oSW50 ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQsIGludGVyYWN0aXZlRm9ybVZhbGlkYXRpb25F bmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0hUTUxfSU5URVJBQ1RJVkVfRk9STV9WQUxJREFU SU9OX0VOQUJMRUQsICJIVE1MIEludGVyYWN0aXZlIEZvcm0gVmFsaWRhdGlvbiIsICJIVE1MIGlu dGVyYWN0aXZlIGZvcm0gdmFsaWRhdGlvbiIpIFwKICAgICBtYWNybyhTaG91bGRTdXBwcmVzc0tl eWJvYXJkSW5wdXREdXJpbmdQcm92aXNpb25hbE5hdmlnYXRpb24sIHNob3VsZFN1cHByZXNzS2V5 Ym9hcmRJbnB1dER1cmluZ1Byb3Zpc2lvbmFsTmF2aWdhdGlvbiwgQm9vbCwgYm9vbCwgZmFsc2Us ICIiLCAiIikgXAorICAgIG1hY3JvKENTU0dyaWRMYXlvdXRFbmFibGVkLCBjc3NHcmlkTGF5b3V0 RW5hYmxlZCwgQm9vbCwgYm9vbCwgdHJ1ZSwgIkNTUyBHcmlkIiwgIkNTUyBHcmlkIExheW91dCBN b2R1bGUgc3VwcG9ydCIpIFwKICAgICBcCiAKICNkZWZpbmUgRk9SX0VBQ0hfV0VCS0lUX0RPVUJM RV9QUkVGRVJFTkNFKG1hY3JvKSBcCkBAIC0zMTIsNyArMzEzLDYgQEAKIC8vICAgd2lkZXIgdGVz dGluZykuCiAKICNkZWZpbmUgRk9SX0VBQ0hfV0VCS0lUX0VYUEVSSU1FTlRBTF9GRUFUVVJFX1BS RUZFUkVOQ0UobWFjcm8pIFwKLSAgICBtYWNybyhDU1NHcmlkTGF5b3V0RW5hYmxlZCwgY3NzR3Jp ZExheW91dEVuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVT X0VOQUJMRUQsICJDU1MgR3JpZCIsICJDU1MgR3JpZCBMYXlvdXQgTW9kdWxlIHN1cHBvcnQiKSBc CiAgICAgbWFjcm8oU3ByaW5nVGltaW5nRnVuY3Rpb25FbmFibGVkLCBzcHJpbmdUaW1pbmdGdW5j dGlvbkVuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VO QUJMRUQsICJDU1MgU3ByaW5nIEFuaW1hdGlvbnMiLCAiQ1NTIFNwcmluZyBBbmltYXRpb24gcHJv dG90eXBlIikgXAogICAgIG1hY3JvKEdhbWVwYWRzRW5hYmxlZCwgZ2FtZXBhZHNFbmFibGVkLCBC b29sLCBib29sLCBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVELCAiR2FtZXBh ZHMiLCAiV2ViIEdhbWVwYWQgQVBJIHN1cHBvcnQiKSBcCiAgICAgbWFjcm8oTGlua1ByZWxvYWRF bmFibGVkLCBsaW5rUHJlbG9hZEVuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVO VEFMX0ZFQVRVUkVTX0VOQUJMRUQsICJMaW5rIFByZWxvYWQiLCAiTGluayBwcmVsb2FkIHN1cHBv cnQiKSBcCg==