167577 2017-01-30 01:23:41 -0800 Several web timing tests crash in GTK+ and AppleWin bots 2017-01-30 11:13:58 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply joepeck rniwa oldest_to_newest 1271203 0 cgarcia 2017-01-30 01:23:41 -0800 Thread 1 (Thread 0x7ff3e7c27940 (LWP 19299)): #0 0x00007ff3f7776b11 in WebCore::insertPerformanceEntry(WTF::HashMap<WTF::String, WTF::Vector<WTF::RefPtr<WebCore::PerformanceEntry>, 0ul, WTF::CrashOnOverflow, 16ul>, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::Vector<WTF::RefPtr<WebCore::PerformanceEntry>, 0ul, WTF::CrashOnOverflow, 16ul> > >&, WTF::Ref<WebCore::PerformanceEntry>&&) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #1 0x00007ff3f7776dec in WebCore::UserTiming::mark(WTF::String const&) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #2 0x00007ff3f7771634 in WebCore::Performance::mark(WTF::String const&) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #3 0x00007ff3f815c2fb in WebCore::jsPerformancePrototypeFunctionMark(JSC::ExecState*) () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #4 0x00007ff3a6ffe028 in ?? () #5 0x00007fffc0588b80 in ?? () #6 0x00007ff3f47345e0 in llint_entry () from /home/slave/webkitgtk/gtk-linux-64-release/build/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 Backtrace stopped: frame did not save the PC I think this doesn't happen in other bots because of the compiler version. The problem is that entry is used in both the key, to get name, and in the value with WTFMove. So, the name is invalidated by the move. It could be fixed by simply copying the name, instead of using entry->name, but I think that code could be simplified using HashMap::ensure and then we don't need any string copy, nor even the static insertPerformanceEntry(). 1271204 1 300091 cgarcia 2017-01-30 01:26:08 -0800 Created attachment 300091 Patch 1271211 2 cgarcia 2017-01-30 02:16:08 -0800 Committed r211360: <http://trac.webkit.org/changeset/211360> 1271335 3 300091 joepeck 2017-01-30 11:13:58 -0800 Comment on attachment 300091 Patch Awesome change! 300091 2017-01-30 01:26:08 -0800 2017-01-30 01:44:45 -0800 Patch wk-timing-crashes.diff text/plain 3234 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMzVjZTQ0OTkxMy4uMTBlOTJkY2VmOGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNCBAQAogMjAxNy0wMS0zMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgU2V2ZXJhbCB3ZWIgdGltaW5nIHRlc3RzIGNyYXNoIGluIEdU SysgYW5kIEFwcGxlV2luIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NzU3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgZW50cnkgaXMgdXNlZCBpbiBib3RoIHRo ZSBrZXksIHRvIGdldCBuYW1lLCBhbmQgaW4gdGhlIHZhbHVlIHdpdGggV1RGTW92ZS4gU28sIHRo ZSBuYW1lIGlzCisgICAgICAgIGludmFsaWRhdGVkIGJ5IHRoZSBtb3ZlLiBJdCBjb3VsZCBiZSBm aXhlZCBieSBzaW1wbHkgY29weWluZyB0aGUgbmFtZSwgaW5zdGVhZCBvZiB1c2luZyBlbnRyeS0+ bmFtZSwgYnV0IEkgdGhpbmsKKyAgICAgICAgdGhhdCBjb2RlIGNvdWxkIGJlIHNpbXBsaWZpZWQg dXNpbmcgSGFzaE1hcDo6ZW5zdXJlIGFuZCB0aGVuIHdlIGRvbid0IG5lZWQgYW55IHN0cmluZyBj b3B5LCBub3IgZXZlbiB0aGUgc3RhdGljCisgICAgICAgIGluc2VydFBlcmZvcm1hbmNlRW50cnko KS4KKworICAgICAgICBGaXggY3Jhc2hlcyBpbiBzZXZlcmFsIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvdXNlci10aW1pbmcvIHRlc3RzLgorCisgICAgICAgICogcGFnZS9QZXJmb3Jt YW5jZVVzZXJUaW1pbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VXNlclRpbWluZzo6bWFyayk6 CisgICAgICAgIChXZWJDb3JlOjpVc2VyVGltaW5nOjptZWFzdXJlKToKKyAgICAgICAgKFdlYkNv cmU6Omluc2VydFBlcmZvcm1hbmNlRW50cnkpOiBEZWxldGVkLgorCisyMDE3LTAxLTMwICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbVGhyZWFk ZWQgQ29tcG9zaXRvcl0gQ3Jhc2ggaW4gR3JhcGhpY3NDb250ZXh0M0Q6OmRlbGV0ZVRleHR1cmUg d2hlbiBkZXN0cm95aW5nIFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyUHJveHkKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzU3NQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlVXNlclRpbWluZy5jcHAKaW5kZXggYzU0NzE2MDUw OTguLmFiYmU5NTBiODg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1h bmNlVXNlclRpbWluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVVz ZXJUaW1pbmcuY3BwCkBAIC04OCwxNiArODgsNiBAQCBVc2VyVGltaW5nOjpVc2VyVGltaW5nKFBl cmZvcm1hbmNlJiBwZXJmb3JtYW5jZSkKIHsKIH0KIAotc3RhdGljIHZvaWQgaW5zZXJ0UGVyZm9y bWFuY2VFbnRyeShQZXJmb3JtYW5jZUVudHJ5TWFwJiBwZXJmb3JtYW5jZUVudHJ5TWFwLCBSZWY8 UGVyZm9ybWFuY2VFbnRyeT4mJiBwZXJmb3JtYW5jZUVudHJ5KQotewotICAgIFJlZlB0cjxQZXJm b3JtYW5jZUVudHJ5PiBlbnRyeSA9IFdURk1vdmUocGVyZm9ybWFuY2VFbnRyeSk7Ci0gICAgYXV0 byBpdCA9IHBlcmZvcm1hbmNlRW50cnlNYXAuZmluZChlbnRyeS0+bmFtZSgpKTsKLSAgICBpZiAo aXQgIT0gcGVyZm9ybWFuY2VFbnRyeU1hcC5lbmQoKSkKLSAgICAgICAgaXQtPnZhbHVlLmFwcGVu ZChXVEZNb3ZlKGVudHJ5KSk7Ci0gICAgZWxzZQotICAgICAgICBwZXJmb3JtYW5jZUVudHJ5TWFw LnNldChlbnRyeS0+bmFtZSgpLCBWZWN0b3I8UmVmUHRyPFBlcmZvcm1hbmNlRW50cnk+PiB7IFdU Rk1vdmUoZW50cnkpIH0pOwotfQotCiBzdGF0aWMgdm9pZCBjbGVhclBlcmZvcm1hbmNlRW50cmll cyhQZXJmb3JtYW5jZUVudHJ5TWFwJiBwZXJmb3JtYW5jZUVudHJ5TWFwLCBjb25zdCBTdHJpbmcm IG5hbWUpCiB7CiAgICAgaWYgKG5hbWUuaXNOdWxsKCkpIHsKQEAgLTExMyw3ICsxMDMsOSBAQCBF eGNlcHRpb25Pcjx2b2lkPiBVc2VyVGltaW5nOjptYXJrKGNvbnN0IFN0cmluZyYgbWFya05hbWUp CiAgICAgaWYgKHJlc3RyaWN0ZWRNYXJrRnVuY3Rpb24obWFya05hbWUpKQogICAgICAgICByZXR1 cm4gRXhjZXB0aW9uIHsgU1lOVEFYX0VSUiB9OwogCi0gICAgaW5zZXJ0UGVyZm9ybWFuY2VFbnRy eShtX21hcmtzTWFwLCBQZXJmb3JtYW5jZU1hcms6OmNyZWF0ZShtYXJrTmFtZSwgbV9wZXJmb3Jt YW5jZS5ub3coKSkpOworICAgIGF1dG8mIHBlcmZvcm1hbmNlRW50cnlMaXN0ID0gbV9tYXJrc01h cC5lbnN1cmUobWFya05hbWUsIFtdIHsgcmV0dXJuIFZlY3RvcjxSZWZQdHI8UGVyZm9ybWFuY2VF bnRyeT4+KCk7IH0pLml0ZXJhdG9yLT52YWx1ZTsKKyAgICBwZXJmb3JtYW5jZUVudHJ5TGlzdC5h cHBlbmQoUGVyZm9ybWFuY2VNYXJrOjpjcmVhdGUobWFya05hbWUsIG1fcGVyZm9ybWFuY2Uubm93 KCkpKTsKKwogICAgIHJldHVybiB7IH07CiB9CiAKQEAgLTE2MSw3ICsxNTMsOSBAQCBFeGNlcHRp b25Pcjx2b2lkPiBVc2VyVGltaW5nOjptZWFzdXJlKGNvbnN0IFN0cmluZyYgbWVhc3VyZU5hbWUs IGNvbnN0IFN0cmluZyYgcwogICAgICAgICBlbmRUaW1lID0gZW5kTWFya1Jlc3VsdC5yZWxlYXNl UmV0dXJuVmFsdWUoKTsKICAgICB9CiAKLSAgICBpbnNlcnRQZXJmb3JtYW5jZUVudHJ5KG1fbWVh c3VyZXNNYXAsIFBlcmZvcm1hbmNlTWVhc3VyZTo6Y3JlYXRlKG1lYXN1cmVOYW1lLCBzdGFydFRp bWUsIGVuZFRpbWUpKTsKKyAgICBhdXRvJiBwZXJmb3JtYW5jZUVudHJ5TGlzdCA9IG1fbWVhc3Vy ZXNNYXAuZW5zdXJlKG1lYXN1cmVOYW1lLCBbXSB7IHJldHVybiBWZWN0b3I8UmVmUHRyPFBlcmZv cm1hbmNlRW50cnk+PigpOyB9KS5pdGVyYXRvci0+dmFsdWU7CisgICAgcGVyZm9ybWFuY2VFbnRy eUxpc3QuYXBwZW5kKFBlcmZvcm1hbmNlTWVhc3VyZTo6Y3JlYXRlKG1lYXN1cmVOYW1lLCBzdGFy dFRpbWUsIGVuZFRpbWUpKTsKKwogICAgIHJldHVybiB7IH07CiB9CiAK