167548 2017-01-28 02:23:15 -0800 [GTK] ASSERTION FAILED: !m_layerTreeHost in DrawingAreaImpl::display() 2017-01-28 23:15:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1270955 0 cgarcia 2017-01-28 02:23:15 -0800 The problem is that non accelerated compositing forceRepaint implementation is doing a layout and then calling display. The layout makes the drawing area enter in AC mode and display asserts that we have a layer tree host. forceRepaint shouldn't do the layout because display already does that and it correctly handles the case of entering AC mode during the layout. It shouldn't call setNeedsDisplay either, because that schedules a display, but we are going to display synchronously. 1270956 1 300016 cgarcia 2017-01-28 02:25:11 -0800 Created attachment 300016 Patch 1271095 2 cgarcia 2017-01-28 23:15:44 -0800 Committed r211346: <http://trac.webkit.org/changeset/211346> 300016 2017-01-28 02:25:11 -0800 2017-01-28 11:20:18 -0800 Patch wk2-layer-tree-host-assert.diff text/plain 1920 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5NzMxY2QyMjdjZS4uZDliODg0OWRhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxNy0wMS0yOCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gQVNTRVJUSU9OIEZBSUxFRDogIW1fbGF5ZXJUcmVl SG9zdCBpbiBEcmF3aW5nQXJlYUltcGw6OmRpc3BsYXkoKQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCBub24gYWNjZWxl cmF0ZWQgY29tcG9zaXRpbmcgZm9yY2VSZXBhaW50IGltcGxlbWVudGF0aW9uIGlzIGRvaW5nIGEg bGF5b3V0IGFuZCB0aGVuIGNhbGxpbmcKKyAgICAgICAgZGlzcGxheS4gVGhlIGxheW91dCBtYWtl cyB0aGUgZHJhd2luZyBhcmVhIGVudGVyIGluIEFDIG1vZGUgYW5kIGRpc3BsYXkgYXNzZXJ0cyB0 aGF0IHdlIGhhdmUgYSBsYXllciB0cmVlCisgICAgICAgIGhvc3QuIGZvcmNlUmVwYWludCBzaG91 bGRuJ3QgZG8gdGhlIGxheW91dCBiZWNhdXNlIGRpc3BsYXkgYWxyZWFkeSBkb2VzIHRoYXQgYW5k IGl0IGNvcnJlY3RseSBoYW5kbGVzIHRoZSBjYXNlCisgICAgICAgIG9mIGVudGVyaW5nIEFDIG1v ZGUgZHVyaW5nIHRoZSBsYXlvdXQuIEl0IHNob3VsZG4ndCBjYWxsIHNldE5lZWRzRGlzcGxheSBl aXRoZXIsIGJlY2F1c2UgdGhhdCBzY2hlZHVsZXMgYQorICAgICAgICBkaXNwbGF5LCBidXQgd2Ug YXJlIGdvaW5nIHRvIGRpc3BsYXkgc3luY2hyb25vdXNseS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5n QXJlYUltcGw6OmZvcmNlUmVwYWludCk6CisKKzIwMTctMDEtMjggIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtUaHJlYWRlZCBDb21wb3NpdG9y XSBDcmFzaCB3aGVuIGRldGFjaGluZyB0aGUgQ29vcmRpbmF0ZWRHcmFwaGljc1NjZW5lCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc1NDcKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhSW1w bC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBs LmNwcAppbmRleCA0ODA3ODljN2QzYi4uOTk5MTdkZDg3NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCkBAIC0xNTIs MTAgKzE1MiwxMSBAQCB2b2lkIERyYXdpbmdBcmVhSW1wbDo6Zm9yY2VSZXBhaW50KCkKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIAotICAgIHNldE5lZWRzRGlzcGxheSgpOwotICAgIG1fd2ViUGFn ZS5sYXlvdXRJZk5lZWRlZCgpOwogICAgIG1faXNXYWl0aW5nRm9yRGlkVXBkYXRlID0gZmFsc2U7 Ci0gICAgZGlzcGxheSgpOworICAgIGlmIChtX2lzUGFpbnRpbmdFbmFibGVkKSB7CisgICAgICAg IG1fZGlydHlSZWdpb24gPSBtX3dlYlBhZ2UuYm91bmRzKCk7CisgICAgICAgIGRpc3BsYXkoKTsK KyAgICB9CiB9CiAKIHZvaWQgRHJhd2luZ0FyZWFJbXBsOjptYWluRnJhbWVDb250ZW50U2l6ZUNo YW5nZWQoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgbmV3U2l6ZSkK