167535 2017-01-27 16:25:17 -0800 [Cocoa] No way to get the text from a WKWebProcessPlugInRangeHandle 2017-01-27 20:52:20 -0800 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz sam thorton oldest_to_newest 1270824 0 mitz 2017-01-27 16:25:17 -0800 WKWebProcessPlugInRangeHandle doesn’t expose any way to get at the result of Range::text. 1270871 1 299988 mitz 2017-01-27 18:03:18 -0800 Created attachment 299988 Add a text property to WKWebProcessPlugInRangeHandle 1270894 2 299988 sam 2017-01-27 20:36:44 -0800 Comment on attachment 299988 Add a text property to WKWebProcessPlugInRangeHandle View in context: https://bugs.webkit.org/attachment.cgi?id=299988&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:41 > +@property (nonatomic, readonly) NSString *text WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); Do we usually make NSString getter's copy? 1270899 3 mitz 2017-01-27 20:43:05 -0800 (In reply to comment #2) > Comment on attachment 299988 [details] > Add a text property to WKWebProcessPlugInRangeHandle > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299988&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:41 > > +@property (nonatomic, readonly) NSString *text WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do we usually make NSString getter's copy? Yes, I’ll make this one copy as well. Thanks for the review! 1270903 4 mitz 2017-01-27 20:52:20 -0800 Fixed in <https://trac.webkit.org/r211321>. 299988 2017-01-27 18:03:18 -0800 2017-01-27 20:36:44 -0800 Add a text property to WKWebProcessPlugInRangeHandle bug-167535-20170127180112.patch text/plain 3816 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTMxNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAxLTI3ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBObyB3YXkgdG8gZ2V0 IHRoZSB0ZXh0IGZyb20gYSBXS1dlYlByb2Nlc3NQbHVnSW5SYW5nZUhhbmRsZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NTM1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSB0ZXh0IHByb3Bl cnR5IHRvIFdLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxlLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5k bGUuaDogRGVjbGFyZSBuZXcgcHJvcGVydHkuCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3Rl ZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5kbGUubW06CisgICAg ICAgICgtW1dLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxlIHRleHRdKTogQWRkZWQuIENhbGxz IEluamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGU6OnRleHQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6SW5qZWN0ZWRCdW5kbGVSYW5nZUhhbmRsZTo6dGV4dCk6IEFkZGVkLiBDYWxs cyBXZWJDb3JlOjpSYW5nZTo6dGV4dC4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVu ZGxlL0RPTS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmg6CisKIDIwMTctMDEtMjcgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIHNt YXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZCB0byBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9Db2NvYS9XS1dl YlByb2Nlc3NQbHVnSW5SYW5nZUhhbmRsZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblJh bmdlSGFuZGxlLmgJKHJldmlzaW9uIDIxMTMxMSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29hL1dLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxl LmgJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYgKzM4LDcgQEAgV0tfQ0xBU1NfQVZBSUxBQkxFKG1h Y29zeChXS19NQUNfVEJBKSwgaQogKyAoV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5kbGUgKily YW5nZUhhbmRsZVdpdGhKU1ZhbHVlOihKU1ZhbHVlICopdmFsdWUgaW5Db250ZXh0OihKU0NvbnRl eHQgKiljb250ZXh0OwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFdLV2ViUHJv Y2Vzc1BsdWdJbkZyYW1lICpmcmFtZTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkg TlNTdHJpbmcgKnRleHQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhX S19JT1NfVEJBKSk7CiAKIEBlbmQKIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9J bmplY3RlZEJ1bmRsZS9BUEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5kbGUubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9B UEkvQ29jb2EvV0tXZWJQcm9jZXNzUGx1Z0luUmFuZ2VIYW5kbGUubW0JKHJldmlzaW9uIDIxMTMx MSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL0NvY29h L1dLV2ViUHJvY2Vzc1BsdWdJblJhbmdlSGFuZGxlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2 ICs1OSwxMSBAQCAtIChXS1dlYlByb2Nlc3NQbHVnSW5GcmFtZSAqKWZyYW1lCiAgICAgcmV0dXJu IFt3cmFwcGVyKCpfcmFuZ2VIYW5kbGUtPmRvY3VtZW50KCktPmRvY3VtZW50RnJhbWUoKS5sZWFr UmVmKCkpIGF1dG9yZWxlYXNlXTsKIH0KIAorLSAoTlNTdHJpbmcgKil0ZXh0Cit7CisgICAgcmV0 dXJuIF9yYW5nZUhhbmRsZS0+dGV4dCgpOworfQorCiAtIChJbmplY3RlZEJ1bmRsZVJhbmdlSGFu ZGxlJilfcmFuZ2VIYW5kbGUKIHsKICAgICByZXR1cm4gKl9yYW5nZUhhbmRsZTsKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxl UmFuZ2VIYW5kbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv SW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwCShyZXZpc2lv biAyMTEzMTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYwLDQg KzE2MCw5IEBAIFBhc3NSZWZQdHI8V2ViSW1hZ2U+IEluamVjdGVkQnVuZGxlUmFuZ2UKICAgICBy ZXR1cm4gV2ViSW1hZ2U6OmNyZWF0ZShiYWNraW5nU3RvcmUucmVsZWFzZU5vbk51bGwoKSk7CiB9 CiAKK1N0cmluZyBJbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlOjp0ZXh0KCkgY29uc3QKK3sKKyAg ICByZXR1cm4gbV9yYW5nZS0+dGV4dCgpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVk QnVuZGxlUmFuZ2VIYW5kbGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmgJKHJldmlz aW9uIDIxMTMxMSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv RE9NL0luamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjksNiAr MjksNyBAQAogI2luY2x1ZGUgIkFQSU9iamVjdC5oIgogI2luY2x1ZGUgIkltYWdlT3B0aW9ucy5o IgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0pTQmFzZS5oPgorI2luY2x1ZGUgPHd0Zi9Gb3J3 YXJkLmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRy Lmg+CiAKQEAgLTU0LDYgKzU1LDcgQEAgcHVibGljOgogCiAgICAgV2ViQ29yZTo6SW50UmVjdCBi b3VuZGluZ1JlY3RJbldpbmRvd0Nvb3JkaW5hdGVzKCkgY29uc3Q7CiAgICAgUGFzc1JlZlB0cjxX ZWJJbWFnZT4gcmVuZGVyZWRJbWFnZShTbmFwc2hvdE9wdGlvbnMpOworICAgIFN0cmluZyB0ZXh0 KCkgY29uc3Q7CiAKICAgICBXZWJDb3JlOjpSYW5nZSogY29yZVJhbmdlKCkgY29uc3Q7CiAK