167532 2017-01-27 15:55:56 -0800 IconLoadingClient API doesn't work asynchronously 2017-01-28 08:57:43 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson achristensen commit-queue sam oldest_to_newest 1270808 0 beidson 2017-01-27 15:55:56 -0800 IconLoadingClient API doesn't work asynchronously This is because the WTF::Function is not properly moved into the objective-C block, and in fact it can't be; Blocks must be copyable. Making it a std::function instead works. 1270809 1 beidson 2017-01-27 15:57:48 -0800 <rdar://problem/30243429> 1270812 2 299972 beidson 2017-01-27 16:00:04 -0800 Created attachment 299972 Patch 1270813 3 commit-queue 2017-01-27 16:02:56 -0800 Attachment 299972 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/Cocoa/IconLoadingDelegate.mm:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebPageProxy.cpp:6731: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:874: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:874: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/API/APIIconLoadingClient.h:42: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 7 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1270819 4 beidson 2017-01-27 16:13:42 -0800 Alex gave in-person r+ with a small change. https://trac.webkit.org/changeset/211310 1270897 5 sam 2017-01-27 20:42:59 -0800 I don't understand what the issue is here. In my testing, WTF::Function works fine with blocks. Can you give an example where it doesn't work? 1270908 6 299972 achristensen 2017-01-27 22:24:28 -0800 Comment on attachment 299972 Patch It doesn't work with blocks that are copied or not called immediately. 1271002 7 sam 2017-01-28 08:57:43 -0800 (In reply to comment #6) > Comment on attachment 299972 [details] > Patch > > It doesn't work with blocks that are copied or not called immediately. Can you give me an example? I made some unit tests that all seem to work when copying a block, but perhaps I am missing something. e.g. this works: TEST(FunctionBlock, BlockCopyAsync) { WTF::initializeMainThread(); typedef void (^BlockType)(); __block bool value = false; BlockType block = ^{ value = true; }; Function<void()> function((BlockType)[block copy]); callOnMainThread(WTFMove(function)); TestWebKitAPI::Util::run(&value); ASSERT_TRUE(value); } 299972 2017-01-27 16:00:04 -0800 2017-01-27 22:24:28 -0800 Patch bug-167532-20170127155759.patch text/plain 5973 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDUzNTg4ZWY3YmI3NDll NDkzNzMyMDcxMDkwMTI4MWNjYWMxMWUwNy4uY2JlOTc2YjZiZjkyN2M0ZDVjZDJmNWY4NWU2M2Zk ZmRhN2Y3ODNhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAxLTI3ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBJY29uTG9hZGluZ0NsaWVu dCBBUEkgZG9lc24ndCB3b3JrIGFzeW5jaHJvbm91c2x5LgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzAyNDM0Mjk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY3NTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFrZSBhIFdURjo6RnVuY3Rpb24gKGluaGVyZW50bHkgbm90IGNvbXBhdGlibGUgd2l0aCBPYmpD IGJsb2NrcyBhcyB0aGV5IG11c3QgYmUgY29weWFibGUpCisgICAgICAgIGludG8gYSBzdGQ6OmZ1 bmN0aW9uLCB3aGljaCBpcyBjb3B5YWJsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQVBJ SWNvbkxvYWRpbmdDbGllbnQuaDoKKyAgICAgICAgKEFQSTo6SWNvbkxvYWRpbmdDbGllbnQ6Omdl dExvYWREZWNpc2lvbkZvckljb24pOgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBtYXliZUluc3RhbGxJY29uTG9hZGlu Z0NsaWVudF0pOgorICAgICAgICAKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvSWNvbkxvYWRp bmdEZWxlZ2F0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9JY29uTG9hZGluZ0RlbGVn YXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpJY29uTG9hZGluZ0RlbGVnYXRlOjpJY29uTG9hZGlu Z0NsaWVudDo6Z2V0TG9hZERlY2lzaW9uRm9ySWNvbik6CisgICAgICAgIAorICAgICAgICAqIFVJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6 OmdldExvYWREZWNpc2lvbkZvckljb24pOgorCiAyMDE3LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IFdlYkdMIGRpYWdub3N0aWMgbG9nZ2luZwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElJY29uTG9hZGluZ0Ns aWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElJY29uTG9hZGluZ0NsaWVu dC5oCmluZGV4IGJiYmEzNGM4ODBlMjgxM2M4NzQ5ZDE5MTBjZmU0MzQ2ZjFhNjBmZDAuLjUzMzFj YmExZjgwMzRjM2Q5YmI4ZGE0YjhlNzMwNTIyYjkzYzA1ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQVBJSWNvbkxvYWRpbmdDbGllbnQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSUljb25Mb2FkaW5nQ2xpZW50LmgKQEAgLTM5LDcgKzM5 LDcgQEAgY2xhc3MgSWNvbkxvYWRpbmdDbGllbnQgewogcHVibGljOgogICAgIHZpcnR1YWwgfklj b25Mb2FkaW5nQ2xpZW50KCkgeyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgZ2V0TG9hZERlY2lzaW9u Rm9ySWNvbihjb25zdCBXZWJDb3JlOjpMaW5rSWNvbiYsIEZ1bmN0aW9uPHZvaWQgKHN0ZDo6ZnVu Y3Rpb248dm9pZCAoQVBJOjpEYXRhKiwgV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKT4pPiYm IGNvbXBsZXRpb25IYW5kbGVyKSB7CisgICAgdmlydHVhbCB2b2lkIGdldExvYWREZWNpc2lvbkZv ckljb24oY29uc3QgV2ViQ29yZTo6TGlua0ljb24mLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKHN0ZDo6 ZnVuY3Rpb248dm9pZCAoQVBJOjpEYXRhKiwgV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKT4p PiBjb21wbGV0aW9uSGFuZGxlcikgewogICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihudWxscHRy KTsKICAgICB9CiB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvV0tWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1t CmluZGV4IDMyNDFjNDM5YWFiMmNkYTM0MjZlZTFkZWM1ZmY5M2UwZWE3YjM5YzEuLmUyYjI5M2Fm MWYxOWZlZGI2ODEwZWY0ZTIzYjgxZGU0YzE5Y2Q0ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KQEAgLTg3MSw3ICs4NzEsNyBAQCAtICh2b2lkKW1heWJl SW5zdGFsbEljb25Mb2FkaW5nQ2xpZW50CiAgICAgcHJpdmF0ZToKICAgICAgICAgdHlwZWRlZiB2 b2lkICheSWNvbkxvYWRDb21wbGV0aW9uSGFuZGxlcikoTlNEYXRhKik7CiAKLSAgICAgICAgdm9p ZCBnZXRMb2FkRGVjaXNpb25Gb3JJY29uKGNvbnN0IFdlYkNvcmU6OkxpbmtJY29uJiBsaW5rSWNv biwgRnVuY3Rpb248dm9pZCAoc3RkOjpmdW5jdGlvbjx2b2lkIChBUEk6OkRhdGEqLCBXZWJLaXQ6 OkNhbGxiYWNrQmFzZTo6RXJyb3IpPik+JiYgY29tcGxldGlvbkhhbmRsZXIpIG92ZXJyaWRlIHsK KyAgICAgICAgdm9pZCBnZXRMb2FkRGVjaXNpb25Gb3JJY29uKGNvbnN0IFdlYkNvcmU6OkxpbmtJ Y29uJiBsaW5rSWNvbiwgc3RkOjpmdW5jdGlvbjx2b2lkIChzdGQ6OmZ1bmN0aW9uPHZvaWQgKEFQ STo6RGF0YSosIFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvcik+KT4gY29tcGxldGlvbkhhbmRs ZXIpIG92ZXJyaWRlIHsKICAgICAgICAgICAgIFJldGFpblB0cjxfV0tMaW5rSWNvblBhcmFtZXRl cnM+IHBhcmFtZXRlcnMgPSBhZG9wdE5TKFtbX1dLTGlua0ljb25QYXJhbWV0ZXJzIGFsbG9jXSBf aW5pdFdpdGhMaW5rSWNvbjpsaW5rSWNvbl0pOwogCiAgICAgICAgICAgICBbbV93a1ZpZXcgcGVy Zm9ybVNlbGVjdG9yOmRlbGVnYXRlU2VsZWN0b3IoKSB3aXRoT2JqZWN0OnBhcmFtZXRlcnMuZ2V0 KCkgd2l0aE9iamVjdDpedm9pZCAoSWNvbkxvYWRDb21wbGV0aW9uSGFuZGxlciBsb2FkQ29tcGxl dGlvbkhhbmRsZXIpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2Nv YS9JY29uTG9hZGluZ0RlbGVnYXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2Ev SWNvbkxvYWRpbmdEZWxlZ2F0ZS5oCmluZGV4IGI3MjlkOTk5NjFiZDBmZWVjNDBlMWY0OGIwN2Uz YmMwY2U2YjA0NzEuLmFlZDFlOTE0ZGFlNDkwMDRlYjU3NzM2M2E5MmVjYjQxMjI4NGNkZjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9JY29uTG9hZGluZ0RlbGVn YXRlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL0ljb25Mb2FkaW5nRGVs ZWdhdGUuaApAQCAtNTUsNyArNTUsNyBAQCBwcml2YXRlOgogICAgICAgICB+SWNvbkxvYWRpbmdD bGllbnQoKTsKIAogICAgIHByaXZhdGU6Ci0gICAgICAgIHZvaWQgZ2V0TG9hZERlY2lzaW9uRm9y SWNvbihjb25zdCBXZWJDb3JlOjpMaW5rSWNvbiYsIEZ1bmN0aW9uPHZvaWQgKHN0ZDo6ZnVuY3Rp b248dm9pZCAoQVBJOjpEYXRhKiwgV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKT4pPiYmIGNv bXBsZXRpb25IYW5kbGVyKSBvdmVycmlkZTsKKyAgICAgICAgdm9pZCBnZXRMb2FkRGVjaXNpb25G b3JJY29uKGNvbnN0IFdlYkNvcmU6OkxpbmtJY29uJiwgc3RkOjpmdW5jdGlvbjx2b2lkIChzdGQ6 OmZ1bmN0aW9uPHZvaWQgKEFQSTo6RGF0YSosIFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvcik+ KT4gY29tcGxldGlvbkhhbmRsZXIpIG92ZXJyaWRlOwogCiAgICAgICAgIEljb25Mb2FkaW5nRGVs ZWdhdGUmIG1faWNvbkxvYWRpbmdEZWxlZ2F0ZTsKICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL0ljb25Mb2FkaW5nRGVsZWdhdGUubW0gYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvSWNvbkxvYWRpbmdEZWxlZ2F0ZS5tbQppbmRleCAyNWY5 NjI4MjljMDU1MTA4ZjBkN2IxYjU0NmUxNWI2OGQ5YWJlZmU2Li4xYjkwOTI5NDQ4OTBjYjNkNmE2 MTI5ZmJlNWM3YWJjZWM0NTAwYjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQ29jb2EvSWNvbkxvYWRpbmdEZWxlZ2F0ZS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ29jb2EvSWNvbkxvYWRpbmdEZWxlZ2F0ZS5tbQpAQCAtNzEsNyArNzEsNyBAQCBJY29u TG9hZGluZ0RlbGVnYXRlOjpJY29uTG9hZGluZ0NsaWVudDo6fkljb25Mb2FkaW5nQ2xpZW50KCkK IAogdHlwZWRlZiB2b2lkICheSWNvbkxvYWRDb21wbGV0aW9uSGFuZGxlcikoTlNEYXRhKik7CiAK LXZvaWQgSWNvbkxvYWRpbmdEZWxlZ2F0ZTo6SWNvbkxvYWRpbmdDbGllbnQ6OmdldExvYWREZWNp c2lvbkZvckljb24oY29uc3QgV2ViQ29yZTo6TGlua0ljb24mIGxpbmtJY29uLCBGdW5jdGlvbjx2 b2lkIChzdGQ6OmZ1bmN0aW9uPHZvaWQgKEFQSTo6RGF0YSosIFdlYktpdDo6Q2FsbGJhY2tCYXNl OjpFcnJvcik+KT4mJiBjb21wbGV0aW9uSGFuZGxlcikKK3ZvaWQgSWNvbkxvYWRpbmdEZWxlZ2F0 ZTo6SWNvbkxvYWRpbmdDbGllbnQ6OmdldExvYWREZWNpc2lvbkZvckljb24oY29uc3QgV2ViQ29y ZTo6TGlua0ljb24mIGxpbmtJY29uLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKHN0ZDo6ZnVuY3Rpb248 dm9pZCAoQVBJOjpEYXRhKiwgV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKT4pPiBjb21wbGV0 aW9uSGFuZGxlcikKIHsKICAgICBpZiAoIW1faWNvbkxvYWRpbmdEZWxlZ2F0ZS5tX2RlbGVnYXRl TWV0aG9kcy53ZWJWaWV3U2hvdWxkTG9hZEljb25XaXRoUGFyYW1ldGVyc0NvbXBsZXRpb25IYW5k bGVyKSB7CiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKG51bGxwdHIpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBjMTYxN2E0M2Y3OTE4YTg3MDRhOWI5 ODkxMjg3ZmNiMjYwNzZhZTZiLi43NDZjMThlNzU5M2QwYjViZTEzODkxYTJlY2UxMjRjNjQ2YmZj YWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNjcy Myw3ICs2NzIzLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmdldExvYWREZWNpc2lvbkZvckljb24o Y29uc3QgV2ViQ29yZTo6TGlua0ljb24mIGljb24sIHVpbnQ2NF8KICAgICBpZiAoIW1faWNvbkxv YWRpbmdDbGllbnQpCiAgICAgICAgIHJldHVybjsKIAotICAgIG1faWNvbkxvYWRpbmdDbGllbnQt PmdldExvYWREZWNpc2lvbkZvckljb24oaWNvbiwgW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBSZWY8 V2ViUGFnZVByb3h5PigqdGhpcyksIGxvYWRJZGVudGlmaWVyXShzdGQ6OmZ1bmN0aW9uPHZvaWQg KEFQSTo6RGF0YSosIENhbGxiYWNrQmFzZTo6RXJyb3IpPiBjYWxsYmFja0Z1bmN0aW9uKSB7Cisg ICAgbV9pY29uTG9hZGluZ0NsaWVudC0+Z2V0TG9hZERlY2lzaW9uRm9ySWNvbihpY29uLCBbdGhp cywgcHJvdGVjdGVkVGhpcyA9IFJlZlB0cjxXZWJQYWdlUHJveHk+KHRoaXMpLCBsb2FkSWRlbnRp Zmllcl0oc3RkOjpmdW5jdGlvbjx2b2lkIChBUEk6OkRhdGEqLCBDYWxsYmFja0Jhc2U6OkVycm9y KT4gY2FsbGJhY2tGdW5jdGlvbikgewogICAgICAgICBpZiAoIWlzVmFsaWQoKSkgewogICAgICAg ICAgICAgaWYgKGNhbGxiYWNrRnVuY3Rpb24pCiAgICAgICAgICAgICAgICAgY2FsbGJhY2tGdW5j dGlvbihudWxscHRyLCBDYWxsYmFja0Jhc2U6OkVycm9yOjpVbmtub3duKTsK