167522 2017-01-27 11:58:33 -0800 JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<> 2017-01-27 16:04:55 -0800 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo msaboff msaboff rniwa oldest_to_newest 1270722 0 fpizlo 2017-01-27 11:58:33 -0800 Patch forthcoming. 1270725 1 299949 fpizlo 2017-01-27 12:02:33 -0800 Created attachment 299949 the patch 1270726 2 fpizlo 2017-01-27 12:02:56 -0800 Ryosuke: I doubt this is the right fix. Do you know what's going on here? 1270758 3 msaboff 2017-01-27 13:43:39 -0800 I talked with Ryosuke and have a fix that he agrees with. 1270761 4 msaboff 2017-01-27 13:55:19 -0800 <rdar://problem/30240378> 1270765 5 299958 msaboff 2017-01-27 14:04:39 -0800 Created attachment 299958 Patch 1270814 6 msaboff 2017-01-27 16:04:55 -0800 Committed r211309: <http://trac.webkit.org/changeset/211309> 299949 2017-01-27 12:02:33 -0800 2017-01-27 14:04:39 -0800 the patch blah.patch text/plain 1597 fpizlo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTI5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTI3ICBGaWxpcCBQ aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgSlNDdXN0b21FbGVtZW50SW50ZXJm YWNlOjppbnZva2VDYWxsYmFjayBjYW4gYmUgY2FsbGVkIHdpdGggYSBudWxsIGNhbGxiYWNrIGJl Y2F1c2UgV2Vhazw+CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjc1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB3ZSBjYXVnaHQgdGhpcyB3aXRoIHRlc3RzLgorICAg ICAgICAKKyAgICAgICAgSSdtIG5vdCBzdXJlIGlmIHRoaXMgaXMgY29ycmVjdCwgYnV0IGl0J3Mg Y2xlYXIgdGhhdCB0aGUgY2FsbGJhY2sgY29tZXMgZnJvbSBXZWFrPD4gYW5kIEkgY2Fubm90Cisg ICAgICAgIGZpbmQgaG93IGl0J3MgbWFya2VkLCBzbyB0aGF0IG1lYW5zIGl0IGNhbiBiZSBudWxs LgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNDdXN0b21FbGVtZW50SW50ZXJmYWNlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkpTQ3VzdG9tRWxlbWVudEludGVyZmFjZTo6aW52b2tlQ2FsbGJh Y2spOgorCiAyMDE3LTAxLTI3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgU2ltcGxlIGxpbmUgbGF5b3V0OiBEbyBub3QgYmFpbCBvdXQgb24gLXdlYmtpdC1saW5l LWJveC1jb250YWluOiBibG9jayBnbHlwaHMgdW5sZXNzIHRleHQgb3ZlcmZsb3dzIHZlcnRpY2Fs bHkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0N1c3RvbUVsZW1lbnRJbnRl cmZhY2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3Vz dG9tRWxlbWVudEludGVyZmFjZS5jcHAJKHJldmlzaW9uIDIxMTIzNykKKysrIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tRWxlbWVudEludGVyZmFjZS5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIyMSw2ICsyMjEsOSBAQCB2b2lkIEpTQ3VzdG9tRWxlbWVudEludGVyZmFjZTo6dXBn cmFkZUVsCiAKIHZvaWQgSlNDdXN0b21FbGVtZW50SW50ZXJmYWNlOjppbnZva2VDYWxsYmFjayhF bGVtZW50JiBlbGVtZW50LCBKU09iamVjdCogY2FsbGJhY2ssIGNvbnN0IFdURjo6RnVuY3Rpb248 dm9pZChFeGVjU3RhdGUqLCBKU0RPTUdsb2JhbE9iamVjdCosIE1hcmtlZEFyZ3VtZW50QnVmZmVy Jik+JiBhZGRBcmd1bWVudHMpCiB7CisgICAgaWYgKCFjYWxsYmFjaykKKyAgICAgICAgcmV0dXJu OworICAgIAogICAgIGlmICghY2FuSW52b2tlQ2FsbGJhY2soKSkKICAgICAgICAgcmV0dXJuOwog Cg== 299958 2017-01-27 14:04:39 -0800 2017-01-27 14:06:58 -0800 Patch 167522.patch text/plain 3406 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxMTMwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTI3ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEpTQ3VzdG9tRWxlbWVudElu dGVyZmFjZTo6aW52b2tlQ2FsbGJhY2sgY2FuIGJlIGNhbGxlZCB3aXRoIGEgbnVsbCBjYWxsYmFj ayBiZWNhdXNlIFdlYWs8PgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY3NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkZWQgYWxsIHByb3ZpZGVkIGNhbGxiYWNrcyB0byB0aGUgZ2xvYmFsIG9iamVj dCB3aXRoIGEgcHJpdmF0ZSBuYW1lIHRoZSBzYW1lIHdheSAKKyAgICAgICAgdGhhdCB0aGUgY29u c3RydWN0b3Igd2FzIGFkZGVkLiAgVGhpcyB3aWxsIGtlZXAgdGhlc2UgY2FsbGJhY2tzIGZyb20g YmVpbmcgR0MnZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0N1c3RvbUVsZW1lbnRSZWdp c3RyeUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0N1c3RvbUVsZW1lbnRSZWdpc3Ry eTo6ZGVmaW5lKToKKwogMjAxNy0wMS0yNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIEZpeCBkaWFnbm9zdGljIGxvZ2dpbmcgdW5kZXIgbG9hZGVyLwpJbmRleDog U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDdXN0b21FbGVtZW50UmVnaXN0cnlDdXN0b20u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ3VzdG9tRWxl bWVudFJlZ2lzdHJ5Q3VzdG9tLmNwcAkocmV2aXNpb24gMjExMjgzKQorKysgU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNDdXN0b21FbGVtZW50UmVnaXN0cnlDdXN0b20uY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMjIsMTUgKzEyMiwxOCBAQCBKU1ZhbHVlIEpTQ3VzdG9tRWxlbWVudFJlZ2lz dHJ5OjpkZWZpbmUoCiAgICAgUXVhbGlmaWVkTmFtZSBuYW1lKG51bGxBdG9tLCBsb2NhbE5hbWUs IEhUTUxOYW1lczo6eGh0bWxOYW1lc3BhY2VVUkkpOwogICAgIGF1dG8gZWxlbWVudEludGVyZmFj ZSA9IEpTQ3VzdG9tRWxlbWVudEludGVyZmFjZTo6Y3JlYXRlKG5hbWUsIGNvbnN0cnVjdG9yLCBn bG9iYWxPYmplY3QoKSk7CiAKLSAgICBpZiAoYXV0byogY29ubmVjdGVkQ2FsbGJhY2sgPSBnZXRD dXN0b21FbGVtZW50Q2FsbGJhY2soc3RhdGUsIHByb3RvdHlwZU9iamVjdCwgSWRlbnRpZmllcjo6 ZnJvbVN0cmluZygmdm0sICJjb25uZWN0ZWRDYWxsYmFjayIpKSkKKyAgICBhdXRvKiBjb25uZWN0 ZWRDYWxsYmFjayA9IGdldEN1c3RvbUVsZW1lbnRDYWxsYmFjayhzdGF0ZSwgcHJvdG90eXBlT2Jq ZWN0LCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZ2bSwgImNvbm5lY3RlZENhbGxiYWNrIikpOwor ICAgIGlmIChjb25uZWN0ZWRDYWxsYmFjaykKICAgICAgICAgZWxlbWVudEludGVyZmFjZS0+c2V0 Q29ubmVjdGVkQ2FsbGJhY2soY29ubmVjdGVkQ2FsbGJhY2spOwogICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7CiAKLSAgICBpZiAoYXV0byogZGlzY29ubmVjdGVkQ2Fs bGJhY2sgPSBnZXRDdXN0b21FbGVtZW50Q2FsbGJhY2soc3RhdGUsIHByb3RvdHlwZU9iamVjdCwg SWRlbnRpZmllcjo6ZnJvbVN0cmluZygmdm0sICJkaXNjb25uZWN0ZWRDYWxsYmFjayIpKSkKKyAg ICBhdXRvKiBkaXNjb25uZWN0ZWRDYWxsYmFjayA9IGdldEN1c3RvbUVsZW1lbnRDYWxsYmFjayhz dGF0ZSwgcHJvdG90eXBlT2JqZWN0LCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZ2bSwgImRpc2Nv bm5lY3RlZENhbGxiYWNrIikpOworICAgIGlmIChkaXNjb25uZWN0ZWRDYWxsYmFjaykKICAgICAg ICAgZWxlbWVudEludGVyZmFjZS0+c2V0RGlzY29ubmVjdGVkQ2FsbGJhY2soZGlzY29ubmVjdGVk Q2FsbGJhY2spOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIEpTVmFsdWUoKSk7CiAK LSAgICBpZiAoYXV0byogYWRvcHRlZENhbGxiYWNrID0gZ2V0Q3VzdG9tRWxlbWVudENhbGxiYWNr KHN0YXRlLCBwcm90b3R5cGVPYmplY3QsIElkZW50aWZpZXI6OmZyb21TdHJpbmcoJnZtLCAiYWRv cHRlZENhbGxiYWNrIikpKQorICAgIGF1dG8qIGFkb3B0ZWRDYWxsYmFjayA9IGdldEN1c3RvbUVs ZW1lbnRDYWxsYmFjayhzdGF0ZSwgcHJvdG90eXBlT2JqZWN0LCBJZGVudGlmaWVyOjpmcm9tU3Ry aW5nKCZ2bSwgImFkb3B0ZWRDYWxsYmFjayIpKTsKKyAgICBpZiAoYWRvcHRlZENhbGxiYWNrKQog ICAgICAgICBlbGVtZW50SW50ZXJmYWNlLT5zZXRBZG9wdGVkQ2FsbGJhY2soYWRvcHRlZENhbGxi YWNrKTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBKU1ZhbHVlKCkpOwogCkBAIC0x NDYsOCArMTQ5LDE4IEBAIEpTVmFsdWUgSlNDdXN0b21FbGVtZW50UmVnaXN0cnk6OmRlZmluZSgK ICAgICAgICAgfQogICAgIH0KIAotICAgIFByaXZhdGVOYW1lIHVuaXF1ZVByaXZhdGVOYW1lOwot ICAgIGdsb2JhbE9iamVjdCgpLT5wdXREaXJlY3Qodm0sIHVuaXF1ZVByaXZhdGVOYW1lLCBjb25z dHJ1Y3Rvcik7CisgICAgYXV0byBhZGRUb0dsb2JhbE9iamVjdFdpdGhQcml2YXRlTmFtZSA9IFsm XSAoSlNPYmplY3QqIG9iamVjdFRvQWRkKSB7CisgICAgICAgIGlmIChvYmplY3RUb0FkZCkgewor ICAgICAgICAgICAgUHJpdmF0ZU5hbWUgdW5pcXVlUHJpdmF0ZU5hbWU7CisgICAgICAgICAgICBn bG9iYWxPYmplY3QoKS0+cHV0RGlyZWN0KHZtLCB1bmlxdWVQcml2YXRlTmFtZSwgb2JqZWN0VG9B ZGQpOworICAgICAgICB9CisgICAgfTsKKworICAgIGFkZFRvR2xvYmFsT2JqZWN0V2l0aFByaXZh dGVOYW1lKGNvbnN0cnVjdG9yKTsKKyAgICBhZGRUb0dsb2JhbE9iamVjdFdpdGhQcml2YXRlTmFt ZShjb25uZWN0ZWRDYWxsYmFjayk7CisgICAgYWRkVG9HbG9iYWxPYmplY3RXaXRoUHJpdmF0ZU5h bWUoZGlzY29ubmVjdGVkQ2FsbGJhY2spOworICAgIGFkZFRvR2xvYmFsT2JqZWN0V2l0aFByaXZh dGVOYW1lKGFkb3B0ZWRDYWxsYmFjayk7CisgICAgYWRkVG9HbG9iYWxPYmplY3RXaXRoUHJpdmF0 ZU5hbWUoYXR0cmlidXRlQ2hhbmdlZENhbGxiYWNrKTsKIAogICAgIHJlZ2lzdHJ5LmFkZEVsZW1l bnREZWZpbml0aW9uKFdURk1vdmUoZWxlbWVudEludGVyZmFjZSkpOwogCg==