167519 2017-01-27 11:25:44 -0800 Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line 2017-01-28 01:28:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck ap ddkilzer joepeck lforschler rniwa simon.fraser oldest_to_newest 1270711 0 joepeck 2017-01-27 11:25:44 -0800 Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line This is ugly and annoying! 1270718 1 299947 joepeck 2017-01-27 11:40:36 -0800 Created attachment 299947 [PATCH] Proposed Fix 1270720 2 299947 joepeck 2017-01-27 11:44:27 -0800 Comment on attachment 299947 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299947&action=review > Tools/QueueStatusServer/templates/statusbubble.html:57 > + var parentContainer = bubbleContainer.parentElement; Please note that I had no way of testing this code with any fake bugzilla instance. I just paused here in inspector and did these operations to ensure they worked for me. If someone has a way to test this for real, please let me know! 1270762 3 ap 2017-01-27 13:57:01 -0800 This is surprising, why do they wrap for you, but not for me? Pretty sure I fixed something like this in the past. Could you add a screenshot? Longer term, we'll be adding more bubbles, so they will no longer fit in a reasonably sized window. 1270880 4 299947 ap 2017-01-27 18:51:17 -0800 Comment on attachment 299947 [PATCH] Proposed Fix Now that I'm back at a Mac, I see that it actually wraps for me too. But is there enough space to let it grow horizontally indeed? The layout gets really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the current 450px looks bad on an iPhone. I agree that the review bar needs it layout to be improved. 1270912 5 299947 rniwa 2017-01-27 22:53:41 -0800 Comment on attachment 299947 [PATCH] Proposed Fix Talked in person. 1270913 6 rniwa 2017-01-27 22:54:34 -0800 (In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. Yeah, I think that's a good long term consideration. For now, increasing the width of the bubbles seems like a good short term solution. 1270924 7 joepeck 2017-01-27 23:57:07 -0800 (In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. The 1000px should only be for measuring. It then gets immediately set back to what it was before. 1270947 8 joepeck 2017-01-28 01:28:17 -0800 <https://trac.webkit.org/changeset/211331> 299947 2017-01-27 11:40:36 -0800 2017-01-27 22:53:41 -0800 [PATCH] Proposed Fix bubbles-1.patch text/plain 3385 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZjA3 ZTRjNTAzYS4uZjkyZmYxZDg0MDggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0wMS0yNyAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFBhdGNoIFJldmlldzogRVdTIEJ1 YmJsZXMgd3JhcCB0byBtdWx0aXBsZSBsaW5lcyBidXQgY2FuIGZpdCBvbiBvbmUgbGluZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NTE5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBRdWV1ZVN0YXR1 c1NlcnZlci90ZW1wbGF0ZXMvc3RhdHVzYnViYmxlLmh0bWw6CisgICAgICAgIFRvIG1lYXN1cmUg dGhlIGJ1YmJsZUNvbnRhaW5lcidzIHdpZHRoLCBpdCBtdXN0IG5vdCBiZSB3cmFwcGluZyBiYXNl ZAorICAgICAgICBvbiBpdHMgcGFyZW50IGNvbnRhaW5lci4gU28gd2hlbiBtZWFzdXJpbmcgdGhl IHdpZHRoIHRlbXBvcmFyaWx5IHNldAorICAgICAgICB0aGUgcGFyZW50IHRvIGEgdmVyeSBsYXJn ZSB3aWR0aCBzbyBhcyB0byBub3QgYXJ0aWZpY2lhbGx5IHdyYXAgdXMuCisgICAgICAgIFJlc3Rv cmUgdGhlIHBhcmVudCdzIHdpZHRoIGFmdGVyIG1lYXN1cmluZy4KKwogMjAxNy0wMS0yNiAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENyYXNoIHdoZW4gbmF2aWdh dGluZyBiYWNrIHRvIGEgcGFnZSBpbiBQYWNoZUNhY2hlIHdoZW4gb25lIG9mIGl0cyBmcmFtZXMg aGFzIGJlZW4gcmVtb3ZlZApkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVt cGxhdGVzL3N0YXR1c2J1YmJsZS5odG1sIGIvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxh dGVzL3N0YXR1c2J1YmJsZS5odG1sCmluZGV4IDMzZjkzY2MyNGE2Li45MWViNzZhZTA4MCAxMDA2 NDQKLS0tIGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3N0YXR1c2J1YmJsZS5o dG1sCisrKyBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9zdGF0dXNidWJibGUu aHRtbApAQCAtNTQsNyArNTQsMTEgQEAgZm9ybSB7CiA8c2NyaXB0Pgogd2luZG93LmFkZEV2ZW50 TGlzdGVuZXIoIm1lc3NhZ2UiLCBmdW5jdGlvbihlKSB7CiAgIGlmIChlLmRhdGEgPT09ICdjb250 YWluZXJNZXRyaWNzJykgeworICAgIHZhciBwYXJlbnRDb250YWluZXIgPSBidWJibGVDb250YWlu ZXIucGFyZW50RWxlbWVudDsKKyAgICB2YXIgb3JpZ2luYWxXaWR0aCA9IHBhcmVudENvbnRhaW5l ci5zdHlsZS53aWR0aDsKKyAgICBwYXJlbnRDb250YWluZXIuc3R5bGUud2lkdGggPSAiMTAwMHB4 IjsKICAgICB2YXIgY2xpZW50UmVjdCA9IGJ1YmJsZUNvbnRhaW5lci5nZXRCb3VuZGluZ0NsaWVu dFJlY3QoKTsKKyAgICBwYXJlbnRDb250YWluZXIuc3R5bGUud2lkdGggPSBvcmlnaW5hbFdpZHRo OwogICAgIGUuc291cmNlLnBvc3RNZXNzYWdlKHsnd2lkdGgnOiBNYXRoLmNlaWwoY2xpZW50UmVj dC53aWR0aCksICdoZWlnaHQnOiBNYXRoLmNlaWwoY2xpZW50UmVjdC5oZWlnaHQpfSwgZS5vcmln aW4pOwogICB9IGVsc2UKICAgICBjb25zb2xlLmxvZygiVW5rbm93biBwb3N0TWVzc2FnZTogIiAr IGUuZGF0YSk7CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9n IGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwppbmRleCA1N2I2MTQwMTI0My4u M2M5MjVkMWU4ZTggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VM b2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE3LTAxLTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisK KyAgICAgICAgUGF0Y2ggUmV2aWV3OiBFV1MgQnViYmxlcyB3cmFwIHRvIG11bHRpcGxlIGxpbmVz IGJ1dCBjYW4gZml0IG9uIG9uZSBsaW5lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjc1MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXaGlsZSB3ZSBkbyBwb3N0IG1lc3NhZ2UgdG8gZGV0ZXJtaW5lIHRo ZSBzaXplLCB0aGUgZmFjdCB0aGF0IHdlIGhhdmUKKyAgICAgICAgY29uc3RyYWluZWQgdGhlIGlm cmFtZSB0byBhIHNpemUgb2YgNDUwcHggbWVhbnQgaXRzIGJvZHkgaXMgNDUwcHggYW5kCisgICAg ICAgIHRoZSBkaXYgY29udGFpbmluZyB0aGUgYnViYmxlcyB3cmFwcyBhdCA0NTBweC4gSXRzIGZ1 bGwgc2l6ZSAofjQ1OHB4KQorICAgICAgICBpcyBub3QgcmV0dXJuZWQuIEFsdGhvdWdoIHdlIHNv bHZlIHRoaXMgYXJ0aWZpY2FsIGNvbnN0cmFpbnQgcHJvYmxlbQorICAgICAgICBpbnNpZGUgb2Yg dGhlIGJ1YmJsZSBjb250YWluZXJNZXRyaWNzIG1lYXN1cmluZywgdXAgdGhpcyBkZWZhdWx0IHZh bHVlCisgICAgICAgIGZyb20gNDUwIHRvIDQ2MCB0byByZWR1Y2UgVUkgaml0dGVyICh0aGUgY3Vy cmVudCBtZWFzdXJlbWVudCBvbiBteQorICAgICAgICBtYWNoaW5lIGlzIDQ1OHB4KS4KKworICAg ICAgICAqIFByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiOgorCiAyMDE3LTAxLTE5ICBUaW1vdGh5 IEhhdGNoZXIgIDx0aW1vdGh5QGhhdGNoZXIubmFtZT4KIAogICAgICAgICBCdWd6aWxsYSBlbWFp bCBhdXRvY29tcGxldGUgZG9lcyBub3Qgd29yayBvbiB0aGlyZCBlbWFpbCBmaWVsZCBvZiBhZHZh bmNlZCBzZWFyY2ggcGFnZQpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1By ZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0 eVBhdGNoL1ByZXR0eVBhdGNoLnJiCmluZGV4IDI3OGMzZmVmYTMwLi42MmNhYjFjM2ZmNiAxMDA2 NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNo LnJiCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRj aC5yYgpAQCAtNDkwLDcgKzQ5MCw3IEBAIGRpdjpmb2N1cyB7CiAKIC5zdGF0dXNCdWJibGUgewog ICAvKiBUaGUgd2lkdGgvaGVpZ2h0IGdldCBzZXQgdG8gdGhlIGJ1YmJsZSBjb250ZW50cyB2aWEg cG9zdE1lc3NhZ2Ugb24gYnJvd3NlcnMgdGhhdCBzdXBwb3J0IGl0LiAqLwotICB3aWR0aDogNDUw cHg7CisgIHdpZHRoOiA0NjBweDsKICAgaGVpZ2h0OiAyMHB4OwogICBtYXJnaW46IDJweCAycHgg MCAwOwogICBib3JkZXI6IG5vbmU7Cg==