167515 2017-01-27 10:31:14 -0800 Round CPU Usage diagnostic logging to 2 significant digits 2017-01-27 15:34:33 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue kling koivisto sam webkit-bug-importer oldest_to_newest 1270684 0 cdumez 2017-01-27 10:31:14 -0800 Round CPU Usage diagnostic logging to 2 significant digits. 1270685 1 cdumez 2017-01-27 10:31:37 -0800 <rdar://problem/30236297> 1270700 2 299943 cdumez 2017-01-27 11:00:38 -0800 Created attachment 299943 Patch 1270721 3 299943 koivisto 2017-01-27 11:49:20 -0800 Comment on attachment 299943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299943&action=review > Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:80 > +static String toStringRoundingSignificantFigures(double value, unsigned significantFigures) > +{ > + DecimalNumber decimal(value, RoundingSignificantFigures, significantFigures); > + NumberToLStringBuffer buffer; > + unsigned length = decimal.toStringDecimal(buffer, WTF::NumberToStringBufferLength); > + return String(buffer, length); > +} Is this somehow better than String::number(cpuUsage, 2)? 1270731 4 299943 cdumez 2017-01-27 12:09:19 -0800 Comment on attachment 299943 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299943&action=review >> Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:80 >> +} > > Is this somehow better than String::number(cpuUsage, 2)? String::number() takes a number of "decimal digits". I really need a number of "significant figures". 10 has 1 significant figure. 10.2 has 3 significant figures. 1270736 5 299943 commit-queue 2017-01-27 12:34:32 -0800 Comment on attachment 299943 Patch Clearing flags on attachment: 299943 Committed r211295: <http://trac.webkit.org/changeset/211295> 1270737 6 commit-queue 2017-01-27 12:34:37 -0800 All reviewed patches have been landed. Closing bug. 1270795 7 koivisto 2017-01-27 15:22:06 -0800 > I really need a number > of "significant figures". 10 has 1 significant figure. 10.2 has 3 > significant figures. I thought that is what String::number() with precision argument does. 1270801 8 cdumez 2017-01-27 15:34:33 -0800 (In reply to comment #7) > > I really need a number > > of "significant figures". 10 has 1 significant figure. 10.2 has 3 > > significant figures. > > I thought that is what String::number() with precision argument does. Oh, I'll double check then. Using String::number() would be nicer indeed if it does what I want. 299943 2017-01-27 11:00:38 -0800 2017-01-27 12:34:32 -0800 Patch bug-167515-20170127105834.patch text/plain 2813 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzUyODJlODRjZjk3OGM2 Y2RiYTJhOWEzYWIzYjQ5ZmJhZjU0MDNiYS4uNTkzYWVhNzE3MTUxMDI5NmVkNjBlMjIyNDQxZGEy MWM1MjBhOGZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAxLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUm91bmQgQ1BVIFVzYWdlIGRp YWdub3N0aWMgbG9nZ2luZyB0byAyIHNpZ25pZmljYW50IGRpZ2l0cworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NTE1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8zMDIzNjI5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSb3VuZCBDUFUgVXNhZ2UgZGlhZ25vc3RpYyBsb2dnaW5nIHRvIDIgc2lnbmlm aWNhbnQgZGlnaXRzCisgICAgICAgIGFzIHJlcXVlc3RlZCBieSBkaWFnbm9zdGljIGxvZ2dpbmcg dGVhbS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QZXJBY3Rpdml0eVN0YXRlQ1BVVXNhZ2VTYW1w bGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6dG9TdHJpbmdSb3VuZGluZ1NpZ25pZmljYW50Rmln dXJlcyk6CisgICAgICAgIChXZWJLaXQ6OlBlckFjdGl2aXR5U3RhdGVDUFVVc2FnZVNhbXBsZXI6 OmxvZ2dpbmdUaW1lckZpcmVkKToKKwogMjAxNy0wMS0yNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1RocmVhZGVkIENvbXBvc2l0b3JdIFN0 b3AgY3JlYXRpbmcgdGhlIEdMQ29udGV4dCBvbiBkZW1hbmQgdGhlIGZpcnN0IHRpbWUgbWFrZUNv bnRleHRDdXJyZW50IGlzIGNhbGxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BlckFjdGl2aXR5U3RhdGVDUFVVc2FnZVNhbXBsZXIuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BlckFjdGl2aXR5U3RhdGVDUFVVc2FnZVNhbXBsZXIuY3BwCmluZGV4IDMzNjYw M2E0OGE1YzI5MTNjN2JjY2Y4MzdkMzI2MzNhZjExYmE1MGUuLjc1ZDljZTM4NWE5NGUzNWNiNDRi MjdkYmVjNDA0NGZkNTE3ZGZjNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QZXJBY3Rpdml0eVN0YXRlQ1BVVXNhZ2VTYW1wbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvUGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlci5jcHAKQEAgLTMwLDYg KzMwLDcgQEAKICNpbmNsdWRlICJXZWJQcm9jZXNzUG9vbC5oIgogI2luY2x1ZGUgIldlYlByb2Nl c3NQcm94eS5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmg+Cisj aW5jbHVkZSA8d3RmL0RlY2ltYWxOdW1iZXIuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKQEAg LTcwLDYgKzcxLDE0IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5nIGxvZ2dpbmdLZXlGb3JBY3Rpdml0 eVN0YXRlKEFjdGl2aXR5U3RhdGVGb3JDUFVTYW1wbGluZyBzdGF0CiAgICAgfQogfQogCitzdGF0 aWMgU3RyaW5nIHRvU3RyaW5nUm91bmRpbmdTaWduaWZpY2FudEZpZ3VyZXMoZG91YmxlIHZhbHVl LCB1bnNpZ25lZCBzaWduaWZpY2FudEZpZ3VyZXMpCit7CisgICAgRGVjaW1hbE51bWJlciBkZWNp bWFsKHZhbHVlLCBSb3VuZGluZ1NpZ25pZmljYW50RmlndXJlcywgc2lnbmlmaWNhbnRGaWd1cmVz KTsKKyAgICBOdW1iZXJUb0xTdHJpbmdCdWZmZXIgYnVmZmVyOworICAgIHVuc2lnbmVkIGxlbmd0 aCA9IGRlY2ltYWwudG9TdHJpbmdEZWNpbWFsKGJ1ZmZlciwgV1RGOjpOdW1iZXJUb1N0cmluZ0J1 ZmZlckxlbmd0aCk7CisgICAgcmV0dXJuIFN0cmluZyhidWZmZXIsIGxlbmd0aCk7Cit9CisKIHZv aWQgUGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlcjo6bG9nZ2luZ1RpbWVyRmlyZWQoKQog ewogICAgIGF1dG8qIHBhZ2UgPSBwYWdlRm9yTG9nZ2luZygpOwpAQCAtODQsNyArOTMsNyBAQCB2 b2lkIFBlckFjdGl2aXR5U3RhdGVDUFVVc2FnZVNhbXBsZXI6OmxvZ2dpbmdUaW1lckZpcmVkKCkK ICAgICBmb3IgKGF1dG8mIHBhaXIgOiBtX2NwdVRpbWVJbkFjdGl2aXR5U3RhdGUpIHsKICAgICAg ICAgZG91YmxlIGNwdVVzYWdlID0gc3RhdGljX2Nhc3Q8ZG91YmxlPihwYWlyLnZhbHVlICogMTAw LikgLyBjcHVUaW1lRGVsdGE7CiAgICAgICAgIFN0cmluZyBhY3Rpdml0eVN0YXRlS2V5ID0gbG9n Z2luZ0tleUZvckFjdGl2aXR5U3RhdGUocGFpci5rZXkpOwotICAgICAgICBwYWdlLT5sb2dEaWFn bm9zdGljTWVzc2FnZVdpdGhWYWx1ZShEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmNwdVVzYWdlS2V5 KCksIGFjdGl2aXR5U3RhdGVLZXksIFN0cmluZzo6bnVtYmVyKGNwdVVzYWdlLCAxKSwgZmFsc2Up OworICAgICAgICBwYWdlLT5sb2dEaWFnbm9zdGljTWVzc2FnZVdpdGhWYWx1ZShEaWFnbm9zdGlj TG9nZ2luZ0tleXM6OmNwdVVzYWdlS2V5KCksIGFjdGl2aXR5U3RhdGVLZXksIHRvU3RyaW5nUm91 bmRpbmdTaWduaWZpY2FudEZpZ3VyZXMoY3B1VXNhZ2UsIDIpLCBmYWxzZSk7CiAgICAgICAgIFJF TEVBU0VfTE9HKFBlcmZvcm1hbmNlTG9nZ2luZywgIldlYkNvbnRlbnQgcHJvY2Vzc2VzIHVzZWQg JS4xZiUlIENQVSBpbiAlcyBzdGF0ZSIsIGNwdVVzYWdlLCBhY3Rpdml0eVN0YXRlS2V5LnV0Zjgo KS5kYXRhKCkpOwogICAgIH0KIAo=