167510 2017-01-27 09:57:54 -0800 Fix diagnostic logging in media code 2017-01-27 12:37:18 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen commit-queue eric.carlson jer.noble oldest_to_newest 1270668 0 cdumez 2017-01-27 09:57:54 -0800 Fix diagnostic logging in media code. It should not use logDiagnosticMessageWithValue() with a non-numeric value. 1270669 1 299939 cdumez 2017-01-27 09:59:11 -0800 Created attachment 299939 Patch 1270738 2 299939 commit-queue 2017-01-27 12:37:14 -0800 Comment on attachment 299939 Patch Clearing flags on attachment: 299939 Committed r211298: <http://trac.webkit.org/changeset/211298> 1270739 3 commit-queue 2017-01-27 12:37:18 -0800 All reviewed patches have been landed. Closing bug. 299939 2017-01-27 09:59:11 -0800 2017-01-27 12:37:14 -0800 Patch bug-167510-20170127095707.patch text/plain 3757 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJhOGIxZjhiM2JlMzEy MDMxZDI3ZTMyZDcyZDM5NjIzOTFmMmI5NS4uZTZiZGM0MDE4NjY3MGZiODEzMDIzY2I5ODg0OGUx ZTFiYjNhMjllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAxLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGRpYWdub3N0aWMgbG9n Z2luZyBpbiBtZWRpYSBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjc1MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggZGlhZ25vc3RpYyBsb2dnaW5nIGluIG1lZGlhIGNvZGUuIEl0IHNob3Vs ZCBub3QgdXNlIGxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFZhbHVlKCkKKyAgICAgICAgd2l0aCBh IG5vbi1udW1lcmljIHZhbHVlLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZSk6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVQbGF5U3RhdGUpOgorCiAy MDE3LTAxLTI1ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtjc3MtZ3JpZF0gTW92ZSBHcmlkIGNsYXNzIG91dCBvZiBSZW5kZXJHcmlkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAyNzBkZWJiNDc0ZWM1ZjU0 ZGQ0ZGY0NjMzZWE5MjMwNjBkMjRkZGVmLi4yNjJiOTkyYmNhODQxODRkNmVjMWYyZGY4ZDkzMTI2 NTE0MzQzNzU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAg LTE0NTUsNyArMTQ1NSw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6bG9hZFJlc291cmNlKGNv bnN0IFVSTCYgaW5pdGlhbFVSTCwgQ29udGVudFR5cGUmIGNvbnRlbnRUCiAgICAgfQogCiAgICAg Ly8gTG9nIHRoYXQgd2Ugc3RhcnRlZCBsb2FkaW5nIGEgbWVkaWEgZWxlbWVudC4KLSAgICBwYWdl LT5kaWFnbm9zdGljTG9nZ2luZ0NsaWVudCgpLmxvZ0RpYWdub3N0aWNNZXNzYWdlV2l0aFZhbHVl KERpYWdub3N0aWNMb2dnaW5nS2V5czo6bWVkaWFLZXkoKSwgaXNWaWRlbygpID8gRGlhZ25vc3Rp Y0xvZ2dpbmdLZXlzOjp2aWRlb0tleSgpIDogRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjphdWRpb0tl eSgpLCBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmxvYWRpbmdLZXkoKSwgU2hvdWxkU2FtcGxlOjpO byk7CisgICAgcGFnZS0+ZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQoKS5sb2dEaWFnbm9zdGljTWVz c2FnZShpc1ZpZGVvKCkgPyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnZpZGVvS2V5KCkgOiBEaWFn bm9zdGljTG9nZ2luZ0tleXM6OmF1ZGlvS2V5KCksIERpYWdub3N0aWNMb2dnaW5nS2V5czo6bG9h ZGluZ0tleSgpLCBTaG91bGRTYW1wbGU6Ok5vKTsKIAogICAgIG1fZmlyc3RUaW1lUGxheWluZyA9 IHRydWU7CiAKQEAgLTQ5MDMsNyArNDkwMyw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBk YXRlUGxheVN0YXRlKFVwZGF0ZVN0YXRlIHVwZGF0ZVN0YXRlKQogICAgICAgICAgICAgaWYgKG1f Zmlyc3RUaW1lUGxheWluZykgewogICAgICAgICAgICAgICAgIC8vIExvZyB0aGF0IGEgbWVkaWEg ZWxlbWVudCB3YXMgcGxheWVkLgogICAgICAgICAgICAgICAgIGlmIChhdXRvKiBwYWdlID0gZG9j dW1lbnQoKS5wYWdlKCkpCi0gICAgICAgICAgICAgICAgICAgIHBhZ2UtPmRpYWdub3N0aWNMb2dn aW5nQ2xpZW50KCkubG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoVmFsdWUoRGlhZ25vc3RpY0xvZ2dp bmdLZXlzOjptZWRpYUtleSgpLCBpc1ZpZGVvKCkgPyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnZp ZGVvS2V5KCkgOiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmF1ZGlvS2V5KCksIERpYWdub3N0aWNM b2dnaW5nS2V5czo6cGxheWVkS2V5KCksIFNob3VsZFNhbXBsZTo6Tm8pOworICAgICAgICAgICAg ICAgICAgICBwYWdlLT5kaWFnbm9zdGljTG9nZ2luZ0NsaWVudCgpLmxvZ0RpYWdub3N0aWNNZXNz YWdlKGlzVmlkZW8oKSA/IERpYWdub3N0aWNMb2dnaW5nS2V5czo6dmlkZW9LZXkoKSA6IERpYWdu b3N0aWNMb2dnaW5nS2V5czo6YXVkaW9LZXkoKSwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwbGF5 ZWRLZXkoKSwgU2hvdWxkU2FtcGxlOjpObyk7CiAgICAgICAgICAgICAgICAgbV9maXJzdFRpbWVQ bGF5aW5nID0gZmFsc2U7CiAgICAgICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmNwcAppbmRleCAyNWVmZGRkYjI5MGZmYzg0OGFjNWNjNzUy MWZlMGZhZDhhYzhiYzM2Li40NTNkM2QzN2VlN2U2YWI2YjUyZmQ0OTNjZjI0ODZlOTRiZDk3NGY3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCkBA IC0yMjMsMTEgKzIyMyw2IEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om1haW5SZXNv dXJjZUtleSgpCiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgibWFpblJlc291cmNlIik7CiB9CiAK LVN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6Om1lZGlhS2V5KCkKLXsKLSAgICByZXR1cm4g QVNDSUlMaXRlcmFsKCJtZWRpYSIpOwotfQotCiBTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdLZXlz Ojppc0Vycm9yUGFnZUtleSgpCiB7CiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgiaXNFcnJvclBh Z2UiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdL ZXlzLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oCmluZGV4 IDUzZDBkYTRmNzViMjA1OTY5MTliODU3MGMxZWUxMzdlMzViOTAzNjEuLjJhN2M0YWMzNTM2YTdm NWQyYjM5MWYwZGNiZjI3MTJhN2QwNTk2NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFn bm9zdGljTG9nZ2luZ0tleXMuaApAQCAtNzUsNyArNzUsNiBAQCBwdWJsaWM6CiAgICAgc3RhdGlj IFN0cmluZyBpc0xvYWRpbmdLZXkoKTsKICAgICBzdGF0aWMgU3RyaW5nIG1haW5Eb2N1bWVudEVy cm9yS2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBtYWluUmVzb3VyY2VLZXkoKTsKLSAgICBzdGF0 aWMgU3RyaW5nIG1lZGlhS2V5KCk7CiAgICAgc3RhdGljIFN0cmluZyBtZWRpYUxvYWRlZEtleSgp OwogICAgIHN0YXRpYyBTdHJpbmcgbWVkaWFMb2FkaW5nRmFpbGVkS2V5KCk7CiAgICAgV0VCQ09S RV9FWFBPUlQgc3RhdGljIFN0cmluZyBtaXNzaW5nVmFsaWRhdG9yRmllbGRzS2V5KCk7Cg==