167508 2017-01-27 09:46:22 -0800 Fix PageCache diagnostic logging 2017-01-27 11:16:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez achristensen commit-queue oldest_to_newest 1270663 0 cdumez 2017-01-27 09:46:22 -0800 Fix PageCache diagnostic logging. It should not call logDiagnosticMessageWithValue() with a non-numeric value. 1270664 1 299937 cdumez 2017-01-27 09:47:42 -0800 Created attachment 299937 Patch 1270708 2 299937 commit-queue 2017-01-27 11:16:18 -0800 Comment on attachment 299937 Patch Clearing flags on attachment: 299937 Committed r211291: <http://trac.webkit.org/changeset/211291> 1270709 3 commit-queue 2017-01-27 11:16:23 -0800 All reviewed patches have been landed. Closing bug. 299937 2017-01-27 09:47:42 -0800 2017-01-27 11:16:18 -0800 Patch bug-167508-20170127094538.patch text/plain 4948 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJhOGIxZjhiM2JlMzEy MDMxZDI3ZTMyZDcyZDM5NjIzOTFmMmI5NS4uMzM4ZjE0OWFlMTI2ODMyODExM2VhZTcyNjhmNWNj MjdiN2RlZDc2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTAxLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IFBhZ2VDYWNoZSBkaWFn bm9zdGljIGxvZ2dpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NzUwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBQYWdlQ2FjaGUgZGlhZ25vc3RpYyBsb2dnaW5nLiBJdCBzaG91bGQgbm90IGNh bGwgbG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoVmFsdWUoKQorICAgICAgICB3aXRoIGEgbm9uLW51 bWVyaWMgdmFsdWUuIFVzZSBsb2dEaWFnbm9zdGljTWVzc2FnZSgpIGluc3RlYWQuCisKKyAgICAg ICAgKiBoaXN0b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpsb2dQYWdlQ2Fj aGVGYWlsdXJlRGlhZ25vc3RpY01lc3NhZ2UpOgorICAgICAgICAoV2ViQ29yZTo6Y2FuQ2FjaGVG cmFtZSk6CisgICAgICAgICogcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ2FjaGVGYWlsdXJlS2V5KToK KyAgICAgICAgKFdlYkNvcmU6OkRpYWdub3N0aWNMb2dnaW5nS2V5czo6c3VjY2Vzc0tleSk6IERl bGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmZhaWx1cmVL ZXkpOiBEZWxldGVkLgorICAgICAgICAqIHBhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmg6CisK IDIwMTctMDEtMjUgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW2Nzcy1ncmlkXSBNb3ZlIEdyaWQgY2xhc3Mgb3V0IG9mIFJlbmRlckdyaWQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAppbmRleCBiZWNhZTI2MDNjNDE5NGIzYWU5ZjFl MGUwNjQ3Y2ZjMDBlOTM1YjViLi44MmVlMGQ4MWQ5ZDkzNjg5MDQ5MzE4ZThkNjhjZWQyOGJmOTU2 M2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCkBAIC02NCw3ICs2NCw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGlubGluZSB2b2lkIGxvZ1BhZ2VDYWNoZUZh aWx1cmVEaWFnbm9zdGljTWVzc2FnZShEaWFnbm9zdGljTG9nZ2luZ0NsaWVudCYgY2xpZW50LCBj b25zdCBTdHJpbmcmIHJlYXNvbikKIHsKLSAgICBjbGllbnQubG9nRGlhZ25vc3RpY01lc3NhZ2VX aXRoVmFsdWUoRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ2FjaGVLZXkoKSwgRGlhZ25vc3Rp Y0xvZ2dpbmdLZXlzOjpmYWlsdXJlS2V5KCksIHJlYXNvbiwgU2hvdWxkU2FtcGxlOjpZZXMpOwor ICAgIGNsaWVudC5sb2dEaWFnbm9zdGljTWVzc2FnZShEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBh Z2VDYWNoZUZhaWx1cmVLZXkoKSwgcmVhc29uLCBTaG91bGRTYW1wbGU6Olllcyk7CiB9CiAKIHN0 YXRpYyBpbmxpbmUgdm9pZCBsb2dQYWdlQ2FjaGVGYWlsdXJlRGlhZ25vc3RpY01lc3NhZ2UoUGFn ZSogcGFnZSwgY29uc3QgU3RyaW5nJiByZWFzb24pCkBAIC0xNTQsNyArMTU0LDcgQEAgc3RhdGlj IGJvb2wgY2FuQ2FjaGVGcmFtZShGcmFtZSYgZnJhbWUsIERpYWdub3N0aWNMb2dnaW5nQ2xpZW50 JiBkaWFnbm9zdGljTG9nZ2kKICAgICAgICAgUENMT0coIiAgIC1UaGUgZG9jdW1lbnQgY2Fubm90 IHN1c3BlbmQgaXRzIGFjdGl2ZSBET00gT2JqZWN0cyIpOwogICAgICAgICBmb3IgKGF1dG8qIGFj dGl2ZURPTU9iamVjdCA6IHVuc3VzcGVuZGFibGVPYmplY3RzKSB7CiAgICAgICAgICAgICBQQ0xP RygiICAgIC0gVW5zdXNwZW5kYWJsZTogIiwgYWN0aXZlRE9NT2JqZWN0LT5hY3RpdmVET01PYmpl Y3ROYW1lKCkpOwotICAgICAgICAgICAgZGlhZ25vc3RpY0xvZ2dpbmdDbGllbnQubG9nRGlhZ25v c3RpY01lc3NhZ2VXaXRoVmFsdWUoRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpwYWdlQ2FjaGVLZXko KSwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjp1bnN1c3BlbmRhYmxlRE9NT2JqZWN0S2V5KCksIGFj dGl2ZURPTU9iamVjdC0+YWN0aXZlRE9NT2JqZWN0TmFtZSgpLCBTaG91bGRTYW1wbGU6Olllcyk7 CisgICAgICAgICAgICBkaWFnbm9zdGljTG9nZ2luZ0NsaWVudC5sb2dEaWFnbm9zdGljTWVzc2Fn ZShEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnVuc3VzcGVuZGFibGVET01PYmplY3RLZXkoKSwgYWN0 aXZlRE9NT2JqZWN0LT5hY3RpdmVET01PYmplY3ROYW1lKCksIFNob3VsZFNhbXBsZTo6WWVzKTsK ICAgICAgICAgICAgIFVOVVNFRF9QQVJBTShhY3RpdmVET01PYmplY3QpOwogICAgICAgICB9CiAg ICAgICAgIGxvZ1BhZ2VDYWNoZUZhaWx1cmVEaWFnbm9zdGljTWVzc2FnZShkaWFnbm9zdGljTG9n Z2luZ0NsaWVudCwgRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpjYW5ub3RTdXNwZW5kQWN0aXZlRE9N T2JqZWN0c0tleSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3Rp Y0xvZ2dpbmdLZXlzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdL ZXlzLmNwcAppbmRleCAyNWVmZGRkYjI5MGZmYzg0OGFjNWNjNzUyMWZlMGZhZDhhYzhiYzM2Li4w Zjg2MzFhNGExZmJhNTZmY2NjNTdiMzg3M2VhZTlhOWQ2ZjU3N2M2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuY3BwCkBAIC0xMDMsMTYgKzEwMyw2IEBA IFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDb250YWluc0F0TGVhc3RPbmVNZWRp YUVuZ2luZUtleSgpCiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicGFnZUNvbnRhaW5zQXRMZWFz dE9uZU1lZGlhRW5naW5lIik7CiB9CiAKLVN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnN1 Y2Nlc3NLZXkoKQotewotICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInN1Y2Nlc3MiKTsKLX0KLQot U3RyaW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6ZmFpbHVyZUtleSgpCi17Ci0gICAgcmV0dXJu IEFTQ0lJTGl0ZXJhbCgiZmFpbHVyZSIpOwotfQotCiBTdHJpbmcgRGlhZ25vc3RpY0xvZ2dpbmdL ZXlzOjpwYWdlTG9hZGVkS2V5KCkKIHsKICAgICByZXR1cm4gQVNDSUlMaXRlcmFsKCJwYWdlTG9h ZGVkIik7CkBAIC0xOTgsNiArMTg4LDExIEBAIFN0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6 OnBhZ2VDYWNoZUtleSgpCiAgICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgicGFnZUNhY2hlIik7CiB9 CiAKK1N0cmluZyBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OnBhZ2VDYWNoZUZhaWx1cmVLZXkoKQor eworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInBhZ2VDYWNoZUZhaWx1cmUiKTsKK30KKwogU3Ry aW5nIERpYWdub3N0aWNMb2dnaW5nS2V5czo6bm9Eb2N1bWVudExvYWRlcktleSgpCiB7CiAgICAg cmV0dXJuIEFTQ0lJTGl0ZXJhbCgibm9Eb2N1bWVudExvYWRlciIpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tleXMuaCBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRGlhZ25vc3RpY0xvZ2dpbmdLZXlzLmgKaW5kZXggNTNkMGRhNGY3NWIyMDU5NjkxOWI4 NTcwYzFlZTEzN2UzNWI5MDM2MS4uNDc2N2QxYjQxMTY2Y2Q2Zjg2NGQyOWIyZWI0ZGUzN2MzNDcy NTlhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EaWFnbm9zdGljTG9nZ2luZ0tl eXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RpYWdub3N0aWNMb2dnaW5nS2V5cy5oCkBA IC05Nyw2ICs5Nyw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgU3RyaW5nIG5vdEluTWVtb3J5Q2Fj aGVLZXkoKTsKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgU3RyaW5nIG90aGVyS2V5KCk7CiAg ICAgc3RhdGljIFN0cmluZyBwYWdlQ2FjaGVLZXkoKTsKKyAgICBzdGF0aWMgU3RyaW5nIHBhZ2VD YWNoZUZhaWx1cmVLZXkoKTsKICAgICBzdGF0aWMgU3RyaW5nIHBhZ2VDb250YWluc0F0TGVhc3RP bmVNZWRpYUVuZ2luZUtleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zQXRMZWFz dE9uZVBsdWdpbktleSgpOwogICAgIHN0YXRpYyBTdHJpbmcgcGFnZUNvbnRhaW5zTWVkaWFFbmdp bmVLZXkoKTsKQEAgLTE2OCwxMCArMTY5LDYgQEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JU IHN0YXRpYyBTdHJpbmcgbWVtb3J5VXNhZ2VUb0RpYWdub3N0aWNMb2dnaW5nS2V5KHVpbnQ2NF90 IG1lbW9yeVVzYWdlKTsKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgU3RyaW5nIGZvcmVncm91 bmRDUFVVc2FnZVRvRGlhZ25vc3RpY0xvZ2dpbmdLZXkoZG91YmxlIGNwdVVzYWdlKTsKICAgICBX RUJDT1JFX0VYUE9SVCBzdGF0aWMgU3RyaW5nIGJhY2tncm91bmRDUFVVc2FnZVRvRGlhZ25vc3Rp Y0xvZ2dpbmdLZXkoZG91YmxlIGNwdVVzYWdlKTsKLQotICAgIC8vIFN1Y2Nlc3MgLyBGYWlsdXJl IGtleXMuCi0gICAgc3RhdGljIFN0cmluZyBzdWNjZXNzS2V5KCk7Ci0gICAgc3RhdGljIFN0cmlu ZyBmYWlsdXJlS2V5KCk7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==