167505 2017-01-27 08:45:35 -0800 Extend create_hash_table to specify Intrinsic 2017-01-27 15:30:51 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1270652 0 ysuzuki 2017-01-27 08:45:35 -0800 Extend create_hash_table to specify Intrinsic 1270655 1 299935 ysuzuki 2017-01-27 08:51:04 -0800 Created attachment 299935 Patch 1270696 2 299935 mark.lam 2017-01-27 10:54:59 -0800 Comment on attachment 299935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review > Source/JavaScriptCore/create_hash_table:-337 > - if ($name eq "arrayPrototypeTable") { > - $intrinsic = "ArrayPushIntrinsic" if ($key eq "push"); > - $intrinsic = "ArrayPopIntrinsic" if ($key eq "pop"); > - } What about these? I don't see the code that replaces them. 1270697 3 299935 mark.lam 2017-01-27 10:57:57 -0800 Comment on attachment 299935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review >> Source/JavaScriptCore/create_hash_table:-337 >> - } > > What about these? I don't see the code that replaces them. Oh, I think they were never needed in the first place. Yusuke, can you confirm before landing? Thanks. 1270789 4 299935 ysuzuki 2017-01-27 15:04:25 -0800 Comment on attachment 299935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review Thanks! >>> Source/JavaScriptCore/create_hash_table:-337 >>> - } >> >> What about these? I don't see the code that replaces them. > > Oh, I think they were never needed in the first place. Yusuke, can you confirm before landing? Thanks. Yes, this is dead code. We no longer use lut table for ArrayPrototype. 1270798 5 299935 commit-queue 2017-01-27 15:30:47 -0800 Comment on attachment 299935 Patch Clearing flags on attachment: 299935 Committed r211306: <http://trac.webkit.org/changeset/211306> 1270799 6 commit-queue 2017-01-27 15:30:51 -0800 All reviewed patches have been landed. Closing bug. 299935 2017-01-27 08:51:04 -0800 2017-01-27 15:30:47 -0800 Patch bug-167505-20170128014900.patch text/plain 4208 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 OWM0NjI4MDhhYzgzOTNmOWQ1MGNiNGNjM2NjNTdhMzRlNGQzYmJlLi41N2E4N2Q0OTIzOWVhNzcx ZWNlN2FmZmY0YmI2NWZiZjMzZmVlNDhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wMS0yNyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBFeHRlbmQgY3JlYXRlX2hhc2hfdGFibGUgdG8gc3BlY2lmeSBJbnRy aW5zaWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NzUwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgcGF0Y2ggZXh0ZW5kcyBjcmVhdGVfaGFzaF90YWJsZSB0byBzcGVjaWZ5IEludHJpbnNpYy4K KyAgICAgICAgV2UgY2FuIHNldCBJbnRyaW5zaWMgaW4gdGhlIHN0YXRpYyBwcm9wZXJ0eSB0YWJs ZSBkZWZpbml0aW9uCisgICAgICAgIGluIHJ1bnRpbWUvWFhYLmguCisKKyAgICAgICAgQW5kIGRy b3AgdGhlIGFkaG9jIGNvZGUgZm9yIFN0cmluZy5mcm9tQ2hhckNvZGUgaW4gY3JlYXRlX2hhc2hf dGFibGUuCisKKyAgICAgICAgKiBjcmVhdGVfaGFzaF90YWJsZToKKyAgICAgICAgKiBydW50aW1l L1N0cmluZ0NvbnN0cnVjdG9yLmNwcDoKKwogMjAxNy0wMS0yNyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IEdUSysg ZGVidWcgYnVpbGQgYWZ0ZXIgcjIxMTI0Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9jcmVhdGVfaGFzaF90YWJsZSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9jcmVhdGVfaGFz aF90YWJsZQppbmRleCAyOGRmNmU3MjdhZWY2YWJiMzA0M2Y5NzQ3MjdhNzg4NWJmM2NhZDAzLi5k MDIwZjAyZGIwZTIyYjllM2QyMTg5ZjA5NGVkMTg1YTRhYTlhZGFmIDEwMDc1NQotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvY3JlYXRlX2hhc2hfdGFibGUKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2NyZWF0ZV9oYXNoX3RhYmxlCkBAIC03NiwxMSArNzYsMTIgQEAgd2hpbGUgKDxJTj4p IHsKICAgICAgICAgJGluY2x1ZGVCdWlsdGluID0gMDsKIAogICAgICAgICAkaW5zaWRlID0gMDsK LSAgICB9IGVsc2lmICgvXihcUyspXHMqKFxTKylccyooW1x3XHxdKilccyooXHcqKVxzKiQvICYm ICRpbnNpZGUpIHsKKyAgICB9IGVsc2lmICgvXihcUyspXHMqKFxTKylccyooW1x3XHxdKilccyoo XHcqKVxzKihcdyopXHMqJC8gJiYgJGluc2lkZSkgewogICAgICAgICBteSAka2V5ID0gJDE7CiAg ICAgICAgIG15ICR2YWwgPSAkMjsKICAgICAgICAgbXkgJGF0dCA9ICQzOwogICAgICAgICBteSAk cGFyYW0gPSAkNDsKKyAgICAgICAgbXkgJGludHJpbnNpYyA9ICQ1OwogCiAgICAgICAgIHB1c2go QGtleXMsICRrZXkpOwogICAgICAgICBwdXNoKEBhdHRycywgbGVuZ3RoKCRhdHQpID4gMCA/ICRh dHQgOiAiMCIpOwpAQCAtOTAsNyArOTEsNyBAQCB3aGlsZSAoPElOPikgewogICAgICAgICB9CiAK ICAgICAgICAgaWYgKCRhdHQgPX4gbS9GdW5jdGlvbi8pIHsKLSAgICAgICAgICAgIHB1c2goQHZh bHVlcywgeyAidHlwZSIgPT4gIkZ1bmN0aW9uIiwgImZ1bmN0aW9uIiA9PiAkdmFsLCAicGFyYW1z IiA9PiAobGVuZ3RoKCRwYXJhbSkgPyAkcGFyYW0gOiAiIikgfSk7CisgICAgICAgICAgICBwdXNo KEB2YWx1ZXMsIHsgInR5cGUiID0+ICJGdW5jdGlvbiIsICJmdW5jdGlvbiIgPT4gJHZhbCwgInBh cmFtcyIgPT4gKGxlbmd0aCgkcGFyYW0pID8gJHBhcmFtIDogIiIpLCAiaW50cmluc2ljIiA9PiAo bGVuZ3RoKCRpbnRyaW5zaWMpID8gJGludHJpbnNpYyA6ICJOb0ludHJpbnNpYyIpIH0pOwogICAg ICAgICAgICAgI3ByaW50ZiBTVERFUlIgIldBUk5JTkc6IE51bWJlciBvZiBhcmd1bWVudHMgbWlz c2luZyBmb3IgJGtleS8kdmFsXG4iIGlmIChsZW5ndGgoJHBhcmFtKSA9PSAwKTsKICAgICAgICAg fSBlbHNpZiAoJGF0dCA9fiBtL0FjY2Vzc29yLykgewogICAgICAgICAgICAgbXkgJGdldCA9ICR2 YWw7CkBAIC0zMDEsMTEgKzMwMiwxMyBAQCBzdWIgb3V0cHV0KCkgewogICAgICAgICBteSAkc2Vj b25kVmFsdWUgPSAiIjsKICAgICAgICAgbXkgJGZpcnN0Q2FzdFN0ciA9ICIiOwogICAgICAgICBt eSAkc2Vjb25kQ2FzdFN0ciA9ICIiOworICAgICAgICBteSAkaW50cmluc2ljID0gIk5vSW50cmlu c2ljIjsKIAogICAgICAgICBpZiAoJHZhbHVlc1skaV17InR5cGUifSBlcSAiRnVuY3Rpb24iKSB7 CiAgICAgICAgICAgICAkZmlyc3RDYXN0U3RyID0gInN0YXRpY19jYXN0PE5hdGl2ZUZ1bmN0aW9u PiI7CiAgICAgICAgICAgICAkZmlyc3RWYWx1ZSA9ICR2YWx1ZXNbJGldeyJmdW5jdGlvbiJ9Owog ICAgICAgICAgICAgJHNlY29uZFZhbHVlID0gJHZhbHVlc1skaV17InBhcmFtcyJ9OworICAgICAg ICAgICAgJGludHJpbnNpYyA9ICR2YWx1ZXNbJGldeyJpbnRyaW5zaWMifTsKICAgICAgICAgfSBl bHNpZiAoJHZhbHVlc1skaV17InR5cGUifSBlcSAiQWNjZXNzb3IiKSB7CiAgICAgICAgICAgICAk Zmlyc3RDYXN0U3RyID0gInN0YXRpY19jYXN0PE5hdGl2ZUZ1bmN0aW9uPiI7CiAgICAgICAgICAg ICAkc2Vjb25kQ2FzdFN0ciA9ICJzdGF0aWNfY2FzdDxOYXRpdmVGdW5jdGlvbj4iOwpAQCAtMzI5 LDEzICszMzIsNiBAQCBzdWIgb3V0cHV0KCkgewogICAgICAgICAgICAgJHNlY29uZFZhbHVlID0g IjAiOwogICAgICAgICB9CiAKLSAgICAgICAgbXkgJGludHJpbnNpYyA9ICJOb0ludHJpbnNpYyI7 Ci0gICAgICAgICRpbnRyaW5zaWMgPSAiRnJvbUNoYXJDb2RlSW50cmluc2ljIiBpZiAoJGtleSBl cSAiZnJvbUNoYXJDb2RlIik7Ci0gICAgICAgIGlmICgkbmFtZSBlcSAiYXJyYXlQcm90b3R5cGVU YWJsZSIpIHsKLSAgICAgICAgICAgICRpbnRyaW5zaWMgPSAiQXJyYXlQdXNoSW50cmluc2ljIiBp ZiAoJGtleSBlcSAicHVzaCIpOwotICAgICAgICAgICAgJGludHJpbnNpYyA9ICJBcnJheVBvcElu dHJpbnNpYyIgaWYgKCRrZXkgZXEgInBvcCIpOwotICAgICAgICB9Ci0KICAgICAgICAgaWYgKCR2 YWx1ZXNbJGldeyJ0eXBlIn0gZXEgIkZ1bmN0aW9uIiAmJiAkZmlyc3RWYWx1ZSBlcSAiSlNCdWls dGluIikgIHsKICAgICAgICAgICAgIG15ICR0YWJsZUhlYWQgPSAkbmFtZTsKICAgICAgICAgICAg ICR0YWJsZUhlYWQgPX4gcy9UYWJsZSQvLzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cmluZ0NvbnN0cnVjdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL1N0cmluZ0NvbnN0cnVjdG9yLmNwcAppbmRleCBhZTI2N2IwYWE5Zjk1OTdmOTNj MDUzNjRhNGY4N2Y5YzM0NmJlMDgxLi45ZGY0YzkyNzYxNGRmNWM2YjMyODE3OTc3MWVjYjJkNDU4 NzJmNWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdD b25zdHJ1Y3Rvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5n Q29uc3RydWN0b3IuY3BwCkBAIC00NCw3ICs0NCw3IEBAIGNvbnN0IENsYXNzSW5mbyBTdHJpbmdD b25zdHJ1Y3Rvcjo6c19pbmZvID0geyAiRnVuY3Rpb24iLCAmSW50ZXJuYWxGdW5jdGlvbjo6c19p CiAKIC8qIFNvdXJjZSBmb3IgU3RyaW5nQ29uc3RydWN0b3IubHV0LmgKIEBiZWdpbiBzdHJpbmdD b25zdHJ1Y3RvclRhYmxlCi0gIGZyb21DaGFyQ29kZSAgICAgICAgICBzdHJpbmdGcm9tQ2hhckNv ZGUgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAxCisgIGZyb21DaGFyQ29kZSAgICAgICAgICBz dHJpbmdGcm9tQ2hhckNvZGUgICAgICAgICBEb250RW51bXxGdW5jdGlvbiAxIEZyb21DaGFyQ29k ZUludHJpbnNpYwogICBmcm9tQ29kZVBvaW50ICAgICAgICAgc3RyaW5nRnJvbUNvZGVQb2ludCAg ICAgICAgRG9udEVudW18RnVuY3Rpb24gMQogICByYXcgICAgICAgICAgICAgICAgICAgSlNCdWls dGluICAgICAgICAgICAgICAgICAgRG9udEVudW18RnVuY3Rpb24gMQogQGVuZAo=