167486 2017-01-26 20:35:35 -0800 Don't flash a tap highlight for the entirety of an editable WKWebView 2017-01-28 16:18:25 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167488 P2 Normal --- 1 thorton thorton cdumez commit-queue dbates enrica esprehn+autocc kangil.han mitz oldest_to_newest 1270512 0 thorton 2017-01-26 20:35:35 -0800 Don't flash a tap highlight for the entirety of an editable WKWebView 1270513 1 299903 thorton 2017-01-26 20:35:52 -0800 Created attachment 299903 Patch 1270528 2 299903 mitz 2017-01-26 21:02:32 -0800 Comment on attachment 299903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299903&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:639 > + if (is<HTMLBodyElement>(node) && m_page->isEditable()) > + return; > + Does this exclude the body of subframes as well? Is that expected? 1270529 3 thorton 2017-01-26 21:05:06 -0800 That is a fair question; this will certainly stop flashing in that case too, but I don't know that that is necessarily a bad thing. To me, the tap highlight is much more about small buttons/links/input fields, and less about (usually) large things like frames. But we could limit it to just the main frame body. What do you think? 1270533 4 mitz 2017-01-26 21:13:35 -0800 (In reply to comment #3) > That is a fair question; this will certainly stop flashing in that case too, > but I don't know that that is necessarily a bad thing. To me, the tap > highlight is much more about small buttons/links/input fields, and less > about (usually) large things like frames. But we could limit it to just the > main frame body. What do you think? If the goal is to make editable views behave more like text views, or to “not flash a tap highlight for the entirety of an editable WKWebView”, then applying this to subframes’ bodies doesn’t seem to support the goal. I believe that there is already a size-based filter to prevent large highlights, so if a subframe’s body or an image are sufficiently large, they won’t highlight. There is no reason to infer size from element type. 1270536 5 thorton 2017-01-26 21:17:54 -0800 (In reply to comment #4) > (In reply to comment #3) > > That is a fair question; this will certainly stop flashing in that case too, > > but I don't know that that is necessarily a bad thing. To me, the tap > > highlight is much more about small buttons/links/input fields, and less > > about (usually) large things like frames. But we could limit it to just the > > main frame body. What do you think? > > If the goal is to make editable views behave more like text views, I think that is the goal. > or to “not flash a tap highlight for the entirety of an editable WKWebView”, then > applying this to subframes’ bodies doesn’t seem to support the goal. I > believe that there is already a size-based filter to prevent large > highlights, Does not seem like a very good filter if it lets a iPad-sized <body> get highlighted, but OK. > so if a subframe’s body or an image are sufficiently large, they > won’t highlight. There is no reason to infer size from element type. Fair! I will adjust the patch. 1270546 6 mitz 2017-01-26 21:33:46 -0800 (In reply to comment #5) > Does not seem like a very good filter if it lets a iPad-sized <body> get > highlighted, but OK. Filed bug 167488 for that. 1270846 7 299982 thorton 2017-01-27 16:51:50 -0800 Created attachment 299982 Patch 1271066 8 299982 mitz 2017-01-28 16:14:56 -0800 Comment on attachment 299982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299982&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:637 > + if (node == m_page->mainFrame().document()->body() && m_page->isEditable()) Is it better to evaluate these in the reverse order? 1271068 9 thorton 2017-01-28 16:18:25 -0800 https://trac.webkit.org/changeset/211343 299903 2017-01-26 20:35:52 -0800 2017-01-27 16:51:48 -0800 Patch bug-167486-20170126203349.patch text/plain 1878 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGY4ZTQ4NzNmMTBjY2Yy ZDA5ZWI5Y2NkMmU2ZDg5NDlhNzA5YjM2Yy4uN2U4NTZkYWNiZTExOTk0YThmNDJkNDFiOTQxZGUy NDY2OTUxYTY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTI2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGZsYXNo IGEgdGFwIGhpZ2hsaWdodCBmb3IgdGhlIGVudGlyZXR5IG9mIGFuIGVkaXRhYmxlIFdLV2ViVmll dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDg2 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDE5Mzk5Nj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2VuZFRhcEhpZ2hsaWdodEZv ck5vZGVJZk5lY2Vzc2FyeSk6CisgICAgICAgIEJhaWwgZnJvbSBwcm92aWRpbmcgYSB0YXAgaGln aGxpZ2h0IGlmIHdlIGFyZSBhYm91dCB0byBoaWdobGlnaHQKKyAgICAgICAgdGhlIGVudGlyZSBi b2R5IG9mIGFuIGVkaXRhYmxlIHdlYiB2aWV3LgorCiAyMDE3LTAxLTI2ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSBmb3IgdXBk YXRpbmcgV2Vic2l0ZVBvbGljaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggMWUzZDU5MGMyYjBhMjlhMGUyZDU1ZmE3 MWEzMzg0MzkzZDg0ZWVjYS4uODg5YmVkNGM1NGViZTc4Y2JkZDVmOGI5Mzk3NWE5YTYxMWIzOWI4 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbQpAQCAtNjgsNiArNjgsNyBAQAogI2ltcG9ydCA8V2ViQ29yZS9HZW9tZXRyeVV0 aWxpdGllcy5oPgogI2ltcG9ydCA8V2ViQ29yZS9IVE1MQXJlYUVsZW1lbnQuaD4KICNpbXBvcnQg PFdlYkNvcmUvSFRNTEF0dGFjaG1lbnRFbGVtZW50Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0hUTUxC b2R5RWxlbWVudC5oPgogI2ltcG9ydCA8V2ViQ29yZS9IVE1MRWxlbWVudC5oPgogI2ltcG9ydCA8 V2ViQ29yZS9IVE1MRWxlbWVudFR5cGVIZWxwZXJzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0hUTUxG b3JtRWxlbWVudC5oPgpAQCAtNjMzLDYgKzYzNCw5IEBAIHZvaWQgV2ViUGFnZTo6c2VuZFRhcEhp Z2hsaWdodEZvck5vZGVJZk5lY2Vzc2FyeSh1aW50NjRfdCByZXF1ZXN0SUQsIE5vZGUqIG5vZGUp CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoaXM8SFRNTEJvZHlF bGVtZW50Pihub2RlKSAmJiBtX3BhZ2UtPmlzRWRpdGFibGUoKSkKKyAgICAgICAgcmV0dXJuOwor CiAgICAgaWYgKGlzPEVsZW1lbnQ+KCpub2RlKSkgewogICAgICAgICBBU1NFUlQobV9wYWdlKTsK ICAgICAgICAgbV9wYWdlLT5tYWluRnJhbWUoKS5sb2FkZXIoKS5jbGllbnQoKS5wcmVmZXRjaERO Uyhkb3duY2FzdDxFbGVtZW50Pigqbm9kZSkuYWJzb2x1dGVMaW5rVVJMKCkuaG9zdCgpKTsK 299982 2017-01-27 16:51:50 -0800 2017-01-28 16:14:56 -0800 Patch bug-167486-20170127164946.patch text/plain 3222 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUwNGMzNDc2Yjk0NDAx OTM0OTIxZTMwYmEwY2ViYzRhNzlkZGUwYi4uZjUzYmRjNzY2MDQwYThlNTgyODkzY2M0MmZiYjEx NmVlMTliYzhkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAxLTI3ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGZsYXNo IGEgdGFwIGhpZ2hsaWdodCBmb3IgdGhlIGVudGlyZXR5IG9mIGFuIGVkaXRhYmxlIFdLV2ViVmll dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDg2 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDE5Mzk5Nj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICBF eHBvcnQuCisKIDIwMTctMDEtMjYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgog CiAgICAgICAgIEdhbWVwYWQgc3VwcG9ydCBzaG93cyB3cm9uZyB2YWx1ZXMgZm9yIFBTNCBjb250 cm9sbGVycyAoRC1wYWQgaXMgbWlzc2luZykuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZGY4ZTQ4NzNmMTBjY2Yy ZDA5ZWI5Y2NkMmU2ZDg5NDlhNzA5YjM2Yy4uN2U4NTZkYWNiZTExOTk0YThmNDJkNDFiOTQxZGUy NDY2OTUxYTY4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAxLTI2ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIERvbid0IGZsYXNo IGEgdGFwIGhpZ2hsaWdodCBmb3IgdGhlIGVudGlyZXR5IG9mIGFuIGVkaXRhYmxlIFdLV2ViVmll dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDg2 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDE5Mzk5Nj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2VuZFRhcEhpZ2hsaWdodEZv ck5vZGVJZk5lY2Vzc2FyeSk6CisgICAgICAgIEJhaWwgZnJvbSBwcm92aWRpbmcgYSB0YXAgaGln aGxpZ2h0IGlmIHdlIGFyZSBhYm91dCB0byBoaWdobGlnaHQKKyAgICAgICAgdGhlIGVudGlyZSBi b2R5IG9mIGFuIGVkaXRhYmxlIHdlYiB2aWV3LgorCiAyMDE3LTAxLTI2ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSBmb3IgdXBk YXRpbmcgV2Vic2l0ZVBvbGljaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDI4YzAxNTQ2ZWEw MmVhNTMyYzU2NDE0ZmUzMjEyZjdkMDJhMjUxZGEuLjcyYTg2MjQyMDk2MzE2MGE2Nzc2NWQzNzY5 NTlmZTg1NWFmNThlYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC04ODYsNyArODg2LDcgQEAg cHVibGljOgogICAgIHN0YXRpYyBib29sIGhhc1ZhbGlkTmFtZXNwYWNlRm9yRWxlbWVudHMoY29u c3QgUXVhbGlmaWVkTmFtZSYpOwogICAgIHN0YXRpYyBib29sIGhhc1ZhbGlkTmFtZXNwYWNlRm9y QXR0cmlidXRlcyhjb25zdCBRdWFsaWZpZWROYW1lJik7CiAKLSAgICBIVE1MQm9keUVsZW1lbnQq IGJvZHkoKSBjb25zdDsKKyAgICBXRUJDT1JFX0VYUE9SVCBIVE1MQm9keUVsZW1lbnQqIGJvZHko KSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCBIVE1MRWxlbWVudCogYm9keU9yRnJhbWVzZXQo KSBjb25zdDsKICAgICBXRUJDT1JFX0VYUE9SVCBFeGNlcHRpb25Pcjx2b2lkPiBzZXRCb2R5T3JG cmFtZXNldChSZWZQdHI8SFRNTEVsZW1lbnQ+JiYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggMWUzZDU5MGMyYjBh MjlhMGUyZDU1ZmE3MWEzMzg0MzkzZDg0ZWVjYS4uMjk5OTQwNTUxNDQxOTQzNDc1ZDczY2ZiNzA2 ZDI3MTliMzU0MmUwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtNjgsNiArNjgsNyBAQAogI2ltcG9ydCA8V2ViQ29y ZS9HZW9tZXRyeVV0aWxpdGllcy5oPgogI2ltcG9ydCA8V2ViQ29yZS9IVE1MQXJlYUVsZW1lbnQu aD4KICNpbXBvcnQgPFdlYkNvcmUvSFRNTEF0dGFjaG1lbnRFbGVtZW50Lmg+CisjaW1wb3J0IDxX ZWJDb3JlL0hUTUxCb2R5RWxlbWVudC5oPgogI2ltcG9ydCA8V2ViQ29yZS9IVE1MRWxlbWVudC5o PgogI2ltcG9ydCA8V2ViQ29yZS9IVE1MRWxlbWVudFR5cGVIZWxwZXJzLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL0hUTUxGb3JtRWxlbWVudC5oPgpAQCAtNjMzLDYgKzYzNCw5IEBAIHZvaWQgV2ViUGFn ZTo6c2VuZFRhcEhpZ2hsaWdodEZvck5vZGVJZk5lY2Vzc2FyeSh1aW50NjRfdCByZXF1ZXN0SUQs IE5vZGUqIG5vZGUpCiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAo bm9kZSA9PSBtX3BhZ2UtPm1haW5GcmFtZSgpLmRvY3VtZW50KCktPmJvZHkoKSAmJiBtX3BhZ2Ut PmlzRWRpdGFibGUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgaWYgKGlzPEVsZW1lbnQ+KCpu b2RlKSkgewogICAgICAgICBBU1NFUlQobV9wYWdlKTsKICAgICAgICAgbV9wYWdlLT5tYWluRnJh bWUoKS5sb2FkZXIoKS5jbGllbnQoKS5wcmVmZXRjaEROUyhkb3duY2FzdDxFbGVtZW50Pigqbm9k ZSkuYWJzb2x1dGVMaW5rVVJMKCkuaG9zdCgpKTsK