16748 2008-01-05 14:12:12 -0800 DOMRange.cloneContents does not work (Acid3 bug) 2008-01-06 03:30:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned ap oldest_to_newest 66301 0 eric 2008-01-05 14:12:12 -0800 DOMRange.cloneContents does not work (Acid3 bug) // DOM Range function () { // test 11: basic ranges tests var r = document.createRange(); assert(r, "range not created"); assert(r.collapsed, "new range wasn't collapsed"); assert(r.commonAncestorContainer == document, "new range's common ancestor wasn't the document"); assert(r.startContainer == document, "new range's start container wasn't the document"); assert(r.startOffset == 0, "new range's start offset wasn't zero"); assert(r.endContainer == document, "new range's end container wasn't the document"); assert(r.endOffset == 0, "new range's end offset wasn't zero"); assert(r.cloneContents(), "cloneContents() didn't return an object"); assert(r.cloneContents().childNodes.length == 0, "nothing cloned was more than nothing"); assert(r.cloneRange().toString() == "", "nothing cloned stringifed to more than nothing"); r.collapse(true); // no effect assert(r.compareBoundaryPoints(r.START_TO_END, r.cloneRange()) == 0, "starting boundary point of range wasn't the same as the end boundary point of the clone range"); r.deleteContents(); // no effect assert(r.extractContents().childNodes.length == 0, "nothing removed was more than nothing"); r.insertNode(document.createComment("commented inserted to test ranges")); assert(!r.collapsed, "range with inserted comment isn't collapsed"); assert(r.commonAncestorContainer == document, "range with inserted comment has common ancestor that isn't the document"); assert(r.startContainer == document, "range with inserted comment has start container that isn't the document"); assert(r.startOffset == 0, "range with inserted comment has start offset that isn't zero"); assert(r.endContainer == document, "range with inserted comment has end container that isn't the document"); assert(r.endOffset == 1, "range with inserted comment has end offset that isn't after the comment"); return 1; }, 66365 1 18297 andrew 2008-01-06 01:13:36 -0800 Created attachment 18297 Proposed patch The first part of this bug is due to not returning a DocumentFragment for an empty range. (This won't fix the full Acid3 test, we fail at "range with inserted comment isn't collapsed" after this patch) 66368 2 18297 darin 2008-01-06 03:04:05 -0800 Comment on attachment 18297 Proposed patch There's no need to call fragment.release() if you're not returning the fragment. A plain old "return 0" will do, and it's more efficient. Otherwise looks great. I'll say review+, but really those extra fragment.release() calls should not be in there. 66369 3 andrew 2008-01-06 03:30:17 -0800 Landed in r29207 18297 2008-01-06 01:13:36 -0800 2008-01-06 03:04:05 -0800 Proposed patch 16748-patch-1.txt text/plain 4737 andrew SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyOTIwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDgtMDEtMDYgIEFuZHJldyBXZWxsaW5ndG9uICA8cHJvdG9uQHdp cmV0YXBwZWQubmV0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAg ICAgICAKKyAgICAgICAgRE9NUmFuZ2UuY2xvbmVDb250ZW50cyBkb2VzIG5vdCB3b3JrIChBY2lk MyBidWcpCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NzQ4CisgICAgICAgIAorICAgICAgICBXaGVuIGNsb25pbmcgYW4gZW1wdHkgcmFuZ2UsIHJldHVy biBhbiBlbXB0eSBEb2NtZW50RnJhZ21lbnQgaW5zdGVhZCBvZgorICAgICAgICBudWxsIG9yIHVu ZGVmaW5lZC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0 eS5odG1sCisKKyAgICAgICAgKiBkb20vUmFuZ2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmFu Z2U6OnByb2Nlc3NDb250ZW50cyk6CisKIDIwMDgtMDEtMDYgIEFscCBUb2tlciAgPGFscEBhdG9r ZXIuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiBXZWJDb3JlL2RvbS9S YW5nZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vUmFuZ2UuY3BwCShyZXZpc2lvbiAy OTIwNSkKKysrIFdlYkNvcmUvZG9tL1JhbmdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMzLDE1 ICs2MzMsMjMgQEAgUGFzc1JlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBSYW5nZTo6cHJvYwogCiAg ICAgLy8gIyMjIHBlcmhhcHMgZGlzYWJsZSBub2RlIGRlbGV0aW9uIG5vdGlmaWNhdGlvbiBmb3Ig dGhpcyByYW5nZSB3aGlsZSB3ZSBkbyB0aGlzPwogCisgICAgUmVmUHRyPERvY3VtZW50RnJhZ21l bnQ+IGZyYWdtZW50OworICAgIGlmIChhY3Rpb24gPT0gRVhUUkFDVF9DT05URU5UUyB8fCBhY3Rp b24gPT0gQ0xPTkVfQ09OVEVOVFMpCisgICAgICAgIGZyYWdtZW50ID0gbmV3IERvY3VtZW50RnJh Z21lbnQobV9vd25lckRvY3VtZW50LmdldCgpKTsKKyAgICAKICAgICBlYyA9IDA7CiAgICAgaWYg KGNvbGxhcHNlZChlYykpCisgICAgICAgIHJldHVybiBmcmFnbWVudC5yZWxlYXNlKCk7CisgICAg aWYgKGVjKSB7CisgICAgICAgIGZyYWdtZW50LnJlbGVhc2UoKTsKICAgICAgICAgcmV0dXJuIDA7 Ci0gICAgaWYgKGVjKQotICAgICAgICByZXR1cm4gMDsKKyAgICB9CiAKICAgICBOb2RlICpjbW5S b290ID0gY29tbW9uQW5jZXN0b3JDb250YWluZXIoZWMpOwotICAgIGlmIChlYykKKyAgICBpZiAo ZWMpIHsKKyAgICAgICAgZnJhZ21lbnQucmVsZWFzZSgpOwogICAgICAgICByZXR1cm4gMDsKKyAg ICB9CiAKICAgICAvLyB3aGF0IGlzIHRoZSBoaWdoZXN0IG5vZGUgdGhhdCBwYXJ0aWFsbHkgc2Vs ZWN0cyB0aGUgc3RhcnQgb2YgdGhlIHJhbmdlPwogICAgIE5vZGUgKnBhcnRpYWxTdGFydCA9IDA7 CkBAIC02NTksMTAgKzY2Nyw2IEBAIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gUmFuZ2U6 OnByb2MKICAgICAgICAgICAgIHBhcnRpYWxFbmQgPSBwYXJ0aWFsRW5kLT5wYXJlbnROb2RlKCk7 CiAgICAgfQogCi0gICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50OwotICAgIGlm IChhY3Rpb24gPT0gRVhUUkFDVF9DT05URU5UUyB8fCBhY3Rpb24gPT0gQ0xPTkVfQ09OVEVOVFMp Ci0gICAgICAgIGZyYWdtZW50ID0gbmV3IERvY3VtZW50RnJhZ21lbnQobV9vd25lckRvY3VtZW50 LmdldCgpKTsKLQogICAgIC8vIFNpbXBsZSBjYXNlOiB0aGUgc3RhcnQgYW5kIGVuZCBjb250YWlu ZXJzIGFyZSB0aGUgc2FtZS4gV2UganVzdCBncmFiCiAgICAgLy8gZXZlcnl0aGluZyA+PSBzdGFy dCBvZmZzZXQgYW5kIDwgZW5kIG9mZnNldAogICAgIGlmIChtX3N0YXJ0Q29udGFpbmVyID09IG1f ZW5kQ29udGFpbmVyKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyOTIwNSkKKysrIExheW91dFRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA4LTAxLTA2ICBB bmRyZXcgV2VsbGluZ3RvbiAgPHByb3RvbkB3aXJldGFwcGVkLm5ldD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIERPTVJhbmdlLmNsb25l Q29udGVudHMgZG9lcyBub3Qgd29yayAoQWNpZDMgYnVnKQorICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjc0OAorICAgICAgICAKKyAgICAgICAgV2hlbiBj bG9uaW5nIGFuIGVtcHR5IHJhbmdlLCByZXR1cm4gYW4gZW1wdHkgRG9jbWVudEZyYWdtZW50IGlu c3RlYWQgb2YKKyAgICAgICAgbnVsbCBvciB1bmRlZmluZWQuCisKKyAgICAgICAgKiBmYXN0L2Rv bS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0eS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZG9tL1JhbmdlL3JhbmdlLWNsb25lLWVtcHR5Lmh0bWw6IEFkZGVkLgorICAgICAgICAq IGZhc3QvZG9tL1JhbmdlL3Jlc291cmNlcy9yYW5nZS1jbG9uZS1lbXB0eS5qczogQWRkZWQuCisK IDIwMDgtMDEtMDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFNhbS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3JhbmdlLWNs b25lLWVtcHR5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0eS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0eS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdCBjaGVja3MgY2xvbmluZyBh biBlbXB0eSByYW5nZSByZXR1cm5zIGFuIGVtcHR5IGZyYWdtZW50LgorCitPbiBzdWNjZXNzLCB5 b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVT VCBDT01QTEVURSIuCisKKworUEFTUyByLmNsb25lQ29udGVudHMoKSAhPSB1bmRlZmluZWQgaXMg dHJ1ZQorUEFTUyByLmNsb25lQ29udGVudHMoKSAhPSBudWxsIGlzIHRydWUKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2RvbS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0eS5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZG9tL1JhbmdlL3JhbmdlLWNsb25lLWVtcHR5Lmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9yYW5nZS1jbG9uZS1lbXB0eS5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0v L0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNo ZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlw dCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hl YWQ+Cis8Ym9keT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3JhbmdlLWNsb25lLWVtcHR5LmpzIj48L3Nj cmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL1Jh bmdlL3Jlc291cmNlcy9yYW5nZS1jbG9uZS1lbXB0eS5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9SYW5nZS9yZXNvdXJjZXMvcmFuZ2UtY2xvbmUtZW1wdHkuanMJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9SYW5nZS9yZXNvdXJjZXMvcmFuZ2UtY2xv bmUtZW1wdHkuanMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorZGVzY3JpcHRpb24oCisi VGhpcyB0ZXN0IGNoZWNrcyBjbG9uaW5nIGFuIGVtcHR5IHJhbmdlIHJldHVybnMgYW4gZW1wdHkg ZnJhZ21lbnQuIgorKTsKKwordmFyIHIgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOworc2hvdWxk QmVUcnVlKCJyLmNsb25lQ29udGVudHMoKSAhPSB1bmRlZmluZWQiKTsKK3Nob3VsZEJlVHJ1ZSgi ci5jbG9uZUNvbnRlbnRzKCkgIT0gbnVsbCIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsK