167472 2017-01-26 16:17:39 -0800 REGRESSION (r207483): Touch Bar: Lists and BIU Buttons Missing from Touch Bar in HTML Notes 2017-01-27 08:38:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue thorton webkit-bug-importer oldest_to_newest 1270420 0 wenson_hsieh 2017-01-26 16:17:39 -0800 The touch bar does not appear in HTML notes due to a recent regression. 1270421 1 wenson_hsieh 2017-01-26 16:20:02 -0800 <rdar://problem/30149809> 1270423 2 299875 wenson_hsieh 2017-01-26 16:24:03 -0800 Created attachment 299875 Patch 1270425 3 299876 wenson_hsieh 2017-01-26 16:30:18 -0800 Created attachment 299876 Patch for landing 1270427 4 299876 commit-queue 2017-01-26 16:33:20 -0800 Comment on attachment 299876 Patch for landing Rejecting attachment 299876 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 299876, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2955072 1270433 5 299879 wenson_hsieh 2017-01-26 16:40:31 -0800 Created attachment 299879 Patch for landing 1270451 6 299879 commit-queue 2017-01-26 17:02:49 -0800 Comment on attachment 299879 Patch for landing Clearing flags on attachment: 299879 Committed r211243: <http://trac.webkit.org/changeset/211243> 299875 2017-01-26 16:24:03 -0800 2017-01-26 16:25:32 -0800 Patch bug-167472-20170126162200.patch text/plain 2043 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQ2ZmZhZWEy ZTBhYjUwZTg3NTQzMGRjNTMwM2NkNjU4ZjUwOTZmNC4uNTlmMWM0YmRiMDJkMzM2ZWNkMjAwMjgx NDM2ZjUxMWZhMDFmMTI4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3 LTAxLTI2ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyMDc0ODMpOiBUb3VjaCBCYXI6IExpc3RzIGFuZCBCSVUgQnV0dG9ucyBN aXNzaW5nIGZyb20gVG91Y2ggQmFyIGluIEhUTUwgTm90ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzQ3MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzAxNDk4MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmV2aXNpb24gMjA3NDgzIGNhdXNlZCB0aGUgdG91Y2ggYmFyIHRvIHN0b3Agc2hvd2lu ZyB1cCBpbiBIVE1MIE5vdGVzIGR1ZSB0byAtdXBkYXRlVGV4dFRvdWNoQmFyIG5vdAorICAgICAg ICBpbml0aWFsaXppbmcgdGhlIHRleHQgdG91Y2ggYmFyIGFuZCBjYXVzaW5nIC1tYWtlVG91Y2hC YXIgdG8gcmV0dXJuIG5pbCB3aGlsZSBwcm9jZXNzaW5nIGEgbW91c2UgY2xpY2suIFRoZQorICAg ICAgICBwdXJwb3NlIG9mIGJhaWxpbmcgb3V0IG9mIHRoZSB1cGRhdGUgd2FzIHRvIHByZXZlbnQg dGhlIHRleHQgdG91Y2ggYmFyIGZyb20gdGhyYXNoaW5nIGR1cmluZyBhIHNlbGVjdGlvbiBkcmFn LgorICAgICAgICBJZiB0aGUgdGV4dCB0b3VjaCBiYXIgZG9lc27igJl0IGV4aXN0IHlldCwgd2Ug ZG9uJ3QgaGF2ZSB0byB3b3JyeSBhYm91dCBpdHMgYXBwZWFyYW5jZSBmbGlja2VyaW5nIGZyb20g YSBkaWZmZXJlbnQKKyAgICAgICAgcHJldmlvdXMgc3RhdGUsIHNvIHdlIHNob3VsZCBqdXN0IGFs bG93IHRoZSB0b3VjaCBiYXIgdG8gdXBkYXRlIGluc3RlYWQuCisKKyAgICAgICAgKiBXZWJWaWV3 L1dlYlZpZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgdXBkYXRlVGV4dFRvdWNoQmFyXSk6CisK IDIwMTctMDEtMjUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVmYWN0b3IgZHJhZyBhbmQgZHJvcCBpbXBsZW1lbnRhdGlvbiBvbiBNYWMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJL aXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQppbmRleCA5ZTEzZjZhYjM2ZGU4N2Q4MWJkMTg0YTIx NzI1MTQxODQyNTVlODM0Li40ZmY3YzcxZTU2ODU2NDUxNTFkYjJiMDEwNzJhMTA5ZmIyNThiMTNl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KKysrIGIv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCkBAIC05NTQ4LDcgKzk1NDgsOCBA QCBzdGF0aWMgTlNUZXh0QWxpZ25tZW50IG5zVGV4dEFsaWdubWVudEZyb21SZW5kZXJTdHlsZShj b25zdCBSZW5kZXJTdHlsZSogc3R5bGUpCiAKIC0gKHZvaWQpdXBkYXRlVGV4dFRvdWNoQmFyCiB7 Ci0gICAgaWYgKF9wcml2YXRlLT5faXNEZWZlcnJpbmdUZXh0VG91Y2hCYXJVcGRhdGVzKSB7Cisg ICAgQk9PTCB0b3VjaEJhcnNSZXF1aXJlSW5pdGlhbGl6YXRpb24gPSAhX3ByaXZhdGUtPl9yaWNo VGV4dFRvdWNoQmFyIHx8ICFfcHJpdmF0ZS0+X3BsYWluVGV4dFRvdWNoQmFyOworICAgIGlmIChf cHJpdmF0ZS0+X2lzRGVmZXJyaW5nVGV4dFRvdWNoQmFyVXBkYXRlcyAmJiAhdG91Y2hCYXJzUmVx dWlyZUluaXRpYWxpemF0aW9uKSB7CiAgICAgICAgIF9wcml2YXRlLT5fbmVlZHNEZWZlcnJlZFRl eHRUb3VjaEJhclVwZGF0ZSA9IFlFUzsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 299876 2017-01-26 16:30:18 -0800 2017-01-26 16:33:20 -0800 Patch for landing bug-167472-20170126162815.patch text/plain 2041 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZjQ2ZmZhZWEy ZTBhYjUwZTg3NTQzMGRjNTMwM2NkNjU4ZjUwOTZmNC4uM2ZmMTBiNjhjMDVkYWFiMDE3Y2U2ZjUx ZjU2MTEyY2YwNjI5OWQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3 LTAxLTI2ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyMDc0ODMpOiBUb3VjaCBCYXI6IExpc3RzIGFuZCBCSVUgQnV0dG9ucyBN aXNzaW5nIGZyb20gVG91Y2ggQmFyIGluIEhUTUwgTm90ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzQ3MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzAxNDk4MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmV2aXNpb24gMjA3NDgzIGNhdXNlZCB0aGUgdG91Y2ggYmFyIHRvIHN0b3Agc2hvd2lu ZyB1cCBpbiBIVE1MIE5vdGVzIGR1ZSB0byAtdXBkYXRlVGV4dFRvdWNoQmFyIG5vdAorICAgICAg ICBpbml0aWFsaXppbmcgdGhlIHRleHQgdG91Y2ggYmFyIGFuZCBjYXVzaW5nIC1tYWtlVG91Y2hC YXIgdG8gcmV0dXJuIG5pbCB3aGlsZSBwcm9jZXNzaW5nIGEgbW91c2UgY2xpY2suIFRoZQorICAg ICAgICBwdXJwb3NlIG9mIGJhaWxpbmcgb3V0IG9mIHRoZSB1cGRhdGUgd2FzIHRvIHByZXZlbnQg dGhlIHRleHQgdG91Y2ggYmFyIGZyb20gdGhyYXNoaW5nIGR1cmluZyBhIHNlbGVjdGlvbiBkcmFn LgorICAgICAgICBJZiB0aGUgdGV4dCB0b3VjaCBiYXIgZG9lc24ndCBleGlzdCB5ZXQsIHdlIGRv bid0IGhhdmUgdG8gd29ycnkgYWJvdXQgaXRzIGFwcGVhcmFuY2UgZmxpY2tlcmluZyBmcm9tIGEg ZGlmZmVyZW50CisgICAgICAgIHByZXZpb3VzIHN0YXRlLCBzbyB3ZSBzaG91bGQganVzdCBhbGxv dyB0aGUgdG91Y2ggYmFyIHRvIHVwZGF0ZSBpbnN0ZWFkLgorCisgICAgICAgICogV2ViVmlldy9X ZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IHVwZGF0ZVRleHRUb3VjaEJhcl0pOgorCiAy MDE3LTAxLTI1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlZmFjdG9yIGRyYWcgYW5kIGRyb3AgaW1wbGVtZW50YXRpb24gb24gTWFjCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KaW5kZXggOWUxM2Y2YWIzNmRlODdkODFiZDE4NGEyMTcy NTE0MTg0MjU1ZTgzNC4uNGZmN2M3MWU1Njg1NjQ1MTUxZGIyYjAxMDcyYTEwOWZiMjU4YjEzZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQpAQCAtOTU0OCw3ICs5NTQ4LDggQEAg c3RhdGljIE5TVGV4dEFsaWdubWVudCBuc1RleHRBbGlnbm1lbnRGcm9tUmVuZGVyU3R5bGUoY29u c3QgUmVuZGVyU3R5bGUqIHN0eWxlKQogCiAtICh2b2lkKXVwZGF0ZVRleHRUb3VjaEJhcgogewot ICAgIGlmIChfcHJpdmF0ZS0+X2lzRGVmZXJyaW5nVGV4dFRvdWNoQmFyVXBkYXRlcykgeworICAg IEJPT0wgdG91Y2hCYXJzUmVxdWlyZUluaXRpYWxpemF0aW9uID0gIV9wcml2YXRlLT5fcmljaFRl eHRUb3VjaEJhciB8fCAhX3ByaXZhdGUtPl9wbGFpblRleHRUb3VjaEJhcjsKKyAgICBpZiAoX3By aXZhdGUtPl9pc0RlZmVycmluZ1RleHRUb3VjaEJhclVwZGF0ZXMgJiYgIXRvdWNoQmFyc1JlcXVp cmVJbml0aWFsaXphdGlvbikgewogICAgICAgICBfcHJpdmF0ZS0+X25lZWRzRGVmZXJyZWRUZXh0 VG91Y2hCYXJVcGRhdGUgPSBZRVM7CiAgICAgICAgIHJldHVybjsKICAgICB9Cg== 299879 2017-01-26 16:40:31 -0800 2017-01-26 17:02:49 -0800 Patch for landing bug-167472-20170126163827.patch text/plain 2030 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNTUxOTI4OGRl OWRjNGJlOTk5MzhlOTFkZThiOGVjMGVlNjNhY2QyYi4uZWJhMjUyYzQ1NDcwYjdiZGFhNGIwOTA3 MDE1MjY5MGM2OGE0N2E5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3 LTAxLTI2ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIyMDc0ODMpOiBUb3VjaCBCYXI6IExpc3RzIGFuZCBCSVUgQnV0dG9ucyBN aXNzaW5nIGZyb20gVG91Y2ggQmFyIGluIEhUTUwgTm90ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NzQ3MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMzAxNDk4MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KKworICAgICAg ICBSZXZpc2lvbiAyMDc0ODMgY2F1c2VkIHRoZSB0b3VjaCBiYXIgdG8gc3RvcCBzaG93aW5nIHVw IGluIEhUTUwgTm90ZXMgZHVlIHRvIC11cGRhdGVUZXh0VG91Y2hCYXIgbm90CisgICAgICAgIGlu aXRpYWxpemluZyB0aGUgdGV4dCB0b3VjaCBiYXIgYW5kIGNhdXNpbmcgLW1ha2VUb3VjaEJhciB0 byByZXR1cm4gbmlsIHdoaWxlIHByb2Nlc3NpbmcgYSBtb3VzZSBjbGljay4gVGhlCisgICAgICAg IHB1cnBvc2Ugb2YgYmFpbGluZyBvdXQgb2YgdGhlIHVwZGF0ZSB3YXMgdG8gcHJldmVudCB0aGUg dGV4dCB0b3VjaCBiYXIgZnJvbSB0aHJhc2hpbmcgZHVyaW5nIGEgc2VsZWN0aW9uIGRyYWcuCisg ICAgICAgIElmIHRoZSB0ZXh0IHRvdWNoIGJhciBkb2Vzbid0IGV4aXN0IHlldCwgd2UgZG9uJ3Qg aGF2ZSB0byB3b3JyeSBhYm91dCBpdHMgYXBwZWFyYW5jZSBmbGlja2VyaW5nIGZyb20gYSBkaWZm ZXJlbnQKKyAgICAgICAgcHJldmlvdXMgc3RhdGUsIHNvIHdlIHNob3VsZCBqdXN0IGFsbG93IHRo ZSB0b3VjaCBiYXIgdG8gdXBkYXRlIGluc3RlYWQuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZp ZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgdXBkYXRlVGV4dFRvdWNoQmFyXSk6CisKIDIwMTct MDEtMjYgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIENy YXNoIHdoZW4gc2V0dGluZyBjdXN0b20gc2NhbGUgZmFjdG9yLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJWaWV3Lm1tCmluZGV4IDlmMjBlMWI2NmY5NmI0NTBjZTIyMmE1MTZiNjc0NjVjNWY5ZGJl YTcuLmUzZmNmMDJlMzYwMmZlYzNiNWVkYWMzNzFmZjVkZGFmZjA3MjNjYmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYlZpZXcubW0KQEAgLTk1NDgsNyArOTU0OCw4IEBAIHN0YXRpYyBOU1Rl eHRBbGlnbm1lbnQgbnNUZXh0QWxpZ25tZW50RnJvbVJlbmRlclN0eWxlKGNvbnN0IFJlbmRlclN0 eWxlKiBzdHlsZSkKIAogLSAodm9pZCl1cGRhdGVUZXh0VG91Y2hCYXIKIHsKLSAgICBpZiAoX3By aXZhdGUtPl9pc0RlZmVycmluZ1RleHRUb3VjaEJhclVwZGF0ZXMpIHsKKyAgICBCT09MIHRvdWNo QmFyc1JlcXVpcmVJbml0aWFsaXphdGlvbiA9ICFfcHJpdmF0ZS0+X3JpY2hUZXh0VG91Y2hCYXIg fHwgIV9wcml2YXRlLT5fcGxhaW5UZXh0VG91Y2hCYXI7CisgICAgaWYgKF9wcml2YXRlLT5faXNE ZWZlcnJpbmdUZXh0VG91Y2hCYXJVcGRhdGVzICYmICF0b3VjaEJhcnNSZXF1aXJlSW5pdGlhbGl6 YXRpb24pIHsKICAgICAgICAgX3ByaXZhdGUtPl9uZWVkc0RlZmVycmVkVGV4dFRvdWNoQmFyVXBk YXRlID0gWUVTOwogICAgICAgICByZXR1cm47CiAgICAgfQo=