167471 2017-01-26 15:44:42 -0800 Fix CPU usage diagnostic logging in PerActivityStateCPUUsageSampler 2017-01-26 16:16:14 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen commit-queue kling koivisto webkit-bug-importer oldest_to_newest 1270391 0 cdumez 2017-01-26 15:44:42 -0800 Fix CPU usage diagnostic logging in PerActivityStateCPUUsageSampler to use numeric values for logDiagnosticMessageWithValue(). 1270398 1 cdumez 2017-01-26 15:50:12 -0800 <rdar://problem/30221723> 1270407 2 299870 cdumez 2017-01-26 15:56:47 -0800 Created attachment 299870 Patch 1270411 3 299870 achristensen 2017-01-26 16:08:12 -0800 Comment on attachment 299870 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299870&action=review > Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:87 > + page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, String::number(cpuUsage, 1), false); Yeah, we could just make logDiagnosticMessageWithValue take a double and call String::number. 1270414 4 299870 cdumez 2017-01-26 16:10:42 -0800 Comment on attachment 299870 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299870&action=review >> Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:87 >> + page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, String::number(cpuUsage, 1), false); > > Yeah, we could just make logDiagnosticMessageWithValue take a double and call String::number. The number of significant digits we log matters though and may depend on the call sites. For example, here 1 significant digit is sufficient but you could imagine us wanting more (or less) in other places. 1270418 5 299870 cdumez 2017-01-26 16:16:09 -0800 Comment on attachment 299870 Patch Clearing flags on attachment: 299870 Committed r211239: <http://trac.webkit.org/changeset/211239> 1270419 6 cdumez 2017-01-26 16:16:14 -0800 All reviewed patches have been landed. Closing bug. 299870 2017-01-26 15:56:47 -0800 2017-01-26 16:16:09 -0800 Patch bug-167471-20170126155444.patch text/plain 3035 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjExMjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDUzNTg4ZWY3YmI3NDll NDkzNzMyMDcxMDkwMTI4MWNjYWMxMWUwNy4uYTQ3N2I5MmZkOTY0NWViOWIwZDVlMmQ0ZmRjODJl NjBiYmI3OWY3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTAxLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IENQVSB1c2FnZSBkaWFn bm9zdGljIGxvZ2dpbmcgaW4gUGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDcxCisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8zMDIyMTcyMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggQ1BVIHVzYWdlIGRpYWdub3N0aWMgbG9nZ2luZyBpbiBQ ZXJBY3Rpdml0eVN0YXRlQ1BVVXNhZ2VTYW1wbGVyCisgICAgICAgIHRvIHVzZSBudW1lcmljIHZh bHVlcyBmb3IgbG9nRGlhZ25vc3RpY01lc3NhZ2VXaXRoVmFsdWUoKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9QZXJBY3Rpdml0eVN0YXRlQ1BVVXNhZ2VTYW1wbGVyLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlcjo6bG9nZ2luZ1RpbWVyRmlyZWQp OgorICAgICAgICAoV2ViS2l0Ojpsb2dnaW5nS2V5Rm9yQ1BVVXNhZ2UpOiBEZWxldGVkLgorCisy MDE3LTAxLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgRml4 IFdlYkdMIGRpYWdub3N0aWMgbG9nZ2luZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY3NDYzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDIxNjk4 MT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QZXJBY3Rpdml0eVN0YXRl Q1BVVXNhZ2VTYW1wbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QZXJBY3Rpdml0 eVN0YXRlQ1BVVXNhZ2VTYW1wbGVyLmNwcAppbmRleCAyNDM3ZTk3ZWI2NGFmYTVmNWRkZDM1MjNm MTZlNmRkZWM1NjJhOGNmLi4zMzY2MDNhNDhhNWMyOTEzYzdiY2NmODM3ZDMyNjMzYWYxMWJhNTBl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGVyQWN0aXZpdHlTdGF0ZUNQ VVVzYWdlU2FtcGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BlckFjdGl2 aXR5U3RhdGVDUFVVc2FnZVNhbXBsZXIuY3BwCkBAIC03MCwxNyArNzAsNiBAQCBzdGF0aWMgaW5s aW5lIFN0cmluZyBsb2dnaW5nS2V5Rm9yQWN0aXZpdHlTdGF0ZShBY3Rpdml0eVN0YXRlRm9yQ1BV U2FtcGxpbmcgc3RhdAogICAgIH0KIH0KIAotc3RhdGljIGlubGluZSBTdHJpbmcgbG9nZ2luZ0tl eUZvckNQVVVzYWdlKEFjdGl2aXR5U3RhdGVGb3JDUFVTYW1wbGluZyBzdGF0ZSwgZG91YmxlIGNw dVVzYWdlKQotewotICAgIHN3aXRjaCAoc3RhdGUpIHsKLSAgICBjYXNlIEFjdGl2aXR5U3RhdGVG b3JDUFVTYW1wbGluZzo6Tm9uVmlzaWJsZToKLSAgICAgICAgcmV0dXJuIERpYWdub3N0aWNMb2dn aW5nS2V5czo6YmFja2dyb3VuZENQVVVzYWdlVG9EaWFnbm9zdGljTG9nZ2luZ0tleShjcHVVc2Fn ZSk7Ci0gICAgY2FzZSBBY3Rpdml0eVN0YXRlRm9yQ1BVU2FtcGxpbmc6OlZpc2libGVOb25BY3Rp dmU6Ci0gICAgY2FzZSBBY3Rpdml0eVN0YXRlRm9yQ1BVU2FtcGxpbmc6OlZpc2libGVBbmRBY3Rp dmU6Ci0gICAgICAgIHJldHVybiBEaWFnbm9zdGljTG9nZ2luZ0tleXM6OmZvcmVncm91bmRDUFVV c2FnZVRvRGlhZ25vc3RpY0xvZ2dpbmdLZXkoY3B1VXNhZ2UpOwotICAgIH0KLX0KLQogdm9pZCBQ ZXJBY3Rpdml0eVN0YXRlQ1BVVXNhZ2VTYW1wbGVyOjpsb2dnaW5nVGltZXJGaXJlZCgpCiB7CiAg ICAgYXV0byogcGFnZSA9IHBhZ2VGb3JMb2dnaW5nKCk7CkBAIC05NCw5ICs4Myw5IEBAIHZvaWQg UGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlcjo6bG9nZ2luZ1RpbWVyRmlyZWQoKQogCiAg ICAgZm9yIChhdXRvJiBwYWlyIDogbV9jcHVUaW1lSW5BY3Rpdml0eVN0YXRlKSB7CiAgICAgICAg IGRvdWJsZSBjcHVVc2FnZSA9IHN0YXRpY19jYXN0PGRvdWJsZT4ocGFpci52YWx1ZSAqIDEwMC4p IC8gY3B1VGltZURlbHRhOwotICAgICAgICBTdHJpbmcgbG9nZ2luZ0tleSA9IGxvZ2dpbmdLZXlG b3JBY3Rpdml0eVN0YXRlKHBhaXIua2V5KTsKLSAgICAgICAgcGFnZS0+bG9nRGlhZ25vc3RpY01l c3NhZ2VXaXRoVmFsdWUoRGlhZ25vc3RpY0xvZ2dpbmdLZXlzOjpjcHVVc2FnZUtleSgpLCBsb2dn aW5nS2V5LCBsb2dnaW5nS2V5Rm9yQ1BVVXNhZ2UocGFpci5rZXksIGNwdVVzYWdlKSwgZmFsc2Up OwotICAgICAgICBSRUxFQVNFX0xPRyhQZXJmb3JtYW5jZUxvZ2dpbmcsICJXZWJDb250ZW50IHBy b2Nlc3NlcyB1c2VkICUuMWYlJSBDUFUgaW4gJXMgc3RhdGUiLCBjcHVVc2FnZSwgbG9nZ2luZ0tl eS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgU3RyaW5nIGFjdGl2aXR5U3RhdGVLZXkgPSBsb2dn aW5nS2V5Rm9yQWN0aXZpdHlTdGF0ZShwYWlyLmtleSk7CisgICAgICAgIHBhZ2UtPmxvZ0RpYWdu b3N0aWNNZXNzYWdlV2l0aFZhbHVlKERpYWdub3N0aWNMb2dnaW5nS2V5czo6Y3B1VXNhZ2VLZXko KSwgYWN0aXZpdHlTdGF0ZUtleSwgU3RyaW5nOjpudW1iZXIoY3B1VXNhZ2UsIDEpLCBmYWxzZSk7 CisgICAgICAgIFJFTEVBU0VfTE9HKFBlcmZvcm1hbmNlTG9nZ2luZywgIldlYkNvbnRlbnQgcHJv Y2Vzc2VzIHVzZWQgJS4xZiUlIENQVSBpbiAlcyBzdGF0ZSIsIGNwdVVzYWdlLCBhY3Rpdml0eVN0 YXRlS2V5LnV0ZjgoKS5kYXRhKCkpOwogICAgIH0KIAogICAgIG1fY3B1VGltZUluQWN0aXZpdHlT dGF0ZS5jbGVhcigpOwo=